mike cullerton
96d38e6e65
Removed double-quotes
2021-09-07 15:18:05 -04:00
mike cullerton
ee68d818e6
Test for new endpoint
2021-09-07 15:15:38 -04:00
Dan Funk
86c017a6a6
Merge pull request #367 from sartography/value-error-expression-428
...
Value error expression #428
2021-09-03 14:32:46 -04:00
mike cullerton
26a625c5db
Test for new service
2021-09-02 09:57:01 -04:00
mike cullerton
d9fa94b64f
Added spreadsheet for testing
2021-09-02 09:56:40 -04:00
mike cullerton
f2741921cb
Added task to select a spreadsheet
2021-09-02 09:56:22 -04:00
mike cullerton
f49128adf4
Rename test file
2021-09-01 10:44:53 -04:00
mike cullerton
3020c76d5c
Rename test BPMN file
2021-09-01 10:41:21 -04:00
mike cullerton
0c31b091ee
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-09-01 09:38:03 -04:00
mike cullerton
e6a2b9d642
New test and BPMN for changes
2021-08-31 16:18:29 -04:00
mike cullerton
86583aa2d6
Be explicit about loading sample data
...
Add category_id when checking order
2021-08-31 12:19:45 -04:00
Dan
1140b21414
Adding a test that assures we pick up libraries on the remote system when syncing.
2021-08-31 12:07:41 -04:00
Dan
d17a2c39ed
A little cleanup to assure that when we sync we correctly pick up and associate librarires with a workflow when we sync.
2021-08-30 15:46:16 -04:00
mike cullerton
cfd8f3fe74
Test for reordering remaining spec categories after delete
2021-08-30 15:21:42 -04:00
mike cullerton
e317b59bfe
Test for reordering workflow specs upon deletion
2021-08-30 14:57:16 -04:00
mike cullerton
c99080845b
renamed a test
2021-08-30 13:56:27 -04:00
mike cullerton
dfe967d578
Tests for reordering categories
2021-08-30 13:56:13 -04:00
mike cullerton
d43eb4d6f8
Tests for workflow spec reordering
2021-08-30 12:35:57 -04:00
mike cullerton
543fc1fb4a
Start of tests for new reorder API endpoint
...
Modified example_data to include a display_order for example spec
2021-08-27 13:04:11 -04:00
Dan
083abd1b58
Just being consistent in the names as we named it delete_task_data in the class, but not elsewhere, and since I'm here, using the name I prefer.
2021-08-26 14:22:12 -04:00
mike cullerton
cd3d17862a
Add task_spec_name to a bunch of tests
2021-08-26 10:43:28 -04:00
mike cullerton
5f0db3f2fb
Test and BPMN file for new script
2021-08-26 10:42:30 -04:00
mike cullerton
35285a0b60
Fixed tests that broke from the new irb_documents spreadsheet
2021-08-26 08:51:52 -04:00
mike cullerton
54cb74e0a4
Test for the new script
2021-08-26 08:44:22 -04:00
Mike Cullerton
961925e03e
Merge pull request #361 from sartography/430-email-enhancements
...
#430 email enhancements
2021-08-25 15:02:14 -04:00
mike cullerton
e8f8ba67cf
Added test for email attachments
...
Moved cc test to the main test_email_script test, and added bcc and reply_to
Added load_example_data to test_email_script_multiple.
2021-08-19 17:40:37 -04:00
mike cullerton
a9452d6533
Modified the test workflow form to add the new bcc, reply_to, and attachments arguments
2021-08-19 17:37:10 -04:00
Mike Cullerton
5692f7d377
Merge pull request #359 from sartography/413-LibraryCleanup
...
413 library cleanup
2021-08-18 13:39:37 -04:00
Kelly McDonald
f3f42eea2b
Fixes #413
...
Add test for cleanup
2021-08-18 08:33:44 -04:00
Dan
7a8eeab820
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-17 11:16:03 -04:00
Dan
4e0e162fd6
Removing the execution flag Nile keeps adding to files.
2021-08-17 09:50:57 -04:00
mike cullerton
2a2fd710c4
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-08-16 14:22:02 -04:00
mike cullerton
ab8714c93e
Remove HSRNUMBER from mock data
2021-08-16 13:01:51 -04:00
mike cullerton
3f44c202ca
Merge branch '417-hsr-open-to-enrollment-bug' into 426-remove-hsr-number
2021-08-16 12:55:24 -04:00
nilez
0a232dace6
assertEquals -> assertEqual
2021-08-16 10:25:41 -04:00
nilez
b9d4f6c436
assertEquals -> assertEqual
2021-08-16 10:18:29 -04:00
nilez
f8dd4c3eb9
Check Study Associates Endpoint
2021-08-16 09:32:02 -04:00
mike cullerton
febcb1ac5b
Clarified my comments
2021-08-13 12:36:43 -04:00
mike cullerton
58119c8969
Modified `test_get_all_studies` so they don't fail looking for studies that are open for enrollment
...
We will soon have a new way to automatically set study status to `Open for Enrollment`, so I left the failing tests there and commented them out for now.
2021-08-13 12:32:11 -04:00
nilez
e32c1db4c8
Merge remote-tracking branch 'origin/dev' into bug/missing_pi_name_246
...
# Conflicts:
# crc/models/study.py
# crc/services/study_service.py
# crc/services/workflow_service.py
# tests/study/test_study_associate_script.py
2021-08-12 12:59:15 -04:00
nilez
d20b68e483
Fixed Deprecation Warnings in Test Files
2021-08-12 12:33:27 -04:00
nilez
2732071585
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-12 12:07:25 -04:00
Dan Funk
adb1b74822
Merge pull request #352 from sartography/post-process-empty-field-408
...
Post process empty field #408
2021-08-12 10:53:26 -04:00
mike cullerton
e0096ebc8e
Test and BPMN to make sure we don't process when field is hidden, but do process when field is not hidden
2021-08-11 16:44:45 -04:00
Dan
848c2e622f
Always use a schema to define what is being returned, it enforces consistency of the API and internally we can depend on well defined objects.
2021-08-10 16:16:08 -04:00
mike cullerton
dce95189cb
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-08-10 09:39:42 -04:00
Kelly McDonald
960d302c03
Finish #367 - Make sure that we only use a primary_id if it is in the workflow that we are currently working on - otherwise it is a library and might have its own primary id.
2021-08-10 09:15:38 -04:00
mike cullerton
abe258cdf1
Added example data so we can grab a workflow spec
2021-08-03 11:56:53 -04:00
Kelly McDonald
6e1fedb704
Add tests for libraries, remove an API endpoint that didn't make sense after recent changes and remove some commented out sections that were not needed after some decisions about the api endpoints were made
2021-08-03 10:02:22 -04:00
mike cullerton
e8ea9776a5
Test for creating dmn from spreadsheet
2021-08-02 10:04:47 -04:00
Kelly McDonald
25319a0e6a
Make changes to alembic process - fix test for new API
2021-08-02 08:59:24 -04:00
mike cullerton
097dd9f9a3
Included the failing test, with self.assertRaises
...
Reworded some of the comments
2021-07-28 11:22:45 -04:00
Kelly McDonald
217e61eed3
next_task returns the next available task, except when the task is completed when it returns the EndEvent -
...
The problem was that it was returning the first EndEvent it found, not the last one. This caused a problem when we had a CallActivity which has its own EndEvent.
Fixes #399
2021-07-27 09:19:08 -04:00
mike cullerton
2c892560ad
Failing test for Call Activity End Events - Ticket 399
2021-07-26 12:12:01 -04:00
Dan Funk
25e00823a7
Merge pull request #342 from sartography/enum-file-data-375
...
Enum file data #375
2021-07-23 13:47:57 -04:00
mike cullerton
612ce6dc35
Better test to make sure file data works with all standard field types.
...
(Except maybe custom types)
2021-07-23 11:25:36 -04:00
NWalker4483
a73d1794eb
Fixed Associate API Endpoint description
2021-07-22 14:09:24 -04:00
mike cullerton
6b51fc7c06
Added a test with uppercase UID
...
Modified the script test to expect an empty dictionary now, instead of raising an error
2021-07-22 10:47:25 -04:00
mike cullerton
fa19b36279
Removed temporary print statement
2021-07-15 13:16:06 -04:00
mike cullerton
9023be66f4
added a comment to the test
2021-07-15 13:14:40 -04:00
mike cullerton
82bf25cbc6
Test that we set file data_store values correctly when using the file_data property
2021-07-15 13:10:51 -04:00
Mike Cullerton
522ca9d164
Merge pull request #340 from sartography/bug/better_errors_on_scheduled_tasks
...
Assure we log reasonably clear errors when executing scheduled tasks …
2021-07-12 10:13:02 -04:00
Mike Cullerton
d1bf370a39
Merge pull request #339 from sartography/restrict-loaded-studies-374
...
Restrict loaded studies #374
2021-07-12 10:11:34 -04:00
Mike Cullerton
7070761089
Merge pull request #338 from sartography/document-spreadsheet-name-380
...
Document spreadsheet name #380
2021-07-12 10:11:16 -04:00
Dan
f982745d32
fixing a failing test, don't assume the study and workflow ids will always be 1.
2021-07-12 10:00:39 -04:00
Dan
1916c4ff54
Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively.
2021-07-12 09:43:12 -04:00
mike cullerton
69974e89fd
Added 2 simple tests for filtering by REVIEW_TYPE
2021-07-09 11:39:30 -04:00
mike cullerton
682b010f6f
Added mocked study_details with an invalid REVIEW_TYPE
...
This is used to test StudyService.get_studies_for_user
StudyService.get_studies_for_user should now filter on REVIEW_TYPE
2021-07-09 11:38:45 -04:00
mike cullerton
445d3e5f0b
Added mocked pb study_details since we now check whether a study has valid REVIEW_TYPEs
2021-07-09 10:41:46 -04:00
mike cullerton
95c710768e
Fixed test to reflect adding REVIEW_TYPE to mocked study_details PB data
2021-07-09 10:40:18 -04:00
mike cullerton
841bbe73ef
Added REVIEW_TYPE to the mocked PB data
2021-07-09 10:38:41 -04:00
mike cullerton
f1a15ef8e9
Fix the test
2021-07-07 12:54:16 -04:00
Dan Funk
3c52453c26
Merge branch 'dev' into add-name-error-hint-8
2021-07-07 11:35:24 -04:00
Dan Funk
2ed436327f
Merge pull request #333 from sartography/check-study-script-273
...
Check study script #273
2021-07-07 11:28:32 -04:00
Dan
2a45f2fcda
Merge branch 'dev' into add-name-error-hint-8
2021-07-07 11:24:00 -04:00
mike cullerton
b0cf74fa3d
Merge branch 'dev' into add-by-user-61
...
# Conflicts:
# tests/files/test_files_api.py
2021-07-07 10:46:50 -04:00
mike cullerton
ac19c3e3c6
Add users first
2021-07-07 10:33:30 -04:00
mike cullerton
621c11fe24
Add test for user_uid
2021-07-07 09:39:01 -04:00
Dan
fb54edac1c
Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
...
Most noteable is the addition of the line on which the error occurs for script tasks. It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
Dan
1b1a994360
Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them.
...
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
2021-07-06 13:10:20 -04:00
mike cullerton
8145ff9025
Tests for calling the script
2021-07-02 16:14:19 -04:00
mike cullerton
2cb2874a49
Added test and json data for new check_study pb mock api endpoint
2021-07-02 15:26:39 -04:00
mike cullerton
2a43230121
Test and workflow for the new name error hint code
2021-07-01 15:39:25 -04:00
Dan
9a32fadc2f
Merge branch 'dev' into 346-waiting-task-schedule
...
# Conflicts:
# Pipfile.lock
# crc/services/workflow_service.py
2021-06-30 10:14:37 -04:00
Dan Funk
48bf721b23
Merge pull request #331 from sartography/bug/356_duplicate_workflow
...
Bug/356 duplicate workflow
2021-06-22 17:42:24 -04:00
Dan
92ca506c8e
Calls to eval no longer return the data, rather it will accept and return a key, allowing the front end to cache similar queries and not re-execute them.
2021-06-22 17:23:18 -04:00
Dan
61ad371680
Clean up the file api so we don't have a bunch of extra stuff in there. Just include the raw data from the document spraedsheet if it is available.
2021-06-22 15:08:08 -04:00
Dan
1f3febe2df
Fix the panda warnings, which means we only support xlsx files now.
...
Include the document details when reutnring a file from the file model.
Improve the validation of file form elements.
2021-06-22 14:58:52 -04:00
Dan
0722a4bf13
Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously.
...
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
2021-06-18 17:00:10 -04:00
Dan
07eb3f9ca8
Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously.
...
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
2021-06-18 16:41:55 -04:00
Dan Funk
19d63e2aa2
Merge pull request #328 from sartography/restart-workflow-programmatically-347
...
Restart workflow programmatically #347
2021-06-17 10:36:46 -04:00
Dan
a4caae8d64
when validating, we need to take every step to remove the workflows we create during the validation.
2021-06-16 14:40:20 -04:00
mike cullerton
94e730d04e
Test script validation
2021-06-15 11:15:31 -04:00
mike cullerton
8db4199d73
Separate workflows for `using` the script and `validating` the script.
2021-06-15 11:15:04 -04:00
mike cullerton
addf1cab5b
Added tests for failing conditions
2021-06-15 10:30:18 -04:00
mike cullerton
9e20025f33
Test and workflow for reset_workflow
2021-06-15 08:37:42 -04:00
Dan
7282419174
modified the tools api to return the expression and data with the result, making it easier to cash results on the front end, This should help drastically reduce the calls to the python_eval from the front end.
...
The post processors for form submissions needs to take repeating sections into account, or it won't find the files it is looking for.
2021-06-11 08:27:50 -04:00
Kelly McDonald
5f722d675f
Add a function that gets runs via a background scheduler to look for any workflows that are in a 'waiting' state - it runs the update waiting tasks and does do_engine_steps
...
We have a test for the function that runs, but an assumption was made that the scheduler module has its own unit tests and we do not need to test that.
fixes #346
2021-06-09 10:42:34 -04:00
Dan
286803d10b
fixing a big stupid bug I created when merging all the code and making changes to the files.
2021-06-08 14:24:59 -04:00
Dan
50ad42d3a8
You have to mock out the protocol builder in tests that rely on it.
2021-06-08 12:36:47 -04:00