sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 13:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,311 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

866 Commits

Author SHA1 Message Date
mike cullerton
ac19c3e3c6 Add users first 2021-07-07 10:33:30 -04:00
mike cullerton
621c11fe24 Add test for user_uid 2021-07-07 09:39:01 -04:00
Dan
fb54edac1c Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct. 
Most noteable is the addition of the line on which the error occurs for script tasks.  It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
 2021-07-07 00:53:49 -04:00
Dan
1b1a994360 Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them. 
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
 2021-07-06 13:10:20 -04:00
mike cullerton
8145ff9025 Tests for calling the script 2021-07-02 16:14:19 -04:00
mike cullerton
2cb2874a49 Added test and json data for new check_study pb mock api endpoint 2021-07-02 15:26:39 -04:00
mike cullerton
2a43230121 Test and workflow for the new name error hint code 2021-07-01 15:39:25 -04:00
Dan
9a32fadc2f Merge branch 'dev' into 346-waiting-task-schedule 
# Conflicts:
#	Pipfile.lock
#	crc/services/workflow_service.py
 2021-06-30 10:14:37 -04:00
Dan Funk
48bf721b23
Merge pull request #331 from sartography/bug/356_duplicate_workflow 
Bug/356 duplicate workflow
 2021-06-22 17:42:24 -04:00
Dan
92ca506c8e Calls to eval no longer return the data, rather it will accept and return a key, allowing the front end to cache similar queries and not re-execute them. 2021-06-22 17:23:18 -04:00
Dan
61ad371680 Clean up the file api so we don't have a bunch of extra stuff in there. Just include the raw data from the document spraedsheet if it is available. 2021-06-22 15:08:08 -04:00
Dan
1f3febe2df Fix the panda warnings, which means we only support xlsx files now. 
Include the document details when reutnring a file from the file model.
Improve the validation of file form elements.
 2021-06-22 14:58:52 -04:00
Dan
0722a4bf13 Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously. 
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
 2021-06-18 17:00:10 -04:00
Dan
07eb3f9ca8 Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously. 
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
 2021-06-18 16:41:55 -04:00
Dan Funk
19d63e2aa2
Merge pull request #328 from sartography/restart-workflow-programmatically-347 
Restart workflow programmatically #347
 2021-06-17 10:36:46 -04:00
Dan
a4caae8d64 when validating, we need to take every step to remove the workflows we create during the validation. 2021-06-16 14:40:20 -04:00
mike cullerton
94e730d04e Test script validation 2021-06-15 11:15:31 -04:00
mike cullerton
8db4199d73 Separate workflows for using the script and validating the script. 2021-06-15 11:15:04 -04:00
mike cullerton
addf1cab5b Added tests for failing conditions 2021-06-15 10:30:18 -04:00
mike cullerton
9e20025f33 Test and workflow for reset_workflow 2021-06-15 08:37:42 -04:00
Dan
7282419174 modified the tools api to return the expression and data with the result, making it easier to cash results on the front end, This should help drastically reduce the calls to the python_eval from the front end. 
The post processors for form submissions needs to take repeating sections into account, or it won't find the files it is looking for.
 2021-06-11 08:27:50 -04:00
Kelly McDonald
5f722d675f Add a function that gets runs via a background scheduler to look for any workflows that are in a 'waiting' state - it runs the update waiting tasks and does do_engine_steps 
We have a test for the function that runs, but an assumption was made that the scheduler module has its own unit tests and we do not need to test that.

fixes #346
 2021-06-09 10:42:34 -04:00
Dan
286803d10b fixing a big stupid bug I created when merging all the code and making changes to the files. 2021-06-08 14:24:59 -04:00
Dan
50ad42d3a8 You have to mock out the protocol builder in tests that rely on it. 2021-06-08 12:36:47 -04:00
Dan
076d198fc6 fixing a failing test for study associate. 2021-06-08 12:18:16 -04:00
Dan Funk
586a0f2f1a
Merge pull request #325 from sartography/feature/file_refactor 
Prefer tasks that share a parent over just the the next available tas…
 2021-06-08 11:28:23 -04:00
Dan
8d79fe9d94 Fixing failing tests, and now asserting that we only perform the post_process_form if we actually have a form. 2021-06-08 11:16:10 -04:00
Dan Funk
9c4994581d
Merge pull request #324 from sartography/modify-infinite-loop-312 
Modify infinite loop #312
 2021-06-08 10:30:13 -04:00
Dan Funk
e10b210302
Merge pull request #323 from sartography/shield-test-issue-344 
Shield test issue #344
 2021-06-08 08:59:58 -04:00
Dan Funk
a7b208f50a
Merge pull request #322 from sartography/data-store-refactor-330 
Data store refactor #330
 2021-06-08 08:58:53 -04:00
Dan Funk
6937c33719
Merge pull request #319 from sartography/datastore-file-endpoints-325 
Datastore file endpoints #325
 2021-06-08 08:54:43 -04:00
Dan Funk
37d4e7cc79
Merge pull request #318 from sartography/340-update_study_associate_change 
Add test and fix to make sure that an empty study associates list (or…
 2021-06-08 08:52:44 -04:00
Dan
59f605c3df Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor. 2021-06-08 08:03:14 -04:00
mike cullerton
9dc5871848 Added mocked PB data for tests using study_info script. 2021-06-07 10:08:44 -04:00
mike cullerton
70651e2a6a Test and BPMN files for testing 2021-06-04 11:45:51 -04:00
mike cullerton
37ba46fb8f These tests now require PB Mock because of the validate_study_id changes 2021-06-03 14:30:00 -04:00
mike cullerton
a2e577829a Cleanup: 
- removed unused imports
- removed testing print statement
 2021-06-02 10:02:26 -04:00
mike cullerton
200a5b3bf3 Updated tests for file datastore endpoint 
Added test of 2 entries
 2021-06-01 16:27:55 -04:00
mike cullerton
ec8353aaa6 Test for new datastore file api endpoint 2021-06-01 13:51:40 -04:00
Kelly McDonald
8c04e228e9 Add test and fix to make sure that an empty study associates list (or a blank list) will effectively clear the extra study associates 2021-06-01 11:46:43 -04:00
Kelly McDonald
a5d67bb245 337 partial fix 
if the user calls the file_data_set function for a valid file with the key 'irb_code' and a value of a valid IRB document code, then we should set the irb code on the file.
 2021-05-27 12:24:30 -04:00
Dan
ef7ee284b2 Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor. 2021-05-19 16:26:16 -04:00
Dan Funk
77f7fec5d4
Merge pull request #312 from sartography/study-is-none-329 
Study is none #329
 2021-05-14 16:33:04 -04:00
Mike Cullerton
668e2f4e3c
Merge pull request #313 from sartography/feature/add_file_data_store_properties_to_file 
Assure that any data store values associated with a file come back as…
 2021-05-14 16:30:35 -04:00
Dan
8e37f27399 Assure that any data store values associated with a file come back as a part of the get_study_data[documents 
] endooint.
 2021-05-14 15:52:25 -04:00
mike cullerton
e75d933830 Make sure a standalone study does not cause an error in the /task_events api endpoint. 2021-05-14 15:35:17 -04:00
Dan Funk
4d7ce5eda9
Merge pull request #311 from sartography/deprecate-study-info-protocol-261 
Deprecate study info protocol #261
 2021-05-14 14:14:18 -04:00
mike cullerton
1a8c374ac0 Need to mock out these tests 2021-05-14 13:32:25 -04:00
mike cullerton
a53e2db223 Final test for study_info script 2021-05-14 13:10:06 -04:00
Dan Funk
ade7812540
Merge pull request #310 from sartography/get-primary-workflow-301 
Get primary workflow #301
 2021-05-14 12:41:48 -04:00