sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 05:38:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,518 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

2518 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan
455c1035f1 Performance upgrade to script.py - reduce the number of times we generate the augmented list of script functions for running python evals. 
Performance upgrade to study_service.py - Don't query on the whole WorkflowModel, just get the status that we need.  Saves lots of complex joins.
Performance upgrade to SpiffWorkflow - don't convert to box unless we have to do so.
 2021-11-29 17:48:05 -05:00
Dan
b9c936da38 Fix the test. 2021-11-29 11:25:45 -05:00
Dan
e5b1daa3d9 Remove wild-card from uid search, it performs very badly. Add a bit of logging so we can easily see performance in the future. 2021-11-29 11:03:14 -05:00
Dan
8ec58fd6d7 Assure better error messages when parsing word documents with jinja syntax. 
I also have a pull request into the folks that run the python docx library to improve their error messages that we depend on here.
 2021-11-23 14:38:48 -05:00
Dan
4a1285b8e0 When validating a workflow, don't run the master workflow multiple times, its a huge waste of time. 
Provide decent data when calling get_study_associate(s) scripts.
 2021-11-22 17:17:19 -05:00
Dan
5bb7dbfb19 Improve the error messages returned from jinja template processing. Try to find the actual line with an error in it. 2021-11-22 14:46:33 -05:00
Dan
12b78c1f99 Value Errors should also alert us that we can't serialize the json. 
Enum Label was depending on the options attribute not existing in some situtations, which is a bad assumption.  Rather, check for specific properties, and call back to using options as the default.
 2021-11-22 12:37:10 -05:00
Dan
4d1f4429ff Fixing a bug in enum_label that was not working when lookup up an select list from a spreadsheet. 
Assure we raise more thoughtful error messages when running getting exceptions in engine tasks.
Field Options should always be available now due to a fix in Spiffworkflow.
 2021-11-22 12:26:30 -05:00
Dan
7041c2285b bumping spiffworkflow for some small fixes. 2021-11-18 14:23:55 -05:00
Dan
84fd3da99f Force celery to be <5 to deal with the increasing pain of Connexion. We should definitely kill Connexion and go a diffrent rounte. 2021-11-18 13:32:26 -05:00
Dan
b12e178288 Fixing a failing test. 2021-11-17 14:12:15 -05:00
Dan
7b02f46403 During validation, options were not being handled correctly for certain types of lookups. 2021-11-17 13:38:41 -05:00
Dan
5e97953c19 Merge branch 'dev' into xls-xlsx-issue-540 2021-11-16 15:59:06 -05:00
Dan
8e2e3519f6 fixes to our tests related to updates in SpiffWorkflow 2021-11-16 15:57:37 -05:00
Dan
3569c82e80 fixing additional tests 2021-11-16 15:46:02 -05:00
mike cullerton
99d0035b41 Merge branch 'dev' into xls-xlsx-issue-540 2021-11-16 12:33:32 -05:00
mike cullerton
cb77db26a3 Minor edit, for clarity 2021-11-16 12:05:20 -05:00
mike cullerton
df0800f071 New test and xls file for failing test 2021-11-16 11:57:24 -05:00
mike cullerton
9f18484ebb Grab exception when reading older xls spreadsheet into pandas 
Renamed `xls` variable to `xlsx`, so it makes more sense
Added a hint to error_service for validation
 2021-11-16 11:54:31 -05:00
Dan
c25d173606 Set the default level of logging to be INFO, not DEBUG, we don't want everyone elses debug information. 2021-11-15 13:39:42 -05:00
Dan
ca5e984915 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-11-11 13:47:43 -05:00
Dan
8cabdd1f96 Bumping to new release of SpiffWorkflow. 2021-11-11 13:47:35 -05:00
Dan Funk
8c166bd029
Merge pull request #423 from sartography/test-protocol-builder-519 
Test protocol builder #519
 2021-11-11 11:49:57 -05:00
Dan
f4f3842059 Fixing a stupid mistake. 2021-11-11 11:45:35 -05:00
Dan
197b75c6bf Quickfix - validation was failing if we had a date object in the task data, but this isn't really a problem. We now use the same JSON serializer as flask does, when doing validations, to better verify behavior with the front end. 2021-11-11 11:18:58 -05:00
mike cullerton
c7147274f0 Resolving issues from code review 2021-11-10 17:43:34 -05:00
mike cullerton
0e8c4580ed Moved to instance/config 2021-11-10 17:18:33 -05:00
mike cullerton
a8b7cd8bba Merge branch 'dev' into test-protocol-builder-519 2021-11-10 16:32:34 -05:00
Dan Funk
037692f42b
Merge pull request #422 from sartography/chore/group-repeating-validation-536 
Fixes #536 - Group + Repeating property validation
 2021-11-10 15:28:04 -05:00
Dan Funk
e764bf937d
Merge pull request #421 from sartography/bug/validation_of_enum_label_failing_in_sub_workflows 
Validation was failing for enum_label() expressions when called withi…
 2021-11-10 15:26:03 -05:00
Dan Funk
81f8aed68b
Merge pull request #420 from sartography/drop-tasklog-on-delete 
Delete Task log model when deleting a study
 2021-11-10 15:20:11 -05:00
Dan Funk
56dc34a209
Merge pull request #414 from sartography/chore/view-as-382 
remove email script test line about UTC stuff
 2021-11-10 15:18:41 -05:00
Dan Funk
84f364ce37
Merge branch 'dev' into chore/view-as-382 2021-11-10 15:16:20 -05:00
alicia pritchett
accdd281fa Fixes #536 - Group + Repeating property validation 
For now, we should not allow both group and repeat properties on a field together.
 2021-11-09 13:21:44 -05:00
mike cullerton
748c80964f Don't need the .strip('/') for the UVA urls 2021-11-09 13:09:01 -05:00
mike cullerton
5cf742d955 remove unused import 2021-11-09 13:07:01 -05:00
mike cullerton
d584e735ec Possible way to switch between real and mock PB 2021-11-09 13:03:41 -05:00
Dan
d1eae3c15a Validation was failing for enum_label() expressions when called within a sub-process. Possible (but unlikely) that this would occur outside validation. 2021-11-09 12:55:06 -05:00
alicia pritchett
cd889c5b67 test that you can't be someone not in ldap 2021-11-09 11:08:55 -05:00
alicia pritchett
024a63b725 new and improved test 2021-11-09 11:05:04 -05:00
alicia pritchett
aa1ba59bb1 Delete Task log model when deleting a study 
just a minor fix
 2021-11-09 10:42:47 -05:00
mike cullerton
fe502ad306 Added easy way to switch back and forth between PB urls 2021-11-09 10:29:23 -05:00
mike cullerton
b193f56f35 Minor cleanup for readability. 2021-11-08 10:13:07 -05:00
mike cullerton
ed5689c1b9 Fixed test_info_script_documents to use a mocked call to required_docs. 
Fixed `test_get_required_docs` to use new required_docs syntax
study_details now in a list, so we look at the first item in the list
 2021-11-08 10:00:19 -05:00
mike cullerton
4e13ea6704 Fixing test mocks 
- study_details returned in a list
- added `Q_COMPLETE` and `HSRNUMBER` to user_studies
- `required_docs` totally different from what we had
 2021-11-08 09:55:06 -05:00
mike cullerton
6f09b0d7dd Added comment to _is_valid_study. 
Fixed get_required_docs. The data returned for get_required_dcs from UVA PB was *very* different than what we had.
 2021-11-05 14:37:41 -04:00
mike cullerton
d186b24de3 UVA PB returns the info in a list. We want the dictionary in the list 2021-11-05 14:26:21 -04:00
mike cullerton
271d4da5ff Merge branch 'dev' into test-protocol-builder-519 2021-11-05 10:29:20 -04:00
mike cullerton
6d548c2a74 *** WIP *** 
Committing to work on another ticket
There are TODOs in study_service
 2021-11-05 09:59:14 -04:00
Dan
9376d3deaf Don't error out trying to send an error about invalid review types. 2021-11-04 13:32:57 -04:00