sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 13:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,454 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

674 Commits

Author SHA1 Message Date
Dan
ad93b5fae6 We were not correctly handing the possibility of there only being a waiting task (and no ready tasks). 
We also had a problem with the validator throwing a 500 when it was trying tell us it would never finish validation.
 2021-11-30 12:44:35 -05:00
Mike Cullerton
ec9d8f8a5c
Merge pull request #425 from sartography/bug/slow_ldap 
Remove wild-card from uid search, it performs very badly.  Add a bit …
 2021-11-30 11:09:42 -05:00
Mike Cullerton
8cc581611e
Merge pull request #426 from sartography/feature/performance_improvement 
Performance upgrades - study dashboard in less than 2 seconds now
 2021-11-30 11:09:28 -05:00
Dan Funk
c8c8c8b244
Merge pull request #424 from sartography/xls-xlsx-issue-540 
Xls xlsx issue #540
 2021-11-30 10:50:33 -05:00
Dan
455c1035f1 Performance upgrade to script.py - reduce the number of times we generate the augmented list of script functions for running python evals. 
Performance upgrade to study_service.py - Don't query on the whole WorkflowModel, just get the status that we need.  Saves lots of complex joins.
Performance upgrade to SpiffWorkflow - don't convert to box unless we have to do so.
 2021-11-29 17:48:05 -05:00
Dan
e5b1daa3d9 Remove wild-card from uid search, it performs very badly. Add a bit of logging so we can easily see performance in the future. 2021-11-29 11:03:14 -05:00
Dan
8ec58fd6d7 Assure better error messages when parsing word documents with jinja syntax. 
I also have a pull request into the folks that run the python docx library to improve their error messages that we depend on here.
 2021-11-23 14:38:48 -05:00
Dan
4a1285b8e0 When validating a workflow, don't run the master workflow multiple times, its a huge waste of time. 
Provide decent data when calling get_study_associate(s) scripts.
 2021-11-22 17:17:19 -05:00
Dan
5bb7dbfb19 Improve the error messages returned from jinja template processing. Try to find the actual line with an error in it. 2021-11-22 14:46:33 -05:00
Dan
4d1f4429ff Fixing a bug in enum_label that was not working when lookup up an select list from a spreadsheet. 
Assure we raise more thoughtful error messages when running getting exceptions in engine tasks.
Field Options should always be available now due to a fix in Spiffworkflow.
 2021-11-22 12:26:30 -05:00
Dan
7b02f46403 During validation, options were not being handled correctly for certain types of lookups. 2021-11-17 13:38:41 -05:00
mike cullerton
cb77db26a3 Minor edit, for clarity 2021-11-16 12:05:20 -05:00
mike cullerton
9f18484ebb Grab exception when reading older xls spreadsheet into pandas 
Renamed `xls` variable to `xlsx`, so it makes more sense
Added a hint to error_service for validation
 2021-11-16 11:54:31 -05:00
Dan Funk
8c166bd029
Merge pull request #423 from sartography/test-protocol-builder-519 
Test protocol builder #519
 2021-11-11 11:49:57 -05:00
Dan
f4f3842059 Fixing a stupid mistake. 2021-11-11 11:45:35 -05:00
Dan
197b75c6bf Quickfix - validation was failing if we had a date object in the task data, but this isn't really a problem. We now use the same JSON serializer as flask does, when doing validations, to better verify behavior with the front end. 2021-11-11 11:18:58 -05:00
mike cullerton
a8b7cd8bba Merge branch 'dev' into test-protocol-builder-519 2021-11-10 16:32:34 -05:00
Dan Funk
037692f42b
Merge pull request #422 from sartography/chore/group-repeating-validation-536 
Fixes #536 - Group + Repeating property validation
 2021-11-10 15:28:04 -05:00
Dan Funk
e764bf937d
Merge pull request #421 from sartography/bug/validation_of_enum_label_failing_in_sub_workflows 
Validation was failing for enum_label() expressions when called withi…
 2021-11-10 15:26:03 -05:00
Dan Funk
81f8aed68b
Merge pull request #420 from sartography/drop-tasklog-on-delete 
Delete Task log model when deleting a study
 2021-11-10 15:20:11 -05:00
Dan Funk
84f364ce37
Merge branch 'dev' into chore/view-as-382 2021-11-10 15:16:20 -05:00
alicia pritchett
accdd281fa Fixes #536 - Group + Repeating property validation 
For now, we should not allow both group and repeat properties on a field together.
 2021-11-09 13:21:44 -05:00
mike cullerton
5cf742d955 remove unused import 2021-11-09 13:07:01 -05:00
Dan
d1eae3c15a Validation was failing for enum_label() expressions when called within a sub-process. Possible (but unlikely) that this would occur outside validation. 2021-11-09 12:55:06 -05:00
alicia pritchett
aa1ba59bb1 Delete Task log model when deleting a study 
just a minor fix
 2021-11-09 10:42:47 -05:00
mike cullerton
b193f56f35 Minor cleanup for readability. 2021-11-08 10:13:07 -05:00
mike cullerton
6f09b0d7dd Added comment to _is_valid_study. 
Fixed get_required_docs. The data returned for get_required_dcs from UVA PB was *very* different than what we had.
 2021-11-05 14:37:41 -04:00
mike cullerton
6d548c2a74 *** WIP *** 
Committing to work on another ticket
There are TODOs in study_service
 2021-11-05 09:59:14 -04:00
mike cullerton
7f163285c3 Test w/Alex's ID 2021-11-03 11:56:07 -04:00
mike cullerton
50d4159168 info log didn't show up. Maybe debug? 2021-11-03 10:36:27 -04:00
mike cullerton
8b6c8f9518 Logging to troubleshoot API call 2021-11-03 10:14:11 -04:00
Dan Funk
8a6c1e1b51
Merge pull request #416 from sartography/bug/fix-hide-518 
Fixes validation for #518
 2021-11-01 16:22:24 -04:00
alicia pritchett
1866e6bba9 Fixes validation for #518 
Well really what this does is give every field a default value of None. what that does is allow you to use value expressions even without a given default value. this part in the backend fixes validation.
 2021-11-01 14:35:30 -04:00
mike cullerton
7722b89faa If a file was archived, users could not update the file. 
In some situations, this kept users from re-uploading files that were previously deleted.
We now allow an archived file to be updated and unarchived.
 2021-10-29 11:52:27 -04:00
alicia pritchett
702b8eaed6 add ldap endpoint that doesnt require workflow info 2021-10-28 16:19:39 -04:00
Dan
e0d1f63c08 Fix an issue with validation where we didn't properly parse dot notation in fields. 2021-10-26 14:48:06 -04:00
alicia pritchett
7959f8ca3f
Merge pull request #405 from sartography/refactor/enums_as_key_value 
Death to enumerated dictionaries
 2021-10-25 15:17:17 -04:00
mike cullerton
a7fcaac5ef Better messaging for the configurators. 
We were generating 500 errors here
 2021-10-22 12:53:26 -04:00
Dan
84ce24243f add an enum_label script that will return the label given a value selection. 2021-10-21 13:57:49 -04:00
mike cullerton
1220f7bef8 Allow embedded templates in Word documents 2021-10-21 13:37:13 -04:00
mike cullerton
3619240bae Move the parts for using Word documents as Jinja templates into JinjaService 2021-10-21 10:29:56 -04:00
mike cullerton
62bf7c50bb Move to new branch 2021-10-20 13:48:20 -04:00
Dan
1c84bd9f1b Merge branch 'dev' into refactor/enums_as_key_value 2021-10-19 12:02:45 -04:00
Dan
5429e7da7d All enumerated lists used in web forms should contain a single value, not a dictionary of value/labels. 
Removing the spreadsheet.value.column and data.value.column so we just have value.column for both.
Improving the __str__ function in the ApiError class, to make debugging a little easier.
Adding a "validate_all" flask command, to help us track down any issues with current workflows in production (use this in concert with sync_with_testing)
Fixed logs of tests.
removed fact_runner.py, a very early and crufty bit of code.
 2021-10-19 10:13:43 -04:00
mike cullerton
1c02928d04 Merge branch 'dev' into jinja-include-403 2021-10-19 10:09:18 -04:00
Dan Funk
ee839a85ed
Merge pull request #401 from sartography/email-cleanup-498 
Email cleanup #498
 2021-10-19 08:59:48 -04:00
Dan Funk
e1b72c8edf
Merge pull request #380 from sartography/file-cleanup-466 
File cleanup #466
 2021-10-19 08:57:14 -04:00
mike cullerton
0122029e30 *** WIP *** 
Migrating the complete_template script stuff to JinjaService.
Having trouble with the tools stuff.
Pulled back to spot where test pass using CompleteTemplate
 2021-10-18 16:56:03 -04:00
mike cullerton
da9b902c19 Removed old commented code 2021-10-18 16:10:30 -04:00
mike cullerton
983c4104e1 We run the same basic Jinja code in 4 different contexts. 
Now call the the Jinja service
 2021-10-16 14:20:48 -04:00