Dan Funk
cccb722e07
Merge pull request #226 from sartography/enum_default_value_expression_162
...
Enum default value expression 162
2021-01-27 10:43:46 -05:00
mike cullerton
420ef0b2b0
Test and data for cleaning up my smell. We now test explicitly whether a task has both a default_value and value_expression. If so, we raise an error.
2021-01-27 10:22:43 -05:00
mike cullerton
81e55b6055
Cleaning up my smell. A task should only have default_value *or* value_expresion, not both.
2021-01-27 10:21:13 -05:00
Dan Funk
98f946c119
Merge pull request #227 from sartography/missing_form_key_163
...
Missing form key 163
2021-01-27 09:42:46 -05:00
Dan Funk
691b779a0c
Merge pull request #223 from sartography/152-workflow-spec-pull
...
152 workflow spec pull
2021-01-27 09:39:09 -05:00
mike cullerton
d01f8e1018
This workflow had a form with a missing form key, so it's associated test failed after my changes in this ticket. I added a form key to the form. Test now passes.
2021-01-22 12:16:02 -05:00
mike cullerton
2438779470
Test and workflow file for missing form key. Ticket 163
2021-01-22 12:14:59 -05:00
mike cullerton
b71fd93dd4
We now make sure that forms have a form key. Ticket 163
2021-01-22 12:14:17 -05:00
mike cullerton
1ee6a11d46
Test and associated data files for setting enum default values from value_expression. Ticket 162
2021-01-22 10:01:20 -05:00
mike cullerton
00d9276483
In spiff_task_to_api_task, when looping through fields, if the field doesn't have a value, we now try to set it with the default value
...
In test_spec, we now check for FIELD_PROP_VALUE_EXPRESSION when setting default values
2021-01-22 10:00:28 -05:00
Dan
5921ce9f10
Merge branch 'dev' into 152-workflow-spec-pull
2021-01-21 12:30:43 -05:00
Dan Funk
5b13195182
Merge pull request #224 from sartography/restart-with-no-data-99
...
Restart with no data 99
2021-01-20 17:22:18 -05:00
Dan
41dac33039
Removed two tests around soft_reset that are no longer required.
...
Reset should construct the workflow_processor, thus completing the reset process.
Removed the spec argument from init, as it is never used anywhere.
2021-01-20 13:24:53 -05:00
Dan
6a7ee09a5d
Updating the readme file.
2021-01-20 11:00:41 -05:00
mike cullerton
27a8383898
Not sure about this one. We no longer support the task this test is testing (soft_reset). I commented out that part of the test. We can discuss, if necessary.
2021-01-19 15:44:11 -05:00
mike cullerton
61d366c111
Fixed hard_reset test. Now we reset the workflow and run do_engine_steps
2021-01-19 15:39:59 -05:00
mike cullerton
61b34fd6f4
Fixed hard_reset test. We now call restart_workflow_api.
2021-01-19 15:34:46 -05:00
mike cullerton
1b18b53107
Fixed hard_reset test. We now call restart_workflow_api.
2021-01-19 15:32:38 -05:00
mike cullerton
bfb3871671
Added method for restart_workflow_api. Pulled out some common code with get_workflow_api.
2021-01-19 15:27:44 -05:00
mike cullerton
9281a93abb
New test for new restart_workflow endpoint
2021-01-19 15:15:44 -05:00
mike cullerton
039a1dcd79
WorkflowProcessor code for new restart_workflow api endpoint. WorkflowProcessor.reset will clear workflow_model.bpmn_workflow_json, and if clear_data is True will clear form data.
...
WorkflowProcessor.__init__ is mostly unchanged.
2021-01-19 15:14:36 -05:00
mike cullerton
9c71a503ca
Python code for new restart_workflow api endpoint. Cleaned up code and docstring in get_workflow to match.
2021-01-19 15:09:20 -05:00
mike cullerton
e1532a90c9
New api endpoint for restarting a workflow. Unsure if I needed the responses section. **Dan, can you check this?**
...
Also, removed clear_data and reload_spec as parameters for standard get workflow endpoint.
2021-01-19 15:00:39 -05:00
mike cullerton
6a9e6d3570
Restart workflow without form data. Committing so Dan can check it out
2021-01-14 15:32:14 -05:00
mike cullerton
99c1d1b129
Test for changes to hard_reset and soft_reset
2021-01-13 16:12:14 -05:00
Kelly McDonald
442a4524c4
Test for new functionality and code coverage
2021-01-12 10:18:35 -05:00
Kelly McDonald
cf7990ce85
Refactor for better readability due to code smell test
2021-01-12 08:54:32 -05:00
Kelly McDonald
abc17add89
file order was not deterministic - alter test to make sure we updated the 'right' file rather than relying on ordering
2021-01-12 08:54:15 -05:00
Kelly McDonald
e14b896225
Add documentation
2021-01-11 09:31:08 -05:00
Kelly McDonald
f282a9ef73
Make sure that top_level_workflow is transferred over, also include reference files in the list of files to sync
...
We may want to revisit this because I used a 'Magic' workflow_ref_id of 'REFERENCE_FILES' as a special case so I could re-use most of what I already had. This works well, but we may want to structure it different.
2021-01-11 09:21:44 -05:00
Dan
336c093bf8
Catch errors when building enumeration lists.
2021-01-08 15:15:24 -05:00
Dan Funk
4bb4a93161
Merge pull request #221 from sartography/validate-form-field-names-96
...
We now check form field IDs so they play well with Python and Javascript
2021-01-08 14:42:54 -05:00
Dan
26655b26d3
merging in dev, and fixing a failing test from dev.
2021-01-08 14:42:13 -05:00
Dan Funk
9118517995
Merge pull request #220 from sartography/prevent-duplicate-template-upload-111
...
Users cannot upload a workflow_spec_file that already exists. We rais…
2021-01-08 13:55:19 -05:00
Dan Funk
be288ae048
Merge pull request #219 from sartography/fix-api-call-missing-fieldname-143
...
Fixed ApiError call. Now includes task_id and task_name.
2021-01-08 13:46:26 -05:00
Dan Funk
81fe3e7957
Merge pull request #218 from sartography/is-file-uploaded-143
...
Ticket 143. Test whether file is uploaded.
2021-01-08 13:45:24 -05:00
Dan
72a73c1fc4
Allow for synch to work even if the local set of workflow specifications are completely empty.
2021-01-08 13:23:01 -05:00
mike cullerton
d274813ae5
We now check form field IDs so they play well with Python and Javascript.
2021-01-07 11:10:31 -05:00
mike cullerton
c9a4a9685f
Users cannot upload a workflow_spec_file that already exists. We raise an error that is displayed on the fron end.
2021-01-04 15:47:45 -05:00
mike cullerton
0ae4448fbe
Fixed ApiError call. Now includes task_id and task_name.
2021-01-04 13:48:34 -05:00
Dan
b0dc834682
Don't error out on autocomplete_num
2021-01-04 13:41:57 -05:00
mike cullerton
0c47d09972
Ticket 143. Test whether file is uploaded.
2021-01-04 10:53:21 -05:00
Dan Funk
386feddeed
Merge pull request #214 from sartography/validate-hide-expression-103
...
Modified study_info do_task_validate_only so that we take the default…
2020-12-31 10:53:27 -05:00
Dan Funk
cf106fb9cd
Merge pull request #216 from sartography/place-study-on-hold-20
...
Studies can now be put on hold in the dashboard. We were overriding t…
2020-12-31 10:53:03 -05:00
mike cullerton
80d2009573
Modified the test to cover hold, abandon, and open_enrollment. These are tickets 21 and 94
2020-12-31 10:40:27 -05:00
mike cullerton
ede5df4df5
Studies can now be put on hold in the dashboard. We were overriding the status in StudyModel.update_from_protocol_builder.
2020-12-30 17:49:59 -05:00
Dan
c13ee15449
Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev
2020-12-30 14:52:05 -05:00
Dan
efdbbcbc72
StudyInfo sometimes returns arrays of items, each item in the array should be coverted to a Box dictionary if possible.
2020-12-30 14:51:51 -05:00
Dan Funk
dfddc46a7b
Merge branch 'testing' into dev
2020-12-30 12:48:40 -05:00
mike cullerton
f29429f0d0
Modified study_info do_task_validate_only so that we take the default path in ind_update workflow.
2020-12-30 10:04:10 -05:00