971 Commits

Author SHA1 Message Date
mike cullerton
f900279a02 include workflow.user_id in the WorkflowApi Model 2022-12-01 12:24:08 -05:00
Dan Funk
49f7cd92a6
Merge pull request #573 from sartography/bug/rename-file-issue
Rename file issue #768
2022-11-17 11:45:34 -05:00
mike cullerton
00c1c80356 Backend changes for renaming a bpmn file. 2022-11-17 10:47:35 -05:00
Dan
513d5664c1 Getting all tests passing with latest SpiffWorkflow. 2022-11-16 12:29:18 -05:00
jpitts-uva
e7e4e6afc7 Merge branch 'dev' into pb-sync-date 2022-10-19 14:21:41 -04:00
Dan
2249965ade Paginator arguments changed slightly in latest releases of SQLAlchemy
Spiffworkflow 1.2:  Top Level Imports moved to appropriate modules
   - replace 'from SpiffWorkflow import WorkflowException' to 'from SpiffWorkflow.exceptions import WorkflowException'
   - replace 'from SpiffWorkflow import TaskState' to 'from SpiffWorkflow.task import TaskState'
   - replace 'from SpiffWorkflow import Task' to 'from SpiffWorkflow.task import Task'

SpiffWorkflow 1.2: Navigation code removed completely.  Proved to be of little use to folks, was super complex and difficult to maintain.

SpiffWorkflow 1.2: When inserting custom functions into the PythonExecutionEngine - be aware that the task data will act as the full context for execution, and will contain global functions and methods during the exec call.

SpiffWorkflow 1.2: All Task Specs now have a spec_type attribute, containing a descriptive string of the type, such as "User Task", "Script Task", "Start Event" etc...
2022-10-07 14:58:08 -04:00
Dan
5c76c90d04 send_file's arguments changed in a 2.2 of Flask.
Spiffworkflow 1.2:  remove all references of timeit (no longer in SpiffWorkflow)
Spiffworkflow 1.2:  pythonScriptEngine._evaluate no longer accepts a task argument.
Spiffworkflow 1.2:  CancelEventDefinition was removed - please use SignalEventDefinition instead
 EX: replace bpmn_workflow.signal('cancel')  # generate a cancel signal.
              bpmn_workflow.catch(CancelEventDefinition())
 WITH: bpmn_workflow.catch(SignalEventDefinition('cancel'))
Spiffworkflow 1.2:  Task States are JUST integers and TaskSpecNames is now a public dictionary, and can be used to covert a state to human readable string
    EX:  REPLACE:  user_task.state.name
         WITH:     TaskStateNames[user_task.state]
2022-10-05 15:31:56 -04:00
jpitts-uva
369f1e64ed Fixed conflicts 2022-09-30 14:50:52 -04:00
jpitts-uva
e2a2a691ef Filtering of studies is now by creation date instead of modified date. 2022-09-15 22:53:38 -04:00
jpitts-uva
33016005c2 Filtering of studies is now by creation date instead of modified date. 2022-09-15 15:36:17 -04:00
Dan
4305b36b74 Removed total_tasks and completed_tasks - as they are no longer used by the front end, and were dubious as hell to begin with.
Upraded SpiffWorkflow and now use th new get_subprocess_specs
updated the calculate_stats in the workflow processor - as the serialization had changed drastically, and needed to debug some performance issues.
Added a get_navigation method that will calcuate a basic navigation list MUCH faster than using the get_flat_nav_list in Spiffworkflows Navigation object.
Modified a hellton of tests because we don't have total_task and completed_task counts, or a complex nested navigation list anymore.
2022-07-20 12:10:23 -04:00
Dan
9ab29cf1fe Upgrade spiffworkflow - the WorkflowTaskExecException was moved - so we have to update all import statements. 2022-07-14 13:37:16 -04:00
mike cullerton
cd743b4a72 Clean up data_store set
Fix workflow_service to work with data_store_service
2022-07-13 11:47:30 -04:00
mike cullerton
a1c5f0d492 Be explicit about values in data store service.
I.e., none of this adding variables to args, and counting them
2022-07-12 16:11:50 -04:00
mike cullerton
644629fbc8 Bug deleting a study 2022-07-12 15:07:19 -04:00
Dan
b15750d2e4 Cleaned up the Workflow Processor's init method
* removed all the performance metric code into a separate function.
* restructured the code so it is either creating a new workflow, or deserializing an old one.
* Added code to upgrade serialized objects from 1.0 to 1.1
* Using the new method of creating a bpmn_workflow object:
```python
                parser = self.get_spec_parser(self.spec_files, spec_info)
                top_level = parser.get_spec(spec_info.primary_process_id)
                subprocesses = parser.get_process_specs()
                self.bpmn_workflow = BpmnWorkflow(top_level, subprocesses, script_engine=self._script_engine)
```
Fixed a few minor bugs that stood out while testing
1. when updating a workflow, we should check for a valid task BEFORE calling cancel_notify, which requires a valid task.
2. get_localtime - quick fix on the date parser - for python 3.9.
3. the start_workflow script would error out in a way that made it unclear which workflow was having the problem.  Fixed the error.
2022-06-24 11:34:39 -04:00
Dan Funk
9378a2ae1f
Merge pull request #557 from sartography/chore/return-to-pi-api-759
Chore/return to pi api #759
2022-06-20 16:40:33 -04:00
Dan Funk
56d3a61f54
Merge pull request #556 from sartography/chore/email-attachment-info-758
Chore/email attachment info #758
2022-06-20 12:55:07 -04:00
mike cullerton
7c9ccac8d2 Add new PB API endpoint for Pre Reviews. 2022-06-20 11:24:54 -04:00
mike cullerton
f060c60b03 save doc_codes to the DB, when we send an email 2022-06-15 17:06:01 -04:00
mike cullerton
4dcba38fdd Add a method to FileSystemService that moves a workflow spec to a different category. 2022-06-07 12:55:48 -04:00
Dan Funk
d434602f55
Merge pull request #551 from sartography/chore/current-user-changes-755
Chore/current user changes #755  and lane permissions #737
2022-06-03 15:45:49 -04:00
Dan
0746848d8d just a little quick cleanup 2022-06-03 15:28:04 -04:00
mike cullerton
30d6c3ac36 Make sure we are in a lane 2022-06-02 15:56:45 -04:00
mike cullerton
906e02f81a Set the LOCKED state for StartEvent
We use this in lanes
2022-06-02 14:25:28 -04:00
mike cullerton
2063ee42d8 Allow impersonations when checking user_is_admin 2022-06-02 14:24:05 -04:00
mike cullerton
6911ab7aae Fixes for failing tests after removing current_user from task data 2022-05-31 16:53:15 -04:00
mike cullerton
f74afc3e18 Remove current_user from task data 2022-05-31 16:51:03 -04:00
mike cullerton
1d8fc77cf3 Add impersonator to current_user, if we have one 2022-05-31 15:01:34 -04:00
mike cullerton
2f6b84e29c add get_impersonator method to user_service 2022-05-31 15:00:58 -04:00
mike cullerton
0887fec9e2 Merge branch 'chore/unlock-admin-sandbox-739' of https://github.com/sartography/cr-connect-workflow into chore/unlock-admin-sandbox-739 2022-05-26 13:36:43 -04:00
mike cullerton
95c915a434 Remove code that doesn't let master workflow set state and state_message for admin sandbox workflows
Remove test for this feature
2022-05-26 13:35:30 -04:00
Dan
289b4b0ae8 Merge branch 'dev' into chore/unlock-admin-sandbox-739 2022-05-26 11:53:16 -04:00
mike cullerton
5b2b2f7b60 better wording 2022-05-25 15:06:31 -04:00
mike cullerton
2c083f73a8 Add is_admin_workflow attribute to WorkflowApi and WorkflowApiSchema
Set is_admin_workflow when we instantiate WorkflowApi in WorkflowService.processor_to_workflow_api
2022-05-24 15:57:08 -04:00
mike cullerton
eb3011ae5f Don't let the master workflow change the state of workflows in the admin sandbox.
I.e., when category.admin is True

If a workflow is in the admin sandbox, we set the state to 'optional', no matter what the master workflow says

Added a method to get the category for a workflow spec.
2022-05-24 15:28:13 -04:00
mike cullerton
4c24fde952 Code cleanup after file refactor 2022-05-20 10:47:14 -04:00
Dan
e4627c472a rollback database transactions when we encounter an error resetting a workflow, or processing a waiting workflow. 2022-05-19 10:23:48 -04:00
Dan
45d5654da4 Do not automatically archive old files when a file of the same type is added. 2022-05-17 09:39:38 -04:00
Dan
62d2229379 don't delete the status messages, that would be senseless. 2022-05-16 16:42:02 -04:00
Dan
a44a278854 We were providing spurious/inaccurate warnings before because we were passing in the wrong arguments to the function. 2022-05-16 12:58:40 -04:00
mike cullerton
cb2bab33b0 Restore admin warnings 2022-05-11 16:57:39 -04:00
Dan
063da419d0 updating for the last version of Spiffworkflow which deprecates the use of task.STATE values, in favor of TaskState.STATE, for example TaskState.READY 2022-05-10 12:28:55 -04:00
Dan Funk
a78bb46682
Merge pull request #538 from sartography/bug/email-data-issues-735
Bug/email data issues #735
2022-05-10 09:54:16 -04:00
Dan
8d8194da45 Removing some unused code. 2022-05-10 09:42:23 -04:00
mike cullerton
7371d9f4aa cc and bcc should be strings, like recipients 2022-05-10 08:54:11 -04:00
mike cullerton
67f435af2f redundant 2022-05-09 10:06:06 -04:00
mike cullerton
312d338068 Merge branch 'dev' into chore/unlock-admin-sandbox-720 2022-05-09 08:35:13 -04:00
mike cullerton
3d2ba971f2 Include the state message 2022-05-09 08:31:46 -04:00
mike cullerton
f49615bfec Change item to workflow_spec_id 2022-05-06 17:54:05 -04:00