sartography
/
cr-connect-workflow
mirror of https://github.com/sartography/cr-connect-workflow.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,009 Commits 13 Branches 0 Tags 8.7 MiB
Commit Graph

2009 Commits

Author SHA1 Message Date
mike cullerton 39eb5c5c21 This is a decent beginning framework for customer error messages. 
It is not complete, but is in a state where we can start to interact with the front end.
Two tests are failing.
Committing so I can work on an error for Alex.
 2021-02-12 14:18:42 -05:00
Dan Funk 3037cdfca2
Merge pull request #241 from sartography/dev 
dev to testing
 2021-02-12 10:33:37 -05:00
Dan 62fdb38e59 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-12 09:50:55 -05:00
Dan c44e784eb2 Fixing a bug with the user model. 2021-02-12 09:48:41 -05:00
Nile Walker ab3453a70e
Update user.py 2021-02-12 09:43:30 -05:00
Dan Funk 35773ebc29
Merge pull request #240 from sartography/weird-email-error 
The email script was failing validation because of missing parameters…
 2021-02-12 09:31:52 -05:00
Nile Walker 7eeb491dfa User str decode Removed 2021-02-12 09:30:18 -05:00
mike cullerton d8bd203139 The email script was failing validation because of missing parameters in scripts.email.do_task_validate_only. 
I added a test in tests.test_email_script to make sure we get the default email_address.
I also found and fixed a bug in workflow_service.populate_form_with_random_data where we would overwrite default_values with random text because of a missing continue.
(We don't want to continue if we have repeating fields though.)
 2021-02-11 15:36:12 -05:00
Dan 044b82cb25 Maybe a faster, more dependeable dockerfile? 2021-02-11 12:44:34 -05:00
Dan d0f30c4f9c Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-11 11:45:00 -05:00
Dan d08f2ce837 Moving to quay.io, no longer need to run the deploy section for travis, as this is handled within quay. 2021-02-11 11:44:46 -05:00
Dan Funk 508640ea1e
Merge pull request #239 from sartography/dev 
Dev to testing
 2021-02-11 11:41:02 -05:00
Dan Funk fe4e737596
Merge pull request #238 from sartography/value-expression-failing-shield-test-194 
We now allow value_expression to evaluate to an empty string ("") so …
 2021-02-11 11:25:09 -05:00
Dan Funk df0cfc755b
Merge pull request #237 from sartography/get-study-from-model-error-191 
We now test whether we have a valid StudyModel when getting a study b…
 2021-02-11 11:23:59 -05:00
Dan Funk 40639bbd03
Merge pull request #236 from sartography/trap-non-api-errors-187 
New error handler for non Api errors. Ticket 187
 2021-02-11 11:22:48 -05:00
Dan Funk df25b83958
Merge pull request #235 from sartography/index-error-for-enums-186 
Index error for enums 186
 2021-02-11 11:21:50 -05:00
Dan Funk 10b9c7b892
Merge pull request #234 from sartography/hidden-and-required-fields-185 
Hidden and required fields 185
 2021-02-11 11:20:35 -05:00
Dan f7337f4e54 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-11 11:17:56 -05:00
Dan 2ada9f6f42 Private Ldap settings 2021-02-11 11:17:21 -05:00
mike cullerton 39e874504f We now allow value_expression to evaluate to an empty string ("") so that we *do not* set a default value for enums in some cases. 
This was causing an error because "" was not an option for the enum.
 2021-02-10 14:35:58 -05:00
mike cullerton 8a2a8b1443 Still not in working order. Committing to work on another ticket. 2021-02-10 12:28:59 -05:00
Kelly McDonald da0af14724 Changes to enable front-end changes 
Added a human readable name to created user

added last updated task time and name,

added is_review on the workflow which is triggered by a swimlane with a name present.

Notably - it does NOT update or change any of the performance concerns that we were having with this.
 2021-02-10 11:58:19 -05:00
mike cullerton 777cfbdecd We now test whether we have a valid StudyModel when getting a study by study model. 
We raise an ApiError if the model is None or empty.
 2021-02-09 17:37:55 -05:00
mike cullerton 3e32cdedc4 New error handler for non Api errors. Ticket 187 2021-02-09 16:35:57 -05:00
mike cullerton 11177b4296 Test, workflow, and empty spreadsheet for the new code. The workflow references the spreadsheet, which has no rows. 2021-02-08 15:12:11 -05:00
mike cullerton b42b843f7d It was possible for an enum field lookup to return an empty list. This meant there were no options for the list. 
We now test for this and raise an error.
 2021-02-08 15:10:53 -05:00
Dan Funk c14a72719c
Merge pull request #233 from sartography/dev 
Dev to testing
 2021-02-08 10:32:07 -05:00
mike cullerton eb504465f6 Test and workflow for new code. 
We test 2 things.
 - If a field can be hidden and required, it must have a default value or value_expression
 - If a field is hidden and required, make sure we use the default value
 2021-02-08 10:20:05 -05:00
mike cullerton e87e7b5b8b Form fields that can be hidden and required must now have a default value or value_expression. 
Also, if a field is hidden but not required, it should not produce a value.
 2021-02-08 10:18:41 -05:00
mike cullerton fa34bee18a First commit for cleaning up error messages for customers. 
This is *not* in a working state.
Committing this so I can work on another ticket.
 2021-02-04 11:23:05 -05:00
Dan Funk 329146237e
Merge pull request #232 from sartography/boolean-default-values-175 
Boolean default values 175
 2021-02-03 16:34:54 -05:00
Dan Funk effd11f947
Merge pull request #231 from sartography/cancellations-137 
Cancellations 137
 2021-02-03 16:31:18 -05:00
Dan Funk 2d01b92a50
Merge pull request #230 from sartography/pretty-emails-160 
Pretty emails 160
 2021-02-03 16:20:38 -05:00
Dan Funk 1eba20f420
Merge pull request #229 from sartography/workflow-spec-order-74 
Workflow spec order 74
 2021-02-03 16:18:34 -05:00
mike cullerton 1247744463 Test and workflow for new code. 2021-02-03 09:50:37 -05:00
mike cullerton b090e31e00 This fixes 2 issues with setting boolean defaults 
- If the default was False, we failed an early test and returned None. We now only return None if default is None
 - We have a better test for deciding if the default value we return should be True or False. We used to return True if the value was the string 'false'.
 2021-02-03 09:50:16 -05:00
mike cullerton 6f7abc0a97 Added tests to test_workflow_restart to make sure we call cancel_notify events when appropriate. 2021-01-29 14:48:35 -05:00
mike cullerton c5cf3ea7ff Changed call to WorkflowProcessor.reset to reflect change from class method to instance method. 2021-01-29 14:34:09 -05:00
mike cullerton f9e4b6a972 Test and workflow for the new code. We test the correct cancel notify is called, and only when appropriate. 2021-01-29 14:09:42 -05:00
mike cullerton c026717b4a Changed the call to WorkflowProcessor.reset to reflect the change from class method to instance method 2021-01-29 14:06:25 -05:00
mike cullerton 7e76639cf3 When a study is put on hold, we now reset workflows and call any pending cancel_notify events. 
In api.study.update_study we test the study status and call the new WorkflowService method process_workflows_for_cancels.
In services.workflow_service we added the new method process_workflows_for_cancels. It loops through workflows for a study, and resets them if they are in progress.
In services.workflow_processor, we changed the reset method to be an instance method so we can call self.cancel_notify.
In tests.test_lookup_service we changed the call to WorkflowProcessor.reset to reflect the change from class method to instance method
 2021-01-29 14:05:07 -05:00
mike cullerton 83632c64de added exclusion for email template in sonarcloud properties file. 2021-01-28 10:42:15 -05:00
mike cullerton 958d5a6281 Possible solution for W3C issues raised by Sonarcloud 2021-01-28 09:45:53 -05:00
mike cullerton d7a3afe8f4 changed the template to use the responsive html email template at https://github.com/leemunroe/responsive-html-email-template 
added method get_cr_connect_wrapper to render our new html email template. This takes the email text generated from the task element documentation as the email_body.
 2021-01-27 17:12:03 -05:00
Dan Funk 328de0e584
Merge pull request #228 from sartography/dev 
Dev to Test
 2021-01-27 11:32:00 -05:00
mike cullerton 7b91fb9f61 Modified test to check for display_order within workflow category. 2021-01-27 11:08:28 -05:00
Dan Funk cccb722e07
Merge pull request #226 from sartography/enum_default_value_expression_162 
Enum default value expression 162
 2021-01-27 10:43:46 -05:00
mike cullerton 420ef0b2b0 Test and data for cleaning up my smell. We now test explicitly whether a task has both a default_value and value_expression. If so, we raise an error. 2021-01-27 10:22:43 -05:00
mike cullerton 81e55b6055 Cleaning up my smell. A task should only have default_value *or* value_expresion, not both. 2021-01-27 10:21:13 -05:00
mike cullerton c99a388405 We now set the display_order automatically. Users can modify order using the arrows. 2021-01-27 09:50:29 -05:00