Dan Funk
6428e4ab0a
Merge pull request #397 from sartography/email-data-script-487
...
Email data script #487
2021-10-12 15:55:48 -04:00
Dan Funk
dc07d42a9c
Merge pull request #395 from sartography/email-format-489
...
Email format #489
2021-10-12 15:51:57 -04:00
mike cullerton
f41406a6d9
Fixes from changing workflow_id to workflow_spec_id
2021-10-12 13:46:05 -04:00
mike cullerton
1fb298f796
Test for the new formatting
2021-10-08 11:26:54 -04:00
mike cullerton
24932072dc
Merge branch 'dev' into email-data-script-487
2021-10-07 12:30:13 -04:00
mike cullerton
7f11d5bd58
Tests for get_email_data script.
2021-10-07 12:11:22 -04:00
mike cullerton
ea083e3a52
Changes to tests, and new test for the get_file_data script
2021-10-07 09:25:07 -04:00
Dan
b02731df17
Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates)
...
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.
remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
2021-10-04 15:07:47 -04:00
Dan Funk
f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478
...
Ids approval validation #478
2021-09-30 13:59:26 -04:00
Dan Funk
0353161402
Merge branch 'dev' into feature/381_validate_field_types
2021-09-30 13:19:36 -04:00
mike cullerton
2067c7226a
Better test. Actually grab data explicitly from the list in Element Documentation
2021-09-30 12:54:03 -04:00
mike cullerton
7676e230e5
Test and bpmn for enum checkbox
2021-09-30 12:10:47 -04:00
Dan
8e00f16eaa
Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea"
2021-09-29 11:43:08 -04:00
mike cullerton
fb9c3e96ac
Test and mocked status data for adding master workflow into validation.
...
Make sure we see ApiError for disabled workflow spec
2021-09-24 11:08:54 -04:00
Dan Funk
deff293fff
Merge pull request #376 from sartography/bug/468_missing_file_date
...
fixes #448 - Missing file date
2021-09-22 15:29:32 -04:00
Dan Funk
e672d46dd0
Merge pull request #375 from sartography/study-info-adds-463
...
Study info adds #463
2021-09-22 15:28:40 -04:00
Dan
4b591a076f
Adding importlib-resournces as a dependency, which is suddenly failing on Travis, likely due to different versions of Python as I try to upgrade to 3.9
2021-09-21 14:36:57 -04:00
mike cullerton
1e48cbea1a
Added test and workflow for updating `short_name` and `proposal_name`
2021-09-17 12:05:29 -04:00
mike cullerton
7956c71fcc
Changed test to use a workflow, so we have the correct type of task
2021-09-16 13:45:51 -04:00
mike cullerton
cc403f1fac
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-09-09 13:09:35 -04:00
mike cullerton
7211a1de46
Removed unused test files
2021-09-07 15:22:02 -04:00
mike cullerton
96d38e6e65
Removed double-quotes
2021-09-07 15:18:05 -04:00
mike cullerton
d9fa94b64f
Added spreadsheet for testing
2021-09-02 09:56:40 -04:00
mike cullerton
f2741921cb
Added task to select a spreadsheet
2021-09-02 09:56:22 -04:00
mike cullerton
3020c76d5c
Rename test BPMN file
2021-09-01 10:41:21 -04:00
mike cullerton
0c31b091ee
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-09-01 09:38:03 -04:00
mike cullerton
e6a2b9d642
New test and BPMN for changes
2021-08-31 16:18:29 -04:00
Dan
083abd1b58
Just being consistent in the names as we named it delete_task_data in the class, but not elsewhere, and since I'm here, using the name I prefer.
2021-08-26 14:22:12 -04:00
mike cullerton
5f0db3f2fb
Test and BPMN file for new script
2021-08-26 10:42:30 -04:00
mike cullerton
a9452d6533
Modified the test workflow form to add the new bcc, reply_to, and attachments arguments
2021-08-19 17:37:10 -04:00
mike cullerton
2a2fd710c4
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-08-16 14:22:02 -04:00
mike cullerton
ab8714c93e
Remove HSRNUMBER from mock data
2021-08-16 13:01:51 -04:00
Dan Funk
adb1b74822
Merge pull request #352 from sartography/post-process-empty-field-408
...
Post process empty field #408
2021-08-12 10:53:26 -04:00
mike cullerton
e0096ebc8e
Test and BPMN to make sure we don't process when field is hidden, but do process when field is not hidden
2021-08-11 16:44:45 -04:00
Dan
848c2e622f
Always use a schema to define what is being returned, it enforces consistency of the API and internally we can depend on well defined objects.
2021-08-10 16:16:08 -04:00
mike cullerton
e8ea9776a5
Test for creating dmn from spreadsheet
2021-08-02 10:04:47 -04:00
mike cullerton
2c892560ad
Failing test for Call Activity End Events - Ticket 399
2021-07-26 12:12:01 -04:00
mike cullerton
612ce6dc35
Better test to make sure file data works with all standard field types.
...
(Except maybe custom types)
2021-07-23 11:25:36 -04:00
mike cullerton
82bf25cbc6
Test that we set file data_store values correctly when using the file_data property
2021-07-15 13:10:51 -04:00
Mike Cullerton
522ca9d164
Merge pull request #340 from sartography/bug/better_errors_on_scheduled_tasks
...
Assure we log reasonably clear errors when executing scheduled tasks …
2021-07-12 10:13:02 -04:00
Dan
1916c4ff54
Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively.
2021-07-12 09:43:12 -04:00
mike cullerton
682b010f6f
Added mocked study_details with an invalid REVIEW_TYPE
...
This is used to test StudyService.get_studies_for_user
StudyService.get_studies_for_user should now filter on REVIEW_TYPE
2021-07-09 11:38:45 -04:00
mike cullerton
841bbe73ef
Added REVIEW_TYPE to the mocked PB data
2021-07-09 10:38:41 -04:00
Dan Funk
3c52453c26
Merge branch 'dev' into add-name-error-hint-8
2021-07-07 11:35:24 -04:00
Dan Funk
2ed436327f
Merge pull request #333 from sartography/check-study-script-273
...
Check study script #273
2021-07-07 11:28:32 -04:00
Dan
2a45f2fcda
Merge branch 'dev' into add-name-error-hint-8
2021-07-07 11:24:00 -04:00
Dan
fb54edac1c
Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
...
Most noteable is the addition of the line on which the error occurs for script tasks. It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
Dan
1b1a994360
Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them.
...
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
2021-07-06 13:10:20 -04:00
mike cullerton
8145ff9025
Tests for calling the script
2021-07-02 16:14:19 -04:00
mike cullerton
2cb2874a49
Added test and json data for new check_study pb mock api endpoint
2021-07-02 15:26:39 -04:00