sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-23 21:28:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,424 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

468 Commits

Author SHA1 Message Date
mike cullerton
b6b9482a64 *** WIP *** 
Incremental commit. Mainly cleaning up failing tests.
 2022-01-12 13:16:09 -05:00
mike cullerton
4df2ed6ce4 *** WIP *** 
Failing tests, and missing functionality.
Committing to get stuff on Github.
 2022-01-11 15:30:22 -05:00
mike cullerton
f537fd7fbf *** WIP *** 2022-01-07 15:58:23 -05:00
mike cullerton
dc27f795c8 *** WIP *** 
Committing because it is Friday afternoon, and my computer is acting flaky
 2022-01-07 15:34:51 -05:00
mike cullerton
86a6039dc8 *** WIP *** 
**Many** tests are failing!

Committing so I can merge dev into this branch
 2022-01-06 11:46:54 -05:00
Dan
c83b047881 Fixing some bugs I introduced with the latest fix. 2021-12-21 16:22:41 -05:00
Dan
f129509802 Looks like reording the deletes allows us to remove workflow specs a little easier. Tested this with libraries, and seems to work ok. 2021-12-20 14:36:45 -05:00
Dan
421e4fd9aa Fixes related to resent commit to SpiffWorkflow that provides better handling for workflows that loop back on themselves. 2021-12-15 16:00:31 -05:00
mike cullerton
daebf42a30 Move some of the work in crc.api.workflow.delete_workflow_specification to separate workflow_service methods 
Added a session.commit to `delete_workflow_spec_task_events`
 2021-12-13 11:04:28 -05:00
Dan
8ec58fd6d7 Assure better error messages when parsing word documents with jinja syntax. 
I also have a pull request into the folks that run the python docx library to improve their error messages that we depend on here.
 2021-11-23 14:38:48 -05:00
Dan
4a1285b8e0 When validating a workflow, don't run the master workflow multiple times, its a huge waste of time. 
Provide decent data when calling get_study_associate(s) scripts.
 2021-11-22 17:17:19 -05:00
Dan
5bb7dbfb19 Improve the error messages returned from jinja template processing. Try to find the actual line with an error in it. 2021-11-22 14:46:33 -05:00
Dan
12b78c1f99 Value Errors should also alert us that we can't serialize the json. 
Enum Label was depending on the options attribute not existing in some situtations, which is a bad assumption.  Rather, check for specific properties, and call back to using options as the default.
 2021-11-22 12:37:10 -05:00
Dan
4d1f4429ff Fixing a bug in enum_label that was not working when lookup up an select list from a spreadsheet. 
Assure we raise more thoughtful error messages when running getting exceptions in engine tasks.
Field Options should always be available now due to a fix in Spiffworkflow.
 2021-11-22 12:26:30 -05:00
Dan Funk
84f364ce37
Merge branch 'dev' into chore/view-as-382 2021-11-10 15:16:20 -05:00
Dan
9376d3deaf Don't error out trying to send an error about invalid review types. 2021-11-04 13:32:57 -04:00
alicia pritchett
702b8eaed6 add ldap endpoint that doesnt require workflow info 2021-10-28 16:19:39 -04:00
alicia pritchett
7959f8ca3f
Merge pull request #405 from sartography/refactor/enums_as_key_value 
Death to enumerated dictionaries
 2021-10-25 15:17:17 -04:00
mike cullerton
1671caacec Use the new JinjaService 2021-10-21 10:30:42 -04:00
mike cullerton
8fd55565a4 Move changes to another branch 2021-10-20 13:11:06 -04:00
Dan
1c84bd9f1b Merge branch 'dev' into refactor/enums_as_key_value 2021-10-19 12:02:45 -04:00
Dan
5429e7da7d All enumerated lists used in web forms should contain a single value, not a dictionary of value/labels. 
Removing the spreadsheet.value.column and data.value.column so we just have value.column for both.
Improving the __str__ function in the ApiError class, to make debugging a little easier.
Adding a "validate_all" flask command, to help us track down any issues with current workflows in production (use this in concert with sync_with_testing)
Fixed logs of tests.
removed fact_runner.py, a very early and crufty bit of code.
 2021-10-19 10:13:43 -04:00
mike cullerton
1c02928d04 Merge branch 'dev' into jinja-include-403 2021-10-19 10:09:18 -04:00
mike cullerton
0122029e30 *** WIP *** 
Migrating the complete_template script stuff to JinjaService.
Having trouble with the tools stuff.
Pulled back to spot where test pass using CompleteTemplate
 2021-10-18 16:56:03 -04:00
mike cullerton
983c4104e1 We run the same basic Jinja code in 4 different contexts. 
Now call the the Jinja service
 2021-10-16 14:20:48 -04:00
mike cullerton
771019d9ca Clarify call to email service. We now use the words content and content_html 2021-10-13 12:05:08 -04:00
alicia pritchett
40b5bf3afa Adds a POST for reference file. and a cool test 2021-10-12 14:29:15 -04:00
alicia pritchett
8b5686ce40 wip 2021-10-12 09:46:22 -04:00
Dan Funk
a39e0ba219
Merge pull request #390 from sartography/varchar-category-id-483 
Varchar category id #483
 2021-10-07 12:23:56 -04:00
Dan
84680ea846 Fixing multiple issues that came out of Study Info, as we debugged issue #474 related to navigating back to a previous task. 
There was a problem with the python script engine as well that wasn't handling the de-serialize properly and didn't correctly pick back up on the script engine, and the renaming of methods in PythonScriptEngine created some conflicts with the way we override functions.
We were not handling ldap looks up efficiently, and this was also breaking in Study Info.

Finally we had a bug in SpiffWorkflow that did not allow us to reset back to the previous task in some cases where nested call activities happen far later in the process and are currently active when the reset is created.
 2021-10-06 12:17:57 -04:00
mike cullerton
572ca1db6b Fixes for backend code after removing name column from workflow_spec and workflow_spec_category tables 2021-10-05 14:17:41 -04:00
Dan
b02731df17 Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates) 
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.

remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
 2021-10-04 15:07:47 -04:00
Dan
d0c819dd5f sync was failing because it tried to add the libraries before adding the spec the libraries connect to. 2021-09-29 10:21:24 -04:00
Dan Funk
e4add14193
Merge pull request #378 from sartography/bug/246_user_ldap_refactor 
Bug/246 user ldap refactor
 2021-09-22 15:31:34 -04:00
Dan
19104303de Refactor of the way we store and return details about users - All the details about a user, or individual associated with a study is returned within in an Ldap model. I've removed duplication between these models. This required some cleanup of the tests, and a migration that will drop the user details. 2021-09-22 13:16:25 -04:00
mike cullerton
d7b7f39128 Added a field handle that displays the filename, which is what configurators actually call in a script task. 2021-09-22 12:10:43 -04:00
Mike Cullerton
787614ee91
Merge pull request #369 from sartography/dmn-from-spreadsheet-395 
Dmn from spreadsheet #395
 2021-09-14 17:41:01 -04:00
Mike Cullerton
15efc2f3f1
Merge pull request #370 from sartography/library-listing-453 
Library listing #453
 2021-09-14 16:11:56 -04:00
alicia pritchett
a7f032d372 Returns workflow spec categories ordered by display order 
sorry to open a whole branch just for this little fix
 2021-09-14 10:56:41 -04:00
mike cullerton
7b7c228a81 2 changes 
- The `all_specifications` method is now explicit in what it returns; either `library`, `standalone`, or `regular` workflow specs

- When we add/edit a workflow spec, we make sure that `library` and `standalone` workflow specs do not get a category_id
 2021-09-13 16:15:18 -04:00
mike cullerton
5ddff1d1be Merge branch 'dev' into add-reorder-api-endpoints-444 2021-09-09 13:10:54 -04:00
mike cullerton
cc403f1fac Merge branch 'dev' into dmn-from-spreadsheet-395 2021-09-09 13:09:35 -04:00
mike cullerton
9bd012c822 Clean up display_order numbers when reordering. 
This fixes the problem where we have don't have all unique display_order numbers.
I.e., 0, 1, 1, 3, 5
 2021-09-08 11:16:49 -04:00
mike cullerton
a3b3df1bbb Use flask send_file to return DMN file 2021-09-07 12:09:30 -04:00
Dan Funk
1a008499c4
Merge pull request #366 from sartography/file-id-error-info-449 
Added file_id to some error messages in api.file #449
 2021-09-03 14:32:14 -04:00
mike cullerton
8677d0368b Grab the file data from the request, not as a parameter 2021-09-03 10:32:32 -04:00
mike cullerton
b5082b8fd3 Call FileService 2021-09-02 09:53:17 -04:00
mike cullerton
0c31b091ee Merge branch 'dev' into dmn-from-spreadsheet-395 2021-09-01 09:38:03 -04:00
mike cullerton
5db5c7ca43 Added file_id to some error messages in api.file 2021-08-31 15:28:21 -04:00
mike cullerton
ed57993f8d Workflow spec cleanup needs a category_id 2021-08-31 12:17:25 -04:00