mike cullerton
b52343903c
Add name to email script and email_service
2022-04-25 15:38:15 -04:00
mike cullerton
97323279cf
Merge branch 'dev' into email-name-parameter-726
2022-04-25 15:01:06 -04:00
Dan
c3e8793110
hot fix for issus with the new serializer.
2022-04-20 15:22:08 -04:00
mike cullerton
cf68367085
remove unused code
...
cleanup imports
2022-04-20 11:16:07 -04:00
Dan
5686b15de8
Don't return a boolean value for get_irb_info, that's just broken.
2022-04-20 11:00:31 -04:00
Dan
85d11d913f
Merge branch 'dev' into feature/new_spiff_serializer
2022-04-20 10:59:58 -04:00
mike cullerton
fea9c969c2
document => file
...
file_refactor => file
2022-04-20 10:39:19 -04:00
mike cullerton
8e6ca4c97f
DocumentModel => FileModel
...
document_id => file_id
2022-04-19 14:56:34 -04:00
mike cullerton
80560b96c4
doc_code is now required
2022-04-19 11:35:53 -04:00
mike cullerton
fb5731ff23
Merge branch 'dev' into file-refactor-705
...
# Conflicts:
# crc/scripts/delete_task_data.py
# crc/services/workflow_processor.py
# tests/base_test.py
# tests/files/test_delete_task_data.py
2022-04-19 08:19:52 -04:00
mike cullerton
4c81623497
return something for the validation
2022-04-19 08:01:18 -04:00
Dan
5e54c90b47
"Reset" should not mean "re-start". Calling the reset_workflow script will now set the workflow to an "unstarted" state with no outstanding tasks, no json-state structure stored. The workflow is not yet running.
...
Also:
* Assured that arguments are consistent (we always seem to use workflow_spec_id, so I made sure we use that consistently.
* Don't require named parameters - so it's cool to call it like: reset_workflow('my_workflow_id')
* Task Actions (ie create, assign, etc...) are now an enumeration in the models, and not static variables on Workflow Service, so we can reference them consistently from anywhere.
* Removed some repetitive code
* Always try to validate as much as possible in the scripts to save folks time debugging.
*
2022-04-15 15:36:23 -04:00
mike cullerton
dca91b83f5
No longer a static method
2022-04-15 11:45:13 -04:00
mike cullerton
e10bc23623
We archive files now, we don't delete them
2022-04-15 11:44:38 -04:00
Dan
e68c95f03c
New serialization code, with the ability to load from the old serlializer if needed.
...
pipenv insisted on updating some other libraries so slight modifications for markupsafe.
2022-04-15 10:26:23 -04:00
mike cullerton
b304b4725b
Merge branch 'dev' into file-refactor-705
2022-04-14 11:40:08 -04:00
mike cullerton
72f9ac33d0
Consolidate data_store scripts
2022-04-13 17:57:22 -04:00
mike cullerton
216c15ed1c
FileModel => DocumentModel
2022-04-13 08:15:23 -04:00
mike cullerton
b732fee675
Merge branch 'dev' into file-refactor-705
2022-04-12 14:01:49 -04:00
mike cullerton
3be67a8bd9
FileModel => DocumentModel
...
Also, type is no longer an Enum field, no need to grab type.value
2022-04-12 13:44:58 -04:00
mike cullerton
0c313f44b2
FileModel => DocumentModel
...
Don't need separate call for data
2022-04-12 13:43:00 -04:00
mike cullerton
e9ea95d1d7
The IRB Info API endpoint can return a dictionary--if the study is **not** yet uploaded, or a list with 1 dictionary if the study **is** uploaded
2022-04-07 14:38:32 -04:00
Dan Funk
095105e3e6
Merge pull request #508 from sartography/validation-with-data-store-396
...
Validation with data store #396
2022-04-04 16:51:57 -04:00
mike cullerton
f92f9d64ea
Allow users to pass a doc_code to get_zipped_files script
2022-03-28 11:59:10 -04:00
mike cullerton
5229cf457e
Modify scripts to use the changes in data_store_service validate methods
...
Make sure we return values in the validate methods
Minor cleanup
2022-03-25 10:03:12 -04:00
mike cullerton
94abd7eebf
*** WIP ***
...
Add a temporary data store for validation
2022-03-23 15:15:01 -04:00
Dan
befc299475
Merge branch 'dev' into chore/fix_validation_errors
2022-03-19 09:53:12 -04:00
alicia pritchett
b9b8210f8a
rm pi id refs
2022-03-18 12:04:20 -04:00
mike cullerton
d4a1b8ad3b
We didn't return the value for do_task_validation_only
2022-03-18 11:32:37 -04:00
Dan Funk
791ab20f8c
Merge pull request #494 from sartography/chore/fix_validation_errors
...
Chore/fix validation errors
2022-03-14 16:51:27 -04:00
Dan
483d7e858b
Improved Errors - Pick up on the new task_trace information in WorkflowException and pass it on through the api.
...
Also: All script tasks should raise WorkflowTaskExecExceptions - NOT APIExceptions - this is because our scripts are executed by Spiff (not the other way around) so the errors need to pass fluidly through spiff, and come back to use THEN we can convert them to APIErrors. Otherwise we lose all kinds of good information about the error.
2022-03-14 16:00:53 -04:00
mike cullerton
a974b65333
Remove unused code
2022-03-14 12:03:11 -04:00
mike cullerton
3b049e358d
Remove unused imports
2022-03-14 12:02:48 -04:00
mike cullerton
b753f06394
Changes to remove pagination for the get_logs scripts.
...
We only use pagination for the get_logs_for_study API endpoint. (Used on the study page)
2022-03-11 14:03:09 -05:00
mike cullerton
733e596283
rename get_logs to get_logs_for_workflow to better represent what it does
2022-03-11 13:58:25 -05:00
Dan Funk
2d5517bd15
Merge pull request #487 from sartography/chore/update-get-workflow-status-664
...
Chore/update get workflow status #664
2022-03-10 14:30:32 -05:00
Dan
d90bf1c977
always but always return a valid status.
2022-03-10 14:28:47 -05:00
mike cullerton
bbd12da472
Use workflow_spec_id instead of workflow_id, since workflows can be deleted
...
I simplified do_task_validation since we get a random string for the workflow_spec_id
2022-03-09 11:14:54 -05:00
Dan
0a906a4b3c
Cleaning up Print Statements (it was making it hard to see what was happening)
...
The Jinja2 service was treating all the task data as a possible template, modified it to only include the referenced templates.
(This turned out not to be the problem, but it seems like a good idea to keep it in place)
There is a terrible bug with the wordwrap pipe that will die without any details if you pass it a value of None. We now cature the terrible error, and replace it with a sensible one.
Removed an unused Jinja_extensions file.
2022-03-08 15:46:36 -05:00
Dan Funk
3f82cdae48
Merge pull request #485 from sartography/bug/validating-associates-659
...
Bug/validating associates #659
2022-03-07 14:20:20 -05:00
mike cullerton
eb7548ea0f
Use the actual enum values so we don't have to deal with this the next time we make a change to study status
2022-03-07 13:28:29 -05:00
mike cullerton
30f68eb831
If we receive a study_id during validation, return the associates for the study
2022-03-04 16:27:33 -05:00
mike cullerton
027e436546
Cleaned up the description
2022-03-03 11:49:45 -05:00
mike cullerton
c6484f7bdb
Remove print statement
2022-03-03 11:28:21 -05:00
mike cullerton
3920444acf
*** WIP ***
...
Need to create a migration and some tests.
2022-03-02 15:26:21 -05:00
Dan
51a14311eb
An optimization prevented us from picking up a change to the documents associated with a study. This assures that even if scripts run side by side, the document list will get updated, but only on a change. So it's still performant. Also added a sligthly better error message to the workflow service.
2022-02-28 12:17:21 -05:00
mike cullerton
f2c97f80d5
Merge branch 'dev' into feature/delete-variable-script-584
...
# Conflicts:
# Pipfile.lock
2022-02-25 15:54:34 -05:00
Dan Funk
18802d6732
Merge pull request #468 from sartography/chore/performance
...
Performance Improvements:
2022-02-25 12:10:47 -05:00
Dan Funk
b6af80f6de
Merge pull request #469 from sartography/feature/modify-spreadsheet-624
...
modify spreadsheet #624
2022-02-25 10:29:37 -05:00
Dan Funk
5ff84d74f1
Merge pull request #464 from sartography/feature/start-workflow-602
...
Feature/start workflow #602
2022-02-25 10:28:26 -05:00
