sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 13:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,494 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

167 Commits

Author SHA1 Message Date
Dan
ad095aaaf5 don't try to load the workflowspecservice too early. 2022-02-07 12:38:00 -05:00
Dan
abc17a8aff load the workflow_spec_service from app to avoid frequent file scans. 2022-02-07 12:30:20 -05:00
Dan
1c384a78e9 the tests kind of try and run now ... 2022-02-07 12:18:32 -05:00
Dan
ff9b2694ae Fix migrations that depend on removed models. 2022-02-07 11:56:22 -05:00
Dan
ed07907ee2 at least allow the tests to spin up, even if they all fail. 2022-02-07 11:00:19 -05:00
Dan
2383c7d76d WIP - lots of random changes, trying to swtich over 2022-02-04 14:50:31 -05:00
Dan
6765afbd02 WIP - Move the categories and specifications out of the database. 2022-02-04 13:51:39 -05:00
Dan
4ec6e403f5 1. Created a UserFileService, so it's clear what we use when for File Services, UserFiles, SpecFiles, and ReferenceFiles each function differently. 
2. Reference Files and Spec Files are written to disk, they do not exist in the database at all.
 2022-02-02 12:59:56 -05:00
Dan
4c00a5762f partial commit - new spec_file_service, and new spec_file_api endpoints that use spec and file name, not file id. 
removed worklow_sync
cleaned up file and workflow models
most of the test are broken.
 2022-01-28 06:42:37 -05:00
Dan Funk
97c29bf77c
Merge pull request #449 from sartography/files-to-filesystem-572 
Files to filesystem 572
 2022-01-26 10:11:26 -05:00
mike cullerton
6f31a26772 Better description 2022-01-24 11:06:01 -05:00
mike cullerton
2ecf6cdf86 Validation is the right way to test this. 2022-01-24 11:03:49 -05:00
mike cullerton
73e250a54c Test for missing library hint in the error message 2022-01-24 10:35:11 -05:00
mike cullerton
91fa44b2ab ** WIP ** 
Committing so I can work on another ticket.
 2022-01-21 14:37:11 -05:00
mike cullerton
7e5f2a7d6a We no longer use versioning for spec files 2022-01-12 15:09:03 -05:00
mike cullerton
b99ed73951 Remove unused imports 2022-01-12 15:00:26 -05:00
mike cullerton
4df2ed6ce4 *** WIP *** 
Failing tests, and missing functionality.
Committing to get stuff on Github.
 2022-01-11 15:30:22 -05:00
mike cullerton
dc27f795c8 *** WIP *** 
Committing because it is Friday afternoon, and my computer is acting flaky
 2022-01-07 15:34:51 -05:00
Dan
f129509802 Looks like reording the deletes allows us to remove workflow specs a little easier. Tested this with libraries, and seems to work ok. 2021-12-20 14:36:45 -05:00
alicia pritchett
0e28d2c5f5 Fix a test 2021-12-10 12:16:39 -05:00
Dan Funk
0cfa59bfea
Merge pull request #429 from sartography/chore/clear-form-data-553 
Fixes #553 - Don't load Form data
 2021-12-08 10:37:44 -05:00
Dan
ffafc1674a assure we don't overwrite task data with a previous form submission if that data already exists. 2021-12-07 17:04:20 -05:00
mike cullerton
4ea3682dd6 Updated for new ProtocolBuilderCreatorStudy model and schema 
Removed unused imports
 2021-12-06 14:43:07 -05:00
alicia pritchett
22320efad4 test for this ticket 2021-12-03 12:23:57 -05:00
Dan
676321c2e2 Fixing a test. 2021-11-30 12:55:52 -05:00
Dan
ad93b5fae6 We were not correctly handing the possibility of there only being a waiting task (and no ready tasks). 
We also had a problem with the validator throwing a 500 when it was trying tell us it would never finish validation.
 2021-11-30 12:44:35 -05:00
Dan
b12e178288 Fixing a failing test. 2021-11-17 14:12:15 -05:00
alicia pritchett
1866e6bba9 Fixes validation for #518 
Well really what this does is give every field a default value of None. what that does is allow you to use value expressions even without a given default value. this part in the backend fixes validation.
 2021-11-01 14:35:30 -04:00
Dan
539174d4c4 drop unused method 2021-10-21 14:02:19 -04:00
Dan
5429e7da7d All enumerated lists used in web forms should contain a single value, not a dictionary of value/labels. 
Removing the spreadsheet.value.column and data.value.column so we just have value.column for both.
Improving the __str__ function in the ApiError class, to make debugging a little easier.
Adding a "validate_all" flask command, to help us track down any issues with current workflows in production (use this in concert with sync_with_testing)
Fixed logs of tests.
removed fact_runner.py, a very early and crufty bit of code.
 2021-10-19 10:13:43 -04:00
Dan Funk
a39e0ba219
Merge pull request #390 from sartography/varchar-category-id-483 
Varchar category id #483
 2021-10-07 12:23:56 -04:00
mike cullerton
da894219c5 Changes to tests after removing name column from workflow_spec and workflow_spec_category tables. 2021-10-05 14:20:03 -04:00
Dan
b02731df17 Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates) 
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.

remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
 2021-10-04 15:07:47 -04:00
Dan Funk
f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478 
Ids approval validation #478
 2021-09-30 13:59:26 -04:00
Dan Funk
0353161402
Merge branch 'dev' into feature/381_validate_field_types 2021-09-30 13:19:36 -04:00
mike cullerton
2067c7226a Better test. Actually grab data explicitly from the list in Element Documentation 2021-09-30 12:54:03 -04:00
mike cullerton
7676e230e5 Test and bpmn for enum checkbox 2021-09-30 12:10:47 -04:00
Dan
8e00f16eaa Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 11:43:08 -04:00
mike cullerton
fb9c3e96ac Test and mocked status data for adding master workflow into validation. 
Make sure we see ApiError for disabled workflow spec
 2021-09-24 11:08:54 -04:00
mike cullerton
9aadaac0df Test to make sure we do not set a category_id for library workflow specs 2021-09-13 16:16:05 -04:00
mike cullerton
5ddff1d1be Merge branch 'dev' into add-reorder-api-endpoints-444 2021-09-09 13:10:54 -04:00
mike cullerton
a35d122a03 Tests for case where we have bad display_order numbers. 
I.e., 0, 1, 1, 1
 2021-09-08 11:18:06 -04:00
mike cullerton
e6a2b9d642 New test and BPMN for changes 2021-08-31 16:18:29 -04:00
mike cullerton
86583aa2d6 Be explicit about loading sample data 
Add category_id when checking order
 2021-08-31 12:19:45 -04:00
mike cullerton
cfd8f3fe74 Test for reordering remaining spec categories after delete 2021-08-30 15:21:42 -04:00
mike cullerton
e317b59bfe Test for reordering workflow specs upon deletion 2021-08-30 14:57:16 -04:00
mike cullerton
c99080845b renamed a test 2021-08-30 13:56:27 -04:00
mike cullerton
dfe967d578 Tests for reordering categories 2021-08-30 13:56:13 -04:00
mike cullerton
d43eb4d6f8 Tests for workflow spec reordering 2021-08-30 12:35:57 -04:00
mike cullerton
543fc1fb4a Start of tests for new reorder API endpoint 
Modified example_data to include a display_order for example spec
 2021-08-27 13:04:11 -04:00