Commit Graph

1483 Commits

Author SHA1 Message Date
Kelly McDonald 442a4524c4 Test for new functionality and code coverage 2021-01-12 10:18:35 -05:00
Kelly McDonald cf7990ce85 Refactor for better readability due to code smell test 2021-01-12 08:54:32 -05:00
Kelly McDonald abc17add89 file order was not deterministic - alter test to make sure we updated the 'right' file rather than relying on ordering 2021-01-12 08:54:15 -05:00
Dan Funk 3056fe28e1
Merge pull request #222 from sartography/dev
dev to testing
2021-01-11 14:18:46 -05:00
Kelly McDonald e14b896225 Add documentation 2021-01-11 09:31:08 -05:00
Kelly McDonald f282a9ef73 Make sure that top_level_workflow is transferred over, also include reference files in the list of files to sync
We may want to revisit this because I used a 'Magic' workflow_ref_id of 'REFERENCE_FILES' as a special case so I could re-use most of what I already had. This works well, but we may want to structure it different.
2021-01-11 09:21:44 -05:00
Dan 336c093bf8 Catch errors when building enumeration lists. 2021-01-08 15:15:24 -05:00
Dan Funk 4bb4a93161
Merge pull request #221 from sartography/validate-form-field-names-96
We now check form field IDs so they play well with Python and Javascript
2021-01-08 14:42:54 -05:00
Dan 26655b26d3 merging in dev, and fixing a failing test from dev. 2021-01-08 14:42:13 -05:00
Dan Funk 9118517995
Merge pull request #220 from sartography/prevent-duplicate-template-upload-111
Users cannot upload a workflow_spec_file that already exists. We rais…
2021-01-08 13:55:19 -05:00
Dan Funk be288ae048
Merge pull request #219 from sartography/fix-api-call-missing-fieldname-143
Fixed ApiError call. Now includes task_id and task_name.
2021-01-08 13:46:26 -05:00
Dan Funk 81fe3e7957
Merge pull request #218 from sartography/is-file-uploaded-143
Ticket 143. Test whether file is uploaded.
2021-01-08 13:45:24 -05:00
Dan 72a73c1fc4 Allow for synch to work even if the local set of workflow specifications are completely empty. 2021-01-08 13:23:01 -05:00
mike cullerton d274813ae5 We now check form field IDs so they play well with Python and Javascript. 2021-01-07 11:10:31 -05:00
mike cullerton c9a4a9685f Users cannot upload a workflow_spec_file that already exists. We raise an error that is displayed on the fron end. 2021-01-04 15:47:45 -05:00
mike cullerton 0ae4448fbe Fixed ApiError call. Now includes task_id and task_name. 2021-01-04 13:48:34 -05:00
Dan b0dc834682 Don't error out on autocomplete_num 2021-01-04 13:41:57 -05:00
mike cullerton 0c47d09972 Ticket 143. Test whether file is uploaded. 2021-01-04 10:53:21 -05:00
Dan Funk 2656821b61
Merge pull request #217 from sartography/dev
Additional bug fixes #214, #216
2020-12-31 13:39:38 -05:00
Dan Funk 386feddeed
Merge pull request #214 from sartography/validate-hide-expression-103
Modified study_info do_task_validate_only so that we take the default…
2020-12-31 10:53:27 -05:00
Dan Funk cf106fb9cd
Merge pull request #216 from sartography/place-study-on-hold-20
Studies can now be put on hold in the dashboard. We were overriding t…
2020-12-31 10:53:03 -05:00
mike cullerton 80d2009573 Modified the test to cover hold, abandon, and open_enrollment. These are tickets 21 and 94 2020-12-31 10:40:27 -05:00
mike cullerton ede5df4df5 Studies can now be put on hold in the dashboard. We were overriding the status in StudyModel.update_from_protocol_builder. 2020-12-30 17:49:59 -05:00
Dan Funk 404ff5a586
Merge pull request #215 from sartography/dev
Covert arrays of dicts to arrays of Box in the script task.
2020-12-30 15:09:23 -05:00
Dan c13ee15449 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2020-12-30 14:52:05 -05:00
Dan efdbbcbc72 StudyInfo sometimes returns arrays of items, each item in the array should be coverted to a Box dictionary if possible. 2020-12-30 14:51:51 -05:00
Dan Funk c4ad71e5b5
Merge pull request #213 from sartography/dev
A hard or soft reset should also cause a 'cancel_notify' which will k…
2020-12-30 13:18:10 -05:00
Dan Funk dfddc46a7b
Merge branch 'testing' into dev 2020-12-30 12:48:40 -05:00
mike cullerton f29429f0d0 Modified study_info do_task_validate_only so that we take the default path in ind_update workflow. 2020-12-30 10:04:10 -05:00
Dan e5a38874f6 A hard or soft reset should also cause a 'cancel_notify' which will kick off any CANCEL events. If this happens during
a hard or soft reset, and an error is thrown trying to fulfil a cancel event, the reset should still fire.
Sending emails still had a number of issues correctly parsing it's arguments.  This is corrected.
2020-12-29 18:05:13 -05:00
Dan Funk e1eee2bbd8
Merge pull request #212 from sartography/dev
Assert field types are set in the validation code.
2020-12-29 14:35:51 -05:00
Dan Funk 578f9e4b81
Merge pull request #211 from sartography/check-field-type#143
Check field type#143
2020-12-29 11:27:05 -05:00
Dan 96739d99c4 Fixing a failing test because new logic was catching a different error. 2020-12-29 11:14:40 -05:00
Dan c288a8a2bc Merge branch 'dev' into check-field-type#143 2020-12-29 11:11:43 -05:00
Dan Funk c6153c218b
Merge pull request #210 from sartography/dev
dev to test
2020-12-28 18:11:48 -05:00
mike cullerton 052ee40238 Cleanup from test email script changes. Removed commented piece of code containing my private email address. 2020-12-28 18:05:47 -05:00
mike cullerton 06318c87b1 Test and workflow for changes to workflow_service. The workflow does not have a field type. We look for evidence of raised exception in data of response. 2020-12-28 18:03:59 -05:00
mike cullerton 7938ac8eed We now assure each form field has a field type. Modified populate_form_with_random_data, added check at beginning of form field loop. 2020-12-28 18:02:16 -05:00
Dan 084e9d50a4 Bouncing the spiffworkflow version to properly fix #155 2020-12-28 17:55:52 -05:00
Dan 6cfce839c1 Validation now assures that we won't encounter errors when generating navigation lists.
Fixing workflow sync paths that were incorrect.
Repairing a suddenly failing test in files, that just don't make no sense.
Bumping spiffworkflow that contains a fix for issue #155
2020-12-28 17:33:38 -05:00
Dan Funk cdd3c13dff
Merge pull request #209 from sartography/dev
Email Script, Sentry User details, Workflow Spec Transfers, Navigation refactor
2020-12-14 21:56:38 -05:00
Dan 86ba20b2b4 Moving back to using Spiffworkflow master. 2020-12-14 21:44:50 -05:00
Dan Funk 4246c1ec7e
Merge pull request #206 from sartography/bug/navigation
Bug/navigation
2020-12-14 12:05:26 -05:00
Dan 1f9bf72c59 Merge branch 'dev' into bug/navigation 2020-12-14 11:46:44 -05:00
Dan Funk 4268d0f482
Merge pull request #208 from sartography/152-workflow-spec-pull
152 workflow spec pull
2020-12-14 11:35:06 -05:00
Dan bcb78de225 Merge branch 'dev' into bug/navigation 2020-12-14 11:33:51 -05:00
Dan Funk e54404e424
Merge pull request #205 from sartography/test-email-script
Test email script
2020-12-14 11:28:14 -05:00
Dan 6bf24cc438 fixing some failing tests related to changes in the underlying spiffworkflow library. 2020-12-14 11:27:38 -05:00
Dan b62a9c7074 Merge remote-tracking branch 'origin/dev' into bug/navigation 2020-12-14 10:40:21 -05:00
Dan Funk 9fb5a17c97
Merge pull request #207 from sartography/user-id-in-sentry#153
User id in sentry#153
2020-12-14 10:38:54 -05:00