sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-22 20:58:28 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,615 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

878 Commits

Author SHA1 Message Date
Kelly McDonald
2ed825aef3 Fixes problem with swtiching users fixes #237 2021-03-10 10:59:15 -05:00
Mike Cullerton
eaf52a21ca
Merge pull request #260 from sartography/bug/delete_study 
Allows us to delete a study even if there are emails, and associated …
 2021-03-09 13:51:25 -05:00
Dan
80ff8a6212 Allows us to delete a study even if there are emails, and associated study users connected to that study. 2021-03-09 13:31:26 -05:00
Dan
576aebab19 Sometimes a workflow can be completely broken and unloadable. For instance, it starts off with a engine step / script task that will not execute. So the failure happens the second it is processed. When calling reset on a workflow, we should catch the failure, and reset the workflow, so we aren't trapped in an unrecoverable state. 
To do so, I changed the WorkflowProcessor's reset method to be static, it will try to instantiate the current workflow and execute a cancel_notify event, but if that fails, it will continue and always return a new workflow processor using the latest spec.
 2021-03-09 11:52:55 -05:00
mike cullerton
7171219e8b removed unused import 2021-03-09 07:00:20 -05:00
mike cullerton
44ac55bc32 We can now send emails to users associated with a study, by using 'associated' as the recipient 
We now use keyword arguments in the email script; subject and recipients
 2021-03-09 06:49:39 -05:00
Dan
36dcc58705 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-03-08 14:00:14 -05:00
Dan
291216e081 Fixing a bug that prevented proper evaluation of a enum field where the default value was null or empty. 2021-03-08 14:00:03 -05:00
mike cullerton
f883eb2bbe We now include field.id in the ApiError message for hidden and default validation. (The field must have a default value or value expression) 
While working on this ticket I found a logic error in the test. I expected both default_value and value_expression. It turns out the default_value is always there, it's just null if we don't set it.

Modified the existing test for hidden and required, and added tests to make sure my passing logic is now correct.
 2021-03-04 10:42:13 -05:00
Dan
9e758c57d3 Merge branch 'dev' into bug/225_enum_lookup_same_field_name 2021-03-02 14:15:58 -05:00
Dan Funk
572eb3457a
Merge pull request #252 from sartography/customer-error-messages-192 
Customer error messages 192
 2021-03-02 13:45:38 -05:00
Dan
adb9e3afba Merge branch 'dev' into bug/225_enum_lookup_same_field_name 2021-03-02 13:40:21 -05:00
Dan
c8f5a44050 adding a warning in the logger so we can see when expensive calls are made to rebuild searches for enumerations. But all looks good. 2021-03-02 12:21:51 -05:00
Kelly McDonald
06dedd8a32 Add short_title to study, change update_study task to use kw arguments and add the short_title to the update_study script 2021-03-02 10:03:53 -05:00
mike cullerton
9a2ffb98ad Customer Error is in a place that we can try it out on testing. 
So far, there are two known errors.
 - Missing condition type (Ticket 178)
 - Invalid property value in extensions tab for display_name (No ticket for this error)

We now have the option of using regular expressions to pull task_id, etc. from an error to pass back to the user in the hint.
 2021-03-01 16:41:55 -05:00
Dan Funk
3e0541fa15
Merge pull request #250 from sartography/206-extend-study-access 
206 extend study access
 2021-03-01 14:55:38 -05:00
Dan
aac3d5c16e Bug #255, this requires the front end to pass in the name of the task, when doing a lookup. This will prevent a bug where we have multiple user tasks, with enum fields that set the same variable, but use different lookup tables to populate the dropbown or search feature. 2021-03-01 14:54:04 -05:00
mike cullerton
9d804c36d5 Merge branch 'dev' into customer-error-messages-192. 
Needed some sql changes from dev
 2021-03-01 10:29:10 -05:00
Kelly McDonald
0b08a95e25 Add test and make sure that the API endpoint does the right thing when we switch users - checks both associated with access and associated with no access 2021-02-25 12:20:43 -05:00
mike cullerton
5c3d791bf3 UVA asked us to remove the extra whitespace in emails. 
We removed the string replacement of '\n' -> '<br>' to solve this.
This means you can't purposely add blank lines any more.
Trade offs.
 2021-02-25 11:08:08 -05:00
Kelly McDonald
f3414e22c1 use the associated table to grant access to users who have been designated to have access to the study, not just the study owner. 2021-02-25 11:08:06 -05:00
Kelly McDonald
f592a8a0b0 Added a few more tests - I think I need to test one more script endpoint 2021-02-25 09:07:46 -05:00
Kelly McDonald
9bd3aa8dcb service and scripts with working test - still needs a few more tests to try out, but should work to get Mike going 2021-02-24 12:55:23 -05:00
Kelly McDonald
c795dd7aea Merge branch 'dev' into 206-extend-study-access 2021-02-24 12:16:35 -05:00
Kelly McDonald
3dbe39c6fe initial checkin of changes for branch 2021-02-24 12:05:06 -05:00
mike cullerton
f937ac3ce9 Getting some thoughts down for the extension property error. This might force us to use regexes for the error service. 
Committing so I can work on another branch.
 2021-02-24 10:56:25 -05:00
mike cullerton
0a58dce394 Changes for ticket 215 - Change email header and footer to say CR Connect 2021-02-23 12:13:21 -05:00
Dan Funk
349c3d657a
Merge branch 'dev' into 201-changes-to-in-progress 2021-02-22 18:17:59 -05:00
Dan Funk
53fa49e668
Merge pull request #243 from sartography/183-remove-study-approval-code 
Remove Approvals per ticket 183
 2021-02-22 18:12:02 -05:00
mike cullerton
4fc2929356 Put the preamble back in to the error message. 2021-02-19 15:57:01 -05:00
mike cullerton
3b06795c4c File cleanup for readability. Removed some commented code. 2021-02-19 14:49:53 -05:00
Kelly McDonald
4fa0f9720a Allow frontend to honor 'view as' and fix problem with tests 2021-02-18 11:25:17 -05:00
Kelly McDonald
8c309e9a41 Add user display name to the response for task events 2021-02-18 08:44:44 -05:00
Kelly McDonald
6fbaecf9b2 Change selection to include task events that are for someone else, but are on a study I own. 2021-02-18 08:09:13 -05:00
Dan Funk
f0a921d46d
Merge pull request #242 from sartography/allow-period-in-field-id-199 
Allow period in field id 199
 2021-02-17 15:08:53 -05:00
Kelly McDonald
93f29e86d8 Merge branch 'dev' into STG-181_frontend-ux-model-changes 2021-02-17 07:49:05 -05:00
Dan
ff8a44a7b1 Make sure we always have a current user, even if the very first task is a script task. 2021-02-16 12:42:59 -05:00
Kelly McDonald
e54a6956df Make a change in the case that we have no task_events at all. 2021-02-16 11:10:40 -05:00
Kelly McDonald
118cf62172 Merge remote-tracking branch 'origin/dev' into STG-181_frontend-ux-model-changes 2021-02-16 10:07:34 -05:00
Kelly McDonald
003bf2f9b9 Remove Approvals per ticket 183 2021-02-16 09:05:29 -05:00
Kelly McDonald
3b1dc70558 Add comment for later ticket 2021-02-16 08:44:41 -05:00
mike cullerton
ed6218028c We now allow periods in field ids. 
Also, added task_id and task_name to the ApiError for missing default value on hidden and required fields
 2021-02-15 16:27:56 -05:00
mike cullerton
39eb5c5c21 This is a decent beginning framework for customer error messages. 
It is not complete, but is in a state where we can start to interact with the front end.
Two tests are failing.
Committing so I can work on an error for Alex.
 2021-02-12 14:18:42 -05:00
Dan
c44e784eb2 Fixing a bug with the user model. 2021-02-12 09:48:41 -05:00
Dan Funk
35773ebc29
Merge pull request #240 from sartography/weird-email-error 
The email script was failing validation because of missing parameters…
 2021-02-12 09:31:52 -05:00
Nile Walker
7eeb491dfa User str decode Removed 2021-02-12 09:30:18 -05:00
mike cullerton
d8bd203139 The email script was failing validation because of missing parameters in scripts.email.do_task_validate_only. 
I added a test in tests.test_email_script to make sure we get the default email_address.
I also found and fixed a bug in workflow_service.populate_form_with_random_data where we would overwrite default_values with random text because of a missing continue.
(We don't want to continue if we have repeating fields though.)
 2021-02-11 15:36:12 -05:00
Dan Funk
fe4e737596
Merge pull request #238 from sartography/value-expression-failing-shield-test-194 
We now allow value_expression to evaluate to an empty string ("") so …
 2021-02-11 11:25:09 -05:00
Dan Funk
df0cfc755b
Merge pull request #237 from sartography/get-study-from-model-error-191 
We now test whether we have a valid StudyModel when getting a study b…
 2021-02-11 11:23:59 -05:00
Dan Funk
40639bbd03
Merge pull request #236 from sartography/trap-non-api-errors-187 
New error handler for non Api errors. Ticket 187
 2021-02-11 11:22:48 -05:00