d0ddc7a00f
Updated to match new UVA API endpoint
2021-12-06 14:39:49 -05:00
22320efad4
test for this ticket
2021-12-03 12:23:57 -05:00
7ca7de177e
Removed print statements
2021-12-03 11:55:35 -05:00
fa61aa0354
Tests for set_study_status
2021-12-03 11:45:39 -05:00
1ed76bf534
test for get_study_status
2021-12-02 15:31:14 -05:00
cf3f8ce444
Missing the bpmns for a test.
2021-11-30 13:29:31 -05:00
676321c2e2
Fixing a test.
2021-11-30 12:55:52 -05:00
ad93b5fae6
We were not correctly handing the possibility of there only being a waiting task (and no ready tasks).
...
We also had a problem with the validator throwing a 500 when it was trying tell us it would never finish validation.
2021-11-30 12:44:35 -05:00
ec9d8f8a5c
Merge pull request #425 from sartography/bug/slow_ldap
...
Remove wild-card from uid search, it performs very badly. Add a bit …
2021-11-30 11:09:42 -05:00
8c30df011b
Merge pull request #427 from sartography/workflow-status-script-548
...
Workflow status script #548
2021-11-30 10:51:57 -05:00
c8c8c8b244
Merge pull request #424 from sartography/xls-xlsx-issue-540
...
Xls xlsx issue #540
2021-11-30 10:50:33 -05:00
0f1ccd7db5
New script to check workflow status.
...
Includes test and test workflow
2021-11-30 08:54:15 -05:00
b9c936da38
Fix the test.
2021-11-29 11:25:45 -05:00
8ec58fd6d7
Assure better error messages when parsing word documents with jinja syntax.
...
I also have a pull request into the folks that run the python docx library to improve their error messages that we depend on here.
2021-11-23 14:38:48 -05:00
4a1285b8e0
When validating a workflow, don't run the master workflow multiple times, its a huge waste of time.
...
Provide decent data when calling get_study_associate(s) scripts.
2021-11-22 17:17:19 -05:00
5bb7dbfb19
Improve the error messages returned from jinja template processing. Try to find the actual line with an error in it.
2021-11-22 14:46:33 -05:00
4d1f4429ff
Fixing a bug in enum_label that was not working when lookup up an select list from a spreadsheet.
...
Assure we raise more thoughtful error messages when running getting exceptions in engine tasks.
Field Options should always be available now due to a fix in Spiffworkflow.
2021-11-22 12:26:30 -05:00
b12e178288
Fixing a failing test.
2021-11-17 14:12:15 -05:00
5e97953c19
Merge branch 'dev' into xls-xlsx-issue-540
2021-11-16 15:59:06 -05:00
8e2e3519f6
fixes to our tests related to updates in SpiffWorkflow
2021-11-16 15:57:37 -05:00
3569c82e80
fixing additional tests
2021-11-16 15:46:02 -05:00
df0800f071
New test and xls file for failing test
2021-11-16 11:57:24 -05:00
a8b7cd8bba
Merge branch 'dev' into test-protocol-builder-519
2021-11-10 16:32:34 -05:00
e764bf937d
Merge pull request #421 from sartography/bug/validation_of_enum_label_failing_in_sub_workflows
...
Validation was failing for enum_label() expressions when called withi…
2021-11-10 15:26:03 -05:00
84f364ce37
Merge branch 'dev' into chore/view-as-382
2021-11-10 15:16:20 -05:00
d1eae3c15a
Validation was failing for enum_label() expressions when called within a sub-process. Possible (but unlikely) that this would occur outside validation.
2021-11-09 12:55:06 -05:00
cd889c5b67
test that you can't be someone not in ldap
2021-11-09 11:08:55 -05:00
024a63b725
new and improved test
2021-11-09 11:05:04 -05:00
ed5689c1b9
Fixed `test_info_script_documents` to use a mocked call to required_docs.
...
Fixed `test_get_required_docs` to use new required_docs syntax
study_details now in a list, so we look at the first item in the list
2021-11-08 10:00:19 -05:00
4e13ea6704
Fixing test mocks
...
- study_details returned in a list
- added `Q_COMPLETE` and `HSRNUMBER` to user_studies
- `required_docs` totally different from what we had
2021-11-08 09:55:06 -05:00
3a36a48b88
Merge pull request #418 from sartography/convert-timestamp-499
...
Added ordered arguments to the get_localtime script #499
2021-11-03 14:28:57 -04:00
1f9c80d70d
Added ordered arguments to the get_localtime script
...
Modified the workflow so the first task is a form with booleans that allows me to test all the permutations.
Modified tests to cover all the permutations for calling the script
2021-11-03 08:36:24 -04:00
47ead5ab45
Fixed validation bug.
...
There is no element documentation available in the task, so we mock up the email content.
2021-11-02 10:00:41 -04:00
8a6c1e1b51
Merge pull request #416 from sartography/bug/fix-hide-518
...
Fixes validation for #518
2021-11-01 16:22:24 -04:00
a4f8e39546
Merge pull request #415 from sartography/upload-file-previous-name-514
...
Upload file previous name #514
2021-11-01 15:59:57 -04:00
c4f3a3ad0d
Merge pull request #413 from sartography/logging-script-513
...
Logging script #513
2021-11-01 15:41:38 -04:00
fb25404a90
Merge pull request #412 from sartography/remove-content-html-512
...
Remove content_html #512
2021-11-01 15:38:46 -04:00
1866e6bba9
Fixes validation for #518
...
Well really what this does is give every field a default value of None. what that does is allow you to use value expressions even without a given default value. this part in the backend fixes validation.
2021-11-01 14:35:30 -04:00
85b4c4e89e
Test for uploading new version of archived file
2021-10-29 11:53:03 -04:00
702b8eaed6
add ldap endpoint that doesnt require workflow info
2021-10-28 16:19:39 -04:00
b80e0507fe
remove email script test line about UTC stuff
2021-10-28 15:49:53 -04:00
81bb0013c8
Doh
2021-10-27 17:15:49 -04:00
14593d54ef
Added tests for validation
2021-10-27 17:03:46 -04:00
629fe6f571
Tests and workflows
2021-10-27 16:39:50 -04:00
38fbd08517
Renamed file
2021-10-27 16:36:48 -04:00
a3c3a9a75d
Test and workflow for the new logging script
2021-10-27 12:22:17 -04:00
7090a22a23
Remove content_html from the data we return from the email and get_email_data scripts
2021-10-26 16:28:50 -04:00
45fd317dc6
Merge branch 'dev' into convert-timestamp-499
2021-10-26 14:35:33 -04:00
f88aba1db0
Cleanup validation for get_locatime.
...
Make sure we send the same type of values back for validation.
2021-10-26 14:29:38 -04:00
d2799a758e
Merge branch 'refactor/enums_as_key_value' into dev
2021-10-26 13:02:36 -04:00
d0446cbc8a
A quick fix to enum_label script.
2021-10-26 12:59:43 -04:00
7959f8ca3f
Merge pull request #405 from sartography/refactor/enums_as_key_value
...
Death to enumerated dictionaries
2021-10-25 15:17:17 -04:00
61e51e736f
Merge pull request #408 from sartography/jinja-complete-template-508
...
Jinja complete template #508
2021-10-21 14:22:00 -04:00
36d30f23a1
Merge pull request #407 from sartography/jinja-include-403
...
Jinja include #403
2021-10-21 14:20:04 -04:00
2ef03b0c79
Merge pull request #406 from sartography/convert-timestamp-499
...
Convert timestamp #499
2021-10-21 14:12:59 -04:00
539174d4c4
drop unused method
2021-10-21 14:02:19 -04:00
84ce24243f
add an enum_label script that will return the label given a value selection.
2021-10-21 13:57:49 -04:00
9ffd003d56
Test for embedded templates
2021-10-21 13:37:56 -04:00
383bb964d1
Use the new JinjaService
2021-10-21 10:31:02 -04:00
3cdb3fe311
Move to new branch
2021-10-20 13:41:16 -04:00
a9aa3fac89
Renamed tests for clarification
2021-10-20 13:40:44 -04:00
c566fa1c8f
Fixed test to look for datetime object
2021-10-20 12:16:18 -04:00
e707783cea
*** WIP ***
...
committing changes to work on another ticket.
Still need to figure out the complete_template piece
2021-10-20 09:21:45 -04:00
4efdef3d77
Better/more assertions
2021-10-20 09:20:15 -04:00
1c84bd9f1b
Merge branch 'dev' into refactor/enums_as_key_value
2021-10-19 12:02:45 -04:00
2ad9f71232
Merge branch 'dev' into jinja-include-403
2021-10-19 10:50:37 -04:00
dfd1a6a7f6
Fix failing test.
...
We removed `name` from WorkflowSpecModel, and use `id` now
2021-10-19 10:44:43 -04:00
5429e7da7d
All enumerated lists used in web forms should contain a single value, not a dictionary of value/labels.
...
Removing the spreadsheet.value.column and data.value.column so we just have value.column for both.
Improving the __str__ function in the ApiError class, to make debugging a little easier.
Adding a "validate_all" flask command, to help us track down any issues with current workflows in production (use this in concert with sync_with_testing)
Fixed logs of tests.
removed fact_runner.py, a very early and crufty bit of code.
2021-10-19 10:13:43 -04:00
1c02928d04
Merge branch 'dev' into jinja-include-403
2021-10-19 10:09:18 -04:00
afd983e7f5
Merge pull request #404 from sartography/email-attachment-error-503
...
Email attachment error #503
2021-10-19 09:51:15 -04:00
8415ef9776
Merge pull request #402 from sartography/convert-timestamp-499
...
Convert timestamp #499
2021-10-19 09:50:10 -04:00
ee839a85ed
Merge pull request #401 from sartography/email-cleanup-498
...
Email cleanup #498
2021-10-19 08:59:48 -04:00
e1b72c8edf
Merge pull request #380 from sartography/file-cleanup-466
...
File cleanup #466
2021-10-19 08:57:14 -04:00
d84625c51e
Merge branch 'convert-timestamp-499' into email-attachment-error-503
...
# Conflicts:
# tests/emails/test_email_script.py
2021-10-18 17:08:56 -04:00
0122029e30
*** WIP ***
...
Migrating the complete_template script stuff to JinjaService.
Having trouble with the tools stuff.
Pulled back to spot where test pass using CompleteTemplate
2021-10-18 16:56:03 -04:00
dc7b39b5c8
Tests and workflows for the cases where attachments is None or ''
2021-10-18 11:21:24 -04:00
6b1e0ebbfe
First couple tests, and a workflow for testing email
2021-10-16 14:23:12 -04:00
fc3e7f8183
Simple test for get_localtime script
2021-10-14 11:02:51 -04:00
1ef063de37
Merge branch 'email-cleanup-498' into convert-timestamp-499
2021-10-13 15:50:01 -04:00
8015d35424
Script to get localtime from a UTC datetime
2021-10-13 15:36:37 -04:00
2f3fe59a0f
Test for Exception when email service fails
2021-10-13 13:40:14 -04:00
b3d515bf68
Test for condition where email_service.add_email raises an exception.
2021-10-13 13:23:18 -04:00
bd6a2f3005
Check the model we get back from the email script
...
Make sure timestamp is UTC
2021-10-13 11:48:27 -04:00
a1a06f06ca
We now get an email model back
2021-10-13 11:47:40 -04:00
c5d8e20e74
Merge pull request #399 from sartography/chore/resource-files-461
...
Chore/resource files 461
2021-10-12 15:56:56 -04:00
6428e4ab0a
Merge pull request #397 from sartography/email-data-script-487
...
Email data script #487
2021-10-12 15:55:48 -04:00
dc07d42a9c
Merge pull request #395 from sartography/email-format-489
...
Email format #489
2021-10-12 15:51:57 -04:00
40b5bf3afa
Adds a POST for reference file. and a cool test
2021-10-12 14:29:15 -04:00
3366142cf3
Remove unused import
2021-10-12 13:56:43 -04:00
f41406a6d9
Fixes from changing workflow_id to workflow_spec_id
2021-10-12 13:46:05 -04:00
1fb298f796
Test for the new formatting
2021-10-08 11:26:54 -04:00
b0a6af8d5e
Merge pull request #392 from sartography/email-data-script-487
...
Email data script #487
2021-10-07 14:52:31 -04:00
fdce91507c
Improve the warning messages that come back when running the master workflow spec.
2021-10-07 14:43:38 -04:00
24932072dc
Merge branch 'dev' into email-data-script-487
2021-10-07 12:30:13 -04:00
a39e0ba219
Merge pull request #390 from sartography/varchar-category-id-483
...
Varchar category id #483
2021-10-07 12:23:56 -04:00
7f11d5bd58
Tests for get_email_data script.
2021-10-07 12:11:22 -04:00
548c35a4a3
Merge branch 'dev' into varchar-category-id-483
2021-10-07 11:35:10 -04:00
208ca92fb2
Merge pull request #388 from sartography/bug/472_date_time
...
fixes 472 - a bug with the datetime validation
2021-10-07 11:13:53 -04:00
ea083e3a52
Changes to tests, and new test for the get_file_data script
2021-10-07 09:25:07 -04:00
ea4e382f06
Fixing some tests
2021-10-06 15:24:58 -04:00
da894219c5
Changes to tests after removing `name` column from `workflow_spec` and `workflow_spec_category` tables.
2021-10-05 14:20:03 -04:00
fb660182aa
Testing setup changes
2021-10-05 13:36:53 -04:00
b02731df17
Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates)
...
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.
remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
2021-10-04 15:07:47 -04:00
7357fe7507
test for new From field
2021-10-01 14:02:56 -04:00
64e3cd044f
Merge branch 'dev' into file-cleanup-466
2021-09-30 14:11:59 -04:00
f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478
...
Ids approval validation #478
2021-09-30 13:59:26 -04:00
6b5a55df4c
Merge pull request #383 from sartography/feature/476_file_url
...
URL for files
2021-09-30 13:47:37 -04:00
fbfb241c0b
Merge pull request #382 from sartography/feature/381_validate_field_types
...
fixes #381 Assure that the field type provided is supported. Catches errors suc…
2021-09-30 13:46:40 -04:00
615d0e7f89
Merge pull request #384 from sartography/chore/admin-cat-456
...
Admin flag on category + migration + updated test
2021-09-30 13:37:09 -04:00
0353161402
Merge branch 'dev' into feature/381_validate_field_types
2021-09-30 13:19:36 -04:00
2067c7226a
Better test. Actually grab data explicitly from the list in Element Documentation
2021-09-30 12:54:03 -04:00
7676e230e5
Test and bpmn for enum checkbox
2021-09-30 12:10:47 -04:00
d5d4496cd0
Admin flag on category + migration + updated test
2021-09-29 16:53:59 -04:00
8a4a53f028
Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea"
2021-09-29 14:05:45 -04:00
8e00f16eaa
Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea"
2021-09-29 11:43:08 -04:00
cc0b7853e3
reordered the setup and tests
2021-09-28 13:12:16 -04:00
89b8be0755
Take saved files into account during assertion
2021-09-28 10:25:13 -04:00
767a90faba
Removed debug print statement
2021-09-28 10:20:45 -04:00
0ee377dda3
Test for file data cleanup
2021-09-27 17:16:21 -04:00
fb9c3e96ac
Test and mocked status data for adding master workflow into validation.
...
Make sure we see ApiError for disabled workflow spec
2021-09-24 11:08:54 -04:00
e4add14193
Merge pull request #378 from sartography/bug/246_user_ldap_refactor
...
Bug/246 user ldap refactor
2021-09-22 15:31:34 -04:00
48d979dd5a
Merge pull request #377 from sartography/study-info-mislabeled-464
...
Study info mislabeled #464
2021-09-22 15:31:23 -04:00
deff293fff
Merge pull request #376 from sartography/bug/468_missing_file_date
...
fixes #448 - Missing file date
2021-09-22 15:29:32 -04:00
e672d46dd0
Merge pull request #375 from sartography/study-info-adds-463
...
Study info adds #463
2021-09-22 15:28:40 -04:00
19104303de
Refactor of the way we store and return details about users - All the details about a user, or individual associated with a study is returned within in an Ldap model. I've removed duplication between these models. This required some cleanup of the tests, and a migration that will drop the user details.
2021-09-22 13:16:25 -04:00
181e885563
Added the new `handle` attribute to the test
2021-09-22 12:12:54 -04:00
4b591a076f
Adding importlib-resournces as a dependency, which is suddenly failing on Travis, likely due to different versions of Python as I try to upgrade to 3.9
2021-09-21 14:36:57 -04:00
1e48cbea1a
Added test and workflow for updating `short_name` and `proposal_name`
2021-09-17 12:05:29 -04:00
deb3d7bf67
Updated for `short_name` and `proposal_name`
...
Also cleaned up some for readability
2021-09-17 11:59:02 -04:00
7956c71fcc
Changed test to use a workflow, so we have the correct type of task
2021-09-16 13:45:51 -04:00
66bfbf0a49
Merge pull request #371 from sartography/zip-documents-379
...
Zip documents #379
2021-09-14 17:42:13 -04:00
787614ee91
Merge pull request #369 from sartography/dmn-from-spreadsheet-395
...
Dmn from spreadsheet #395
2021-09-14 17:41:01 -04:00
02de382b8b
Test for new script
2021-09-14 10:41:01 -04:00
444e3fa76d
Merge branch 'dev' into zip-documents-379
2021-09-14 09:39:19 -04:00
9aadaac0df
Test to make sure we do not set a category_id for library workflow specs
2021-09-13 16:16:05 -04:00
5ddff1d1be
Merge branch 'dev' into add-reorder-api-endpoints-444
2021-09-09 13:10:54 -04:00
cc403f1fac
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-09-09 13:09:35 -04:00
a35d122a03
Tests for case where we have bad display_order numbers.
...
I.e., 0, 1, 1, 1
2021-09-08 11:18:06 -04:00
7211a1de46
Removed unused test files
2021-09-07 15:22:02 -04:00
96d38e6e65
Removed double-quotes
2021-09-07 15:18:05 -04:00
ee68d818e6
Test for new endpoint
2021-09-07 15:15:38 -04:00
86c017a6a6
Merge pull request #367 from sartography/value-error-expression-428
...
Value error expression #428
2021-09-03 14:32:46 -04:00
26a625c5db
Test for new service
2021-09-02 09:57:01 -04:00
d9fa94b64f
Added spreadsheet for testing
2021-09-02 09:56:40 -04:00
f2741921cb
Added task to select a spreadsheet
2021-09-02 09:56:22 -04:00
f49128adf4
Rename test file
2021-09-01 10:44:53 -04:00
3020c76d5c
Rename test BPMN file
2021-09-01 10:41:21 -04:00
0c31b091ee
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-09-01 09:38:03 -04:00
e6a2b9d642
New test and BPMN for changes
2021-08-31 16:18:29 -04:00
86583aa2d6
Be explicit about loading sample data
...
Add category_id when checking order
2021-08-31 12:19:45 -04:00
1140b21414
Adding a test that assures we pick up libraries on the remote system when syncing.
2021-08-31 12:07:41 -04:00
d17a2c39ed
A little cleanup to assure that when we sync we correctly pick up and associate librarires with a workflow when we sync.
2021-08-30 15:46:16 -04:00
cfd8f3fe74
Test for reordering remaining spec categories after delete
2021-08-30 15:21:42 -04:00
e317b59bfe
Test for reordering workflow specs upon deletion
2021-08-30 14:57:16 -04:00
c99080845b
renamed a test
2021-08-30 13:56:27 -04:00
dfe967d578
Tests for reordering categories
2021-08-30 13:56:13 -04:00
d43eb4d6f8
Tests for workflow spec reordering
2021-08-30 12:35:57 -04:00
543fc1fb4a
Start of tests for new reorder API endpoint
...
Modified example_data to include a display_order for example spec
2021-08-27 13:04:11 -04:00
083abd1b58
Just being consistent in the names as we named it delete_task_data in the class, but not elsewhere, and since I'm here, using the name I prefer.
2021-08-26 14:22:12 -04:00
cd3d17862a
Add task_spec_name to a bunch of tests
2021-08-26 10:43:28 -04:00
5f0db3f2fb
Test and BPMN file for new script
2021-08-26 10:42:30 -04:00
35285a0b60
Fixed tests that broke from the new irb_documents spreadsheet
2021-08-26 08:51:52 -04:00
54cb74e0a4
Test for the new script
2021-08-26 08:44:22 -04:00
961925e03e
Merge pull request #361 from sartography/430-email-enhancements
...
#430 email enhancements
2021-08-25 15:02:14 -04:00
e8f8ba67cf
Added test for email attachments
...
Moved cc test to the main test_email_script test, and added bcc and reply_to
Added load_example_data to test_email_script_multiple.
2021-08-19 17:40:37 -04:00
a9452d6533
Modified the test workflow form to add the new bcc, reply_to, and attachments arguments
2021-08-19 17:37:10 -04:00
5692f7d377
Merge pull request #359 from sartography/413-LibraryCleanup
...
413 library cleanup
2021-08-18 13:39:37 -04:00
f3f42eea2b
Fixes #413
...
Add test for cleanup
2021-08-18 08:33:44 -04:00
7a8eeab820
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-17 11:16:03 -04:00
4e0e162fd6
Removing the execution flag Nile keeps adding to files.
2021-08-17 09:50:57 -04:00
2a2fd710c4
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-08-16 14:22:02 -04:00
ab8714c93e
Remove HSRNUMBER from mock data
2021-08-16 13:01:51 -04:00
3f44c202ca
Merge branch '417-hsr-open-to-enrollment-bug' into 426-remove-hsr-number
2021-08-16 12:55:24 -04:00
0a232dace6
assertEquals -> assertEqual
2021-08-16 10:25:41 -04:00
b9d4f6c436
assertEquals -> assertEqual
2021-08-16 10:18:29 -04:00
f8dd4c3eb9
Check Study Associates Endpoint
2021-08-16 09:32:02 -04:00
febcb1ac5b
Clarified my comments
2021-08-13 12:36:43 -04:00
58119c8969
Modified `test_get_all_studies` so they don't fail looking for studies that are open for enrollment
...
We will soon have a new way to automatically set study status to `Open for Enrollment`, so I left the failing tests there and commented them out for now.
2021-08-13 12:32:11 -04:00
e32c1db4c8
Merge remote-tracking branch 'origin/dev' into bug/missing_pi_name_246
...
# Conflicts:
# crc/models/study.py
# crc/services/study_service.py
# crc/services/workflow_service.py
# tests/study/test_study_associate_script.py
2021-08-12 12:59:15 -04:00
d20b68e483
Fixed Deprecation Warnings in Test Files
2021-08-12 12:33:27 -04:00
2732071585
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-12 12:07:25 -04:00
adb1b74822
Merge pull request #352 from sartography/post-process-empty-field-408
...
Post process empty field #408
2021-08-12 10:53:26 -04:00
e0096ebc8e
Test and BPMN to make sure we don't process when field is hidden, but do process when field is not hidden
2021-08-11 16:44:45 -04:00
848c2e622f
Always use a schema to define what is being returned, it enforces consistency of the API and internally we can depend on well defined objects.
2021-08-10 16:16:08 -04:00
dce95189cb
Merge branch 'dev' into dmn-from-spreadsheet-395
2021-08-10 09:39:42 -04:00
960d302c03
Finish #367 - Make sure that we only use a primary_id if it is in the workflow that we are currently working on - otherwise it is a library and might have its own primary id.
2021-08-10 09:15:38 -04:00
abe258cdf1
Added example data so we can grab a workflow spec
2021-08-03 11:56:53 -04:00
6e1fedb704
Add tests for libraries, remove an API endpoint that didn't make sense after recent changes and remove some commented out sections that were not needed after some decisions about the api endpoints were made
2021-08-03 10:02:22 -04:00
e8ea9776a5
Test for creating dmn from spreadsheet
2021-08-02 10:04:47 -04:00
25319a0e6a
Make changes to alembic process - fix test for new API
2021-08-02 08:59:24 -04:00
097dd9f9a3
Included the failing test, with self.assertRaises
...
Reworded some of the comments
2021-07-28 11:22:45 -04:00
217e61eed3
next_task returns the next available task, except when the task is completed when it returns the EndEvent -
...
The problem was that it was returning the first EndEvent it found, not the last one. This caused a problem when we had a CallActivity which has its own EndEvent.
Fixes #399
2021-07-27 09:19:08 -04:00
2c892560ad
Failing test for Call Activity End Events - Ticket 399
2021-07-26 12:12:01 -04:00
25e00823a7
Merge pull request #342 from sartography/enum-file-data-375
...
Enum file data #375
2021-07-23 13:47:57 -04:00
612ce6dc35
Better test to make sure file data works with all standard field types.
...
(Except maybe custom types)
2021-07-23 11:25:36 -04:00
a73d1794eb
Fixed Associate API Endpoint description
2021-07-22 14:09:24 -04:00
6b51fc7c06
Added a test with uppercase UID
...
Modified the script test to expect an empty dictionary now, instead of raising an error
2021-07-22 10:47:25 -04:00
fa19b36279
Removed temporary print statement
2021-07-15 13:16:06 -04:00
9023be66f4
added a comment to the test
2021-07-15 13:14:40 -04:00
82bf25cbc6
Test that we set file data_store values correctly when using the file_data property
2021-07-15 13:10:51 -04:00
522ca9d164
Merge pull request #340 from sartography/bug/better_errors_on_scheduled_tasks
...
Assure we log reasonably clear errors when executing scheduled tasks …
2021-07-12 10:13:02 -04:00
d1bf370a39
Merge pull request #339 from sartography/restrict-loaded-studies-374
...
Restrict loaded studies #374
2021-07-12 10:11:34 -04:00
7070761089
Merge pull request #338 from sartography/document-spreadsheet-name-380
...
Document spreadsheet name #380
2021-07-12 10:11:16 -04:00
f982745d32
fixing a failing test, don't assume the study and workflow ids will always be 1.
2021-07-12 10:00:39 -04:00
1916c4ff54
Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively.
2021-07-12 09:43:12 -04:00
69974e89fd
Added 2 simple tests for filtering by REVIEW_TYPE
2021-07-09 11:39:30 -04:00
682b010f6f
Added mocked study_details with an invalid REVIEW_TYPE
...
This is used to test StudyService.get_studies_for_user
StudyService.get_studies_for_user should now filter on REVIEW_TYPE
2021-07-09 11:38:45 -04:00
445d3e5f0b
Added mocked pb study_details since we now check whether a study has valid REVIEW_TYPEs
2021-07-09 10:41:46 -04:00
95c710768e
Fixed test to reflect adding REVIEW_TYPE to mocked study_details PB data
2021-07-09 10:40:18 -04:00
841bbe73ef
Added REVIEW_TYPE to the mocked PB data
2021-07-09 10:38:41 -04:00
f1a15ef8e9
Fix the test
2021-07-07 12:54:16 -04:00
3c52453c26
Merge branch 'dev' into add-name-error-hint-8
2021-07-07 11:35:24 -04:00
2ed436327f
Merge pull request #333 from sartography/check-study-script-273
...
Check study script #273
2021-07-07 11:28:32 -04:00
2a45f2fcda
Merge branch 'dev' into add-name-error-hint-8
2021-07-07 11:24:00 -04:00
b0cf74fa3d
Merge branch 'dev' into add-by-user-61
...
# Conflicts:
# tests/files/test_files_api.py
2021-07-07 10:46:50 -04:00
ac19c3e3c6
Add users first
2021-07-07 10:33:30 -04:00
621c11fe24
Add test for user_uid
2021-07-07 09:39:01 -04:00
fb54edac1c
Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
...
Most noteable is the addition of the line on which the error occurs for script tasks. It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
1b1a994360
Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them.
...
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
2021-07-06 13:10:20 -04:00
8145ff9025
Tests for calling the script
2021-07-02 16:14:19 -04:00
2cb2874a49
Added test and json data for new check_study pb mock api endpoint
2021-07-02 15:26:39 -04:00
2a43230121
Test and workflow for the new name error hint code
2021-07-01 15:39:25 -04:00
9a32fadc2f
Merge branch 'dev' into 346-waiting-task-schedule
...
# Conflicts:
# Pipfile.lock
# crc/services/workflow_service.py
2021-06-30 10:14:37 -04:00
48bf721b23
Merge pull request #331 from sartography/bug/356_duplicate_workflow
...
Bug/356 duplicate workflow
2021-06-22 17:42:24 -04:00
92ca506c8e
Calls to eval no longer return the data, rather it will accept and return a key, allowing the front end to cache similar queries and not re-execute them.
2021-06-22 17:23:18 -04:00
61ad371680
Clean up the file api so we don't have a bunch of extra stuff in there. Just include the raw data from the document spraedsheet if it is available.
2021-06-22 15:08:08 -04:00
1f3febe2df
Fix the panda warnings, which means we only support xlsx files now.
...
Include the document details when reutnring a file from the file model.
Improve the validation of file form elements.
2021-06-22 14:58:52 -04:00
0722a4bf13
Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously.
...
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
2021-06-18 17:00:10 -04:00
07eb3f9ca8
Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously.
...
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
2021-06-18 16:41:55 -04:00
19d63e2aa2
Merge pull request #328 from sartography/restart-workflow-programmatically-347
...
Restart workflow programmatically #347
2021-06-17 10:36:46 -04:00
a4caae8d64
when validating, we need to take every step to remove the workflows we create during the validation.
2021-06-16 14:40:20 -04:00
94e730d04e
Test script validation
2021-06-15 11:15:31 -04:00
8db4199d73
Separate workflows for `using` the script and `validating` the script.
2021-06-15 11:15:04 -04:00
addf1cab5b
Added tests for failing conditions
2021-06-15 10:30:18 -04:00
9e20025f33
Test and workflow for reset_workflow
2021-06-15 08:37:42 -04:00
7282419174
modified the tools api to return the expression and data with the result, making it easier to cash results on the front end, This should help drastically reduce the calls to the python_eval from the front end.
...
The post processors for form submissions needs to take repeating sections into account, or it won't find the files it is looking for.
2021-06-11 08:27:50 -04:00
5f722d675f
Add a function that gets runs via a background scheduler to look for any workflows that are in a 'waiting' state - it runs the update waiting tasks and does do_engine_steps
...
We have a test for the function that runs, but an assumption was made that the scheduler module has its own unit tests and we do not need to test that.
fixes #346
2021-06-09 10:42:34 -04:00
286803d10b
fixing a big stupid bug I created when merging all the code and making changes to the files.
2021-06-08 14:24:59 -04:00
50ad42d3a8
You have to mock out the protocol builder in tests that rely on it.
2021-06-08 12:36:47 -04:00
076d198fc6
fixing a failing test for study associate.
2021-06-08 12:18:16 -04:00
586a0f2f1a
Merge pull request #325 from sartography/feature/file_refactor
...
Prefer tasks that share a parent over just the the next available tas…
2021-06-08 11:28:23 -04:00
8d79fe9d94
Fixing failing tests, and now asserting that we only perform the post_process_form if we actually have a form.
2021-06-08 11:16:10 -04:00
9c4994581d
Merge pull request #324 from sartography/modify-infinite-loop-312
...
Modify infinite loop #312
2021-06-08 10:30:13 -04:00
e10b210302
Merge pull request #323 from sartography/shield-test-issue-344
...
Shield test issue #344
2021-06-08 08:59:58 -04:00
a7b208f50a
Merge pull request #322 from sartography/data-store-refactor-330
...
Data store refactor #330
2021-06-08 08:58:53 -04:00
6937c33719
Merge pull request #319 from sartography/datastore-file-endpoints-325
...
Datastore file endpoints #325
2021-06-08 08:54:43 -04:00
37d4e7cc79
Merge pull request #318 from sartography/340-update_study_associate_change
...
Add test and fix to make sure that an empty study associates list (or…
2021-06-08 08:52:44 -04:00
59f605c3df
Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor.
2021-06-08 08:03:14 -04:00
9dc5871848
Added mocked PB data for tests using study_info script.
2021-06-07 10:08:44 -04:00
70651e2a6a
Test and BPMN files for testing
2021-06-04 11:45:51 -04:00
37ba46fb8f
These tests now require PB Mock because of the validate_study_id changes
2021-06-03 14:30:00 -04:00
a2e577829a
Cleanup:
...
- removed unused imports
- removed testing print statement
2021-06-02 10:02:26 -04:00
200a5b3bf3
Updated tests for file datastore endpoint
...
Added test of 2 entries
2021-06-01 16:27:55 -04:00
ec8353aaa6
Test for new datastore file api endpoint
2021-06-01 13:51:40 -04:00
8c04e228e9
Add test and fix to make sure that an empty study associates list (or a blank list) will effectively clear the extra study associates
2021-06-01 11:46:43 -04:00
a5d67bb245
337 partial fix
...
if the user calls the file_data_set function for a valid file with the key 'irb_code' and a value of a valid IRB document code, then we should set the irb code on the file.
2021-05-27 12:24:30 -04:00
ef7ee284b2
Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor.
2021-05-19 16:26:16 -04:00
77f7fec5d4
Merge pull request #312 from sartography/study-is-none-329
...
Study is none #329
2021-05-14 16:33:04 -04:00
668e2f4e3c
Merge pull request #313 from sartography/feature/add_file_data_store_properties_to_file
...
Assure that any data store values associated with a file come back as…
2021-05-14 16:30:35 -04:00
8e37f27399
Assure that any data store values associated with a file come back as a part of the get_study_data[documents
...
] endooint.
2021-05-14 15:52:25 -04:00
e75d933830
Make sure a standalone study does not cause an error in the /task_events api endpoint.
2021-05-14 15:35:17 -04:00
4d7ce5eda9
Merge pull request #311 from sartography/deprecate-study-info-protocol-261
...
Deprecate study info protocol #261
2021-05-14 14:14:18 -04:00
1a8c374ac0
Need to mock out these tests
2021-05-14 13:32:25 -04:00
a53e2db223
Final test for study_info script
2021-05-14 13:10:06 -04:00
ade7812540
Merge pull request #310 from sartography/get-primary-workflow-301
...
Get primary workflow #301
2021-05-14 12:41:48 -04:00
6a34fc0cde
Merge pull request #309 from sartography/persist-read-only-data-324
...
Persist read only data #324
2021-05-14 12:38:48 -04:00
1d28d602d5
Merge pull request #308 from sartography/get-dashboard-url-230
...
Get dashboard url #230
2021-05-14 12:36:40 -04:00
b0fcb09581
Fixed test to correspond to the changes in the mock data
2021-05-14 12:35:36 -04:00
99da502912
Merge branch 'dev' into 321-Markdown-Macro
2021-05-14 12:32:41 -04:00
1509bf23f8
Added some detail to the study_details mock data
2021-05-14 12:26:54 -04:00
3e756dd501
Added two more test for the study_info script
2021-05-14 12:26:20 -04:00
885c4c9a20
Started writing tests for the study_info script.
...
Need to add some mock data for a couple more
2021-05-13 16:30:17 -04:00
4c8ea14435
Fixed test - changed the method name
2021-05-12 14:07:54 -04:00
8f8d9d30e4
Added test for get_primary_workflow
2021-05-12 13:52:18 -04:00
67321ecd97
Test and workflow for persisting read-only data
2021-05-07 14:07:19 -04:00
4dc4e270aa
Fixed the test to also use HTTPS
2021-05-06 15:54:39 -04:00
375089e5df
test and bpmn file for new get_dashboard_url script
2021-05-06 15:32:28 -04:00
09a395fa34
Start for ticket 230 - Get Dashboard URL
2021-05-06 14:07:21 -04:00
cbd1d01203
Add URL to the study_info('documents') script
...
fixes #321 - I merged in branches that fix #320 and #297
320-add-default-for-file-data-get
297-filename-in-documents
2021-05-05 11:30:08 -04:00
8f28970f92
Resolving an alembic conflict.
...
Upgrading libraries, and resolving issues from that upgrade, including changes to how we manage tokens. This seems to be working locally.
2021-05-04 13:39:49 -04:00
8b0afa4437
Merge pull request #304 from sartography/irb-info-script-307
...
Irb info script #307
2021-05-04 11:40:52 -04:00
34759a2f3d
Merge branch 'dev' into feature/performance-refactor
2021-05-04 11:30:13 -04:00
4780240103
Merge pull request #302 from sartography/320-add-default-for-file-data-get
...
Add default capability to file_data_get script
2021-05-04 11:28:40 -04:00
d6054a9846
Merge branch 'dev' into 310-task-event-timezone
2021-05-04 11:21:36 -04:00
77d9bfca43
Merge pull request #296 from sartography/launch-workflow-outside-study-204
...
Launch workflow outside study 204
2021-05-04 11:16:08 -04:00
576f3a661d
Removed print statement used while debugging.
2021-05-03 14:52:01 -04:00
c8446bfafd
Mock the Protocol Builder response in my test
2021-05-03 14:51:27 -04:00
9465b6408d
Test and workflow for new `get_irb_info` script
2021-05-01 15:53:43 -04:00
1bcf4ea02e
Test and mock data for new `get_irb_info` service in ProtocolBuilderService
2021-05-01 15:23:07 -04:00
a719cf4bf9
When retrieving the study, only update the status of underlying workflows if specifically requested.
...
Record the size of a file in the database for quick access (this helps with a frontend refactor, so it isn't downloading the file just to see it's size)
Cleaning up the timing/performance metric reporting to make it easier to read.
Fixing a bug that prevented non-admins for getting the document-directory
2021-04-30 11:55:12 -04:00
7608a889fb
Add default capability to file_data_get
...
script
2021-04-30 10:11:50 -04:00
2b9cee6b89
Update database to include timezone and change all points where we set the time on an event to be utc time. If we get something in the database with a timezone, it will display properly on the front end, but by default everything will be put in the database in UTC
2021-04-29 10:25:28 -04:00
09d8c8bcba
added missing test for update_workflow_spec_category
2021-04-26 12:57:08 -04:00
21e95b106d
Merge pull request #295 from sartography/299-document-datastore
...
Add file_data_get and file_data_set functions that can be accessed in…
2021-04-26 12:49:46 -04:00
0aa3e8f586
added missing test for add_workflow_spec_category
2021-04-26 12:41:50 -04:00
047c68b2b5
Just some quick tidying up. Dropping commented out code, and using the SQLAlchemyAutoSchema to handle serializing db models
2021-04-26 12:31:22 -04:00
b73c2ff1cb
Added missing test for `get_workflow_from_workflow_spec`
2021-04-26 12:00:06 -04:00
1a44f50de6
Added `standalone` argument to fix failing test.
2021-04-26 11:21:35 -04:00
39fcab3730
Merge branch 'dev' into launch-workflow-outside-study-204
2021-04-26 10:27:32 -04:00
d3d7eeb309
Add file_data_get and file_data_set functions that can be accessed in a bpmn script function
...
Fixes #299
2021-04-26 09:41:14 -04:00
mike cullerton
alicia pritchett
Dan
Mike Cullerton
alicia pritchett
Kelly McDonald
nilez