mike cullerton
db6f594ba9
Allow for missing data
2022-03-17 15:18:06 -04:00
mike cullerton
a578cf2498
Some studies don't have a DATELASTMODIFIED, so we use DATECREATED instead
2022-03-17 14:50:47 -04:00
mike cullerton
be2b7c07ef
add the new study to the session after we run update_from_protocol_builder
2022-03-17 14:29:38 -04:00
alicia pritchett
9b1a7ff286
Fixes #668 - Cancel/Notify Called when loading last task
...
don't call cancel notify if its an end event
2022-03-17 10:58:25 -04:00
mike cullerton
69b5d80b23
Included templates wrapped by if clause don't always exist
...
Don't raise an error here
2022-03-16 16:57:26 -04:00
mike cullerton
9a345da763
typo
2022-03-16 16:54:36 -04:00
alicia pritchett
c18bc6f876
fix study service
2022-03-16 16:21:02 -04:00
alicia pritchett
5b7e71d42d
meta field for categories
2022-03-16 12:49:35 -04:00
Dan
1506952df7
task_trace was a little mixed up in the errors.
2022-03-16 10:18:50 -04:00
alicia pritchett
829c810807
wip
2022-03-15 13:21:58 -04:00
alicia pritchett
37d92c6a5f
WIP ~ adding a category metadata object
2022-03-15 10:49:41 -04:00
Dan Funk
791ab20f8c
Merge pull request #494 from sartography/chore/fix_validation_errors
...
Chore/fix validation errors
2022-03-14 16:51:27 -04:00
Dan Funk
8ea8993421
Merge pull request #493 from sartography/jinja-included-includes-670
...
Jinja included includes #670
2022-03-14 16:49:56 -04:00
Dan
483d7e858b
Improved Errors - Pick up on the new task_trace information in WorkflowException and pass it on through the api.
...
Also: All script tasks should raise WorkflowTaskExecExceptions - NOT APIExceptions - this is because our scripts are executed by Spiff (not the other way around) so the errors need to pass fluidly through spiff, and come back to use THEN we can convert them to APIErrors. Otherwise we lose all kinds of good information about the error.
2022-03-14 16:00:53 -04:00
mike cullerton
416adcbe69
Recursively parse the included templates
2022-03-14 13:51:41 -04:00
mike cullerton
a974b65333
Remove unused code
2022-03-14 12:03:11 -04:00
mike cullerton
3b049e358d
Remove unused imports
2022-03-14 12:02:48 -04:00
mike cullerton
a6a98bed10
Include workflow_spec_id when adding a log
2022-03-14 11:56:36 -04:00
Dan
90bfbed6fd
Merge branch 'dev' into chore/fix_validation_errors
2022-03-14 10:58:01 -04:00
Dan
dec63839f3
Merge remote-tracking branch 'origin/dev' into chore/log-changes-661
2022-03-12 16:19:23 -05:00
Dan
2fc4b44ef3
Create a path to directly download the spreadsheet file (and avoid the weird dance on the front end of making an API call to get file data.)
...
Fixing pagination. Seems the front end uses a page_index that is 0 based, and sqlAlchemy prefers to start at 1.
2022-03-12 16:19:07 -05:00
mike cullerton
015eeccb54
Change API endpoint to a GET
2022-03-12 14:23:22 -05:00
Dan
4e9fe3a6bb
Merge branch 'dev' into chore/fix_validation_errors
2022-03-12 14:09:40 -05:00
Dan
4ab314c7b8
Be sure to delete the data store items when you delete a study.
2022-03-12 13:38:09 -05:00
Dan
52b5e1d34a
Fixing tests.
2022-03-11 18:02:37 -05:00
alicia pritchett
4f0b9e3c4f
Adds 2 new study progress statuses
2022-03-11 15:40:13 -05:00
mike cullerton
b753f06394
Changes to remove pagination for the get_logs scripts.
...
We only use pagination for the get_logs_for_study API endpoint. (Used on the study page)
2022-03-11 14:03:09 -05:00
mike cullerton
1bfe656817
Remove unused API endpoint to get logs for a workflow.
...
We have a script for this that is used (in workflows)
We do use the API endpoint to get logs for a study. (On the study page)
2022-03-11 14:01:06 -05:00
mike cullerton
733e596283
rename get_logs to get_logs_for_workflow to better represent what it does
2022-03-11 13:58:25 -05:00
mike cullerton
356a322e85
Merge branch 'dev' into chore/log-changes-661
2022-03-11 08:50:13 -05:00
Dan Funk
2d5517bd15
Merge pull request #487 from sartography/chore/update-get-workflow-status-664
...
Chore/update get workflow status #664
2022-03-10 14:30:32 -05:00
Dan
d90bf1c977
always but always return a valid status.
2022-03-10 14:28:47 -05:00
Dan
5990f37183
Making the run-all-validations easier to work with.
2022-03-10 13:18:22 -05:00
mike cullerton
d57d741c10
Added TODO
2022-03-10 12:17:32 -05:00
mike cullerton
423426c2c8
Removed some unused imports
...
Finished up get_all_logs_for_download
2022-03-10 12:14:14 -05:00
mike cullerton
9efb4c4fb3
New spreadsheet_service.
...
Accepts list of dictionaries, and optional headers and title
Creates spreadsheet from list of dictionaries
Returns the spreadsheet as a binary stream
2022-03-10 12:13:10 -05:00
mike cullerton
2224e34a94
Remove unused imports
...
Finish up download_logs_for_study
2022-03-10 12:10:54 -05:00
Dan
c55cc4715d
Fixing a bug that would cause us to evaluate the wrong field almost all of the time.
...
We looped over all the other fields in the task, to assure they at least had a null value, but in doing so, we overwrote the variable containing the field we were trying to test.
2022-03-09 15:26:29 -05:00
mike cullerton
42f430673d
Add metrics to TaskLogLevels
2022-03-09 14:54:56 -05:00
mike cullerton
bf31364b1f
*** WIP ***
...
Committing to fix logging so we can use a level of 'metrics'
2022-03-09 13:07:56 -05:00
mike cullerton
6ec01a0a85
Merge branch 'dev' into chore/log-changes-661
2022-03-09 11:27:13 -05:00
mike cullerton
bbd12da472
Use workflow_spec_id instead of workflow_id, since workflows can be deleted
...
I simplified do_task_validation since we get a random string for the workflow_spec_id
2022-03-09 11:14:54 -05:00
Dan
1e9c9919c2
hot fix, missed a critical part of the jinja include syntax when identifying included templates
2022-03-09 11:03:42 -05:00
Dan
ce57a3753a
fixing some comments and error messages for clarity
2022-03-09 10:28:22 -05:00
Dan
e3c1a908fe
A better comment around a tricky part of the code.
2022-03-09 09:43:08 -05:00
Dan
41b5106a28
patching up the tests.
...
Looks like we want to use default values, if they are provided, for validation. So good test, and I didn't have to create a new bug. Also added skipping the test about requiring a default for hidden+required fields. Maybe we don't need to after all.
2022-03-08 18:38:05 -05:00
Dan
26eeb2912a
Only run the form validation stuff if we have a form.
...
If there is a default value, use it, regardless of whether the form is hidden (this is how the front end works)
(accomplished by moving the hide_epxression check -> continue stuff below the set default_value code)
2022-03-08 18:13:54 -05:00
Dan
b03e24bbf4
Properly handle forms where a field is required, based on a later field.
...
Do an aboutface on saying that if a field is required but hidden, it has to have a default value. I'm just commenting this out for now, as it made getting these workflows to validate bloody impossible.
Clean up the replication of code for identifying required fields (as it wasn't consistently applied)
Removing some very broken and apparently unused methods.
2022-03-08 17:36:13 -05:00
mike cullerton
8cab382926
The task log model expected has_prev instead of has_previous
2022-03-08 16:52:37 -05:00
mike cullerton
c2035b7b40
Add workflow_spec_id to task_log model. This is because workflows can be deleted, so workflow_id is not dependable.
...
Add workflow (display_name) and category (display_name) to TaskLogModelSchema. We display these to the user on study home page in the logs.
2022-03-08 16:45:19 -05:00
