sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-22 12:48:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,747 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

535 Commits

Author SHA1 Message Date
Dan
91ed50e45e Be sure we update the document list when new workflow documents are added. 2022-02-28 15:49:21 -05:00
Dan
ad17db067d mild little performance improvement. 2022-02-27 19:32:45 -05:00
Dan
ebbb04a1af Fixing failing validation. 2022-02-27 10:00:44 -05:00
Dan Funk
140de7ed03
Merge pull request #473 from sartography/nonetype-displayname-error-632 
Nonetype displayname error #632
 2022-02-25 15:41:14 -05:00
mike cullerton
531802f927 Make sure we don't try to get WorkflowMetadata if the spec does not exist 
This was raising a 500 error
 2022-02-25 14:41:58 -05:00
Dan
dde8873c9e 1. defer the loading of the bpmn_json when loading the workflow model. It can be stupidly larger. (see models/workflow.py) 
2. Shave a little more time off the reset by not re-creating the whole WorkflowProcessor

cleaning up all the firsttime/sincetime statements.
 2022-02-24 20:56:57 -05:00
Dan
3442655bd1 Performance Improvements: 
1. Avoid ever re-generating the list of scripts that can be used in a script task.  Terribly expensive as we call eval constantly, and it never ever changes once the app starts. (see script.py changes, and comments)
2. Cache the DocumentStatus list in the flask session, so we calculate it at most once per API Call.  It's at least .25 seconds per call.  (see study_sevice)
3. We called UserFileService.get_files_for_study (which runs a db query EVERY time) for every possible document type.  Now we run the query once (study service line 321)
4. When returning a workflow, we looped through every single task in that workflow's navigation, and called the expensive spiff_task_to_api_task just to figure out it's proper display name. We run a much faster and more efficient method to calculate the display name naow (see workflow_service on lie 680, and 799)
5. A hellton of @timeit and sincetime() calls, that I want to leave in, to help debug any slowness on production.
 2022-02-24 14:25:42 -05:00
Dan
b72ecb8375 Another re-work to fix 619 - and to assure that we aren't rebuilding the lookup tables too frequently. 2022-02-17 11:59:48 -05:00
Dan
f2b6008e5f Fixes 619 - look up models were being built incorrectly, and repeatedly, and sometimes bombed out all together. 
bonus: resond with a valid error message when an invalid task_id is requested (don't just 500)
 2022-02-17 11:04:50 -05:00
Dan
7a99859108 fixing some failing test 2022-02-11 11:00:42 -05:00
Dan
3993297360 minor fixes to the study api to get things working locally when we pull down a database from testing. 2022-02-10 18:19:57 -05:00
Dan
eb7760fa55 Adding the migration - very destructive, but required for running the app. 
minor fixes - there is still some weird problems with study id and user id being null that I need to track down, but the issue is sporadic, and hard to track down.
 2022-02-10 11:50:31 -05:00
alicia pritchett
3ee95b3c39 gets master spec 2022-02-10 11:29:38 -05:00
Dan
df3f67601c performance improvements. and last rements of load_example_data() 2022-02-09 23:29:39 -05:00
Dan
f12c4aba52 Refactor the workflow_spec_service so it doesn't cache anything, it always reads what it needs from the file system. 2022-02-09 21:06:55 -05:00
Dan
cf71f68ad9 all tests passing!!!!!!!!!!!!! 2022-02-09 15:30:07 -05:00
Dan
2cc20d4b9d really need to avoid any kind of caching in the WorkflowSpecService 2022-02-09 14:43:32 -05:00
Dan
7e7821a5e7 more test passing 2022-02-09 13:01:26 -05:00
Dan
db93f9be4e fixing the test_spec_files 2022-02-09 12:44:54 -05:00
Dan
f72b25d9be Merge branch 'feature/spec_files_wthout_db' of github.com:sartography/cr-connect-workflow into feature/spec_files_wthout_db 2022-02-09 11:37:58 -05:00
Dan
8e7c8c87c3 down to just 38 failed tests 2022-02-09 11:37:54 -05:00
alicia pritchett
5bd25b9f60 get all specs change 2022-02-09 11:34:17 -05:00
mike cullerton
1c033ce7f2 Merge branch 'feature/spec_files_wthout_db' of https://github.com/sartography/cr-connect-workflow into feature/spec_files_wthout_db 2022-02-09 10:55:19 -05:00
mike cullerton
9576089e84 Reorder categories 2022-02-09 10:55:02 -05:00
alicia pritchett
8c5f3a8cfb slight model change thing for categories 2022-02-09 10:27:46 -05:00
Dan
cc915ac25a refactoring the study service. 2022-02-09 08:50:00 -05:00
mike cullerton
65d6728be7 pass specs to _add_all_workflow_specs_to_study 2022-02-08 15:03:00 -05:00
Dan
25ecc1593a test_workflow_spec_api passing. 2022-02-08 13:35:27 -05:00
Dan
6c0e38c0a5 Merge branch 'feature/spec_files_wthout_db' of github.com:sartography/cr-connect-workflow into feature/spec_files_wthout_db 2022-02-08 11:31:56 -05:00
Dan
dc040f190e got one more test to work. 2022-02-08 11:30:13 -05:00
alicia pritchett
38c30adbfc i think this fixes adding and removing libraries to a spec 2022-02-08 11:27:20 -05:00
mike cullerton
3f856355e2 Merge branch 'git-integration-596' into feature/spec_files_wthout_db 
# Conflicts:
#	config/testing.py
#	crc/services/lookup_service.py
 2022-02-08 10:38:03 -05:00
alicia pritchett
7b031c26dc small change to libraries in workflow.py 2022-02-08 10:06:20 -05:00
alicia pritchett
aa9807a543 heres the categories 2022-02-07 15:45:09 -05:00
Dan
1d7ecad51f Merge branch 'feature/spec_files_wthout_db' of github.com:sartography/cr-connect-workflow into feature/spec_files_wthout_db 2022-02-07 14:58:42 -05:00
Dan
4b8d193fb9 a few more tests passing 2022-02-07 14:58:25 -05:00
alicia pritchett
d4b04f5b80 fixes the import thing for real 2022-02-07 14:10:10 -05:00
Dan
056f901f9a WIP - its just caos right now. 2022-02-07 12:59:48 -05:00
alicia pritchett
c78140e60c fixed spec_file.py 2022-02-07 12:17:49 -05:00
alicia pritchett
2a6578b785 fixed workflow.py 2022-02-07 12:10:57 -05:00
alicia pritchett
66906c3786 fix a couple things 2022-02-07 10:57:34 -05:00
alicia pritchett
699d0ab797 updated method calls in workflow.py 
except for reordering
 2022-02-04 15:31:36 -05:00
alicia pritchett
2fb6746f6b new methods 2022-02-04 14:45:52 -05:00
Dan
6765afbd02 WIP - Move the categories and specifications out of the database. 2022-02-04 13:51:39 -05:00
mike cullerton
64ffbde3d9 Remove unused code 2022-02-03 06:47:41 -05:00
Dan
4ec6e403f5 1. Created a UserFileService, so it's clear what we use when for File Services, UserFiles, SpecFiles, and ReferenceFiles each function differently. 
2. Reference Files and Spec Files are written to disk, they do not exist in the database at all.
 2022-02-02 12:59:56 -05:00
mike cullerton
35e2a53b09 Actually use the model 2022-02-02 12:35:08 -05:00
mike cullerton
55697c6c88 Return the schema 2022-02-02 12:04:28 -05:00
mike cullerton
1cb6465f22 Return the schema 2022-02-02 10:04:02 -05:00
mike cullerton
070c3cfd5d *** WIP *** 
New API endpoints, and associated methods.
Services for the new endpoints
Minimal test
 2022-02-01 10:49:35 -05:00