2852 Commits

Author SHA1 Message Date
Dan
52b5e1d34a Fixing tests. 2022-03-11 18:02:37 -05:00
Dan Funk
0cee44985a
Merge pull request #489 from sartography/chore/new-progress-stats-673
Adds 2 new study progress statuses
2022-03-11 15:54:24 -05:00
alicia pritchett
4f0b9e3c4f Adds 2 new study progress statuses 2022-03-11 15:40:13 -05:00
mike cullerton
b753f06394 Changes to remove pagination for the get_logs scripts.
We only use pagination for the get_logs_for_study API endpoint. (Used on the study page)
2022-03-11 14:03:09 -05:00
mike cullerton
1bfe656817 Remove unused API endpoint to get logs for a workflow.
We have a script for this that is used (in workflows)
We do use the API endpoint to get logs for a study. (On the study page)
2022-03-11 14:01:06 -05:00
mike cullerton
733e596283 rename get_logs to get_logs_for_workflow to better represent what it does 2022-03-11 13:58:25 -05:00
mike cullerton
356a322e85 Merge branch 'dev' into chore/log-changes-661 2022-03-11 08:50:13 -05:00
Dan Funk
2d5517bd15
Merge pull request #487 from sartography/chore/update-get-workflow-status-664
Chore/update get workflow status #664
2022-03-10 14:30:32 -05:00
Dan
d90bf1c977 always but always return a valid status. 2022-03-10 14:28:47 -05:00
Dan Funk
e1625d45f0
Merge pull request #488 from sartography/chore/add-metrics-to-logging-level-665
Chore/add metrics to logging level #665
2022-03-10 13:27:52 -05:00
Dan
5990f37183 Making the run-all-validations easier to work with. 2022-03-10 13:18:22 -05:00
mike cullerton
ec9ff4ff8a *** WIP ***
Need to finish writing tests
2022-03-10 12:19:41 -05:00
mike cullerton
d57d741c10 Added TODO 2022-03-10 12:17:32 -05:00
mike cullerton
423426c2c8 Removed some unused imports
Finished up get_all_logs_for_download
2022-03-10 12:14:14 -05:00
mike cullerton
9efb4c4fb3 New spreadsheet_service.
Accepts list of dictionaries, and optional headers and title
Creates spreadsheet from list of dictionaries
Returns the spreadsheet as a binary stream
2022-03-10 12:13:10 -05:00
mike cullerton
2224e34a94 Remove unused imports
Finish up download_logs_for_study
2022-03-10 12:10:54 -05:00
Dan
c55cc4715d Fixing a bug that would cause us to evaluate the wrong field almost all of the time.
We looped over all the other fields in the task, to assure they at least had a null value, but in doing so, we overwrote the variable containing the field we were trying to test.
2022-03-09 15:26:29 -05:00
mike cullerton
bb605bb23c Remove unused imports
Cleaned up some extra spaces
2022-03-09 15:03:14 -05:00
mike cullerton
203213d700 Fix tests to use new version of workflow
Add test with `metrics` as log level
2022-03-09 14:56:45 -05:00
Dan
02f1e40e32 Bumping SpiffWorkflow 2022-03-09 14:56:25 -05:00
mike cullerton
291de1c322 Add UserTask to pass in log data--level, code, and message 2022-03-09 14:55:52 -05:00
mike cullerton
42f430673d Add metrics to TaskLogLevels 2022-03-09 14:54:56 -05:00
mike cullerton
bf31364b1f *** WIP ***
Committing to fix logging so we can use a level of 'metrics'
2022-03-09 13:07:56 -05:00
mike cullerton
6ec01a0a85 Merge branch 'dev' into chore/log-changes-661 2022-03-09 11:27:13 -05:00
mike cullerton
e1d1a7613d Fix test to use workflow_spec_id 2022-03-09 11:15:20 -05:00
mike cullerton
bbd12da472 Use workflow_spec_id instead of workflow_id, since workflows can be deleted
I simplified do_task_validation since we get a random string for the workflow_spec_id
2022-03-09 11:14:54 -05:00
Dan
1e9c9919c2 hot fix, missed a critical part of the jinja include syntax when identifying included templates 2022-03-09 11:03:42 -05:00
Dan
ce57a3753a fixing some comments and error messages for clarity 2022-03-09 10:28:22 -05:00
Dan Funk
1d8bc1eb26
Merge pull request #486 from sartography/chore/fix_validation_errors
Chore/fix validation errors
2022-03-09 10:24:31 -05:00
Dan
e3c1a908fe A better comment around a tricky part of the code. 2022-03-09 09:43:08 -05:00
Dan
41b5106a28 patching up the tests.
Looks like we want to use default values, if they are provided, for validation. So good test, and I didn't have to create a new bug.  Also added skipping the test about requiring a default for hidden+required fields.  Maybe we don't need to after all.
2022-03-08 18:38:05 -05:00
Dan
26eeb2912a Only run the form validation stuff if we have a form.
If there is a default value, use it, regardless of whether the form is hidden (this is how the front end works)
  (accomplished by moving the hide_epxression check -> continue stuff below the set default_value code)
2022-03-08 18:13:54 -05:00
Dan
b03e24bbf4 Properly handle forms where a field is required, based on a later field.
Do an aboutface on saying that if a field is required but hidden, it has to have a default value.  I'm just commenting this out for now, as it made getting these workflows to validate bloody impossible.
Clean up the replication of code for identifying required fields (as it wasn't consistently applied)
Removing some very broken and apparently unused methods.
2022-03-08 17:36:13 -05:00
mike cullerton
8cab382926 The task log model expected has_prev instead of has_previous 2022-03-08 16:52:37 -05:00
mike cullerton
04ac0335b8 Migration for the task log changes.
Also populate the new workflow_spec_id column
2022-03-08 16:47:54 -05:00
mike cullerton
c2035b7b40 Add workflow_spec_id to task_log model. This is because workflows can be deleted, so workflow_id is not dependable.
Add workflow (display_name) and category (display_name) to TaskLogModelSchema. We display these to the user on study home page in the logs.
2022-03-08 16:45:19 -05:00
Dan
0a906a4b3c Cleaning up Print Statements (it was making it hard to see what was happening)
The Jinja2 service was treating all the task data as a possible template, modified it to only include the referenced templates.
(This turned out not to be the problem, but it seems like a good idea to keep it in place)
There is a terrible bug with the wordwrap pipe that will die without any details if you pass it a value of None.  We now cature the terrible error, and replace it with a sensible one.
Removed an unused Jinja_extensions file.
2022-03-08 15:46:36 -05:00
Dan Funk
3f82cdae48
Merge pull request #485 from sartography/bug/validating-associates-659
Bug/validating associates #659
2022-03-07 14:20:20 -05:00
Dan Funk
eae0b5286e
Merge pull request #483 from sartography/chore/study-status-changes-653
Chore/study status changes #653
2022-03-07 14:20:05 -05:00
mike cullerton
eb7548ea0f Use the actual enum values so we don't have to deal with this the next time we make a change to study status 2022-03-07 13:28:29 -05:00
Dan Funk
0b3fa781c5
Merge pull request #484 from sartography/bug/bleeding_data
Loading latest chages from Spiff whic refactored the way the PythonEx…
2022-03-07 10:22:36 -05:00
Dan Funk
fcc7e98ba6
Merge pull request #482 from sartography/git-integration-596
Git integration #596
2022-03-07 10:00:42 -05:00
mike cullerton
ebaf857a14 Tests for using study in get_study_associates 2022-03-04 16:28:42 -05:00
mike cullerton
30f68eb831 If we receive a study_id during validation, return the associates for the study 2022-03-04 16:27:33 -05:00
Dan
0455506e2b Loading latest chages from Spiff whic refactored the way the PythonExpressionEngine works.
This cleans up the _evaluate method which previously accepted arbitrary args and kwargs, and now requires an expression, a context to which exectute it, and, optionally, the current task being executed if the DMN is being executed as a part of a BusinessRuleTask in a BPMN diagram.

This also cleans up several bits of duplicated code.

There is also a bit of code here to assure that the current user is included when running the master workflow.
2022-03-04 15:34:36 -05:00
mike cullerton
027e436546 Cleaned up the description 2022-03-03 11:49:45 -05:00
mike cullerton
c6484f7bdb Remove print statement 2022-03-03 11:28:21 -05:00
mike cullerton
0ad12f9c85 Test for set_study_status script 2022-03-03 11:11:54 -05:00
mike cullerton
b4e5fac5d9 Migration for new study status 2022-03-03 11:08:02 -05:00
mike cullerton
2cfe1b331c Merge branch 'dev' into git-integration-596 2022-03-02 15:29:27 -05:00