sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-23 05:08:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,867 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

482 Commits

Author SHA1 Message Date
Dan Funk
61504664d4
Merge pull request #346 from sartography/bug/346_timer_fails_to_send_email 
fixes #346, allow emails to fire in scheduled events
 2021-07-22 13:40:12 -04:00
Dan
2009a794ea We were depending on an active http request existing in order to fire emails, using that request to determine the front end url. We have the frontend url in our config file, and we don't have a request object when running scheduled tasks, so I just use our configuration setting instead. 2021-07-22 13:25:06 -04:00
mike cullerton
8df1145471 Modify the LDAP service to only use lowercase UIDs. 
UVA always returns the UID as lowercase.
This caused a postgres unique value problem for us.
 2021-07-22 10:46:09 -04:00
Dan
dd67a5e650 Never set the date to datetime.utcnow() on DateTime fields. We want this to fall back on the func.now() method and allow the database to set the time on insert. 2021-07-12 15:58:32 -04:00
Mike Cullerton
522ca9d164
Merge pull request #340 from sartography/bug/better_errors_on_scheduled_tasks 
Assure we log reasonably clear errors when executing scheduled tasks …
 2021-07-12 10:13:02 -04:00
Mike Cullerton
d1bf370a39
Merge pull request #339 from sartography/restrict-loaded-studies-374 
Restrict loaded studies #374
 2021-07-12 10:11:34 -04:00
Mike Cullerton
7070761089
Merge pull request #338 from sartography/document-spreadsheet-name-380 
Document spreadsheet name #380
 2021-07-12 10:11:16 -04:00
Dan
f982745d32 fixing a failing test, don't assume the study and workflow ids will always be 1. 2021-07-12 10:00:39 -04:00
Dan
1916c4ff54 Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively. 2021-07-12 09:43:12 -04:00
mike cullerton
dad2de9f0c get_user_studies now checks study_details['REVIEW_TYPE'] before displaying a study. 
This corresponds to REVIEWTYPENAME being `Full Committee`, `Expedited`, `Non-UVA IRB Full Board`, or `Non-UVA IRB Expedited`
 2021-07-09 10:37:25 -04:00
mike cullerton
d6f9b013f7 Change irb_documents to documents 2021-07-07 12:54:03 -04:00
mike cullerton
23180908c8 Undo change. Wrong branch 2021-07-07 12:43:51 -04:00
mike cullerton
c39e08972d Change irb_documents to documents 2021-07-07 12:42:01 -04:00
Dan Funk
3c52453c26
Merge branch 'dev' into add-name-error-hint-8 2021-07-07 11:35:24 -04:00
Dan Funk
2ed436327f
Merge pull request #333 from sartography/check-study-script-273 
Check study script #273
 2021-07-07 11:28:32 -04:00
Dan Funk
db9b228735
Merge pull request #334 from sartography/WaitingEventsHotPatch 
Make a change so that anything that has a waiting event is labeled in…
 2021-07-07 11:27:10 -04:00
Dan
2a45f2fcda Merge branch 'dev' into add-name-error-hint-8 2021-07-07 11:24:00 -04:00
mike cullerton
b0cf74fa3d Merge branch 'dev' into add-by-user-61 
# Conflicts:
#	tests/files/test_files_api.py
 2021-07-07 10:46:50 -04:00
Dan
fb54edac1c Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct. 
Most noteable is the addition of the line on which the error occurs for script tasks.  It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
 2021-07-07 00:53:49 -04:00
mike cullerton
894377a607 Add user_uid to FileDataModel calls 2021-07-06 17:09:00 -04:00
Dan
a9805ad40c Adding some documentation for clarity. 2021-07-06 14:40:20 -04:00
Dan
7aa4b0833c Merge remote-tracking branch 'origin/dev' into feature/documents_xls_refactor 2021-07-06 13:11:08 -04:00
Dan
1b1a994360 Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them. 
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
 2021-07-06 13:10:20 -04:00
Kelly McDonald
9803a04d6d Make a change so that anything that has a waiting event is labeled in the database as waiting, even if it is sitting around waiting on a user input task that is ready 2021-07-06 11:46:47 -04:00
mike cullerton
9690c69b6c added check_study method to protocol_builder service for new endpoint 2021-07-02 15:25:33 -04:00
mike cullerton
db44882733 When we encounter a name error running a script, look in the task data and see if there is a variable with a similar name. 
If a variable with a similar name exists, add it to the ApiError as a hint
 2021-07-01 15:38:45 -04:00
Mike Cullerton
98d641f54d
Merge branch 'dev' into partial_testing 2021-06-30 16:13:31 -04:00
NWalker4483
508ef1ff2b Readded exit_at to workflow param 2021-06-30 11:15:48 -04:00
Dan
9a32fadc2f Merge branch 'dev' into 346-waiting-task-schedule 
# Conflicts:
#	Pipfile.lock
#	crc/services/workflow_service.py
 2021-06-30 10:14:37 -04:00
NWalker4483
2ba52a7095 Merge remote-tracking branch 'origin/HEAD' into partial_testing 2021-06-29 11:21:49 -04:00
Dan
187221537b fixing a corner case around file_data attributes. 2021-06-25 16:18:28 -04:00
Dan
628a587d97 We weren't committing to the database in the correct spot, so the delete wasn't sticking, and we were ending up with test workflows showing up in the main interface. 2021-06-23 16:39:58 -04:00
Dan
1f3febe2df Fix the panda warnings, which means we only support xlsx files now. 
Include the document details when reutnring a file from the file model.
Improve the validation of file form elements.
 2021-06-22 14:58:52 -04:00
NWalker4483
369b518384 Removed WorkflowService.delete_test_data() 2021-06-22 11:29:00 -04:00
Dan
07eb3f9ca8 Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously. 
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
 2021-06-18 16:41:55 -04:00
NWalker4483
4ca94b39ce Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing 2021-06-17 15:12:28 -04:00
Dan
a4caae8d64 when validating, we need to take every step to remove the workflows we create during the validation. 2021-06-16 14:40:20 -04:00
Dan
acae6030f5 The API for evaluating python expressions should not raise an error, it can simply return a result of false, and provide an error to explain the problem. In this way the front end doesn't error out when it's running the script tasks but doesn't have enough information to get a valid response back. 
The validation should take into account that repeating sections must be evaluated in the context of the data within the repeating section, not outside of it.
 2021-06-15 16:17:15 -04:00
NWalker4483
5c5b966bc4 Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing 2021-06-15 09:11:18 -04:00
Dan
738a984dcd Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-06-11 17:21:47 -04:00
Dan
879d6e1df3 missed a critical change on the backend with the recent file updates, this assures that we properly handle repeating sections during the post process, 
and we update the file doc code in those repeating sections.
 2021-06-11 17:20:25 -04:00
Dan
7282419174 modified the tools api to return the expression and data with the result, making it easier to cash results on the front end, This should help drastically reduce the calls to the python_eval from the front end. 
The post processors for form submissions needs to take repeating sections into account, or it won't find the files it is looking for.
 2021-06-11 08:27:50 -04:00
Kelly McDonald
394906d840 Add refresh_waiting_tasks to the processor do_engine_steps so that if we have a waiting task that has met its condition prior to the scheduler running, it will go ahead and proceed 2021-06-10 08:33:24 -04:00
NWalker4483
e1a4a79b03 Added Partial Workflow spec 2021-06-09 15:21:21 -04:00
NWalker4483
2364c240b2 Error Text Changed 2021-06-09 14:54:43 -04:00
NWalker4483
338fe30984 Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing 2021-06-09 14:32:01 -04:00
NWalker4483
17077be701 exit at task 2021-06-09 12:40:38 -04:00
Kelly McDonald
5f722d675f Add a function that gets runs via a background scheduler to look for any workflows that are in a 'waiting' state - it runs the update waiting tasks and does do_engine_steps 
We have a test for the function that runs, but an assumption was made that the scheduler module has its own unit tests and we do not need to test that.

fixes #346
 2021-06-09 10:42:34 -04:00
Kelly McDonald
0d8d251e8e Temp save to test dev 2021-06-09 09:24:37 -04:00
Dan Funk
586a0f2f1a
Merge pull request #325 from sartography/feature/file_refactor 
Prefer tasks that share a parent over just the the next available tas…
 2021-06-08 11:28:23 -04:00