sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-23 05:08:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,635 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

398 Commits

Author SHA1 Message Date
Dan
ff8a44a7b1 Make sure we always have a current user, even if the very first task is a script task. 2021-02-16 12:42:59 -05:00
Kelly McDonald
e54a6956df Make a change in the case that we have no task_events at all. 2021-02-16 11:10:40 -05:00
Kelly McDonald
118cf62172 Merge remote-tracking branch 'origin/dev' into STG-181_frontend-ux-model-changes 2021-02-16 10:07:34 -05:00
Kelly McDonald
003bf2f9b9 Remove Approvals per ticket 183 2021-02-16 09:05:29 -05:00
Kelly McDonald
3b1dc70558 Add comment for later ticket 2021-02-16 08:44:41 -05:00
mike cullerton
ed6218028c We now allow periods in field ids. 
Also, added task_id and task_name to the ApiError for missing default value on hidden and required fields
 2021-02-15 16:27:56 -05:00
mike cullerton
39eb5c5c21 This is a decent beginning framework for customer error messages. 
It is not complete, but is in a state where we can start to interact with the front end.
Two tests are failing.
Committing so I can work on an error for Alex.
 2021-02-12 14:18:42 -05:00
Dan Funk
35773ebc29
Merge pull request #240 from sartography/weird-email-error 
The email script was failing validation because of missing parameters…
 2021-02-12 09:31:52 -05:00
mike cullerton
d8bd203139 The email script was failing validation because of missing parameters in scripts.email.do_task_validate_only. 
I added a test in tests.test_email_script to make sure we get the default email_address.
I also found and fixed a bug in workflow_service.populate_form_with_random_data where we would overwrite default_values with random text because of a missing continue.
(We don't want to continue if we have repeating fields though.)
 2021-02-11 15:36:12 -05:00
Dan Funk
fe4e737596
Merge pull request #238 from sartography/value-expression-failing-shield-test-194 
We now allow value_expression to evaluate to an empty string ("") so …
 2021-02-11 11:25:09 -05:00
Dan Funk
df25b83958
Merge pull request #235 from sartography/index-error-for-enums-186 
Index error for enums 186
 2021-02-11 11:21:50 -05:00
Dan Funk
10b9c7b892
Merge pull request #234 from sartography/hidden-and-required-fields-185 
Hidden and required fields 185
 2021-02-11 11:20:35 -05:00
Dan
f7337f4e54 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-11 11:17:56 -05:00
Dan
2ada9f6f42 Private Ldap settings 2021-02-11 11:17:21 -05:00
mike cullerton
39e874504f We now allow value_expression to evaluate to an empty string ("") so that we *do not* set a default value for enums in some cases. 
This was causing an error because "" was not an option for the enum.
 2021-02-10 14:35:58 -05:00
mike cullerton
8a2a8b1443 Still not in working order. Committing to work on another ticket. 2021-02-10 12:28:59 -05:00
Kelly McDonald
da0af14724 Changes to enable front-end changes 
Added a human readable name to created user

added last updated task time and name,

added is_review on the workflow which is triggered by a swimlane with a name present.

Notably - it does NOT update or change any of the performance concerns that we were having with this.
 2021-02-10 11:58:19 -05:00
mike cullerton
b42b843f7d It was possible for an enum field lookup to return an empty list. This meant there were no options for the list. 
We now test for this and raise an error.
 2021-02-08 15:10:53 -05:00
mike cullerton
e87e7b5b8b Form fields that can be hidden and required must now have a default value or value_expression. 
Also, if a field is hidden but not required, it should not produce a value.
 2021-02-08 10:18:41 -05:00
mike cullerton
fa34bee18a First commit for cleaning up error messages for customers. 
This is *not* in a working state.
Committing this so I can work on another ticket.
 2021-02-04 11:23:05 -05:00
Dan Funk
329146237e
Merge pull request #232 from sartography/boolean-default-values-175 
Boolean default values 175
 2021-02-03 16:34:54 -05:00
mike cullerton
b090e31e00 This fixes 2 issues with setting boolean defaults 
- If the default was False, we failed an early test and returned None. We now only return None if default is None
 - We have a better test for deciding if the default value we return should be True or False. We used to return True if the value was the string 'false'.
 2021-02-03 09:50:16 -05:00
mike cullerton
7e76639cf3 When a study is put on hold, we now reset workflows and call any pending cancel_notify events. 
In api.study.update_study we test the study status and call the new WorkflowService method process_workflows_for_cancels.
In services.workflow_service we added the new method process_workflows_for_cancels. It loops through workflows for a study, and resets them if they are in progress.
In services.workflow_processor, we changed the reset method to be an instance method so we can call self.cancel_notify.
In tests.test_lookup_service we changed the call to WorkflowProcessor.reset to reflect the change from class method to instance method
 2021-01-29 14:05:07 -05:00
Dan Funk
cccb722e07
Merge pull request #226 from sartography/enum_default_value_expression_162 
Enum default value expression 162
 2021-01-27 10:43:46 -05:00
mike cullerton
81e55b6055 Cleaning up my smell. A task should only have default_value *or* value_expresion, not both. 2021-01-27 10:21:13 -05:00
Dan Funk
98f946c119
Merge pull request #227 from sartography/missing_form_key_163 
Missing form key 163
 2021-01-27 09:42:46 -05:00
mike cullerton
b71fd93dd4 We now make sure that forms have a form key. Ticket 163 2021-01-22 12:14:17 -05:00
mike cullerton
00d9276483 In spiff_task_to_api_task, when looping through fields, if the field doesn't have a value, we now try to set it with the default value 
In test_spec, we now check for FIELD_PROP_VALUE_EXPRESSION when setting default values
 2021-01-22 10:00:28 -05:00
Dan
5921ce9f10 Merge branch 'dev' into 152-workflow-spec-pull 2021-01-21 12:30:43 -05:00
Dan Funk
5b13195182
Merge pull request #224 from sartography/restart-with-no-data-99 
Restart with no data 99
 2021-01-20 17:22:18 -05:00
Dan
41dac33039 Removed two tests around soft_reset that are no longer required. 
Reset should construct the workflow_processor, thus completing the reset process.
Removed the spec argument from init, as it is never used anywhere.
 2021-01-20 13:24:53 -05:00
mike cullerton
039a1dcd79 WorkflowProcessor code for new restart_workflow api endpoint. WorkflowProcessor.reset will clear workflow_model.bpmn_workflow_json, and if clear_data is True will clear form data. 
WorkflowProcessor.__init__ is mostly unchanged.
 2021-01-19 15:14:36 -05:00
mike cullerton
6a9e6d3570 Restart workflow without form data. Committing so Dan can check it out 2021-01-14 15:32:14 -05:00
Kelly McDonald
f282a9ef73 Make sure that top_level_workflow is transferred over, also include reference files in the list of files to sync 
We may want to revisit this because I used a 'Magic' workflow_ref_id of 'REFERENCE_FILES' as a special case so I could re-use most of what I already had. This works well, but we may want to structure it different.
 2021-01-11 09:21:44 -05:00
Dan
336c093bf8 Catch errors when building enumeration lists. 2021-01-08 15:15:24 -05:00
Dan
26655b26d3 merging in dev, and fixing a failing test from dev. 2021-01-08 14:42:13 -05:00
Dan Funk
9118517995
Merge pull request #220 from sartography/prevent-duplicate-template-upload-111 
Users cannot upload a workflow_spec_file that already exists. We rais…
 2021-01-08 13:55:19 -05:00
mike cullerton
d274813ae5 We now check form field IDs so they play well with Python and Javascript. 2021-01-07 11:10:31 -05:00
mike cullerton
c9a4a9685f Users cannot upload a workflow_spec_file that already exists. We raise an error that is displayed on the fron end. 2021-01-04 15:47:45 -05:00
mike cullerton
0ae4448fbe Fixed ApiError call. Now includes task_id and task_name. 2021-01-04 13:48:34 -05:00
Dan
e5a38874f6 A hard or soft reset should also cause a 'cancel_notify' which will kick off any CANCEL events. If this happens during 
a hard or soft reset, and an error is thrown trying to fulfil a cancel event, the reset should still fire.
Sending emails still had a number of issues correctly parsing it's arguments.  This is corrected.
 2020-12-29 18:05:13 -05:00
Dan
c288a8a2bc Merge branch 'dev' into check-field-type#143 2020-12-29 11:11:43 -05:00
mike cullerton
7938ac8eed We now assure each form field has a field type. Modified populate_form_with_random_data, added check at beginning of form field loop. 2020-12-28 18:02:16 -05:00
Dan
6cfce839c1 Validation now assures that we won't encounter errors when generating navigation lists. 
Fixing workflow sync paths that were incorrect.
Repairing a suddenly failing test in files, that just don't make no sense.
Bumping spiffworkflow that contains a fix for issue #155
 2020-12-28 17:33:38 -05:00
Dan
1f9bf72c59 Merge branch 'dev' into bug/navigation 2020-12-14 11:46:44 -05:00
Dan Funk
4268d0f482
Merge pull request #208 from sartography/152-workflow-spec-pull 
152 workflow spec pull
 2020-12-14 11:35:06 -05:00
Dan
bcb78de225 Merge branch 'dev' into bug/navigation 2020-12-14 11:33:51 -05:00
Dan Funk
e54404e424
Merge pull request #205 from sartography/test-email-script 
Test email script
 2020-12-14 11:28:14 -05:00
Dan
b62a9c7074 Merge remote-tracking branch 'origin/dev' into bug/navigation 2020-12-14 10:40:21 -05:00
Dan
fd4b881416 upgrading the pip libraries. 2020-12-14 10:30:10 -05:00