sartography
/
cr-connect-workflow
mirror of https://github.com/sartography/cr-connect-workflow.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,454 Commits 13 Branches 0 Tags 8.7 MiB
Commit Graph

789 Commits

Author SHA1 Message Date
Kelly McDonald 6fbaecf9b2 Change selection to include task events that are for someone else, but are on a study I own. 2021-02-18 08:09:13 -05:00
Kelly McDonald 93f29e86d8 Merge branch 'dev' into STG-181_frontend-ux-model-changes 2021-02-17 07:49:05 -05:00
Dan ff8a44a7b1 Make sure we always have a current user, even if the very first task is a script task. 2021-02-16 12:42:59 -05:00
Kelly McDonald e54a6956df Make a change in the case that we have no task_events at all. 2021-02-16 11:10:40 -05:00
Kelly McDonald 118cf62172 Merge remote-tracking branch 'origin/dev' into STG-181_frontend-ux-model-changes 2021-02-16 10:07:34 -05:00
Kelly McDonald 3b1dc70558 Add comment for later ticket 2021-02-16 08:44:41 -05:00
Dan c44e784eb2 Fixing a bug with the user model. 2021-02-12 09:48:41 -05:00
Dan Funk 35773ebc29
Merge pull request #240 from sartography/weird-email-error 
The email script was failing validation because of missing parameters…
 2021-02-12 09:31:52 -05:00
Nile Walker 7eeb491dfa User str decode Removed 2021-02-12 09:30:18 -05:00
mike cullerton d8bd203139 The email script was failing validation because of missing parameters in scripts.email.do_task_validate_only. 
I added a test in tests.test_email_script to make sure we get the default email_address.
I also found and fixed a bug in workflow_service.populate_form_with_random_data where we would overwrite default_values with random text because of a missing continue.
(We don't want to continue if we have repeating fields though.)
 2021-02-11 15:36:12 -05:00
Dan Funk fe4e737596
Merge pull request #238 from sartography/value-expression-failing-shield-test-194 
We now allow value_expression to evaluate to an empty string ("") so …
 2021-02-11 11:25:09 -05:00
Dan Funk df0cfc755b
Merge pull request #237 from sartography/get-study-from-model-error-191 
We now test whether we have a valid StudyModel when getting a study b…
 2021-02-11 11:23:59 -05:00
Dan Funk 40639bbd03
Merge pull request #236 from sartography/trap-non-api-errors-187 
New error handler for non Api errors. Ticket 187
 2021-02-11 11:22:48 -05:00
Dan Funk df25b83958
Merge pull request #235 from sartography/index-error-for-enums-186 
Index error for enums 186
 2021-02-11 11:21:50 -05:00
Dan Funk 10b9c7b892
Merge pull request #234 from sartography/hidden-and-required-fields-185 
Hidden and required fields 185
 2021-02-11 11:20:35 -05:00
Dan f7337f4e54 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-11 11:17:56 -05:00
Dan 2ada9f6f42 Private Ldap settings 2021-02-11 11:17:21 -05:00
mike cullerton 39e874504f We now allow value_expression to evaluate to an empty string ("") so that we *do not* set a default value for enums in some cases. 
This was causing an error because "" was not an option for the enum.
 2021-02-10 14:35:58 -05:00
Kelly McDonald da0af14724 Changes to enable front-end changes 
Added a human readable name to created user

added last updated task time and name,

added is_review on the workflow which is triggered by a swimlane with a name present.

Notably - it does NOT update or change any of the performance concerns that we were having with this.
 2021-02-10 11:58:19 -05:00
mike cullerton 777cfbdecd We now test whether we have a valid StudyModel when getting a study by study model. 
We raise an ApiError if the model is None or empty.
 2021-02-09 17:37:55 -05:00
mike cullerton 3e32cdedc4 New error handler for non Api errors. Ticket 187 2021-02-09 16:35:57 -05:00
mike cullerton b42b843f7d It was possible for an enum field lookup to return an empty list. This meant there were no options for the list. 
We now test for this and raise an error.
 2021-02-08 15:10:53 -05:00
mike cullerton e87e7b5b8b Form fields that can be hidden and required must now have a default value or value_expression. 
Also, if a field is hidden but not required, it should not produce a value.
 2021-02-08 10:18:41 -05:00
Dan Funk 329146237e
Merge pull request #232 from sartography/boolean-default-values-175 
Boolean default values 175
 2021-02-03 16:34:54 -05:00
Dan Funk effd11f947
Merge pull request #231 from sartography/cancellations-137 
Cancellations 137
 2021-02-03 16:31:18 -05:00
Dan Funk 2d01b92a50
Merge pull request #230 from sartography/pretty-emails-160 
Pretty emails 160
 2021-02-03 16:20:38 -05:00
Dan Funk 1eba20f420
Merge pull request #229 from sartography/workflow-spec-order-74 
Workflow spec order 74
 2021-02-03 16:18:34 -05:00
mike cullerton b090e31e00 This fixes 2 issues with setting boolean defaults 
- If the default was False, we failed an early test and returned None. We now only return None if default is None
 - We have a better test for deciding if the default value we return should be True or False. We used to return True if the value was the string 'false'.
 2021-02-03 09:50:16 -05:00
mike cullerton c5cf3ea7ff Changed call to WorkflowProcessor.reset to reflect change from class method to instance method. 2021-01-29 14:34:09 -05:00
mike cullerton 7e76639cf3 When a study is put on hold, we now reset workflows and call any pending cancel_notify events. 
In api.study.update_study we test the study status and call the new WorkflowService method process_workflows_for_cancels.
In services.workflow_service we added the new method process_workflows_for_cancels. It loops through workflows for a study, and resets them if they are in progress.
In services.workflow_processor, we changed the reset method to be an instance method so we can call self.cancel_notify.
In tests.test_lookup_service we changed the call to WorkflowProcessor.reset to reflect the change from class method to instance method
 2021-01-29 14:05:07 -05:00
mike cullerton 958d5a6281 Possible solution for W3C issues raised by Sonarcloud 2021-01-28 09:45:53 -05:00
mike cullerton d7a3afe8f4 changed the template to use the responsive html email template at https://github.com/leemunroe/responsive-html-email-template 
added method get_cr_connect_wrapper to render our new html email template. This takes the email text generated from the task element documentation as the email_body.
 2021-01-27 17:12:03 -05:00
Dan Funk cccb722e07
Merge pull request #226 from sartography/enum_default_value_expression_162 
Enum default value expression 162
 2021-01-27 10:43:46 -05:00
mike cullerton 81e55b6055 Cleaning up my smell. A task should only have default_value *or* value_expresion, not both. 2021-01-27 10:21:13 -05:00
mike cullerton c99a388405 We now set the display_order automatically. Users can modify order using the arrows. 2021-01-27 09:50:29 -05:00
Dan Funk 98f946c119
Merge pull request #227 from sartography/missing_form_key_163 
Missing form key 163
 2021-01-27 09:42:46 -05:00
mike cullerton ecc553c4ea Jinja templates and svg file for pretty emails 2021-01-26 09:20:16 -05:00
mike cullerton 909af9b8d6 Change HTML emails so they look like the CR-Connect website. Add logo, color, style, etc. 
Cleaned up email script a little.
Also, email script no longer uses services.mails. It uses email_service directly now.
 2021-01-26 09:19:28 -05:00
mike cullerton b71fd93dd4 We now make sure that forms have a form key. Ticket 163 2021-01-22 12:14:17 -05:00
mike cullerton 00d9276483 In spiff_task_to_api_task, when looping through fields, if the field doesn't have a value, we now try to set it with the default value 
In test_spec, we now check for FIELD_PROP_VALUE_EXPRESSION when setting default values
 2021-01-22 10:00:28 -05:00
Dan 5921ce9f10 Merge branch 'dev' into 152-workflow-spec-pull 2021-01-21 12:30:43 -05:00
Dan Funk 5b13195182
Merge pull request #224 from sartography/restart-with-no-data-99 
Restart with no data 99
 2021-01-20 17:22:18 -05:00
Dan 41dac33039 Removed two tests around soft_reset that are no longer required. 
Reset should construct the workflow_processor, thus completing the reset process.
Removed the spec argument from init, as it is never used anywhere.
 2021-01-20 13:24:53 -05:00
mike cullerton 039a1dcd79 WorkflowProcessor code for new restart_workflow api endpoint. WorkflowProcessor.reset will clear workflow_model.bpmn_workflow_json, and if clear_data is True will clear form data. 
WorkflowProcessor.__init__ is mostly unchanged.
 2021-01-19 15:14:36 -05:00
mike cullerton 9c71a503ca Python code for new restart_workflow api endpoint. Cleaned up code and docstring in get_workflow to match. 2021-01-19 15:09:20 -05:00
mike cullerton e1532a90c9 New api endpoint for restarting a workflow. Unsure if I needed the responses section. **Dan, can you check this?** 
Also, removed clear_data and reload_spec as parameters for standard get workflow endpoint.
 2021-01-19 15:00:39 -05:00
mike cullerton 6a9e6d3570 Restart workflow without form data. Committing so Dan can check it out 2021-01-14 15:32:14 -05:00
Kelly McDonald cf7990ce85 Refactor for better readability due to code smell test 2021-01-12 08:54:32 -05:00
Kelly McDonald e14b896225 Add documentation 2021-01-11 09:31:08 -05:00
Kelly McDonald f282a9ef73 Make sure that top_level_workflow is transferred over, also include reference files in the list of files to sync 
We may want to revisit this because I used a 'Magic' workflow_ref_id of 'REFERENCE_FILES' as a special case so I could re-use most of what I already had. This works well, but we may want to structure it different.
 2021-01-11 09:21:44 -05:00