487a1a3987
Fixes #667- Validate Lane Variables
2022-03-21 12:18:40 -04:00
ce57a3753a
fixing some comments and error messages for clarity
2022-03-09 10:28:22 -05:00
41b5106a28
patching up the tests.
...
Looks like we want to use default values, if they are provided, for validation. So good test, and I didn't have to create a new bug. Also added skipping the test about requiring a default for hidden+required fields. Maybe we don't need to after all.
2022-03-08 18:38:05 -05:00
26eeb2912a
Only run the form validation stuff if we have a form.
...
If there is a default value, use it, regardless of whether the form is hidden (this is how the front end works)
(accomplished by moving the hide_epxression check -> continue stuff below the set default_value code)
2022-03-08 18:13:54 -05:00
b03e24bbf4
Properly handle forms where a field is required, based on a later field.
...
Do an aboutface on saying that if a field is required but hidden, it has to have a default value. I'm just commenting this out for now, as it made getting these workflows to validate bloody impossible.
Clean up the replication of code for identifying required fields (as it wasn't consistently applied)
Removing some very broken and apparently unused methods.
2022-03-08 17:36:13 -05:00
0455506e2b
Loading latest chages from Spiff whic refactored the way the PythonExpressionEngine works.
...
This cleans up the _evaluate method which previously accepted arbitrary args and kwargs, and now requires an expression, a context to which exectute it, and, optionally, the current task being executed if the DMN is being executed as a part of a BusinessRuleTask in a BPMN diagram.
This also cleans up several bits of duplicated code.
There is also a bit of code here to assure that the current user is included when running the master workflow.
2022-03-04 15:34:36 -05:00
9c0b5b9e16
Test for new feature
2022-03-01 16:17:34 -05:00
896ce8934b
Merge pull request #477 from sartography/bug/645_document_updated
...
An optimization prevented us from picking up a change to the document…
2022-02-28 15:57:13 -05:00
2ab3df2466
Force an error during test_spec, to make sure we clean up workflows
2022-02-28 14:02:26 -05:00
51a14311eb
An optimization prevented us from picking up a change to the documents associated with a study. This assures that even if scripts run side by side, the document list will get updated, but only on a change. So it's still performant. Also added a sligthly better error message to the workflow service.
2022-02-28 12:17:21 -05:00
2c427cc34c
Temporary fix for variable issue in SpiffWorkflow.
...
There is a fix coming in SpiffWorkflow
2022-02-25 15:56:13 -05:00
f2c97f80d5
Merge branch 'dev' into feature/delete-variable-script-584
...
# Conflicts:
# Pipfile.lock
2022-02-25 15:54:34 -05:00
e8617038ab
Merge pull request #461 from sartography/bug/missing-executabe-option-601
...
Bug/missing executabe option #601
2022-02-24 08:46:46 -05:00
9fc8158903
Merge branch 'feature/delete-variable-script-584' of github.com:sartography/cr-connect-workflow into feature/delete-variable-script-584
2022-02-21 14:30:41 -05:00
65ffc37787
fixing a bug in Spiff that was preventing our tests from passing.
2022-02-21 14:30:36 -05:00
017f228dd9
Cleanup - create name for reused data
2022-02-21 14:01:35 -05:00
6ec7241a7b
Test for new script
2022-02-21 12:55:33 -05:00
1cd3be70a7
Test for bug fix
2022-02-21 10:17:18 -05:00
a7f591d2ac
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-18 17:19:01 -05:00
b90be07bca
Remove these bloodly log files from the repo.
2022-02-18 11:40:10 -05:00
753534c4cd
Remove boolean tests
...
It could only be True or False now. And again this should be a frontend test now
2022-02-18 10:09:24 -05:00
ad58b67bb6
Delete read only field test
...
This is really something the frontend should be testing. Perhaps in the libraries test suite
2022-02-18 10:00:15 -05:00
7d597a82f4
mostly fixing bpmns
2022-02-18 09:48:02 -05:00
06dc20657b
Fixing various BPMN's for tests
2022-02-17 17:29:44 -05:00
a5acd9b07e
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-17 15:04:41 -05:00
19965d18da
Refactor test workflow_enum_value_expression
...
Same as other commit pretty much
2022-02-17 14:07:41 -05:00
218429f196
Refactor test workflow_value_expression
...
the backend shouldn't try to set a dynamic default value. Instead, the frontend will initialize it to an empty string, then evaluate a default value, then choose to set it. (Basically, move this function from the backend and put the burden on formly)
2022-02-17 12:25:40 -05:00
92eb8e9cb9
test for date field validation
2022-02-17 11:48:31 -05:00
0ad9843569
Dealing with some changes in SpiffWorkflow's latest release. I think this gets all tests passing again, and behaving as expected.
2022-02-16 10:46:46 -05:00
e9cf095810
Fixing a stupid mistake in the tests.
2022-02-11 11:54:46 -05:00
648383f2ea
for some reason jenkins doesn't like the spec_category_reorder test, so just doing it a different way.
2022-02-11 11:37:25 -05:00
7a99859108
fixing some failing test
2022-02-11 11:00:42 -05:00
df3f67601c
performance improvements. and last rements of load_example_data()
2022-02-09 23:29:39 -05:00
788e40a998
death to load_example_data() !!!!!
2022-02-09 22:13:02 -05:00
f12c4aba52
Refactor the workflow_spec_service so it doesn't cache anything, it always reads what it needs from the file system.
2022-02-09 21:06:55 -05:00
cf71f68ad9
all tests passing!!!!!!!!!!!!!
2022-02-09 15:30:07 -05:00
2cc20d4b9d
really need to avoid any kind of caching in the WorkflowSpecService
2022-02-09 14:43:32 -05:00
3b6f217443
specs, not workflows
2022-02-09 13:51:49 -05:00
aaf20a4de7
specs, not workflows
2022-02-09 13:06:33 -05:00
d46dfdec40
Fixed the bad order test
2022-02-09 12:14:37 -05:00
9576089e84
Reorder categories
2022-02-09 10:55:02 -05:00
20ca31dd4d
category to category_id
2022-02-09 08:51:50 -05:00
5396226b0f
Fix reorder spec tests
2022-02-08 16:35:36 -05:00
25ecc1593a
test_workflow_spec_api passing.
2022-02-08 13:35:27 -05:00
6c0e38c0a5
Merge branch 'feature/spec_files_wthout_db' of github.com:sartography/cr-connect-workflow into feature/spec_files_wthout_db
2022-02-08 11:31:56 -05:00
dc040f190e
got one more test to work.
2022-02-08 11:30:13 -05:00
dfb05764db
*** WIP ***
...
Committing to merge in the git integration code
2022-02-08 10:27:48 -05:00
a4fb00b0ed
remove bad imports
2022-02-07 15:28:52 -05:00
4b8d193fb9
a few more tests passing
2022-02-07 14:58:25 -05:00
5c3ab9a035
Move copy_files_to_file_system to base_test
2022-02-07 13:43:20 -05:00
alicia pritchett
Dan
mike cullerton