Dan
51a14311eb
An optimization prevented us from picking up a change to the documents associated with a study. This assures that even if scripts run side by side, the document list will get updated, but only on a change. So it's still performant. Also added a sligthly better error message to the workflow service.
2022-02-28 12:17:21 -05:00
Dan Funk
9b004d0dc6
Merge pull request #462 from sartography/feature/delete-variable-script-584
...
Feature/delete variable script #584
2022-02-25 16:19:51 -05:00
mike cullerton
2c427cc34c
Temporary fix for variable issue in SpiffWorkflow.
...
There is a fix coming in SpiffWorkflow
2022-02-25 15:56:13 -05:00
mike cullerton
f2c97f80d5
Merge branch 'dev' into feature/delete-variable-script-584
...
# Conflicts:
# Pipfile.lock
2022-02-25 15:54:34 -05:00
Dan Funk
140de7ed03
Merge pull request #473 from sartography/nonetype-displayname-error-632
...
Nonetype displayname error #632
2022-02-25 15:41:14 -05:00
mike cullerton
bfcfedbffc
Test for the bug fix
2022-02-25 14:43:32 -05:00
Dan Funk
18802d6732
Merge pull request #468 from sartography/chore/performance
...
Performance Improvements:
2022-02-25 12:10:47 -05:00
Dan Funk
dd7eddb936
Merge pull request #470 from sartography/update-email-reply-address-629
...
Modify default sender for emails #629
2022-02-25 10:30:21 -05:00
Dan Funk
b6af80f6de
Merge pull request #469 from sartography/feature/modify-spreadsheet-624
...
modify spreadsheet #624
2022-02-25 10:29:37 -05:00
Dan Funk
5ff84d74f1
Merge pull request #464 from sartography/feature/start-workflow-602
...
Feature/start workflow #602
2022-02-25 10:28:26 -05:00
mike cullerton
10880d6354
Modify default sender for emails
2022-02-25 08:38:40 -05:00
mike cullerton
9d2436b375
Typo calling script with keywords
2022-02-25 08:18:07 -05:00
Dan
3442655bd1
Performance Improvements:
...
1. Avoid ever re-generating the list of scripts that can be used in a script task. Terribly expensive as we call eval constantly, and it never ever changes once the app starts. (see script.py changes, and comments)
2. Cache the DocumentStatus list in the flask session, so we calculate it at most once per API Call. It's at least .25 seconds per call. (see study_sevice)
3. We called UserFileService.get_files_for_study (which runs a db query EVERY time) for every possible document type. Now we run the query once (study service line 321)
4. When returning a workflow, we looped through every single task in that workflow's navigation, and called the expensive spiff_task_to_api_task just to figure out it's proper display name. We run a much faster and more efficient method to calculate the display name naow (see workflow_service on lie 680, and 799)
5. A hellton of @timeit and sincetime() calls, that I want to leave in, to help debug any slowness on production.
2022-02-24 14:25:42 -05:00
mike cullerton
ed0499a573
Make sure we have a workflow.
...
Raise an ApiError with the workflow_spec_id if we cannot find a workflow
2022-02-24 12:37:25 -05:00
mike cullerton
e1bd301e41
Merge branch 'dev' into feature/start-workflow-602
2022-02-24 10:36:38 -05:00
mike cullerton
0b3187889d
We now raise an error if the spreadsheet does not exist.
...
Added test for case where the spreadsheet does not exist
2022-02-24 10:25:34 -05:00
mike cullerton
1fe1ce2e22
Merge branch 'dev' into feature/modify-spreadsheet-624
2022-02-24 09:42:53 -05:00
Dan Funk
e8617038ab
Merge pull request #461 from sartography/bug/missing-executabe-option-601
...
Bug/missing executabe option #601
2022-02-24 08:46:46 -05:00
mike cullerton
d378078d6f
Change so that we always use the current workflow
2022-02-23 15:18:03 -05:00
mike cullerton
679a875666
Test for new script
2022-02-23 14:30:45 -05:00
mike cullerton
2aea4bc1ae
Test for new script
2022-02-22 14:37:53 -05:00
Dan
9fc8158903
Merge branch 'feature/delete-variable-script-584' of github.com:sartography/cr-connect-workflow into feature/delete-variable-script-584
2022-02-21 14:30:41 -05:00
Dan
65ffc37787
fixing a bug in Spiff that was preventing our tests from passing.
2022-02-21 14:30:36 -05:00
mike cullerton
017f228dd9
Cleanup - create name for reused data
2022-02-21 14:01:35 -05:00
mike cullerton
6ec7241a7b
Test for new script
2022-02-21 12:55:33 -05:00
mike cullerton
1cd3be70a7
Test for bug fix
2022-02-21 10:17:18 -05:00
alicia pritchett
70fc9451a4
fix tests (update BPMNs)
...
test_stupid_slow_file_upload_form still fails
2022-02-21 09:44:00 -05:00
Dan
a7f591d2ac
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-18 17:19:01 -05:00
Dan
b90be07bca
Remove these bloodly log files from the repo.
2022-02-18 11:40:10 -05:00
Dan
e91be2a54d
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-18 11:27:58 -05:00
Dan
635a112796
still trying to fix a rogue test.
2022-02-18 10:41:24 -05:00
Dan
6adf1107fe
Trying to figure out why these files are not the same on testing.
2022-02-18 10:12:36 -05:00
alicia pritchett
753534c4cd
Remove boolean tests
...
It could only be True or False now. And again this should be a frontend test now
2022-02-18 10:09:24 -05:00
alicia pritchett
55aacae608
more BPMN's
2022-02-18 10:05:46 -05:00
alicia pritchett
ad58b67bb6
Delete read only field test
...
This is really something the frontend should be testing. Perhaps in the libraries test suite
2022-02-18 10:00:15 -05:00
alicia pritchett
7d597a82f4
mostly fixing bpmns
2022-02-18 09:48:02 -05:00
alicia pritchett
06dc20657b
Fixing various BPMN's for tests
2022-02-17 17:29:44 -05:00
alicia pritchett
a5acd9b07e
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-17 15:04:41 -05:00
alicia pritchett
19965d18da
Refactor test workflow_enum_value_expression
...
Same as other commit pretty much
2022-02-17 14:07:41 -05:00
Dan Funk
be48f86440
Merge pull request #459 from sartography/bug/619_lookup_tables
...
Another re-work to fix 619 - and to assure that we aren't rebuilding …
2022-02-17 13:15:37 -05:00
Dan
c2dbec1e3f
Merge remote-tracking branch 'origin/dev' into bug/619_lookup_tables
2022-02-17 12:51:24 -05:00
Dan
e0a8e7300c
Merge remote-tracking branch 'origin/dev' into get-erroring-workflows-574
2022-02-17 12:37:34 -05:00
alicia pritchett
218429f196
Refactor test workflow_value_expression
...
the backend shouldn't try to set a dynamic default value. Instead, the frontend will initialize it to an empty string, then evaluate a default value, then choose to set it. (Basically, move this function from the backend and put the burden on formly)
2022-02-17 12:25:40 -05:00
Dan Funk
9d74ee5790
Merge pull request #458 from sartography/bug/date-field-validation-622
...
Bug/date field validation #622
2022-02-17 12:18:39 -05:00
Dan Funk
484b9a9c7c
Merge pull request #457 from sartography/feature/get-spec-script-613
...
Feature/get spec script #613
2022-02-17 12:17:12 -05:00
Dan Funk
b91372171c
Merge pull request #454 from sartography/git-integration-fixes-596
...
Git integration fixes #596
2022-02-17 12:15:13 -05:00
Dan Funk
5def436602
Merge branch 'dev' into get-erroring-workflows-574
2022-02-17 12:12:42 -05:00
Dan
b72ecb8375
Another re-work to fix 619 - and to assure that we aren't rebuilding the lookup tables too frequently.
2022-02-17 11:59:48 -05:00
mike cullerton
d3883323f9
Simplified test workflow
2022-02-17 11:51:33 -05:00
mike cullerton
92eb8e9cb9
test for date field validation
2022-02-17 11:48:31 -05:00
