sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 13:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,926 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

1122 Commits

Author SHA1 Message Date
Dan
5e54c90b47 "Reset" should not mean "re-start". Calling the reset_workflow script will now set the workflow to an "unstarted" state with no outstanding tasks, no json-state structure stored. The workflow is not yet running. 
Also:
* Assured that arguments are consistent (we always seem to use workflow_spec_id, so I made sure we use that consistently.
* Don't require named parameters - so it's cool to call it like: reset_workflow('my_workflow_id')
* Task Actions (ie create, assign, etc...) are now an enumeration in the models, and not static variables on Workflow Service, so we can reference them consistently from anywhere.
* Removed some repetitive code
* Always try to validate as much as possible in the scripts to save folks time debugging.
*
 2022-04-15 15:36:23 -04:00
mike cullerton
ae67c8985a forgot the workflow 2022-04-14 15:50:12 -04:00
mike cullerton
a21aea3348 Fixed a bug where we tried to delete a record that did not exist 2022-04-14 15:37:05 -04:00
mike cullerton
6c1fcc5cee Make sure we don't delete records when value is set to False 2022-04-13 18:10:35 -04:00
mike cullerton
ea657cbbc2 Change value from string 'None' to value None to test deleting data_stores. 
This as a work around, because the form field is set to string for other uses
 2022-04-13 18:09:18 -04:00
mike cullerton
19da7ecd7e Fix test workflows to use new data_store scripts 2022-04-13 18:07:13 -04:00
mike cullerton
e87fae0004 *** WIP *** 
Modify delete test to check for both None and empty string
 2022-04-13 13:52:20 -04:00
mike cullerton
721907bf52 Modify test workflow to use new data_store_set script instead of separate study_data_set, user_data_set, and file_data_set scripts 2022-04-13 13:51:25 -04:00
Dan Funk
bf898993c4
Merge pull request #514 from sartography/get-irb-info-issue-702 
Get irb info issue #702
 2022-04-12 08:14:14 -04:00
mike cullerton
138dfc220d Tests expect 1 record now 
Add test for error state when study is not yet uploaded
 2022-04-07 14:40:47 -04:00
mike cullerton
ed49ebcc23 Fix mock data to only return 1 record 
Add mock record for error state when study is not yet uploaded
 2022-04-07 14:39:39 -04:00
mike cullerton
da7c0a50ae Workflows for new tests 2022-04-05 18:17:54 -04:00
mike cullerton
946e74118f Test updating records 
Test deleting records when setting with empty value
Test deleting 'extra' records
 2022-04-05 18:17:31 -04:00
mike cullerton
3c418f7611 Rename workflow/test_workflow_data_store_validation to test_data_store_service 2022-04-05 11:35:41 -04:00
Dan Funk
6694dc6cb3
Merge pull request #510 from sartography/git-error-filenotfound-690 
Git error filenotfound #690
 2022-04-04 16:53:36 -04:00
Dan Funk
095105e3e6
Merge pull request #508 from sartography/validation-with-data-store-396 
Validation with data store #396
 2022-04-04 16:51:57 -04:00
Dan
e1f9dcded5 Assure we can associate the same person with a workflow under two different roles. 2022-04-04 16:01:48 -04:00
mike cullerton
51c6871d06 Update mock data to use new valid review type 2022-03-30 10:30:27 -04:00
mike cullerton
70e8f6b35e Fix typo in test: delete -> remove 2022-03-29 12:34:05 -04:00
mike cullerton
689aa54d50 Modified tests to work with the bug fix 2022-03-29 09:49:29 -04:00
Mike Cullerton
9ec1514267
Merge pull request #509 from sartography/chore/zip-file-update-688 
Chore/zip file update #688
 2022-03-29 09:41:32 -04:00
Mike Cullerton
6ff0cdbb9d
Merge pull request #507 from sartography/bug/validating_data_security 
Bug/validating data security #684
 2022-03-29 09:41:02 -04:00
mike cullerton
ee3217de62 Test for new feature 2022-03-28 11:59:53 -04:00
mike cullerton
6b93d605d4 Test for new validation_data_store. 
We set 3 `real` data_store values in the DB
The workflow sets 3 validation_data_store values
We assert that the correct values are returned.
We also assert that we get correct default values back if we pass in bad keys
 2022-03-25 10:06:03 -04:00
mike cullerton
51fa494d03 Assert we evaluate the hidden property correctly during validation. 2022-03-23 16:49:35 -04:00
mike cullerton
94abd7eebf *** WIP *** 
Add a temporary data store for validation
 2022-03-23 15:15:01 -04:00
Dan Funk
244fced84d
Merge pull request #506 from sartography/chore/unchecked-checkbox-default-671 
Unchecked checkbox default #671
 2022-03-23 10:59:47 -04:00
mike cullerton
1969e0b051 Make sure we don't get null/None back from a boolean checkbox. 
This is not a comprehensive test, because we can't have an unchecked checkbox in validation.
We really need a frontend test for this.
 2022-03-23 09:48:13 -04:00
alicia pritchett
487a1a3987 Fixes #667- Validate Lane Variables 2022-03-21 12:18:40 -04:00
mike cullerton
27c2b95f31 Pass update_status=True in the test when calling the get_study api endpoint 
This allows master_workflow_results to be set, which allows categories to be processed in StudyService.get_study()
 2022-03-18 17:01:36 -04:00
Dan
e44ea6e13c merging in from dev. 2022-03-18 16:22:33 -04:00
mike cullerton
81e3da043c Fix tests 2022-03-18 16:05:16 -04:00
Dan
a401c41b23 Setting a minimum date for which to import studies. 
Merging in code to improve performance of calculating percent complete for a study.
Assureing we have a primary investigator for the front page (another merge)
 2022-03-18 15:27:45 -04:00
Dan
b7489aea43 merging in PI Name changes from Alicia's #499 PR. 2022-03-18 12:30:20 -04:00
alicia pritchett
5f802a3e79 oops 2022-03-18 12:09:56 -04:00
alicia pritchett
b9b8210f8a rm pi id refs 2022-03-18 12:04:20 -04:00
alicia pritchett
b6b28ed127 fix tests remove pi id 2022-03-18 11:56:56 -04:00
Dan
ef5aca4fe4 ReviewType now comes back with the user studies, so we don't need to make an additional query to get it. 2022-03-18 09:59:10 -04:00
mike cullerton
199fe0626a Assert that if we get null for DATELASTMODIFIED, we use the value in DATECREATED 2022-03-17 15:56:44 -04:00
alicia pritchett
5b7e71d42d meta field for categories 2022-03-16 12:49:35 -04:00
Dan Funk
8ea8993421
Merge pull request #493 from sartography/jinja-included-includes-670 
Jinja included includes #670
 2022-03-14 16:49:56 -04:00
mike cullerton
4a626afa7d Added comment about the test 2022-03-14 14:01:13 -04:00
mike cullerton
eb615012af Cleanup - remove unused import, print statement 2022-03-14 13:56:38 -04:00
mike cullerton
238840822d Included template test from hell 2022-03-14 13:54:46 -04:00
mike cullerton
ace988d551 assert we get category and workflow in all the places 2022-03-14 12:02:11 -04:00
Dan
dec63839f3 Merge remote-tracking branch 'origin/dev' into chore/log-changes-661 2022-03-12 16:19:23 -05:00
Dan
2fc4b44ef3 Create a path to directly download the spreadsheet file (and avoid the weird dance on the front end of making an API call to get file data.) 
Fixing pagination.  Seems the front end uses a page_index that is 0 based, and sqlAlchemy prefers to start at 1.
 2022-03-12 16:19:07 -05:00
mike cullerton
a536a79e87 Test for downloading logs 2022-03-12 14:29:02 -05:00
Dan
4ab314c7b8 Be sure to delete the data store items when you delete a study. 2022-03-12 13:38:09 -05:00
Dan
52b5e1d34a Fixing tests. 2022-03-11 18:02:37 -05:00