15efc2f3f1
Merge pull request #370 from sartography/library-listing-453
...
Library listing #453
2021-09-14 16:11:56 -04:00
a7f032d372
Returns workflow spec categories ordered by display order
...
sorry to open a whole branch just for this little fix
2021-09-14 10:56:41 -04:00
7b7c228a81
2 changes
...
- The `all_specifications` method is now explicit in what it returns; either `library`, `standalone`, or `regular` workflow specs
- When we add/edit a workflow spec, we make sure that `library` and `standalone` workflow specs do not get a category_id
2021-09-13 16:15:18 -04:00
9bd012c822
Clean up display_order numbers when reordering.
...
This fixes the problem where we have don't have all unique display_order numbers.
I.e., 0, 1, 1, 3, 5
2021-09-08 11:16:49 -04:00
ed57993f8d
Workflow spec cleanup needs a category_id
2021-08-31 12:17:25 -04:00
b92676ea75
Make sure we have good display_orders before adding specs and categories
2021-08-31 11:16:27 -04:00
994ce4008f
Don't let updates to workflow-spec and workflow-spec-category metadata change the display_order
...
Force display_order changes to use the new reorder API endpoints
2021-08-31 10:36:22 -04:00
f6816a2e42
Move display_order cleanup to their own methods
2021-08-31 10:07:38 -04:00
b76f45368b
Explicitly commit the changes
2021-08-30 15:29:49 -04:00
7bbb64cf27
Reorder remaining categories after delete
2021-08-30 15:20:45 -04:00
c275c01526
Reorder remaining workflow specs upon deletion
2021-08-30 14:56:26 -04:00
eb6b73fde5
Fixed typo where I returned an ApiError, instead of raising it.
2021-08-30 13:55:21 -04:00
070a9c9350
Code for reordering Workflow Spec Categories
...
Still need to work on edge cases where you try to move past top or bottom of list
Still need to work on tests
2021-08-30 11:27:07 -04:00
f2201a3cef
Move business logic to WorkflowService
...
Return ordered list of specs
2021-08-30 10:41:08 -04:00
41414e39c8
First pass at reorder spec code.
...
Still need to return list of specs
Still need to work on spec categories
2021-08-27 13:02:49 -04:00
f639e101b7
Commit the skeleton API endpoints, so we can use them while developing the BPMN side of things.
2021-08-27 11:40:38 -04:00
feb72af32e
Update workflow.py
...
Just completing a comment so I understood
2021-08-18 13:27:28 -04:00
b4ecb0f97a
Add backref cascade and make changes to the spot where we delete so it loads objects into memory and then uses the SQLAlchemy plumbing to make sure that the db object gets cleaned up.
2021-08-18 08:25:17 -04:00
6e1fedb704
Add tests for libraries, remove an API endpoint that didn't make sense after recent changes and remove some commented out sections that were not needed after some decisions about the api endpoints were made
2021-08-03 10:02:22 -04:00
41ad7935f8
Merge branch 'dev' into 367-Call-Activity
...
# Conflicts:
# Pipfile.lock
2021-07-29 09:28:21 -04:00
b857fddbad
commit in intermediate changes to work on a bug
2021-07-26 13:00:11 -04:00
2455495457
got library side working - still need to have parent working
2021-07-22 10:20:34 -04:00
fb54edac1c
Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
...
Most noteable is the addition of the line on which the error occurs for script tasks. It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
338fe30984
Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing
2021-06-09 14:32:01 -04:00
286803d10b
fixing a big stupid bug I created when merging all the code and making changes to the files.
2021-06-08 14:24:59 -04:00
586a0f2f1a
Merge pull request #325 from sartography/feature/file_refactor
...
Prefer tasks that share a parent over just the the next available tas…
2021-06-08 11:28:23 -04:00
9c4994581d
Merge pull request #324 from sartography/modify-infinite-loop-312
...
Modify infinite loop #312
2021-06-08 10:30:13 -04:00
5881c903ca
Merge pull request #316 from sartography/326-Multi_File_Data_Store
...
Make sure we are using the correct script engine
2021-06-08 08:49:43 -04:00
59f605c3df
Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor.
2021-06-08 08:03:14 -04:00
0dfc96d7f6
Modified `validate_workflow_specification` to accept new optional `validate_study_id` parameter.
...
We then pass validate_study_id on to WorkflowService.test_spec
2021-06-03 14:19:41 -04:00
acccf3b704
Make sure we are using the correct script engine
2021-05-26 10:50:20 -04:00
ce7c07679b
SonarCloud
2021-05-14 15:52:30 -04:00
a9e3f7c861
Standalone workflows do not have a study_id, and we do not record task events for them.
2021-05-14 15:34:29 -04:00
77d9bfca43
Merge pull request #296 from sartography/launch-workflow-outside-study-204
...
Launch workflow outside study 204
2021-05-04 11:16:08 -04:00
799747d638
Add filter for non-active studies so that the events for them do not get returned to the front end for the 'InProgress' data pane.
2021-04-27 12:13:49 -04:00
39fcab3730
Merge branch 'dev' into launch-workflow-outside-study-204
2021-04-26 10:27:32 -04:00
fa818bd751
Code for the 2 new api endpoints
...
Also modified `update_task` so that it no longer requires a study_id
2021-04-26 08:31:12 -04:00
3332b9c7c0
Added delete_files argument to the restart_workflow api method, and pass it along to WorkflowProcessor.reset
2021-04-15 11:23:20 -04:00
6f80d816cd
My privous efforts didn't take into account the fact that we use dot notation in field names.
...
I've re-worked the workflow form endpoint, so that it only accepts the data that should be in the form, and ignores any other values that come back from the front end. It seems Formly has some bugs that were introducing confusing information, and I want everything to behave consistently.
I had to re-work some of the tests, which were relying on an ability to set data through a form post without having a corresponding form to do so.
2021-03-14 12:20:39 -04:00
15c64c862e
Adding an argument to update task that will allow it to complete all remaining tasks through an "update_all" flag,
...
this will allow us to remove some fairly complex logic from the front end that isn't behaving properly.
2021-03-12 20:41:07 -05:00
576aebab19
Sometimes a workflow can be completely broken and unloadable. For instance, it starts off with a engine step / script task that will not execute. So the failure happens the second it is processed. When calling reset on a workflow, we should catch the failure, and reset the workflow, so we aren't trapped in an unrecoverable state.
...
To do so, I changed the WorkflowProcessor's reset method to be static, it will try to instantiate the current workflow and execute a cancel_notify event, but if that fails, it will continue and always return a new workflow processor using the latest spec.
2021-03-09 11:52:55 -05:00
9e758c57d3
Merge branch 'dev' into bug/225_enum_lookup_same_field_name
2021-03-02 14:15:58 -05:00
aac3d5c16e
Bug #255 , this requires the front end to pass in the name of the task, when doing a lookup. This will prevent a bug where we have multiple user tasks, with enum fields that set the same variable, but use different lookup tables to populate the dropbown or search feature.
2021-03-01 14:54:04 -05:00
9d804c36d5
Merge branch 'dev' into customer-error-messages-192.
...
Needed some sql changes from dev
2021-03-01 10:29:10 -05:00
4fc2929356
Put the preamble back in to the error message.
2021-02-19 15:57:01 -05:00
4fa0f9720a
Allow frontend to honor 'view as' and fix problem with tests
2021-02-18 11:25:17 -05:00
6fbaecf9b2
Change selection to include task events that are for someone else, but are on a study I own.
2021-02-18 08:09:13 -05:00
8a2a8b1443
Still not in working order. Committing to work on another ticket.
2021-02-10 12:28:59 -05:00
fa34bee18a
First commit for cleaning up error messages for customers.
...
This is *not* in a working state.
Committing this so I can work on another ticket.
2021-02-04 11:23:05 -05:00
effd11f947
Merge pull request #231 from sartography/cancellations-137
...
Cancellations 137
2021-02-03 16:31:18 -05:00
Mike Cullerton
alicia pritchett
mike cullerton
Kelly McDonald
Dan
NWalker4483