sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 21:58:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,593 Commits 14 Branches 0 Tags 9.1 MiB
Commit Graph

251 Commits

Author SHA1 Message Date
Dan
df3f67601c performance improvements. and last rements of load_example_data() 2022-02-09 23:29:39 -05:00
Dan
f12c4aba52 Refactor the workflow_spec_service so it doesn't cache anything, it always reads what it needs from the file system. 2022-02-09 21:06:55 -05:00
Dan
2cc20d4b9d really need to avoid any kind of caching in the WorkflowSpecService 2022-02-09 14:43:32 -05:00
Dan
de6d7eee84 nearly all study tests work. 2022-02-09 12:03:45 -05:00
alicia pritchett
38d64b1ffd fixes a workflow model related test 
yes i call a service from a service whoops
 2022-02-09 11:07:09 -05:00
Dan
dc040f190e got one more test to work. 2022-02-08 11:30:13 -05:00
Dan
4b8d193fb9 a few more tests passing 2022-02-07 14:58:25 -05:00
alicia pritchett
66906c3786 fix a couple things 2022-02-07 10:57:34 -05:00
Dan
2383c7d76d WIP - lots of random changes, trying to swtich over 2022-02-04 14:50:31 -05:00
Dan
4ec6e403f5 1. Created a UserFileService, so it's clear what we use when for File Services, UserFiles, SpecFiles, and ReferenceFiles each function differently. 
2. Reference Files and Spec Files are written to disk, they do not exist in the database at all.
 2022-02-02 12:59:56 -05:00
Dan
4c00a5762f partial commit - new spec_file_service, and new spec_file_api endpoints that use spec and file name, not file id. 
removed worklow_sync
cleaned up file and workflow models
most of the test are broken.
 2022-01-28 06:42:37 -05:00
mike cullerton
b6b9482a64 *** WIP *** 
Incremental commit. Mainly cleaning up failing tests.
 2022-01-12 13:16:09 -05:00
mike cullerton
dc27f795c8 *** WIP *** 
Committing because it is Friday afternoon, and my computer is acting flaky
 2022-01-07 15:34:51 -05:00
mike cullerton
86a6039dc8 *** WIP *** 
**Many** tests are failing!

Committing so I can merge dev into this branch
 2022-01-06 11:46:54 -05:00
Dan
1446302a04 A quick fix for an error we are seeing in testing. 2021-12-30 15:27:31 -05:00
alicia pritchett
a81f25f0ee Just kidding. We should make deepcopy and put in fake data 4 valdiation 
see above. previously i deleted this, because i didnt want unitializsed data in task data. well heres a hint. don't put it in task data. make a deep copy and hold on to that for validation pursposes
 2021-12-16 14:47:04 -05:00
Dan Funk
e62a99af96
Merge pull request #438 from sartography/bug/fix-task-data 
Bug/fix task data
 2021-12-13 13:31:37 -05:00
Dan Funk
b5f2fe05dc
Merge pull request #439 from sartography/workflow-spec-delete-217 
Problem deleting workflow spec #217
 2021-12-13 13:19:56 -05:00
Dan
c46800171d Merge remote-tracking branch 'origin/dev' into bug/fix-task-data 2021-12-13 13:18:00 -05:00
mike cullerton
daebf42a30 Move some of the work in crc.api.workflow.delete_workflow_specification to separate workflow_service methods 
Added a session.commit to `delete_workflow_spec_task_events`
 2021-12-13 11:04:28 -05:00
mike cullerton
acbb8898e4 Merge branch 'more-study-statuses-562' into waiting-workflow-errors-566 2021-12-10 16:52:07 -05:00
mike cullerton
f748fa3db8 Removed unused imports 2021-12-10 16:48:28 -05:00
alicia pritchett
f9fbb32641 Take this garbage out 
I can say that because I originally wrote that garbage
 2021-12-10 12:10:08 -05:00
alicia pritchett
962cf7c32c Fixes problem with initializing some task data fields 
we had a problem where sometimes, task data gets some values set in its fields to None, which conflicts with default values. this fixes that
 2021-12-10 11:33:26 -05:00
mike cullerton
52baf25459 In WorkflowService.do_waiting, if a workflow causes an exception, change its status from waiting to erroring so we don't continue to call it in do_waiting. 2021-12-09 15:33:39 -05:00
Dan Funk
0cfa59bfea
Merge pull request #429 from sartography/chore/clear-form-data-553 
Fixes #553 - Don't load Form data
 2021-12-08 10:37:44 -05:00
Dan
ffafc1674a assure we don't overwrite task data with a previous form submission if that data already exists. 2021-12-07 17:04:20 -05:00
alicia pritchett
7524e97c9a Fixes #553 - Don't load Form data 
adds an extension so that you can opt to clear out form data on a given task
 2021-12-01 16:11:52 -05:00
Dan
ad93b5fae6 We were not correctly handing the possibility of there only being a waiting task (and no ready tasks). 
We also had a problem with the validator throwing a 500 when it was trying tell us it would never finish validation.
 2021-11-30 12:44:35 -05:00
Dan
4a1285b8e0 When validating a workflow, don't run the master workflow multiple times, its a huge waste of time. 
Provide decent data when calling get_study_associate(s) scripts.
 2021-11-22 17:17:19 -05:00
Dan
5bb7dbfb19 Improve the error messages returned from jinja template processing. Try to find the actual line with an error in it. 2021-11-22 14:46:33 -05:00
Dan
4d1f4429ff Fixing a bug in enum_label that was not working when lookup up an select list from a spreadsheet. 
Assure we raise more thoughtful error messages when running getting exceptions in engine tasks.
Field Options should always be available now due to a fix in Spiffworkflow.
 2021-11-22 12:26:30 -05:00
Dan
7b02f46403 During validation, options were not being handled correctly for certain types of lookups. 2021-11-17 13:38:41 -05:00
Dan
f4f3842059 Fixing a stupid mistake. 2021-11-11 11:45:35 -05:00
Dan
197b75c6bf Quickfix - validation was failing if we had a date object in the task data, but this isn't really a problem. We now use the same JSON serializer as flask does, when doing validations, to better verify behavior with the front end. 2021-11-11 11:18:58 -05:00
Dan Funk
037692f42b
Merge pull request #422 from sartography/chore/group-repeating-validation-536 
Fixes #536 - Group + Repeating property validation
 2021-11-10 15:28:04 -05:00
alicia pritchett
accdd281fa Fixes #536 - Group + Repeating property validation 
For now, we should not allow both group and repeat properties on a field together.
 2021-11-09 13:21:44 -05:00
Dan
d1eae3c15a Validation was failing for enum_label() expressions when called within a sub-process. Possible (but unlikely) that this would occur outside validation. 2021-11-09 12:55:06 -05:00
alicia pritchett
1866e6bba9 Fixes validation for #518 
Well really what this does is give every field a default value of None. what that does is allow you to use value expressions even without a given default value. this part in the backend fixes validation.
 2021-11-01 14:35:30 -04:00
Dan
e0d1f63c08 Fix an issue with validation where we didn't properly parse dot notation in fields. 2021-10-26 14:48:06 -04:00
alicia pritchett
7959f8ca3f
Merge pull request #405 from sartography/refactor/enums_as_key_value 
Death to enumerated dictionaries
 2021-10-25 15:17:17 -04:00
mike cullerton
a7fcaac5ef Better messaging for the configurators. 
We were generating 500 errors here
 2021-10-22 12:53:26 -04:00
Dan
5429e7da7d All enumerated lists used in web forms should contain a single value, not a dictionary of value/labels. 
Removing the spreadsheet.value.column and data.value.column so we just have value.column for both.
Improving the __str__ function in the ApiError class, to make debugging a little easier.
Adding a "validate_all" flask command, to help us track down any issues with current workflows in production (use this in concert with sync_with_testing)
Fixed logs of tests.
removed fact_runner.py, a very early and crufty bit of code.
 2021-10-19 10:13:43 -04:00
mike cullerton
da9b902c19 Removed old commented code 2021-10-18 16:10:30 -04:00
mike cullerton
983c4104e1 We run the same basic Jinja code in 4 different contexts. 
Now call the the Jinja service
 2021-10-16 14:20:48 -04:00
Dan
5706fb3ad3 Don't error out here until we decide if we are going to fully refactor emums or leave as is. 2021-10-12 14:32:51 -04:00
Dan
00e0bd5dd2 When dealing with enum default values, assure that we are looking at the '.value' attribute, not at the value itself. 
Minor change to front end as well, please see companion ticket in the sartography_libraries.
 2021-10-12 14:11:00 -04:00
Dan Funk
a39e0ba219
Merge pull request #390 from sartography/varchar-category-id-483 
Varchar category id #483
 2021-10-07 12:23:56 -04:00
Dan
84680ea846 Fixing multiple issues that came out of Study Info, as we debugged issue #474 related to navigating back to a previous task. 
There was a problem with the python script engine as well that wasn't handling the de-serialize properly and didn't correctly pick back up on the script engine, and the renaming of methods in PythonScriptEngine created some conflicts with the way we override functions.
We were not handling ldap looks up efficiently, and this was also breaking in Study Info.

Finally we had a bug in SpiffWorkflow that did not allow us to reset back to the previous task in some cases where nested call activities happen far later in the process and are currently active when the reset is created.
 2021-10-06 12:17:57 -04:00
mike cullerton
572ca1db6b Fixes for backend code after removing name column from workflow_spec and workflow_spec_category tables 2021-10-05 14:17:41 -04:00