df25b83958
Merge pull request #235 from sartography/index-error-for-enums-186
...
Index error for enums 186
2021-02-11 11:21:50 -05:00
10b9c7b892
Merge pull request #234 from sartography/hidden-and-required-fields-185
...
Hidden and required fields 185
2021-02-11 11:20:35 -05:00
f7337f4e54
Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev
2021-02-11 11:17:56 -05:00
2ada9f6f42
Private Ldap settings
2021-02-11 11:17:21 -05:00
39e874504f
We now allow value_expression to evaluate to an empty string ("") so that we *do not* set a default value for enums in some cases.
...
This was causing an error because "" was not an option for the enum.
2021-02-10 14:35:58 -05:00
da0af14724
Changes to enable front-end changes
...
Added a human readable name to created user
added last updated task time and name,
added is_review on the workflow which is triggered by a swimlane with a name present.
Notably - it does NOT update or change any of the performance concerns that we were having with this.
2021-02-10 11:58:19 -05:00
777cfbdecd
We now test whether we have a valid StudyModel when getting a study by study model.
...
We raise an ApiError if the model is None or empty.
2021-02-09 17:37:55 -05:00
3e32cdedc4
New error handler for non Api errors. Ticket 187
2021-02-09 16:35:57 -05:00
11177b4296
Test, workflow, and empty spreadsheet for the new code. The workflow references the spreadsheet, which has no rows.
2021-02-08 15:12:11 -05:00
b42b843f7d
It was possible for an enum field lookup to return an empty list. This meant there were no options for the list.
...
We now test for this and raise an error.
2021-02-08 15:10:53 -05:00
c14a72719c
Merge pull request #233 from sartography/dev
...
Dev to testing
2021-02-08 10:32:07 -05:00
eb504465f6
Test and workflow for new code.
...
We test 2 things.
- If a field can be hidden and required, it must have a default value or value_expression
- If a field is hidden and required, make sure we use the default value
2021-02-08 10:20:05 -05:00
e87e7b5b8b
Form fields that can be hidden and required must now have a default value or value_expression.
...
Also, if a field is hidden but not required, it should not produce a value.
2021-02-08 10:18:41 -05:00
329146237e
Merge pull request #232 from sartography/boolean-default-values-175
...
Boolean default values 175
2021-02-03 16:34:54 -05:00
effd11f947
Merge pull request #231 from sartography/cancellations-137
...
Cancellations 137
2021-02-03 16:31:18 -05:00
2d01b92a50
Merge pull request #230 from sartography/pretty-emails-160
...
Pretty emails 160
2021-02-03 16:20:38 -05:00
1eba20f420
Merge pull request #229 from sartography/workflow-spec-order-74
...
Workflow spec order 74
2021-02-03 16:18:34 -05:00
1247744463
Test and workflow for new code.
2021-02-03 09:50:37 -05:00
b090e31e00
This fixes 2 issues with setting boolean defaults
...
- If the default was False, we failed an early test and returned None. We now only return None if default is None
- We have a better test for deciding if the default value we return should be True or False. We used to return True if the value was the string 'false'.
2021-02-03 09:50:16 -05:00
6f7abc0a97
Added tests to test_workflow_restart to make sure we call cancel_notify events when appropriate.
2021-01-29 14:48:35 -05:00
c5cf3ea7ff
Changed call to WorkflowProcessor.reset to reflect change from class method to instance method.
2021-01-29 14:34:09 -05:00
f9e4b6a972
Test and workflow for the new code. We test the correct cancel notify is called, and only when appropriate.
2021-01-29 14:09:42 -05:00
c026717b4a
Changed the call to WorkflowProcessor.reset to reflect the change from class method to instance method
2021-01-29 14:06:25 -05:00
7e76639cf3
When a study is put on hold, we now reset workflows and call any pending cancel_notify events.
...
In api.study.update_study we test the study status and call the new WorkflowService method process_workflows_for_cancels.
In services.workflow_service we added the new method process_workflows_for_cancels. It loops through workflows for a study, and resets them if they are in progress.
In services.workflow_processor, we changed the reset method to be an instance method so we can call self.cancel_notify.
In tests.test_lookup_service we changed the call to WorkflowProcessor.reset to reflect the change from class method to instance method
2021-01-29 14:05:07 -05:00
83632c64de
added exclusion for email template in sonarcloud properties file.
2021-01-28 10:42:15 -05:00
958d5a6281
Possible solution for W3C issues raised by Sonarcloud
2021-01-28 09:45:53 -05:00
d7a3afe8f4
changed the template to use the responsive html email template at https://github.com/leemunroe/responsive-html-email-template
...
added method get_cr_connect_wrapper to render our new html email template. This takes the email text generated from the task element documentation as the email_body.
2021-01-27 17:12:03 -05:00
328de0e584
Merge pull request #228 from sartography/dev
...
Dev to Test
2021-01-27 11:32:00 -05:00
7b91fb9f61
Modified test to check for display_order within workflow category.
2021-01-27 11:08:28 -05:00
cccb722e07
Merge pull request #226 from sartography/enum_default_value_expression_162
...
Enum default value expression 162
2021-01-27 10:43:46 -05:00
420ef0b2b0
Test and data for cleaning up my smell. We now test explicitly whether a task has both a default_value and value_expression. If so, we raise an error.
2021-01-27 10:22:43 -05:00
81e55b6055
Cleaning up my smell. A task should only have default_value *or* value_expresion, not both.
2021-01-27 10:21:13 -05:00
c99a388405
We now set the display_order automatically. Users can modify order using the arrows.
2021-01-27 09:50:29 -05:00
98f946c119
Merge pull request #227 from sartography/missing_form_key_163
...
Missing form key 163
2021-01-27 09:42:46 -05:00
691b779a0c
Merge pull request #223 from sartography/152-workflow-spec-pull
...
152 workflow spec pull
2021-01-27 09:39:09 -05:00
e72be4a217
Needed to define SERVER_NAME so get_url worked properly. Made the port into a constant in config.default so I can import it into config.testing.
...
Dan, I'm not sure this is the best approach. Let me know if you want something different.
2021-01-26 09:35:35 -05:00
ecc553c4ea
Jinja templates and svg file for pretty emails
2021-01-26 09:20:16 -05:00
909af9b8d6
Change HTML emails so they look like the CR-Connect website. Add logo, color, style, etc.
...
Cleaned up email script a little.
Also, email script no longer uses services.mails. It uses email_service directly now.
2021-01-26 09:19:28 -05:00
d01f8e1018
This workflow had a form with a missing form key, so it's associated test failed after my changes in this ticket. I added a form key to the form. Test now passes.
2021-01-22 12:16:02 -05:00
2438779470
Test and workflow file for missing form key. Ticket 163
2021-01-22 12:14:59 -05:00
b71fd93dd4
We now make sure that forms have a form key. Ticket 163
2021-01-22 12:14:17 -05:00
1ee6a11d46
Test and associated data files for setting enum default values from value_expression. Ticket 162
2021-01-22 10:01:20 -05:00
00d9276483
In spiff_task_to_api_task, when looping through fields, if the field doesn't have a value, we now try to set it with the default value
...
In test_spec, we now check for FIELD_PROP_VALUE_EXPRESSION when setting default values
2021-01-22 10:00:28 -05:00
5921ce9f10
Merge branch 'dev' into 152-workflow-spec-pull
2021-01-21 12:30:43 -05:00
c60754155f
Merge pull request #225 from sartography/dev
...
dev to testing
2021-01-20 17:49:40 -05:00
5b13195182
Merge pull request #224 from sartography/restart-with-no-data-99
...
Restart with no data 99
2021-01-20 17:22:18 -05:00
41dac33039
Removed two tests around soft_reset that are no longer required.
...
Reset should construct the workflow_processor, thus completing the reset process.
Removed the spec argument from init, as it is never used anywhere.
2021-01-20 13:24:53 -05:00
6a7ee09a5d
Updating the readme file.
2021-01-20 11:00:41 -05:00
27a8383898
Not sure about this one. We no longer support the task this test is testing (soft_reset). I commented out that part of the test. We can discuss, if necessary.
2021-01-19 15:44:11 -05:00
61d366c111
Fixed hard_reset test. Now we reset the workflow and run do_engine_steps
2021-01-19 15:39:59 -05:00
Dan Funk
mike cullerton
Kelly McDonald