6694dc6cb3
Merge pull request #510 from sartography/git-error-filenotfound-690
...
Git error filenotfound #690
2022-04-04 16:53:36 -04:00
095105e3e6
Merge pull request #508 from sartography/validation-with-data-store-396
...
Validation with data store #396
2022-04-04 16:51:57 -04:00
e1f9dcded5
Assure we can associate the same person with a workflow under two different roles.
2022-04-04 16:01:48 -04:00
51c6871d06
Update mock data to use new valid review type
2022-03-30 10:30:27 -04:00
70e8f6b35e
Fix typo in test: delete -> remove
2022-03-29 12:34:05 -04:00
689aa54d50
Modified tests to work with the bug fix
2022-03-29 09:49:29 -04:00
9ec1514267
Merge pull request #509 from sartography/chore/zip-file-update-688
...
Chore/zip file update #688
2022-03-29 09:41:32 -04:00
6ff0cdbb9d
Merge pull request #507 from sartography/bug/validating_data_security
...
Bug/validating data security #684
2022-03-29 09:41:02 -04:00
ee3217de62
Test for new feature
2022-03-28 11:59:53 -04:00
6b93d605d4
Test for new validation_data_store.
...
We set 3 `real` data_store values in the DB
The workflow sets 3 validation_data_store values
We assert that the correct values are returned.
We also assert that we get correct default values back if we pass in bad keys
2022-03-25 10:06:03 -04:00
51fa494d03
Assert we evaluate the hidden property correctly during validation.
2022-03-23 16:49:35 -04:00
94abd7eebf
*** WIP ***
...
Add a temporary data store for validation
2022-03-23 15:15:01 -04:00
244fced84d
Merge pull request #506 from sartography/chore/unchecked-checkbox-default-671
...
Unchecked checkbox default #671
2022-03-23 10:59:47 -04:00
1969e0b051
Make sure we don't get null/None back from a boolean checkbox.
...
This is not a comprehensive test, because we can't have an unchecked checkbox in validation.
We really need a frontend test for this.
2022-03-23 09:48:13 -04:00
487a1a3987
Fixes #667- Validate Lane Variables
2022-03-21 12:18:40 -04:00
27c2b95f31
Pass update_status=True in the test when calling the get_study api endpoint
...
This allows master_workflow_results to be set, which allows categories to be processed in StudyService.get_study()
2022-03-18 17:01:36 -04:00
e44ea6e13c
merging in from dev.
2022-03-18 16:22:33 -04:00
81e3da043c
Fix tests
2022-03-18 16:05:16 -04:00
a401c41b23
Setting a minimum date for which to import studies.
...
Merging in code to improve performance of calculating percent complete for a study.
Assureing we have a primary investigator for the front page (another merge)
2022-03-18 15:27:45 -04:00
b7489aea43
merging in PI Name changes from Alicia's #499 PR.
2022-03-18 12:30:20 -04:00
5f802a3e79
oops
2022-03-18 12:09:56 -04:00
b9b8210f8a
rm pi id refs
2022-03-18 12:04:20 -04:00
b6b28ed127
fix tests remove pi id
2022-03-18 11:56:56 -04:00
ef5aca4fe4
ReviewType now comes back with the user studies, so we don't need to make an additional query to get it.
2022-03-18 09:59:10 -04:00
199fe0626a
Assert that if we get `null` for DATELASTMODIFIED, we use the value in DATECREATED
2022-03-17 15:56:44 -04:00
5b7e71d42d
meta field for categories
2022-03-16 12:49:35 -04:00
8ea8993421
Merge pull request #493 from sartography/jinja-included-includes-670
...
Jinja included includes #670
2022-03-14 16:49:56 -04:00
4a626afa7d
Added comment about the test
2022-03-14 14:01:13 -04:00
eb615012af
Cleanup - remove unused import, print statement
2022-03-14 13:56:38 -04:00
238840822d
Included template test from hell
2022-03-14 13:54:46 -04:00
ace988d551
assert we get category and workflow in all the places
2022-03-14 12:02:11 -04:00
dec63839f3
Merge remote-tracking branch 'origin/dev' into chore/log-changes-661
2022-03-12 16:19:23 -05:00
2fc4b44ef3
Create a path to directly download the spreadsheet file (and avoid the weird dance on the front end of making an API call to get file data.)
...
Fixing pagination. Seems the front end uses a page_index that is 0 based, and sqlAlchemy prefers to start at 1.
2022-03-12 16:19:07 -05:00
a536a79e87
Test for downloading logs
2022-03-12 14:29:02 -05:00
4ab314c7b8
Be sure to delete the data store items when you delete a study.
2022-03-12 13:38:09 -05:00
52b5e1d34a
Fixing tests.
2022-03-11 18:02:37 -05:00
356a322e85
Merge branch 'dev' into chore/log-changes-661
2022-03-11 08:50:13 -05:00
2d5517bd15
Merge pull request #487 from sartography/chore/update-get-workflow-status-664
...
Chore/update get workflow status #664
2022-03-10 14:30:32 -05:00
ec9ff4ff8a
*** WIP ***
...
Need to finish writing tests
2022-03-10 12:19:41 -05:00
bb605bb23c
Remove unused imports
...
Cleaned up some extra spaces
2022-03-09 15:03:14 -05:00
203213d700
Fix tests to use new version of workflow
...
Add test with `metrics` as log level
2022-03-09 14:56:45 -05:00
291de1c322
Add UserTask to pass in log data--level, code, and message
2022-03-09 14:55:52 -05:00
e1d1a7613d
Fix test to use workflow_spec_id
2022-03-09 11:15:20 -05:00
1e9c9919c2
hot fix, missed a critical part of the jinja include syntax when identifying included templates
2022-03-09 11:03:42 -05:00
ce57a3753a
fixing some comments and error messages for clarity
2022-03-09 10:28:22 -05:00
41b5106a28
patching up the tests.
...
Looks like we want to use default values, if they are provided, for validation. So good test, and I didn't have to create a new bug. Also added skipping the test about requiring a default for hidden+required fields. Maybe we don't need to after all.
2022-03-08 18:38:05 -05:00
26eeb2912a
Only run the form validation stuff if we have a form.
...
If there is a default value, use it, regardless of whether the form is hidden (this is how the front end works)
(accomplished by moving the hide_epxression check -> continue stuff below the set default_value code)
2022-03-08 18:13:54 -05:00
b03e24bbf4
Properly handle forms where a field is required, based on a later field.
...
Do an aboutface on saying that if a field is required but hidden, it has to have a default value. I'm just commenting this out for now, as it made getting these workflows to validate bloody impossible.
Clean up the replication of code for identifying required fields (as it wasn't consistently applied)
Removing some very broken and apparently unused methods.
2022-03-08 17:36:13 -05:00
0a906a4b3c
Cleaning up Print Statements (it was making it hard to see what was happening)
...
The Jinja2 service was treating all the task data as a possible template, modified it to only include the referenced templates.
(This turned out not to be the problem, but it seems like a good idea to keep it in place)
There is a terrible bug with the wordwrap pipe that will die without any details if you pass it a value of None. We now cature the terrible error, and replace it with a sensible one.
Removed an unused Jinja_extensions file.
2022-03-08 15:46:36 -05:00
3f82cdae48
Merge pull request #485 from sartography/bug/validating-associates-659
...
Bug/validating associates #659
2022-03-07 14:20:20 -05:00
Dan Funk
mike cullerton
Mike Cullerton
alicia pritchett