da9b902c19
Removed old commented code
2021-10-18 16:10:30 -04:00
983c4104e1
We run the same basic Jinja code in 4 different contexts.
...
Now call the the Jinja service
2021-10-16 14:20:48 -04:00
5706fb3ad3
Don't error out here until we decide if we are going to fully refactor emums or leave as is.
2021-10-12 14:32:51 -04:00
00e0bd5dd2
When dealing with enum default values, assure that we are looking at the '.value' attribute, not at the value itself.
...
Minor change to front end as well, please see companion ticket in the sartography_libraries.
2021-10-12 14:11:00 -04:00
a39e0ba219
Merge pull request #390 from sartography/varchar-category-id-483
...
Varchar category id #483
2021-10-07 12:23:56 -04:00
84680ea846
Fixing multiple issues that came out of Study Info, as we debugged issue #474 related to navigating back to a previous task.
...
There was a problem with the python script engine as well that wasn't handling the de-serialize properly and didn't correctly pick back up on the script engine, and the renaming of methods in PythonScriptEngine created some conflicts with the way we override functions.
We were not handling ldap looks up efficiently, and this was also breaking in Study Info.
Finally we had a bug in SpiffWorkflow that did not allow us to reset back to the previous task in some cases where nested call activities happen far later in the process and are currently active when the reset is created.
2021-10-06 12:17:57 -04:00
572ca1db6b
Fixes for backend code after removing `name` column from `workflow_spec` and `workflow_spec_category` tables
2021-10-05 14:17:41 -04:00
b02731df17
Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates)
...
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.
remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
2021-10-04 15:07:47 -04:00
5bf7bf3e2e
Bug fix for adding master workflow to validation
...
We now check that a workflow is in the status dictionary before looking up its status.
2021-09-30 15:48:57 -04:00
f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478
...
Ids approval validation #478
2021-09-30 13:59:26 -04:00
0353161402
Merge branch 'dev' into feature/381_validate_field_types
2021-09-30 13:19:36 -04:00
0202b409e1
My checkbox test was in a bad place. Moved it into each of the 2 blocks.
2021-09-30 12:34:46 -04:00
73cd729cac
Checkbox enums need to return a list.
2021-09-30 11:35:13 -04:00
8e00f16eaa
Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea"
2021-09-29 11:43:08 -04:00
ef5a0a7e45
Check whether a workflow spec is disabled by the master workflow before validating.
...
Return the master workflow message to the user
2021-09-24 11:05:33 -04:00
19104303de
Refactor of the way we store and return details about users - All the details about a user, or individual associated with a study is returned within in an Ldap model. I've removed duplication between these models. This required some cleanup of the tests, and a migration that will drop the user details.
2021-09-22 13:16:25 -04:00
5ddff1d1be
Merge branch 'dev' into add-reorder-api-endpoints-444
2021-09-09 13:10:54 -04:00
b88daef4fa
Added task name to the error message, for configurators
2021-08-31 16:17:52 -04:00
ed57993f8d
Workflow spec cleanup needs a category_id
2021-08-31 12:17:25 -04:00
f6816a2e42
Move display_order cleanup to their own methods
2021-08-31 10:07:38 -04:00
a99818b177
Make sure we don't try to move past the top or bottom of the list.
2021-08-30 11:42:44 -04:00
070a9c9350
Code for reordering Workflow Spec Categories
...
Still need to work on edge cases where you try to move past top or bottom of list
Still need to work on tests
2021-08-30 11:27:07 -04:00
f2201a3cef
Move business logic to WorkflowService
...
Return ordered list of specs
2021-08-30 10:41:08 -04:00
961925e03e
Merge pull request #361 from sartography/430-email-enhancements
...
#430 email enhancements
2021-08-25 15:02:14 -04:00
4b9c5bd3e8
Fixing a stupid mistake.
2021-08-24 12:10:59 -04:00
ef9fd9514d
This caused a key error if we had a repeating field that was unused
2021-08-19 17:32:24 -04:00
afaecfa21c
Catching an error when variables conflict with repeating section variables.
2021-08-18 13:38:34 -04:00
77de2a8f47
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-17 09:47:09 -04:00
0a2597ae36
Just a quick hot fix so that when can still report errors back to the UI even when the task_data can't be serialized, which can happen when functions are defined.
2021-08-17 09:43:08 -04:00
7027392a1b
Merge remote-tracking branch 'origin/bug/missing_pi_name_246' into bug/missing_pi_name_246
...
# Conflicts:
# crc/services/workflow_service.py
# tests/study/test_study_associate_script.py
2021-08-12 13:01:41 -04:00
e32c1db4c8
Merge remote-tracking branch 'origin/dev' into bug/missing_pi_name_246
...
# Conflicts:
# crc/models/study.py
# crc/services/study_service.py
# crc/services/workflow_service.py
# tests/study/test_study_associate_script.py
2021-08-12 12:59:15 -04:00
41e27cb454
Merge remote-tracking branch 'origin/dev' into bug/missing_pi_name_246
...
# Conflicts:
# crc/models/study.py
# crc/services/study_service.py
# crc/services/workflow_service.py
# tests/study/test_study_associate_script.py
2021-08-12 12:39:04 -04:00
2732071585
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-12 12:07:25 -04:00
40727c7ce6
avoid erroring out when unable to calculate a value expression as a part of finding a default value.
2021-08-12 11:35:05 -04:00
adb1b74822
Merge pull request #352 from sartography/post-process-empty-field-408
...
Post process empty field #408
2021-08-12 10:53:26 -04:00
d07bac27ca
Fix for hidden file data field.
...
We were processing a field that didn't have a value.
Ticket 408
2021-08-11 16:43:50 -04:00
318cd34f81
bouncing to fix a bug in SpiffWorkflow that was holding outo outdated data deed within the python_script_engine.
...
This caused validation to fail for valid repeat sections, so including a fix to allow that validation to continue.
2021-08-11 14:21:23 -04:00
848c2e622f
Always use a schema to define what is being returned, it enforces consistency of the API and internally we can depend on well defined objects.
2021-08-10 16:16:08 -04:00
913c12c02d
Merge branch 'dev' into bug/pi_name_missing_246
2021-08-10 15:06:52 -04:00
41ad7935f8
Merge branch 'dev' into 367-Call-Activity
...
# Conflicts:
# Pipfile.lock
2021-07-29 09:28:21 -04:00
4c8a86f9bf
Fixed bug where processing file data only worked for enums.
2021-07-23 11:24:17 -04:00
38b8c7fcdf
Fixed email_cc test
2021-07-22 15:08:28 -04:00
a73d1794eb
Fixed Associate API Endpoint description
2021-07-22 14:09:24 -04:00
2455495457
got library side working - still need to have parent working
2021-07-22 10:20:34 -04:00
354e20c34b
Use the data_store_service to set the data_store, rather than access DB directly.
...
Pass the label explicitly (as the value)
2021-07-15 13:09:40 -04:00
dd67a5e650
Never set the date to datetime.utcnow() on DateTime fields. We want this to fall back on the func.now() method and allow the database to set the time on insert.
2021-07-12 15:58:32 -04:00
1916c4ff54
Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively.
2021-07-12 09:43:12 -04:00
7aa4b0833c
Merge remote-tracking branch 'origin/dev' into feature/documents_xls_refactor
2021-07-06 13:11:08 -04:00
1b1a994360
Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them.
...
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
2021-07-06 13:10:20 -04:00
98d641f54d
Merge branch 'dev' into partial_testing
2021-06-30 16:13:31 -04:00
mike cullerton
Dan
Mike Cullerton
nilez
Kelly McDonald