sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-23 21:28:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,905 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

1905 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan
f982745d32 fixing a failing test, don't assume the study and workflow ids will always be 1. 2021-07-12 10:00:39 -04:00
Dan
1916c4ff54 Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively. 2021-07-12 09:43:12 -04:00
mike cullerton
69974e89fd Added 2 simple tests for filtering by REVIEW_TYPE 2021-07-09 11:39:30 -04:00
mike cullerton
682b010f6f Added mocked study_details with an invalid REVIEW_TYPE 
This is used to test StudyService.get_studies_for_user
StudyService.get_studies_for_user should now filter on REVIEW_TYPE
 2021-07-09 11:38:45 -04:00
mike cullerton
445d3e5f0b Added mocked pb study_details since we now check whether a study has valid REVIEW_TYPEs 2021-07-09 10:41:46 -04:00
mike cullerton
95c710768e Fixed test to reflect adding REVIEW_TYPE to mocked study_details PB data 2021-07-09 10:40:18 -04:00
mike cullerton
841bbe73ef Added REVIEW_TYPE to the mocked PB data 2021-07-09 10:38:41 -04:00
mike cullerton
690c059335 get_studies_for_user is no longer a static method 2021-07-09 10:37:57 -04:00
mike cullerton
dad2de9f0c get_user_studies now checks study_details['REVIEW_TYPE'] before displaying a study. 
This corresponds to REVIEWTYPENAME being `Full Committee`, `Expedited`, `Non-UVA IRB Full Board`, or `Non-UVA IRB Expedited`
 2021-07-09 10:37:25 -04:00
Kelly McDonald
79c69037dd Filter out Library categories from the list returned 2021-07-08 08:57:40 -04:00
mike cullerton
05ba28b67b Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into dev 2021-07-07 14:33:17 -04:00
mike cullerton
1c9db16bff Migration to change filename from irb_documents to documents in the database 2021-07-07 13:27:57 -04:00
mike cullerton
f1a15ef8e9 Fix the test 2021-07-07 12:54:16 -04:00
mike cullerton
d6f9b013f7 Change irb_documents to documents 2021-07-07 12:54:03 -04:00
mike cullerton
23180908c8 Undo change. Wrong branch 2021-07-07 12:43:51 -04:00
mike cullerton
c39e08972d Change irb_documents to documents 2021-07-07 12:42:01 -04:00
Dan Funk
8374ae3fde
Merge pull request #332 from sartography/add-name-error-hint-8 
Add name error hint #8
 2021-07-07 11:35:45 -04:00
Dan Funk
3c52453c26
Merge branch 'dev' into add-name-error-hint-8 2021-07-07 11:35:24 -04:00
Dan
bef35e4bec Upgrading Spiffworkflow, just incorporating some additional tests. 2021-07-07 11:34:33 -04:00
Dan Funk
2ed436327f
Merge pull request #333 from sartography/check-study-script-273 
Check study script #273
 2021-07-07 11:28:32 -04:00
Dan Funk
db9b228735
Merge pull request #334 from sartography/WaitingEventsHotPatch 
Make a change so that anything that has a waiting event is labeled in…
 2021-07-07 11:27:10 -04:00
Dan Funk
8cb7cbc0ad
Merge pull request #337 from sartography/add-by-user-61 
Add by user #61
 2021-07-07 11:25:45 -04:00
Dan
2a45f2fcda Merge branch 'dev' into add-name-error-hint-8 2021-07-07 11:24:00 -04:00
mike cullerton
b0cf74fa3d Merge branch 'dev' into add-by-user-61 
# Conflicts:
#	tests/files/test_files_api.py
 2021-07-07 10:46:50 -04:00
mike cullerton
ac19c3e3c6 Add users first 2021-07-07 10:33:30 -04:00
Dan Funk
5c229477d3
Merge pull request #336 from sartography/feature/better_errors 
Feature/better errors
 2021-07-07 10:30:41 -04:00
mike cullerton
621c11fe24 Add test for user_uid 2021-07-07 09:39:01 -04:00
mike cullerton
c11b5cfb29 Add user_uid to api output 2021-07-07 08:18:02 -04:00
Dan
fb54edac1c Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct. 
Most noteable is the addition of the line on which the error occurs for script tasks.  It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
 2021-07-07 00:53:49 -04:00
mike cullerton
894377a607 Add user_uid to FileDataModel calls 2021-07-06 17:09:00 -04:00
mike cullerton
23be257db0 Add user_uid column to file_data table 2021-07-06 17:07:47 -04:00
Dan
a9805ad40c Adding some documentation for clarity. 2021-07-06 14:40:20 -04:00
Dan
cafdc4d100 Removing an unneeded modification to the database structure for lookup tables. 2021-07-06 14:02:07 -04:00
Dan
04842aa66b Undo change to 1 minute. 2021-07-06 13:13:07 -04:00
Dan
7aa4b0833c Merge remote-tracking branch 'origin/dev' into feature/documents_xls_refactor 2021-07-06 13:11:08 -04:00
Dan
1b1a994360 Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them. 
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
 2021-07-06 13:10:20 -04:00
Kelly McDonald
9803a04d6d Make a change so that anything that has a waiting event is labeled in the database as waiting, even if it is sitting around waiting on a user input task that is ready 2021-07-06 11:46:47 -04:00
Kelly McDonald
dce1d86e93 commit changes before looking at something else 2021-07-06 10:34:57 -04:00
mike cullerton
8145ff9025 Tests for calling the script 2021-07-02 16:14:19 -04:00
mike cullerton
f647390e1c Added description and validate_only 2021-07-02 15:51:24 -04:00
mike cullerton
2cb2874a49 Added test and json data for new check_study pb mock api endpoint 2021-07-02 15:26:39 -04:00
mike cullerton
9690c69b6c added check_study method to protocol_builder service for new endpoint 2021-07-02 15:25:33 -04:00
mike cullerton
cd26654b3a Script to call new pb mock api endpoint check_study 2021-07-02 15:21:35 -04:00
Mike Cullerton
7406bf7da1
Merge pull request #330 from sartography/partial_testing 
Partial testing
 2021-07-02 10:27:41 -04:00
Nile Walker
a27073fd7e
Delete settings.json 2021-07-02 09:53:53 -04:00
Nile Walker
6e07d9d1cb
Delete launch.json 2021-07-02 09:53:46 -04:00
mike cullerton
2a43230121 Test and workflow for the new name error hint code 2021-07-01 15:39:25 -04:00
mike cullerton
db44882733 When we encounter a name error running a script, look in the task data and see if there is a variable with a similar name. 
If a variable with a similar name exists, add it to the ApiError as a hint
 2021-07-01 15:38:45 -04:00
Mike Cullerton
98d641f54d
Merge branch 'dev' into partial_testing 2021-06-30 16:13:31 -04:00
Mike Cullerton
fafa79a07d
Merge pull request #326 from sartography/346-waiting-task-schedule 
346 waiting task schedule
 2021-06-30 11:41:34 -04:00