sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-23 13:18:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,572 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

551 Commits

Author SHA1 Message Date
Kelly McDonald
116bf5e7aa Merge branch 'dev' into 263-optimize-dashboard 
# Conflicts:
#	crc/services/study_service.py
 2021-03-31 10:20:33 -04:00
Kelly McDonald
60f5be1aef Check in - pending change from @cullerton 2021-03-30 12:10:49 -04:00
Dan Funk
b5d4df595f
Merge pull request #271 from sartography/master-workflow-status-messages-222 
Master workflow status messages 222
 2021-03-26 20:52:24 -04:00
Dan Funk
123ec50912
Merge pull request #272 from sartography/infinite-validations-262 
Infinite validations 262
 2021-03-26 19:49:42 -04:00
Dan
ac4877fecf Merge remote-tracking branch 'origin/dev' into master-workflow-status-messages-222 2021-03-26 17:47:57 -04:00
mike cullerton
3ee8109535 Tests for the changes to master workflow status dictionary 
Test for each valid WorkflowState
Test for all three failure states; not in status, not a dictionary, not a valid state.
 2021-03-22 17:52:14 -04:00
mike cullerton
47ff29e3ab Added a test for dictionary output from a decision table. 
Will need dictionary output for master workflow status messages.
 2021-03-18 12:25:27 -04:00
mike cullerton
c4b52f85af Test and workflow for testing infinite loop code. 2021-03-17 14:52:50 -04:00
mike cullerton
70efdb4788 The do_task_validate_only method in the get_study_associates script now returns a mocked list of associates. 
It used to return `True`, and this caused shield validation to fail when looping over the results of `get_study_associates`.
(You can't loop over a boolean)

Added a for loop in `study_sponsors_associate.bpmn` to test for this.
Moved `BaseTest` import to the top of `test_study_associate_script` because debug was failing.
 2021-03-16 08:57:30 -04:00
Dan Funk
14386b8ba9
Merge pull request #264 from sartography/bug/243_complete_all 
Bug/243 complete all
 2021-03-14 12:34:55 -04:00
Dan
6f80d816cd My privous efforts didn't take into account the fact that we use dot notation in field names. 
I've re-worked the workflow form endpoint, so that it only accepts the data that should be in the form, and ignores any other values that come back from the front end.  It seems Formly has some bugs that were introducing confusing information, and I want everything to behave consistently.
I had to re-work some of the tests, which were relying on an ability to set data through a form post without having a corresponding form to do so.
 2021-03-14 12:20:39 -04:00
Dan
15c64c862e Adding an argument to update task that will allow it to complete all remaining tasks through an "update_all" flag, 
this will allow us to remove some fairly complex logic from the front end that isn't behaving properly.
 2021-03-12 20:41:07 -05:00
Mike Cullerton
e7c78c8d0e
Merge branch 'dev' into study-associated-email-207-223 2021-03-11 12:38:47 -05:00
mike cullerton
b403a3015e Modified existing tests to work with changes to the email script. 
Added test for associated emails.
Added test for cc argument.
 2021-03-11 11:40:46 -05:00
mike cullerton
8bda9889b1 Added a test for the send_email endpoint. 2021-03-11 11:38:34 -05:00
mike cullerton
fa028dd517 Modified the email_script workflow to accommodate the changes to the email script. 
Workflow now uses keyword arguments; subject, recipients, and cc.
If cc is not passed in, we set it to None.
 2021-03-11 11:37:54 -05:00
mike cullerton
78ae719b97 Moved this test to the test_email_script test file. 2021-03-11 11:35:08 -05:00
mike cullerton
fa4707811e Removed the test and templates from the unused mails service. 
Mails was removed in previous commit.
 2021-03-11 11:34:24 -05:00
Mike Cullerton
eaf52a21ca
Merge pull request #260 from sartography/bug/delete_study 
Allows us to delete a study even if there are emails, and associated …
 2021-03-09 13:51:25 -05:00
Dan
80ff8a6212 Allows us to delete a study even if there are emails, and associated study users connected to that study. 2021-03-09 13:31:26 -05:00
Dan
576aebab19 Sometimes a workflow can be completely broken and unloadable. For instance, it starts off with a engine step / script task that will not execute. So the failure happens the second it is processed. When calling reset on a workflow, we should catch the failure, and reset the workflow, so we aren't trapped in an unrecoverable state. 
To do so, I changed the WorkflowProcessor's reset method to be static, it will try to instantiate the current workflow and execute a cancel_notify event, but if that fails, it will continue and always return a new workflow processor using the latest spec.
 2021-03-09 11:52:55 -05:00
mike cullerton
7749f3aeaf Fixed existing workflows to work with keyword arguments 2021-03-09 06:50:58 -05:00
mike cullerton
8c75217042 Test and workflow for associated user emails 2021-03-09 06:50:20 -05:00
Dan
36dcc58705 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-03-08 14:00:14 -05:00
Dan
291216e081 Fixing a bug that prevented proper evaluation of a enum field where the default value was null or empty. 2021-03-08 14:00:03 -05:00
mike cullerton
f883eb2bbe We now include field.id in the ApiError message for hidden and default validation. (The field must have a default value or value expression) 
While working on this ticket I found a logic error in the test. I expected both default_value and value_expression. It turns out the default_value is always there, it's just null if we don't set it.

Modified the existing test for hidden and required, and added tests to make sure my passing logic is now correct.
 2021-03-04 10:42:13 -05:00
Dan
9e758c57d3 Merge branch 'dev' into bug/225_enum_lookup_same_field_name 2021-03-02 14:15:58 -05:00
Dan
ecfc2ee761 a slightly better test. 2021-03-02 14:15:29 -05:00
Dan Funk
572eb3457a
Merge pull request #252 from sartography/customer-error-messages-192 
Customer error messages 192
 2021-03-02 13:45:38 -05:00
Kelly McDonald
06dedd8a32 Add short_title to study, change update_study task to use kw arguments and add the short_title to the update_study script 2021-03-02 10:03:53 -05:00
mike cullerton
9a2ffb98ad Customer Error is in a place that we can try it out on testing. 
So far, there are two known errors.
 - Missing condition type (Ticket 178)
 - Invalid property value in extensions tab for display_name (No ticket for this error)

We now have the option of using regular expressions to pull task_id, etc. from an error to pass back to the user in the hint.
 2021-03-01 16:41:55 -05:00
Dan
aac3d5c16e Bug #255, this requires the front end to pass in the name of the task, when doing a lookup. This will prevent a bug where we have multiple user tasks, with enum fields that set the same variable, but use different lookup tables to populate the dropbown or search feature. 2021-03-01 14:54:04 -05:00
mike cullerton
9d804c36d5 Merge branch 'dev' into customer-error-messages-192. 
Needed some sql changes from dev
 2021-03-01 10:29:10 -05:00
Kelly McDonald
0b08a95e25 Add test and make sure that the API endpoint does the right thing when we switch users - checks both associated with access and associated with no access 2021-02-25 12:20:43 -05:00
Kelly McDonald
1504779bba Make sure we have all test files 2021-02-25 11:40:45 -05:00
Kelly McDonald
a1814a7727 Add some additional comments - just to be clear 2021-02-25 11:40:08 -05:00
Kelly McDonald
55f8825b3c Make sure we are testing both versions of the setting functions as well as the getting functions 2021-02-25 09:14:24 -05:00
Kelly McDonald
f592a8a0b0 Added a few more tests - I think I need to test one more script endpoint 2021-02-25 09:07:46 -05:00
Kelly McDonald
9bd3aa8dcb service and scripts with working test - still needs a few more tests to try out, but should work to get Mike going 2021-02-24 12:55:23 -05:00
mike cullerton
f937ac3ce9 Getting some thoughts down for the extension property error. This might force us to use regexes for the error service. 
Committing so I can work on another branch.
 2021-02-24 10:56:25 -05:00
Dan Funk
53fa49e668
Merge pull request #243 from sartography/183-remove-study-approval-code 
Remove Approvals per ticket 183
 2021-02-22 18:12:02 -05:00
mike cullerton
e0de1d0b3b Fixed 3 tests to reflect a change in crc.api.workflow.validate_workflow_specification. 
Added a '\n' to the error message between the actual error and our preamble.
 2021-02-19 15:55:40 -05:00
Kelly McDonald
003bf2f9b9 Remove Approvals per ticket 183 2021-02-16 09:05:29 -05:00
mike cullerton
c40af1d7df Modified workflow to add form field with period in the id. 2021-02-15 16:36:36 -05:00
mike cullerton
446bff9c8c Modified test for missing default value on hidden and required fields to check for task_id and task_name 2021-02-15 16:28:51 -05:00
mike cullerton
34700568ee Added a test for allowing periods in field ids 2021-02-15 16:28:21 -05:00
mike cullerton
39eb5c5c21 This is a decent beginning framework for customer error messages. 
It is not complete, but is in a state where we can start to interact with the front end.
Two tests are failing.
Committing so I can work on an error for Alex.
 2021-02-12 14:18:42 -05:00
Dan Funk
35773ebc29
Merge pull request #240 from sartography/weird-email-error 
The email script was failing validation because of missing parameters…
 2021-02-12 09:31:52 -05:00
mike cullerton
d8bd203139 The email script was failing validation because of missing parameters in scripts.email.do_task_validate_only. 
I added a test in tests.test_email_script to make sure we get the default email_address.
I also found and fixed a bug in workflow_service.populate_form_with_random_data where we would overwrite default_values with random text because of a missing continue.
(We don't want to continue if we have repeating fields though.)
 2021-02-11 15:36:12 -05:00
Dan Funk
fe4e737596
Merge pull request #238 from sartography/value-expression-failing-shield-test-194 
We now allow value_expression to evaluate to an empty string ("") so …
 2021-02-11 11:25:09 -05:00