Commit Graph

907 Commits

Author SHA1 Message Date
mike cullerton 0122029e30 *** WIP ***
Migrating the complete_template script stuff to JinjaService.
Having trouble with the tools stuff.
Pulled back to spot where test pass using CompleteTemplate
2021-10-18 16:56:03 -04:00
mike cullerton dc7b39b5c8 Tests and workflows for the cases where attachments is None or '' 2021-10-18 11:21:24 -04:00
mike cullerton 6b1e0ebbfe First couple tests, and a workflow for testing email 2021-10-16 14:23:12 -04:00
mike cullerton fc3e7f8183 Simple test for get_localtime script 2021-10-14 11:02:51 -04:00
mike cullerton 1ef063de37 Merge branch 'email-cleanup-498' into convert-timestamp-499 2021-10-13 15:50:01 -04:00
mike cullerton 8015d35424 Script to get localtime from a UTC datetime 2021-10-13 15:36:37 -04:00
mike cullerton 2f3fe59a0f Test for Exception when email service fails 2021-10-13 13:40:14 -04:00
mike cullerton b3d515bf68 Test for condition where email_service.add_email raises an exception. 2021-10-13 13:23:18 -04:00
mike cullerton bd6a2f3005 Check the model we get back from the email script
Make sure timestamp is UTC
2021-10-13 11:48:27 -04:00
mike cullerton a1a06f06ca We now get an email model back 2021-10-13 11:47:40 -04:00
Dan Funk c5d8e20e74
Merge pull request #399 from sartography/chore/resource-files-461
Chore/resource files 461
2021-10-12 15:56:56 -04:00
Dan Funk 6428e4ab0a
Merge pull request #397 from sartography/email-data-script-487
Email data script #487
2021-10-12 15:55:48 -04:00
Dan Funk dc07d42a9c
Merge pull request #395 from sartography/email-format-489
Email format #489
2021-10-12 15:51:57 -04:00
alicia pritchett 40b5bf3afa Adds a POST for reference file. and a cool test 2021-10-12 14:29:15 -04:00
mike cullerton 3366142cf3 Remove unused import 2021-10-12 13:56:43 -04:00
mike cullerton f41406a6d9 Fixes from changing workflow_id to workflow_spec_id 2021-10-12 13:46:05 -04:00
mike cullerton 1fb298f796 Test for the new formatting 2021-10-08 11:26:54 -04:00
Dan Funk b0a6af8d5e
Merge pull request #392 from sartography/email-data-script-487
Email data script #487
2021-10-07 14:52:31 -04:00
Dan fdce91507c Improve the warning messages that come back when running the master workflow spec. 2021-10-07 14:43:38 -04:00
mike cullerton 24932072dc Merge branch 'dev' into email-data-script-487 2021-10-07 12:30:13 -04:00
Dan Funk a39e0ba219
Merge pull request #390 from sartography/varchar-category-id-483
Varchar category id #483
2021-10-07 12:23:56 -04:00
mike cullerton 7f11d5bd58 Tests for get_email_data script. 2021-10-07 12:11:22 -04:00
Dan 548c35a4a3 Merge branch 'dev' into varchar-category-id-483 2021-10-07 11:35:10 -04:00
Dan Funk 208ca92fb2
Merge pull request #388 from sartography/bug/472_date_time
fixes 472 - a bug with the datetime validation
2021-10-07 11:13:53 -04:00
mike cullerton ea083e3a52 Changes to tests, and new test for the get_file_data script 2021-10-07 09:25:07 -04:00
alicia pritchett ea4e382f06 Fixing some tests 2021-10-06 15:24:58 -04:00
mike cullerton da894219c5 Changes to tests after removing `name` column from `workflow_spec` and `workflow_spec_category` tables. 2021-10-05 14:20:03 -04:00
mike cullerton fb660182aa Testing setup changes 2021-10-05 13:36:53 -04:00
Dan b02731df17 Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates)
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.

remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
2021-10-04 15:07:47 -04:00
mike cullerton 7357fe7507 test for new From field 2021-10-01 14:02:56 -04:00
mike cullerton 64e3cd044f Merge branch 'dev' into file-cleanup-466 2021-09-30 14:11:59 -04:00
Dan Funk f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478
Ids approval validation #478
2021-09-30 13:59:26 -04:00
Dan Funk 6b5a55df4c
Merge pull request #383 from sartography/feature/476_file_url
URL for files
2021-09-30 13:47:37 -04:00
Dan Funk fbfb241c0b
Merge pull request #382 from sartography/feature/381_validate_field_types
fixes #381 Assure that the field type provided is supported.  Catches errors suc…
2021-09-30 13:46:40 -04:00
Dan Funk 615d0e7f89
Merge pull request #384 from sartography/chore/admin-cat-456
Admin flag on category + migration + updated test
2021-09-30 13:37:09 -04:00
Dan Funk 0353161402
Merge branch 'dev' into feature/381_validate_field_types 2021-09-30 13:19:36 -04:00
mike cullerton 2067c7226a Better test. Actually grab data explicitly from the list in Element Documentation 2021-09-30 12:54:03 -04:00
mike cullerton 7676e230e5 Test and bpmn for enum checkbox 2021-09-30 12:10:47 -04:00
alicia pritchett d5d4496cd0 Admin flag on category + migration + updated test 2021-09-29 16:53:59 -04:00
Dan 8a4a53f028 Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 14:05:45 -04:00
Dan 8e00f16eaa Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 11:43:08 -04:00
mike cullerton cc0b7853e3 reordered the setup and tests 2021-09-28 13:12:16 -04:00
mike cullerton 89b8be0755 Take saved files into account during assertion 2021-09-28 10:25:13 -04:00
mike cullerton 767a90faba Removed debug print statement 2021-09-28 10:20:45 -04:00
mike cullerton 0ee377dda3 Test for file data cleanup 2021-09-27 17:16:21 -04:00
mike cullerton fb9c3e96ac Test and mocked status data for adding master workflow into validation.
Make sure we see ApiError for disabled workflow spec
2021-09-24 11:08:54 -04:00
Dan Funk e4add14193
Merge pull request #378 from sartography/bug/246_user_ldap_refactor
Bug/246 user ldap refactor
2021-09-22 15:31:34 -04:00
Dan Funk 48d979dd5a
Merge pull request #377 from sartography/study-info-mislabeled-464
Study info mislabeled #464
2021-09-22 15:31:23 -04:00
Dan Funk deff293fff
Merge pull request #376 from sartography/bug/468_missing_file_date
fixes #448 - Missing  file date
2021-09-22 15:29:32 -04:00
Dan Funk e672d46dd0
Merge pull request #375 from sartography/study-info-adds-463
Study info adds #463
2021-09-22 15:28:40 -04:00
Dan 19104303de Refactor of the way we store and return details about users - All the details about a user, or individual associated with a study is returned within in an Ldap model. I've removed duplication between these models. This required some cleanup of the tests, and a migration that will drop the user details. 2021-09-22 13:16:25 -04:00
mike cullerton 181e885563 Added the new `handle` attribute to the test 2021-09-22 12:12:54 -04:00
Dan 4b591a076f Adding importlib-resournces as a dependency, which is suddenly failing on Travis, likely due to different versions of Python as I try to upgrade to 3.9 2021-09-21 14:36:57 -04:00
mike cullerton 1e48cbea1a Added test and workflow for updating `short_name` and `proposal_name` 2021-09-17 12:05:29 -04:00
mike cullerton deb3d7bf67 Updated for `short_name` and `proposal_name`
Also cleaned up some for readability
2021-09-17 11:59:02 -04:00
mike cullerton 7956c71fcc Changed test to use a workflow, so we have the correct type of task 2021-09-16 13:45:51 -04:00
Mike Cullerton 66bfbf0a49
Merge pull request #371 from sartography/zip-documents-379
Zip documents #379
2021-09-14 17:42:13 -04:00
Mike Cullerton 787614ee91
Merge pull request #369 from sartography/dmn-from-spreadsheet-395
Dmn from spreadsheet #395
2021-09-14 17:41:01 -04:00
mike cullerton 02de382b8b Test for new script 2021-09-14 10:41:01 -04:00
mike cullerton 444e3fa76d Merge branch 'dev' into zip-documents-379 2021-09-14 09:39:19 -04:00
mike cullerton 9aadaac0df Test to make sure we do not set a category_id for library workflow specs 2021-09-13 16:16:05 -04:00
mike cullerton 5ddff1d1be Merge branch 'dev' into add-reorder-api-endpoints-444 2021-09-09 13:10:54 -04:00
mike cullerton cc403f1fac Merge branch 'dev' into dmn-from-spreadsheet-395 2021-09-09 13:09:35 -04:00
mike cullerton a35d122a03 Tests for case where we have bad display_order numbers.
I.e., 0, 1, 1, 1
2021-09-08 11:18:06 -04:00
mike cullerton 7211a1de46 Removed unused test files 2021-09-07 15:22:02 -04:00
mike cullerton 96d38e6e65 Removed double-quotes 2021-09-07 15:18:05 -04:00
mike cullerton ee68d818e6 Test for new endpoint 2021-09-07 15:15:38 -04:00
Dan Funk 86c017a6a6
Merge pull request #367 from sartography/value-error-expression-428
Value error expression #428
2021-09-03 14:32:46 -04:00
mike cullerton 26a625c5db Test for new service 2021-09-02 09:57:01 -04:00
mike cullerton d9fa94b64f Added spreadsheet for testing 2021-09-02 09:56:40 -04:00
mike cullerton f2741921cb Added task to select a spreadsheet 2021-09-02 09:56:22 -04:00
mike cullerton f49128adf4 Rename test file 2021-09-01 10:44:53 -04:00
mike cullerton 3020c76d5c Rename test BPMN file 2021-09-01 10:41:21 -04:00
mike cullerton 0c31b091ee Merge branch 'dev' into dmn-from-spreadsheet-395 2021-09-01 09:38:03 -04:00
mike cullerton e6a2b9d642 New test and BPMN for changes 2021-08-31 16:18:29 -04:00
mike cullerton 86583aa2d6 Be explicit about loading sample data
Add category_id when checking order
2021-08-31 12:19:45 -04:00
Dan 1140b21414 Adding a test that assures we pick up libraries on the remote system when syncing. 2021-08-31 12:07:41 -04:00
Dan d17a2c39ed A little cleanup to assure that when we sync we correctly pick up and associate librarires with a workflow when we sync. 2021-08-30 15:46:16 -04:00
mike cullerton cfd8f3fe74 Test for reordering remaining spec categories after delete 2021-08-30 15:21:42 -04:00
mike cullerton e317b59bfe Test for reordering workflow specs upon deletion 2021-08-30 14:57:16 -04:00
mike cullerton c99080845b renamed a test 2021-08-30 13:56:27 -04:00
mike cullerton dfe967d578 Tests for reordering categories 2021-08-30 13:56:13 -04:00
mike cullerton d43eb4d6f8 Tests for workflow spec reordering 2021-08-30 12:35:57 -04:00
mike cullerton 543fc1fb4a Start of tests for new reorder API endpoint
Modified example_data to include a display_order for example spec
2021-08-27 13:04:11 -04:00
Dan 083abd1b58 Just being consistent in the names as we named it delete_task_data in the class, but not elsewhere, and since I'm here, using the name I prefer. 2021-08-26 14:22:12 -04:00
mike cullerton cd3d17862a Add task_spec_name to a bunch of tests 2021-08-26 10:43:28 -04:00
mike cullerton 5f0db3f2fb Test and BPMN file for new script 2021-08-26 10:42:30 -04:00
mike cullerton 35285a0b60 Fixed tests that broke from the new irb_documents spreadsheet 2021-08-26 08:51:52 -04:00
mike cullerton 54cb74e0a4 Test for the new script 2021-08-26 08:44:22 -04:00
Mike Cullerton 961925e03e
Merge pull request #361 from sartography/430-email-enhancements
#430 email enhancements
2021-08-25 15:02:14 -04:00
mike cullerton e8f8ba67cf Added test for email attachments
Moved cc test to the main test_email_script test, and added bcc and reply_to
Added load_example_data to test_email_script_multiple.
2021-08-19 17:40:37 -04:00
mike cullerton a9452d6533 Modified the test workflow form to add the new bcc, reply_to, and attachments arguments 2021-08-19 17:37:10 -04:00
Mike Cullerton 5692f7d377
Merge pull request #359 from sartography/413-LibraryCleanup
413 library cleanup
2021-08-18 13:39:37 -04:00
Kelly McDonald f3f42eea2b Fixes #413
Add test for cleanup
2021-08-18 08:33:44 -04:00
Dan 7a8eeab820 Merge branch 'dev' into bug/missing_pi_name_246 2021-08-17 11:16:03 -04:00
Dan 4e0e162fd6 Removing the execution flag Nile keeps adding to files. 2021-08-17 09:50:57 -04:00
mike cullerton 2a2fd710c4 Merge branch 'dev' into dmn-from-spreadsheet-395 2021-08-16 14:22:02 -04:00
mike cullerton ab8714c93e Remove HSRNUMBER from mock data 2021-08-16 13:01:51 -04:00
mike cullerton 3f44c202ca Merge branch '417-hsr-open-to-enrollment-bug' into 426-remove-hsr-number 2021-08-16 12:55:24 -04:00
nilez 0a232dace6 assertEquals -> assertEqual 2021-08-16 10:25:41 -04:00
nilez b9d4f6c436 assertEquals -> assertEqual 2021-08-16 10:18:29 -04:00
nilez f8dd4c3eb9 Check Study Associates Endpoint 2021-08-16 09:32:02 -04:00
mike cullerton febcb1ac5b Clarified my comments 2021-08-13 12:36:43 -04:00
mike cullerton 58119c8969 Modified `test_get_all_studies` so they don't fail looking for studies that are open for enrollment
We will soon have a new way to automatically set study status to `Open for Enrollment`, so I left the failing tests there and commented them out for now.
2021-08-13 12:32:11 -04:00
nilez e32c1db4c8 Merge remote-tracking branch 'origin/dev' into bug/missing_pi_name_246
# Conflicts:
#	crc/models/study.py
#	crc/services/study_service.py
#	crc/services/workflow_service.py
#	tests/study/test_study_associate_script.py
2021-08-12 12:59:15 -04:00
nilez d20b68e483 Fixed Deprecation Warnings in Test Files 2021-08-12 12:33:27 -04:00
nilez 2732071585 Merge branch 'dev' into bug/missing_pi_name_246 2021-08-12 12:07:25 -04:00
Dan Funk adb1b74822
Merge pull request #352 from sartography/post-process-empty-field-408
Post process empty field #408
2021-08-12 10:53:26 -04:00
mike cullerton e0096ebc8e Test and BPMN to make sure we don't process when field is hidden, but do process when field is not hidden 2021-08-11 16:44:45 -04:00
Dan 848c2e622f Always use a schema to define what is being returned, it enforces consistency of the API and internally we can depend on well defined objects. 2021-08-10 16:16:08 -04:00
mike cullerton dce95189cb Merge branch 'dev' into dmn-from-spreadsheet-395 2021-08-10 09:39:42 -04:00
Kelly McDonald 960d302c03 Finish #367 - Make sure that we only use a primary_id if it is in the workflow that we are currently working on - otherwise it is a library and might have its own primary id. 2021-08-10 09:15:38 -04:00
mike cullerton abe258cdf1 Added example data so we can grab a workflow spec 2021-08-03 11:56:53 -04:00
Kelly McDonald 6e1fedb704 Add tests for libraries, remove an API endpoint that didn't make sense after recent changes and remove some commented out sections that were not needed after some decisions about the api endpoints were made 2021-08-03 10:02:22 -04:00
mike cullerton e8ea9776a5 Test for creating dmn from spreadsheet 2021-08-02 10:04:47 -04:00
Kelly McDonald 25319a0e6a Make changes to alembic process - fix test for new API 2021-08-02 08:59:24 -04:00
mike cullerton 097dd9f9a3 Included the failing test, with self.assertRaises
Reworded some of the comments
2021-07-28 11:22:45 -04:00
Kelly McDonald 217e61eed3 next_task returns the next available task, except when the task is completed when it returns the EndEvent -
The problem was that it was returning the first EndEvent it found, not the last one. This caused a problem when we had a CallActivity which has its own EndEvent.

Fixes #399
2021-07-27 09:19:08 -04:00
mike cullerton 2c892560ad Failing test for Call Activity End Events - Ticket 399 2021-07-26 12:12:01 -04:00
Dan Funk 25e00823a7
Merge pull request #342 from sartography/enum-file-data-375
Enum file data #375
2021-07-23 13:47:57 -04:00
mike cullerton 612ce6dc35 Better test to make sure file data works with all standard field types.
(Except maybe custom types)
2021-07-23 11:25:36 -04:00
NWalker4483 a73d1794eb Fixed Associate API Endpoint description 2021-07-22 14:09:24 -04:00
mike cullerton 6b51fc7c06 Added a test with uppercase UID
Modified the script test to expect an empty dictionary now, instead of raising an error
2021-07-22 10:47:25 -04:00
mike cullerton fa19b36279 Removed temporary print statement 2021-07-15 13:16:06 -04:00
mike cullerton 9023be66f4 added a comment to the test 2021-07-15 13:14:40 -04:00
mike cullerton 82bf25cbc6 Test that we set file data_store values correctly when using the file_data property 2021-07-15 13:10:51 -04:00
Mike Cullerton 522ca9d164
Merge pull request #340 from sartography/bug/better_errors_on_scheduled_tasks
Assure we log reasonably clear errors when executing scheduled tasks …
2021-07-12 10:13:02 -04:00
Mike Cullerton d1bf370a39
Merge pull request #339 from sartography/restrict-loaded-studies-374
Restrict loaded studies #374
2021-07-12 10:11:34 -04:00
Mike Cullerton 7070761089
Merge pull request #338 from sartography/document-spreadsheet-name-380
Document spreadsheet name #380
2021-07-12 10:11:16 -04:00
Dan f982745d32 fixing a failing test, don't assume the study and workflow ids will always be 1. 2021-07-12 10:00:39 -04:00
Dan 1916c4ff54 Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively. 2021-07-12 09:43:12 -04:00
mike cullerton 69974e89fd Added 2 simple tests for filtering by REVIEW_TYPE 2021-07-09 11:39:30 -04:00
mike cullerton 682b010f6f Added mocked study_details with an invalid REVIEW_TYPE
This is used to test StudyService.get_studies_for_user
StudyService.get_studies_for_user should now filter on REVIEW_TYPE
2021-07-09 11:38:45 -04:00
mike cullerton 445d3e5f0b Added mocked pb study_details since we now check whether a study has valid REVIEW_TYPEs 2021-07-09 10:41:46 -04:00
mike cullerton 95c710768e Fixed test to reflect adding REVIEW_TYPE to mocked study_details PB data 2021-07-09 10:40:18 -04:00
mike cullerton 841bbe73ef Added REVIEW_TYPE to the mocked PB data 2021-07-09 10:38:41 -04:00
mike cullerton f1a15ef8e9 Fix the test 2021-07-07 12:54:16 -04:00
Dan Funk 3c52453c26
Merge branch 'dev' into add-name-error-hint-8 2021-07-07 11:35:24 -04:00
Dan Funk 2ed436327f
Merge pull request #333 from sartography/check-study-script-273
Check study script #273
2021-07-07 11:28:32 -04:00
Dan 2a45f2fcda Merge branch 'dev' into add-name-error-hint-8 2021-07-07 11:24:00 -04:00
mike cullerton b0cf74fa3d Merge branch 'dev' into add-by-user-61
# Conflicts:
#	tests/files/test_files_api.py
2021-07-07 10:46:50 -04:00
mike cullerton ac19c3e3c6 Add users first 2021-07-07 10:33:30 -04:00
mike cullerton 621c11fe24 Add test for user_uid 2021-07-07 09:39:01 -04:00
Dan fb54edac1c Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
Most noteable is the addition of the line on which the error occurs for script tasks.  It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
Dan 1b1a994360 Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them.
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
2021-07-06 13:10:20 -04:00
mike cullerton 8145ff9025 Tests for calling the script 2021-07-02 16:14:19 -04:00
mike cullerton 2cb2874a49 Added test and json data for new check_study pb mock api endpoint 2021-07-02 15:26:39 -04:00
mike cullerton 2a43230121 Test and workflow for the new name error hint code 2021-07-01 15:39:25 -04:00
Dan 9a32fadc2f Merge branch 'dev' into 346-waiting-task-schedule
# Conflicts:
#	Pipfile.lock
#	crc/services/workflow_service.py
2021-06-30 10:14:37 -04:00
Dan Funk 48bf721b23
Merge pull request #331 from sartography/bug/356_duplicate_workflow
Bug/356 duplicate workflow
2021-06-22 17:42:24 -04:00