mike cullerton
070a9c9350
Code for reordering Workflow Spec Categories
...
Still need to work on edge cases where you try to move past top or bottom of list
Still need to work on tests
2021-08-30 11:27:07 -04:00
mike cullerton
f2201a3cef
Move business logic to WorkflowService
...
Return ordered list of specs
2021-08-30 10:41:08 -04:00
mike cullerton
41414e39c8
First pass at reorder spec code.
...
Still need to return list of specs
Still need to work on spec categories
2021-08-27 13:02:49 -04:00
mike cullerton
f639e101b7
Commit the skeleton API endpoints, so we can use them while developing the BPMN side of things.
2021-08-27 11:40:38 -04:00
Mike Cullerton
5692f7d377
Merge pull request #359 from sartography/413-LibraryCleanup
...
413 library cleanup
2021-08-18 13:39:37 -04:00
Mike Cullerton
feb72af32e
Update workflow.py
...
Just completing a comment so I understood
2021-08-18 13:27:28 -04:00
Kelly McDonald
b4ecb0f97a
Add backref cascade and make changes to the spot where we delete so it loads objects into memory and then uses the SQLAlchemy plumbing to make sure that the db object gets cleaned up.
2021-08-18 08:25:17 -04:00
Dan
7a8eeab820
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-17 11:16:03 -04:00
Dan
6ce560cc2d
Made a stupid mistake in a hot fix, causing the builds to fail.
2021-08-17 10:14:49 -04:00
Dan
4e0e162fd6
Removing the execution flag Nile keeps adding to files.
2021-08-17 09:50:57 -04:00
Dan
77de2a8f47
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-17 09:47:09 -04:00
Dan
0a2597ae36
Just a quick hot fix so that when can still report errors back to the UI even when the task_data can't be serialized, which can happen when functions are defined.
2021-08-17 09:43:08 -04:00
nilez
07ffcd7c76
Dependencies In Testing are behind this avoids that issue. https://sonarcloud.io/project/issues?id=sartography_cr-connect-workflow&pullRequest=356&resolved=false&types=BUG
2021-08-16 23:46:39 -04:00
nilez
0a232dace6
assertEquals -> assertEqual
2021-08-16 10:25:41 -04:00
nilez
f8dd4c3eb9
Check Study Associates Endpoint
2021-08-16 09:32:02 -04:00
nilez
4a2581e938
get studies raises and error when invalid studies are the only studies associated with the user
2021-08-12 14:03:44 -04:00
nilez
e32c1db4c8
Merge remote-tracking branch 'origin/dev' into bug/missing_pi_name_246
...
# Conflicts:
# crc/models/study.py
# crc/services/study_service.py
# crc/services/workflow_service.py
# tests/study/test_study_associate_script.py
2021-08-12 12:59:15 -04:00
Dan
000de03733
Just a quick hot fix so that when can still report errors back to the UI even when the task_data can't be serialized, which can happen when functions are defined.
2021-08-12 12:49:19 -04:00
nilez
d20b68e483
Fixed Deprecation Warnings in Test Files
2021-08-12 12:33:27 -04:00
nilez
2732071585
Merge branch 'dev' into bug/missing_pi_name_246
2021-08-12 12:07:25 -04:00
Dan
848c2e622f
Always use a schema to define what is being returned, it enforces consistency of the API and internally we can depend on well defined objects.
2021-08-10 16:16:08 -04:00
Dan
913c12c02d
Merge branch 'dev' into bug/pi_name_missing_246
2021-08-10 15:06:52 -04:00
Kelly McDonald
6e1fedb704
Add tests for libraries, remove an API endpoint that didn't make sense after recent changes and remove some commented out sections that were not needed after some decisions about the api endpoints were made
2021-08-03 10:02:22 -04:00
Kelly McDonald
41ad7935f8
Merge branch 'dev' into 367-Call-Activity
...
# Conflicts:
# Pipfile.lock
2021-07-29 09:28:21 -04:00
Kelly McDonald
b857fddbad
commit in intermediate changes to work on a bug
2021-07-26 13:00:11 -04:00
NWalker4483
a73d1794eb
Fixed Associate API Endpoint description
2021-07-22 14:09:24 -04:00
Kelly McDonald
2455495457
got library side working - still need to have parent working
2021-07-22 10:20:34 -04:00
NWalker4483
4632c6374f
Merge branch 'dev' into bug/missing_pi_name_246
...
# Conflicts:
# crc/api.yml
# crc/services/study_service.py
2021-07-20 11:44:11 -04:00
mike cullerton
690c059335
get_studies_for_user is no longer a static method
2021-07-09 10:37:57 -04:00
Dan
fb54edac1c
Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
...
Most noteable is the addition of the line on which the error occurs for script tasks. It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
Dan
7aa4b0833c
Merge remote-tracking branch 'origin/dev' into feature/documents_xls_refactor
2021-07-06 13:11:08 -04:00
Dan
1b1a994360
Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them.
...
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
2021-07-06 13:10:20 -04:00
Kelly McDonald
dce1d86e93
commit changes before looking at something else
2021-07-06 10:34:57 -04:00
NWalker4483
2ba52a7095
Merge remote-tracking branch 'origin/HEAD' into partial_testing
2021-06-29 11:21:49 -04:00
Dan
92ca506c8e
Calls to eval no longer return the data, rather it will accept and return a key, allowing the front end to cache similar queries and not re-execute them.
2021-06-22 17:23:18 -04:00
Dan
1f3febe2df
Fix the panda warnings, which means we only support xlsx files now.
...
Include the document details when reutnring a file from the file model.
Improve the validation of file form elements.
2021-06-22 14:58:52 -04:00
NWalker4483
4ca94b39ce
Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing
2021-06-17 15:12:28 -04:00
Dan
acae6030f5
The API for evaluating python expressions should not raise an error, it can simply return a result of false, and provide an error to explain the problem. In this way the front end doesn't error out when it's running the script tasks but doesn't have enough information to get a valid response back.
...
The validation should take into account that repeating sections must be evaluated in the context of the data within the repeating section, not outside of it.
2021-06-15 16:17:15 -04:00
NWalker4483
5c5b966bc4
Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing
2021-06-15 09:11:18 -04:00
Dan
7282419174
modified the tools api to return the expression and data with the result, making it easier to cash results on the front end, This should help drastically reduce the calls to the python_eval from the front end.
...
The post processors for form submissions needs to take repeating sections into account, or it won't find the files it is looking for.
2021-06-11 08:27:50 -04:00
NWalker4483
338fe30984
Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing
2021-06-09 14:32:01 -04:00
Dan
286803d10b
fixing a big stupid bug I created when merging all the code and making changes to the files.
2021-06-08 14:24:59 -04:00
Dan Funk
586a0f2f1a
Merge pull request #325 from sartography/feature/file_refactor
...
Prefer tasks that share a parent over just the the next available tas…
2021-06-08 11:28:23 -04:00
Dan Funk
9c4994581d
Merge pull request #324 from sartography/modify-infinite-loop-312
...
Modify infinite loop #312
2021-06-08 10:30:13 -04:00
Dan Funk
a7b208f50a
Merge pull request #322 from sartography/data-store-refactor-330
...
Data store refactor #330
2021-06-08 08:58:53 -04:00
Dan Funk
6937c33719
Merge pull request #319 from sartography/datastore-file-endpoints-325
...
Datastore file endpoints #325
2021-06-08 08:54:43 -04:00
Dan Funk
5881c903ca
Merge pull request #316 from sartography/326-Multi_File_Data_Store
...
Make sure we are using the correct script engine
2021-06-08 08:49:43 -04:00
Dan
59f605c3df
Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor.
2021-06-08 08:03:14 -04:00
mike cullerton
0dfc96d7f6
Modified `validate_workflow_specification` to accept new optional `validate_study_id` parameter.
...
We then pass validate_study_id on to WorkflowService.test_spec
2021-06-03 14:19:41 -04:00
mike cullerton
506b84a49a
Import DataStoreBase from service now
2021-06-02 10:00:18 -04:00