sartography
/
cr-connect-workflow
mirror of https://github.com/sartography/cr-connect-workflow.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added a catch for generic exceptions, so the `finally` clause always executes. 

Also, raise if there is an ApiError, because some tests depend on it.
This commit is contained in:
mike cullerton 2022-02-28 14:01:19 -05:00
parent 1dfebf9f1f
commit ef4334b1c8
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crc/services/workflow_service.py
View File

@ -42,7 +42,6 @@ from crc.services.user_service import UserService
from crc.services.workflow_processor import WorkflowProcessor from crc.services.workflow_processor import WorkflowProcessor
from crc.services.workflow_spec_service import WorkflowSpecService from crc.services.workflow_spec_service import WorkflowSpecService
from flask import request
from sentry_sdk import capture_message, push_scope from sentry_sdk import capture_message, push_scope
@ -227,6 +226,14 @@ class WorkflowService(object):
except WorkflowException as we: except WorkflowException as we:
raise ApiError.from_workflow_exception("workflow_validation_exception", str(we), we) raise ApiError.from_workflow_exception("workflow_validation_exception", str(we), we)
except ApiError:
# Raising because we have some tests that depend on it
raise
except Exception as e:
# Catch generic exceptions so that the finally clause always executes
app.logger.error(f'Unexpected exception caught in WorkflowService.test_spec. Original exception: {str(e)}', exc_info=True)
raise ApiError(code='unknown_exception',
message=f'We caught an unexpected exception in test_spec. Original exception is: {str(e)}')
finally: finally:
WorkflowService.delete_test_data(workflow_model) WorkflowService.delete_test_data(workflow_model)
return processor.bpmn_workflow.last_task.data return processor.bpmn_workflow.last_task.data