I absolutely must fix our cascade deletes, but I sort of like the horror such chunks of code cause, we really need to protect these endpoints, and assure they never get called under normal circumstances, and raise some thoughtful errors.

crc/api/workflow.py

@@ -4,6 +4,7 @@ from crc import session
 from crc.api.common import ApiError, ApiErrorSchema
 from crc.models.api_models import WorkflowApi, WorkflowApiSchema, NavigationItem, NavigationItemSchema
 from crc.models.file import FileModel, LookupDataSchema
+from crc.models.stats import TaskEventModel
 from crc.models.workflow import WorkflowModel, WorkflowSpecModelSchema, WorkflowSpecModel, WorkflowSpecCategoryModel, \
     WorkflowSpecCategoryModelSchema
 from crc.services.file_service import FileService
@@ -77,6 +78,8 @@ def delete_workflow_specification(spec_id):
     for file in files:
         FileService.delete_file(file.id)
 
+    session.query(TaskEventModel).filter(TaskEventModel.workflow_spec_id == spec_id).delete()
+
     # Delete all stats and workflow models related to this specification
     for workflow in session.query(WorkflowModel).filter_by(workflow_spec_id=spec_id):
         StudyService.delete_workflow(workflow)

tests/test_workflow_spec_api.py

@@ -1,9 +1,9 @@
 import json
 
+from tests.base_test import BaseTest
 from crc import session
 from crc.models.file import FileModel
 from crc.models.workflow import WorkflowSpecModel, WorkflowSpecModelSchema, WorkflowModel, WorkflowSpecCategoryModel
-from tests.base_test import BaseTest
 
 
 class TestWorkflowSpec(BaseTest):