sartography
/
cr-connect-workflow
mirror of https://github.com/sartography/cr-connect-workflow.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #219 from sartography/fix-api-call-missing-fieldname-143 

Fixed ApiError call. Now includes task_id and task_name.
This commit is contained in:
Dan Funk 2021-01-08 13:46:26 -05:00 committed by GitHub
parent 81fe3e7957 0ae4448fbe
commit be288ae048
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crc/services/workflow_service.py
View File

@ -130,7 +130,9 @@ class WorkflowService(object):
# Assure we have a field type # Assure we have a field type
if field.type is None: if field.type is None:
raise ApiError(code='invalid_form_data', raise ApiError(code='invalid_form_data',
message='Field type is None. A field type must be provided.') message=f'Type is missing for field "{field.id}". A field type must be provided.',
task_id=task.id,
task_name=task.get_name())
# Assure field has valid properties # Assure field has valid properties
WorkflowService.check_field_properties(field, task) WorkflowService.check_field_properties(field, task)

2
tests/workflow/test_workflow_form_field_type.py
View File

@ -10,5 +10,5 @@ class TestFormFieldType(BaseTest):
json_data = json.loads(rv.get_data(as_text=True)) json_data = json.loads(rv.get_data(as_text=True))
self.assertEqual(json_data[0]['message'], self.assertEqual(json_data[0]['message'],
'When populating all fields ... Field type is None. A field type must be provided.') 'When populating all fields ... Type is missing for field "name". A field type must be provided.')
# print('TestFormFieldType: Good Form') # print('TestFormFieldType: Good Form')