does this smell better

This commit is contained in:
mike cullerton 2022-05-27 10:37:06 -04:00
parent 2d9307cc4e
commit 4bab660441
1 changed files with 1 additions and 7 deletions

View File

@ -193,9 +193,7 @@ email(subject="My Subject", recipients="user@example.com", attachments=[('Study_
doc_code_tuple = (attachments, [])
# if we have a doc_code and a filter list
elif len(attachments) == 2 and \
isinstance(attachments[0], str) and \
isinstance(attachments[1], list):
elif is_filter_tuple(attachments):
doc_code_tuple = (attachments[0], attachments[1])
elif isinstance(attachments, list):
@ -204,10 +202,6 @@ email(subject="My Subject", recipients="user@example.com", attachments=[('Study_
if all(isinstance(x, str) for x in attachments):
return_list = [(doc_code, []) for doc_code in attachments]
# if we have a doc_code and a filter list--should get caught above
elif is_filter_tuple(attachments):
doc_code_tuple = (attachments[0], attachments[1])
else:
return_list = []
for item in attachments: