sartography
/
cr-connect-workflow
mirror of https://github.com/sartography/cr-connect-workflow.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #128 from sartography/fix/csv-dump 

Proper error handling in csv/dumps for approvals
This commit is contained in:
Dan Funk 2020-06-29 14:48:22 -04:00 committed by GitHub
parent da530c13a4 d4bcb9af65
commit 2eaa54f59d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crc/services/approval_service.py
View File

@ -1,5 +1,6 @@
import json import json
import pickle import pickle
import sys
from base64 import b64decode from base64 import b64decode
from datetime import datetime, timedelta from datetime import datetime, timedelta
@ -194,7 +195,7 @@ class ApprovalService(object):
health_attesting_rows.append(record) health_attesting_rows.append(record)
except Exception as e: except Exception as e:
app.logger.error("Error pulling data for workflow #%i: %s" % (approval.workflow_id, str(e))) app.logger.error(f'Error pulling data for workflow {approval.workflow_id}', exc_info=True)
return health_attesting_rows return health_attesting_rows
@ -222,7 +223,13 @@ class ApprovalService(object):
output.append(record) output.append(record)
except Exception as e: except Exception as e:
errors.append("Error pulling data for workflow #%i: %s" % (approval.workflow_id, str(e))) errors.append(
f'Error pulling data for workflow #{approval.workflow_id} '
f'(Approval status: {approval.status} - '
f'More details in Sentry): {str(e)}'
)
# Detailed information sent to Sentry
app.logger.error(f'Error pulling data for workflow {approval.workflow_id}', exc_info=True)
return {"results": output, "errors": errors } return {"results": output, "errors": errors }
@staticmethod @staticmethod