From b9876f63ca58ffec12d3db96b678f06f18e8b333 Mon Sep 17 00:00:00 2001 From: Dan Date: Wed, 26 Jan 2022 11:50:35 -0500 Subject: [PATCH 1/3] Allow setting the sync file root using environment variables. --- config/default.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/default.py b/config/default.py index 22ab87f1..451f348a 100644 --- a/config/default.py +++ b/config/default.py @@ -90,4 +90,4 @@ MAIL_USERNAME = environ.get('MAIL_USERNAME', default='') MAIL_PASSWORD = environ.get('MAIL_PASSWORD', default='') # Local file path -SYNC_FILE_ROOT = './SPECS' \ No newline at end of file +SYNC_FILE_ROOT = environ.get('SYNC_FILE_ROOT', default='SPECS') \ No newline at end of file From c2c6410bbbb0b0b78bc7ad4f301e8866294e1340 Mon Sep 17 00:00:00 2001 From: Dan Date: Thu, 17 Feb 2022 14:12:31 -0500 Subject: [PATCH 2/3] Assure we update the workflow model, so we don't keep reporting the error over and over again. --- crc/services/workflow_service.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crc/services/workflow_service.py b/crc/services/workflow_service.py index 42246540..d4027d10 100755 --- a/crc/services/workflow_service.py +++ b/crc/services/workflow_service.py @@ -121,6 +121,8 @@ class WorkflowService(object): processor.save() except Exception as e: workflow_model.status = WorkflowStatus.erroring + db.session.add(workflow_model) + db.session.commit() app.logger.error(f"Error running waiting task for workflow #%i (%s) for study #%i. %s" % (workflow_model.id, workflow_model.workflow_spec_id, From 70fc9451a439f812ddae03267ceaa70683f678ad Mon Sep 17 00:00:00 2001 From: alicia pritchett Date: Mon, 21 Feb 2022 09:44:00 -0500 Subject: [PATCH 3/3] fix tests (update BPMNs) test_stupid_slow_file_upload_form still fails --- .../add_delete_irb_document.bpmn | 2 +- .../associated_email/associated_email.bpmn | 2 +- .../boolean_default_value.bpmn | 4 ++-- .../data/date_validation/date_validation.bpmn | 2 +- .../date_value_expression.bpmn | 2 +- tests/data/decision_table/decision_table.bpmn | 2 +- .../decision_table_dictionary_output.bpmn | 2 +- .../default_value_expression.bpmn | 4 ++-- .../delete_task_data/delete_task_data.bpmn | 12 +++++----- tests/data/docx/docx.bpmn | 10 ++++---- tests/data/docx_embedded/docx_embedded.bpmn | 6 ++--- tests/data/email/email.bpmn | 4 ++-- .../email_attachment_empty_string.bpmn | 4 ++-- .../email_none_attachment.bpmn | 4 ++-- tests/data/email_script/email_script.bpmn | 12 +++++----- tests/data/enum_checkbox/enum_checkbox.bpmn | 2 +- .../data/enum_empty_list/enum_empty_list.bpmn | 2 +- tests/data/enum_file_data/enum_file_data.bpmn | 12 +++++----- .../enum_options_all/enum_options_all.bpmn | 18 +++++++------- .../enum_options_competing_files.bpmn | 2 +- .../enum_options_from_file.bpmn | 2 +- .../enum_options_from_task_data.bpmn | 16 ++++++------- .../enum_options_with_search.bpmn | 2 +- tests/data/enum_results/enum_results.bpmn | 2 +- .../enum_value_expression.bpmn | 4 ++-- .../enum_value_expression_fail.bpmn | 4 ++-- .../exclusive_gateway/exclusive_gateway.bpmn | 6 ++--- .../exclusive_gateway_2.bpmn | 8 +++---- .../failing_gateway_workflow.bpmn | 4 ++-- .../file_upload_form/file_upload_form.bpmn | 6 ++--- .../file_upload_form_single.bpmn | 6 ++--- .../form_expressions/form_expressions.bpmn | 18 +++++++------- .../form_extentsions/form_extentsions.bpmn | 2 +- tests/data/get_email_data/get_email_data.bpmn | 2 +- .../get_email_data_by_workflow.bpmn | 2 +- tests/data/get_localtime/get_localtime.bpmn | 8 +++---- .../get_workflow_status.bpmn | 2 +- tests/data/get_zip_file/get_zip_file.bpmn | 2 +- tests/data/hello_world/hello_world.bpmn | 2 +- .../hidden_file_data_field.bpmn | 8 +++---- .../hidden_required_field.bpmn | 4 ++-- .../hidden_required_field_pass.bpmn | 2 +- ...hidden_required_field_pass_expression.bpmn | 2 +- .../invalid_custom_field.bpmn | 2 +- .../invalid_expression.bpmn | 6 ++--- tests/data/invalid_roles/invalid_roles.bpmn | 10 ++++---- tests/data/invalid_spec/invalid_spec.bpmn | 6 ++--- .../irb_api_personnel/irb_api_personnel.bpmn | 10 ++++---- tests/data/jinja_email/jinja_email.bpmn | 8 +++---- tests/data/ldap_lookup/ldap_lookup.bpmn | 2 +- tests/data/ldap_script/ldap_script.bpmn | 4 ++-- ...nual_task_with_external_documentation.bpmn | 2 +- tests/data/message_event/message_event.bpmn | 4 ++-- .../missing_form_key/missing_form_key.bpmn | 2 +- .../data/missing_library/missing_library.bpmn | 4 ++-- tests/data/multi_instance/multi_instance.bpmn | 2 +- .../multi_instance_parallel.bpmn | 2 +- tests/data/parallel_tasks/parallel_tasks.bpmn | 24 +++++++++---------- ...sk_data_over_previous_form_submission.bpmn | 2 +- tests/data/random_fact/random_fact.bpmn | 2 +- tests/data/random_fact/random_fact2.bpmn | 2 +- .../data/read_only_field/read_only_field.bpmn | 2 +- tests/data/repeat_form/repeat_form.bpmn | 2 +- .../data/required_fields/required_fields.bpmn | 4 ++-- tests/data/reset_workflow/reset_workflow.bpmn | 2 +- tests/data/roles/roles.bpmn | 12 +++++----- .../script_with_name_error.bpmn | 4 ++-- .../set_study_progress_status.bpmn | 2 +- tests/data/spec_from_id/spec_from_id.bpmn | 2 +- .../spec_from_workflow_id.bpmn | 2 +- .../study_cancellations.bpmn | 4 ++-- .../study_info_script/study_info_script.bpmn | 2 +- tests/data/subprocess/subprocess.bpmn | 4 ++-- .../test_value_expression.bpmn | 2 +- .../modified/two_forms_struc_mod.bpmn | 4 ++-- .../modified/two_forms_text_mod.bpmn | 4 ++-- tests/data/two_forms/two_forms.bpmn | 4 ++-- tests/data/two_user_tasks/two_user_tasks.bpmn | 4 ++-- .../update_study_info/update_study_info.bpmn | 4 ++-- .../workflow_form_field_name.bpmn | 6 ++--- .../workflow_form_field_type.bpmn | 2 +- .../workflow_sync_responses/random_fact2.bpmn | 2 +- 82 files changed, 195 insertions(+), 195 deletions(-) diff --git a/tests/data/add_delete_irb_document/add_delete_irb_document.bpmn b/tests/data/add_delete_irb_document/add_delete_irb_document.bpmn index 0f7f2661..216ddca4 100644 --- a/tests/data/add_delete_irb_document/add_delete_irb_document.bpmn +++ b/tests/data/add_delete_irb_document/add_delete_irb_document.bpmn @@ -12,7 +12,7 @@ - + Flow_1j6i6nv diff --git a/tests/data/associated_email/associated_email.bpmn b/tests/data/associated_email/associated_email.bpmn index e01965af..7045b98f 100644 --- a/tests/data/associated_email/associated_email.bpmn +++ b/tests/data/associated_email/associated_email.bpmn @@ -9,7 +9,7 @@ - + Flow_0b5st2e diff --git a/tests/data/boolean_default_value/boolean_default_value.bpmn b/tests/data/boolean_default_value/boolean_default_value.bpmn index 249893e0..897107f6 100644 --- a/tests/data/boolean_default_value/boolean_default_value.bpmn +++ b/tests/data/boolean_default_value/boolean_default_value.bpmn @@ -7,7 +7,7 @@ - + Flow_0zp5mss @@ -37,7 +37,7 @@ <H1>Hello</H1> - + diff --git a/tests/data/date_validation/date_validation.bpmn b/tests/data/date_validation/date_validation.bpmn index 8cf29260..308f17f5 100644 --- a/tests/data/date_validation/date_validation.bpmn +++ b/tests/data/date_validation/date_validation.bpmn @@ -14,7 +14,7 @@ - + diff --git a/tests/data/date_value_expression/date_value_expression.bpmn b/tests/data/date_value_expression/date_value_expression.bpmn index 1a334e9d..a457eb67 100644 --- a/tests/data/date_value_expression/date_value_expression.bpmn +++ b/tests/data/date_value_expression/date_value_expression.bpmn @@ -8,7 +8,7 @@ - + diff --git a/tests/data/decision_table/decision_table.bpmn b/tests/data/decision_table/decision_table.bpmn index 82bcb385..93ff512a 100644 --- a/tests/data/decision_table/decision_table.bpmn +++ b/tests/data/decision_table/decision_table.bpmn @@ -8,7 +8,7 @@ - + diff --git a/tests/data/decision_table_dictionary_output/decision_table_dictionary_output.bpmn b/tests/data/decision_table_dictionary_output/decision_table_dictionary_output.bpmn index 1117386f..adc54078 100644 --- a/tests/data/decision_table_dictionary_output/decision_table_dictionary_output.bpmn +++ b/tests/data/decision_table_dictionary_output/decision_table_dictionary_output.bpmn @@ -26,7 +26,7 @@ - + SequenceFlow_0x4n744 diff --git a/tests/data/default_value_expression/default_value_expression.bpmn b/tests/data/default_value_expression/default_value_expression.bpmn index 3a73f8f5..232d4fd3 100644 --- a/tests/data/default_value_expression/default_value_expression.bpmn +++ b/tests/data/default_value_expression/default_value_expression.bpmn @@ -8,7 +8,7 @@ - + @@ -22,7 +22,7 @@ - + diff --git a/tests/data/delete_task_data/delete_task_data.bpmn b/tests/data/delete_task_data/delete_task_data.bpmn index e7ba46d9..e2fecc98 100644 --- a/tests/data/delete_task_data/delete_task_data.bpmn +++ b/tests/data/delete_task_data/delete_task_data.bpmn @@ -10,13 +10,13 @@ - - + + - + @@ -29,18 +29,18 @@ - + - + - + diff --git a/tests/data/docx/docx.bpmn b/tests/data/docx/docx.bpmn index fe11b7c5..2d26ab6e 100644 --- a/tests/data/docx/docx.bpmn +++ b/tests/data/docx/docx.bpmn @@ -8,11 +8,11 @@ - - - - - + + + + + SequenceFlow_0637d8i diff --git a/tests/data/docx_embedded/docx_embedded.bpmn b/tests/data/docx_embedded/docx_embedded.bpmn index 90bd7a60..8992534a 100644 --- a/tests/data/docx_embedded/docx_embedded.bpmn +++ b/tests/data/docx_embedded/docx_embedded.bpmn @@ -8,12 +8,12 @@ - - + + - + diff --git a/tests/data/email/email.bpmn b/tests/data/email/email.bpmn index 389ba06d..1a0de991 100644 --- a/tests/data/email/email.bpmn +++ b/tests/data/email/email.bpmn @@ -32,8 +32,8 @@ email_model = email(subject=subject,recipients=recipients) - - + + Flow_1synsig diff --git a/tests/data/email_attachment_empty_string/email_attachment_empty_string.bpmn b/tests/data/email_attachment_empty_string/email_attachment_empty_string.bpmn index e93e34a6..bcbf963d 100644 --- a/tests/data/email_attachment_empty_string/email_attachment_empty_string.bpmn +++ b/tests/data/email_attachment_empty_string/email_attachment_empty_string.bpmn @@ -27,8 +27,8 @@ email_id = email(subject=subject,recipients=recipients, attachments=attachments) - - + + Flow_1synsig diff --git a/tests/data/email_none_attachment/email_none_attachment.bpmn b/tests/data/email_none_attachment/email_none_attachment.bpmn index ebfbc897..51a0e7db 100644 --- a/tests/data/email_none_attachment/email_none_attachment.bpmn +++ b/tests/data/email_none_attachment/email_none_attachment.bpmn @@ -27,8 +27,8 @@ email_id = email(subject=subject,recipients=recipients, attachments=attachments) - - + + Flow_1synsig diff --git a/tests/data/email_script/email_script.bpmn b/tests/data/email_script/email_script.bpmn index 44892dc2..34ed4a1d 100644 --- a/tests/data/email_script/email_script.bpmn +++ b/tests/data/email_script/email_script.bpmn @@ -8,20 +8,20 @@ - + - + - - - - + + + + diff --git a/tests/data/enum_checkbox/enum_checkbox.bpmn b/tests/data/enum_checkbox/enum_checkbox.bpmn index f74586fd..b82090e0 100644 --- a/tests/data/enum_checkbox/enum_checkbox.bpmn +++ b/tests/data/enum_checkbox/enum_checkbox.bpmn @@ -8,7 +8,7 @@ - + diff --git a/tests/data/enum_empty_list/enum_empty_list.bpmn b/tests/data/enum_empty_list/enum_empty_list.bpmn index 4d7b92c1..ef7b5d29 100644 --- a/tests/data/enum_empty_list/enum_empty_list.bpmn +++ b/tests/data/enum_empty_list/enum_empty_list.bpmn @@ -8,7 +8,7 @@ - + diff --git a/tests/data/enum_file_data/enum_file_data.bpmn b/tests/data/enum_file_data/enum_file_data.bpmn index 285e0ed4..267478a6 100644 --- a/tests/data/enum_file_data/enum_file_data.bpmn +++ b/tests/data/enum_file_data/enum_file_data.bpmn @@ -8,7 +8,7 @@ - + @@ -20,23 +20,23 @@ - - + + - + - + - + diff --git a/tests/data/enum_options_all/enum_options_all.bpmn b/tests/data/enum_options_all/enum_options_all.bpmn index 4b6d1428..3435e98c 100644 --- a/tests/data/enum_options_all/enum_options_all.bpmn +++ b/tests/data/enum_options_all/enum_options_all.bpmn @@ -26,7 +26,7 @@ - + @@ -35,7 +35,7 @@ - + @@ -45,7 +45,7 @@ - + @@ -53,7 +53,7 @@ - + @@ -61,7 +61,7 @@ - + @@ -70,12 +70,12 @@ - + - + @@ -83,13 +83,13 @@ - + - + diff --git a/tests/data/enum_options_competing_files/enum_options_competing_files.bpmn b/tests/data/enum_options_competing_files/enum_options_competing_files.bpmn index 14687339..e0b98264 100644 --- a/tests/data/enum_options_competing_files/enum_options_competing_files.bpmn +++ b/tests/data/enum_options_competing_files/enum_options_competing_files.bpmn @@ -30,7 +30,7 @@ - + diff --git a/tests/data/enum_options_from_file/enum_options_from_file.bpmn b/tests/data/enum_options_from_file/enum_options_from_file.bpmn index 5db7a3e8..351010f4 100644 --- a/tests/data/enum_options_from_file/enum_options_from_file.bpmn +++ b/tests/data/enum_options_from_file/enum_options_from_file.bpmn @@ -12,7 +12,7 @@ - + diff --git a/tests/data/enum_options_from_task_data/enum_options_from_task_data.bpmn b/tests/data/enum_options_from_task_data/enum_options_from_task_data.bpmn index 7f52aa7b..78629e35 100644 --- a/tests/data/enum_options_from_task_data/enum_options_from_task_data.bpmn +++ b/tests/data/enum_options_from_task_data/enum_options_from_task_data.bpmn @@ -12,7 +12,7 @@ - + @@ -28,37 +28,37 @@ - + - + - + - + - + - + - + diff --git a/tests/data/enum_options_with_search/enum_options_with_search.bpmn b/tests/data/enum_options_with_search/enum_options_with_search.bpmn index 4ecab273..e3720e4a 100644 --- a/tests/data/enum_options_with_search/enum_options_with_search.bpmn +++ b/tests/data/enum_options_with_search/enum_options_with_search.bpmn @@ -12,7 +12,7 @@ -