sartography
/
cr-connect-workflow
mirror of https://github.com/sartography/cr-connect-workflow.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes validation for #518 

Well really what this does is give every field a default value of None. what that does is allow you to use value expressions even without a given default value. this part in the backend fixes validation.
This commit is contained in:
alicia pritchett 2021-11-01 14:35:30 -04:00
parent e0d1f63c08
commit 1866e6bba9
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crc/services/workflow_service.py
View File

@ -363,6 +363,10 @@ class WorkflowService(object):
def evaluate_property(property_name, field, task): def evaluate_property(property_name, field, task):
expression = field.get_property(property_name) expression = field.get_property(property_name)
data = task.data data = task.data
# If there's a field key with no initial value, give it one (None)
for field in task.task_spec.form.fields:
if field.id not in data:
data[field.id] = None
if field.has_property(Task.FIELD_PROP_REPEAT): if field.has_property(Task.FIELD_PROP_REPEAT):
# Then you must evaluate the expression based on the data within the group, if that data exists. # Then you must evaluate the expression based on the data within the group, if that data exists.
# There may not be data available in the group, if no groups where added # There may not be data available in the group, if no groups where added

3
tests/workflow/test_workflow_value_expression.py
View File

@ -3,6 +3,7 @@ from tests.base_test import BaseTest
class TestValueExpression(BaseTest): class TestValueExpression(BaseTest):
# If there is no default value, a value of 'None' should be given.
def test_value_expression_no_default(self): def test_value_expression_no_default(self):
workflow = self.create_workflow('test_value_expression') workflow = self.create_workflow('test_value_expression')
@ -14,7 +15,7 @@ class TestValueExpression(BaseTest):
workflow_api = self.get_workflow_api(workflow) workflow_api = self.get_workflow_api(workflow)
second_task = workflow_api.next_task second_task = workflow_api.next_task
self.assertEqual('', second_task.data['value_expression_value']) self.assertEqual('', second_task.data['value_expression_value'])
self.assertNotIn('color', second_task.data) self.assertIn('color', second_task.data)