From 1db4c6c5694286757d2faa1bd0eb22c70ed674d0 Mon Sep 17 00:00:00 2001 From: Leashys Date: Thu, 19 Aug 2021 11:38:13 -0400 Subject: [PATCH 1/2] Removes 'required' property from checkboxes, makes them false by default --- .../workflow-spec-dialog/workflow-spec-dialog.component.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/app/_dialogs/workflow-spec-dialog/workflow-spec-dialog.component.ts b/src/app/_dialogs/workflow-spec-dialog/workflow-spec-dialog.component.ts index cb94f75..82d28d4 100644 --- a/src/app/_dialogs/workflow-spec-dialog/workflow-spec-dialog.component.ts +++ b/src/app/_dialogs/workflow-spec-dialog/workflow-spec-dialog.component.ts @@ -91,22 +91,20 @@ export class WorkflowSpecDialogComponent { { key: 'standalone', type: 'checkbox', - defaultValue: this.data.standalone, + defaultValue: false, templateOptions: { label: 'Standalone', description: 'Is this a standalone workflow?', - required: true, indeterminate: false, }, }, { key: 'library', type: 'checkbox', - defaultValue: this.data.library, + defaultValue: false, templateOptions: { label: 'Library', description: 'Is this a library workflow?', - required: true, indeterminate: false, }, }, @@ -115,6 +113,7 @@ export class WorkflowSpecDialogComponent { } onNoClick() { + console.log('form model : ', this.model); this.dialogRef.close(); } From ce2cd618ef3036b38538bf05b6d63f4de99d79bb Mon Sep 17 00:00:00 2001 From: alicia pritchett Date: Wed, 25 Aug 2021 15:46:45 -0400 Subject: [PATCH 2/2] Actually fixes #433 - pulls dialog data from database (when available) I wrote some tests in sartography-libs too --- .../workflow-spec-dialog/workflow-spec-dialog.component.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/_dialogs/workflow-spec-dialog/workflow-spec-dialog.component.ts b/src/app/_dialogs/workflow-spec-dialog/workflow-spec-dialog.component.ts index 82d28d4..b6ed230 100644 --- a/src/app/_dialogs/workflow-spec-dialog/workflow-spec-dialog.component.ts +++ b/src/app/_dialogs/workflow-spec-dialog/workflow-spec-dialog.component.ts @@ -91,7 +91,7 @@ export class WorkflowSpecDialogComponent { { key: 'standalone', type: 'checkbox', - defaultValue: false, + defaultValue: this.data.standalone ? this.data.standalone : false, templateOptions: { label: 'Standalone', description: 'Is this a standalone workflow?', @@ -101,7 +101,7 @@ export class WorkflowSpecDialogComponent { { key: 'library', type: 'checkbox', - defaultValue: false, + defaultValue: this.data.library ? this.data.library : false, templateOptions: { label: 'Library', description: 'Is this a library workflow?',