From 6c9a3807f98cdf992465ca4fb16e6a6e9bded5db Mon Sep 17 00:00:00 2001 From: Kelly McDonald Date: Tue, 10 Aug 2021 09:12:26 -0400 Subject: [PATCH 1/4] Finish #367 to allow user to choose libraries for a given workflow --- package-lock.json | 14 +- package.json | 2 +- src/app/app.module.ts | 64 ++--- .../library-list/library-list.component.html | 42 +-- .../library-list.component.spec.ts | 242 +++--------------- .../library-list/library-list.component.ts | 139 ++-------- .../workflow-spec-card.component.html | 5 +- 7 files changed, 96 insertions(+), 412 deletions(-) diff --git a/package-lock.json b/package-lock.json index 8f6dc63..1f46c6b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -40,7 +40,7 @@ "ngx-markdown": "^9.1.1", "protractor": "^7.0.0", "rxjs": "~6.5.4", - "sartography-workflow-lib": "0.0.532", + "sartography-workflow-lib": "0.0.534", "tslib": "^1.13.0", "uuid": "^7.0.2", "zone.js": "^0.10.3" @@ -15269,9 +15269,9 @@ "integrity": "sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==" }, "node_modules/sartography-workflow-lib": { - "version": "0.0.532", - "resolved": "https://registry.npmjs.org/sartography-workflow-lib/-/sartography-workflow-lib-0.0.532.tgz", - "integrity": "sha512-Q9uYVCIAjiRruhrQztPlKF6VC0na56X33ximXCAbyXF5TMeyR5KyslgprXNkVeyMLo4z1I2YBO+5ffOQ9I7TYA==", + "version": "0.0.534", + "resolved": "https://registry.npmjs.org/sartography-workflow-lib/-/sartography-workflow-lib-0.0.534.tgz", + "integrity": "sha512-oUradcyBTsi7mpcIMsuG+WRTHsbc2TeUojK6WqtoAkI9YSGQqBZxCJVRxTWEVVMKsgXrxBytjhz7entsOR0w+g==", "peerDependencies": { "@angular/common": "^9.1.11", "@angular/core": "^9.1.11", @@ -32187,9 +32187,9 @@ "integrity": "sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==" }, "sartography-workflow-lib": { - "version": "0.0.532", - "resolved": "https://registry.npmjs.org/sartography-workflow-lib/-/sartography-workflow-lib-0.0.532.tgz", - "integrity": "sha512-Q9uYVCIAjiRruhrQztPlKF6VC0na56X33ximXCAbyXF5TMeyR5KyslgprXNkVeyMLo4z1I2YBO+5ffOQ9I7TYA==", + "version": "0.0.534", + "resolved": "https://registry.npmjs.org/sartography-workflow-lib/-/sartography-workflow-lib-0.0.534.tgz", + "integrity": "sha512-oUradcyBTsi7mpcIMsuG+WRTHsbc2TeUojK6WqtoAkI9YSGQqBZxCJVRxTWEVVMKsgXrxBytjhz7entsOR0w+g==", "requires": {} }, "sass": { diff --git a/package.json b/package.json index 3ee64e3..18a7a79 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,7 @@ "ngx-markdown": "^9.1.1", "protractor": "^7.0.0", "rxjs": "~6.5.4", - "sartography-workflow-lib": "0.0.532", + "sartography-workflow-lib": "0.0.534", "tslib": "^1.13.0", "uuid": "^7.0.2", "zone.js": "^0.10.3" diff --git a/src/app/app.module.ts b/src/app/app.module.ts index e996eed..bfd1e80 100644 --- a/src/app/app.module.ts +++ b/src/app/app.module.ts @@ -53,8 +53,9 @@ import {MatSidenavModule} from '@angular/material/sidenav'; import { ConfirmDialogComponent } from './_dialogs/confirm-dialog/confirm-dialog.component'; import {MatExpansionModule} from '@angular/material/expansion'; import { SettingsComponent } from './settings/settings.component'; -import {MatSelect, MatSelectModule} from '@angular/material/select'; +import { MatSelectModule} from '@angular/material/select'; import {LibraryListComponent} from './library-list/library-list.component'; +import {MatCheckboxModule} from '@angular/material/checkbox'; @Injectable() export class ThisEnvironment implements AppEnvironment { @@ -107,36 +108,37 @@ export function getBaseHref(platformLocation: PlatformLocation): string { ConfirmDialogComponent, SettingsComponent, ], - imports: [ - BrowserAnimationsModule, - BrowserModule, - FlexLayoutModule, - FormlyModule, - FormsModule, - HttpClientModule, - MatBottomSheetModule, - MatButtonModule, - MatCardModule, - MatDialogModule, - MatDividerModule, - MatIconModule, - MatInputModule, - MatListModule, - MatMenuModule, - MatSnackBarModule, - MatTabsModule, - MatToolbarModule, - MatTooltipModule, - MatSelectModule, - ReactiveFormsModule, - SartographyFormsModule, - SartographyPipesModule, - SartographyWorkflowLibModule, - AppRoutingModule, - MatSidenavModule, - MatExpansionModule, - // <-- This line MUST be last (https://angular.io/guide/router#module-import-order-matters) - ], + imports: [ + BrowserAnimationsModule, + BrowserModule, + FlexLayoutModule, + FormlyModule, + FormsModule, + HttpClientModule, + MatBottomSheetModule, + MatButtonModule, + MatCardModule, + MatDialogModule, + MatDividerModule, + MatIconModule, + MatInputModule, + MatListModule, + MatMenuModule, + MatSnackBarModule, + MatTabsModule, + MatToolbarModule, + MatTooltipModule, + MatSelectModule, + ReactiveFormsModule, + SartographyFormsModule, + SartographyPipesModule, + SartographyWorkflowLibModule, + AppRoutingModule, + MatSidenavModule, + MatExpansionModule, + MatCheckboxModule, + // <-- This line MUST be last (https://angular.io/guide/router#module-import-order-matters) + ], bootstrap: [AppComponent], entryComponents: [ DeleteFileDialogComponent, diff --git a/src/app/library-list/library-list.component.html b/src/app/library-list/library-list.component.html index 0da3442..596a392 100644 --- a/src/app/library-list/library-list.component.html +++ b/src/app/library-list/library-list.component.html @@ -1,46 +1,10 @@
- {{fm.type | getIconCode}} - - - - -

{{fm.name}}

-

Updated: {{fm.last_modified | date:'medium'}}

- - - + {{fm.display_name}}
-
- - - -
+ diff --git a/src/app/library-list/library-list.component.spec.ts b/src/app/library-list/library-list.component.spec.ts index b3f794c..ee5be46 100644 --- a/src/app/library-list/library-list.component.spec.ts +++ b/src/app/library-list/library-list.component.spec.ts @@ -1,241 +1,57 @@ import {APP_BASE_HREF} from '@angular/common'; -import {HttpHeaders} from '@angular/common/http'; import {HttpClientTestingModule, HttpTestingController} from '@angular/common/http/testing'; -import {async, ComponentFixture, TestBed} from '@angular/core/testing'; -import {MAT_DIALOG_DATA, MatDialogModule, MatDialogRef} from '@angular/material/dialog'; +import { async, ComponentFixture, TestBed } from '@angular/core/testing'; import {MatIconModule} from '@angular/material/icon'; -import {MatListModule} from '@angular/material/list'; -import {MatSnackBarModule} from '@angular/material/snack-bar'; -import {BrowserDynamicTestingModule} from '@angular/platform-browser-dynamic/testing'; -import {BrowserAnimationsModule} from '@angular/platform-browser/animations'; -import {RouterTestingModule} from '@angular/router/testing'; -import createClone from 'rfdc'; -import {of} from 'rxjs'; -import { - ApiService, - FileMeta, - FileType, - MockEnvironment, mockFile0, - mockFileMeta0, - mockFileMetas, - mockWorkflowSpec0 -} from 'sartography-workflow-lib'; -import {DeleteFileDialogComponent} from '../_dialogs/delete-file-dialog/delete-file-dialog.component'; -import {DeleteFileDialogData} from '../_interfaces/dialog-data'; -import {GetIconCodePipe} from '../_pipes/get-icon-code.pipe'; -import {FileListComponent} from '../file-list/file-list.component'; +import {MatMenuModule} from '@angular/material/menu'; +import {ApiService, MockEnvironment, mockWorkflowSpec0, mockWorkflowSpec1, WorkflowSpec} from 'sartography-workflow-lib'; +import {LibraryListComponent} from './library-list.component'; -describe('FileListComponent', () => { + +describe('LibraryListComponent', () => { + let component: LibraryListComponent; + let fixture: ComponentFixture; let httpMock: HttpTestingController; - let component: FileListComponent; - let fixture: ComponentFixture; - const timeString = '2020-01-23T12:34:12.345Z'; - const timeCode = new Date(timeString).getTime(); - + let libraries: WorkflowSpec[]; beforeEach(async(() => { TestBed.configureTestingModule({ - imports: [ - BrowserAnimationsModule, - HttpClientTestingModule, - MatDialogModule, - MatIconModule, - MatListModule, - MatSnackBarModule, - RouterTestingModule, - ], declarations: [ - DeleteFileDialogComponent, - FileListComponent, - GetIconCodePipe, + LibraryListComponent + ], + imports: [ + HttpClientTestingModule, + MatIconModule, + MatMenuModule, + // RouterTestingModule, ], providers: [ ApiService, + { + }, {provide: 'APP_ENVIRONMENT', useClass: MockEnvironment}, {provide: APP_BASE_HREF, useValue: ''}, - { - provide: MatDialogRef, - useValue: { - close: (dialogResult: any) => { - } - } - }, - {provide: MAT_DIALOG_DATA, useValue: []}, - ] - }).overrideModule(BrowserDynamicTestingModule, { - set: { - entryComponents: [ - DeleteFileDialogComponent, - ] - } + ], }) .compileComponents(); })); beforeEach(() => { - fixture = TestBed.createComponent(FileListComponent); - component = fixture.componentInstance; + localStorage.setItem('token', 'some_token'); httpMock = TestBed.inject(HttpTestingController); - component.workflowSpec = mockWorkflowSpec0; + fixture = TestBed.createComponent(LibraryListComponent); + component = fixture.componentInstance; + libraries = [mockWorkflowSpec0, mockWorkflowSpec1]; + libraries[0].library = true; + libraries[1].library = true; fixture.detectChanges(); - - - const fmsReq = httpMock.expectOne(`apiRoot/file?workflow_spec_id=${mockWorkflowSpec0.id}`); - expect(fmsReq.request.method).toEqual('GET'); - fmsReq.flush(mockFileMetas); - expect(component.fileMetas.length).toBeGreaterThan(0); - - }); - - afterEach(() => { - httpMock.verify(); - fixture.destroy(); + const uReq = httpMock.expectOne('apiRoot/workflow-specification?libraries=true'); + expect(uReq.request.method).toEqual('GET'); + uReq.flush(libraries); + expect(component.workflowLibraries).toEqual(libraries); }); it('should create', () => { expect(component).toBeTruthy(); }); - - it('should sort files by name', () => { - let prevFileMeta; - - for (const thisFileMeta of component.fileMetas) { - if (!prevFileMeta) { - prevFileMeta = thisFileMeta; - } else { - expect(thisFileMeta.name).toBeGreaterThan(prevFileMeta.name); - prevFileMeta = thisFileMeta; - } - } - }); - - it('should show a confirmation dialog before deleting a file', () => { - const mockConfirmDeleteData: DeleteFileDialogData = { - confirm: false, - fileMeta: mockFileMeta0, - }; - - const _deleteFileSpy = spyOn((component as any), '_deleteFile').and.stub(); - const openDialogSpy = spyOn(component.dialog, 'open') - .and.returnValue({afterClosed: () => of(mockConfirmDeleteData)} as any); - - component.confirmDelete(mockFileMeta0); - expect(openDialogSpy).toHaveBeenCalled(); - expect(_deleteFileSpy).not.toHaveBeenCalled(); - - mockConfirmDeleteData.confirm = true; - component.confirmDelete(mockFileMeta0); - expect(openDialogSpy).toHaveBeenCalled(); - expect(_deleteFileSpy).toHaveBeenCalled(); - }); - - it('should delete a file', () => { - const loadFileMetasSpy = spyOn((component as any), '_loadFileMetas').and.stub(); - (component as any)._deleteFile(mockFileMeta0); - const fmsReq = httpMock.expectOne(`apiRoot/file/${mockFileMeta0.id}`); - expect(fmsReq.request.method).toEqual('DELETE'); - fmsReq.flush(null); - - expect(loadFileMetasSpy).toHaveBeenCalled(); - }); - - it('should navigate to modeler to edit a BPMN or DMN file', () => { - const routerNavigateSpy = spyOn((component as any).router, 'navigate'); - component.workflowSpec = mockWorkflowSpec0; - component.editFile(mockFileMeta0); - expect(routerNavigateSpy).toHaveBeenCalledWith([`/modeler/${mockWorkflowSpec0.id}/${mockFileMeta0.id}`]); - - routerNavigateSpy.calls.reset(); - const mockDmnMeta = createClone()(mockFileMeta0); - mockDmnMeta.type = FileType.DMN; - component.editFile(mockDmnMeta); - expect(routerNavigateSpy).toHaveBeenCalledWith([`/modeler/${mockWorkflowSpec0.id}/${mockDmnMeta.id}`]); - }); - - it('should open file metadata dialog for non-BPMN files', () => { - const routerNavigateSpy = spyOn((component as any).router, 'navigate'); - const editFileMetaSpy = spyOn(component, 'editFileMeta'); - component.workflowSpec = mockWorkflowSpec0; - const mockDocMeta = createClone()(mockFileMeta0); - mockDocMeta.type = FileType.DOCX; - component.editFile(mockDocMeta); - expect(routerNavigateSpy).not.toHaveBeenCalled(); - expect(editFileMetaSpy).toHaveBeenCalledWith(mockDocMeta); - - routerNavigateSpy.calls.reset(); - editFileMetaSpy.calls.reset(); - component.editFile(null); - expect(routerNavigateSpy).not.toHaveBeenCalled(); - expect(editFileMetaSpy).toHaveBeenCalledWith(null); - }); - - it('should open file metadata dialog', () => { - const _openFileDialogSpy = spyOn((component as any), '_openFileDialog').and.stub(); - component.workflowSpec = mockWorkflowSpec0; - const mockDocMeta: FileMeta = createClone()(mockFileMeta0); - mockDocMeta.type = FileType.DOCX; - component.editFileMeta(mockDocMeta); - - const expectedFile = new File([], mockDocMeta.name, { - type: mockDocMeta.content_type, - lastModified: timeCode - }); - const fReq = httpMock.expectOne(`apiRoot/file/${mockDocMeta.id}/data`); - - const mockHeaders = new HttpHeaders() - .append('last-modified', expectedFile.lastModified.toString()) - .append('content-type', mockDocMeta.content_type); - expect(fReq.request.method).toEqual('GET'); - fReq.flush(new ArrayBuffer(8), {headers: mockHeaders}); - expect(fReq.request.method).toEqual('GET'); - expect(_openFileDialogSpy).toHaveBeenCalledWith(mockDocMeta, expectedFile); - - _openFileDialogSpy.calls.reset(); - - component.editFileMeta(null); - expect(_openFileDialogSpy).toHaveBeenCalledWith(); - }); - - it('should upload new file from file dialog', () => { - const openDialogSpy = spyOn(component.dialog, 'open') - .and.returnValue({afterClosed: () => of({file: mockFile0})} as any); - const _loadFileMetasSpy = spyOn((component as any), '_loadFileMetas').and.stub(); - component.workflowSpec = mockWorkflowSpec0; - - (component as any)._openFileDialog(); - const addReq = httpMock.expectOne(`apiRoot/file?workflow_spec_id=${mockWorkflowSpec0.id}`); - expect(addReq.request.method).toEqual('POST'); - addReq.flush(mockFileMeta0); - - expect(openDialogSpy).toHaveBeenCalled(); - expect(_loadFileMetasSpy).toHaveBeenCalled(); - }); - - it('should update existing file from file dialog', () => { - const openDialogSpy = spyOn(component.dialog, 'open') - .and.returnValue({afterClosed: () => of({fileMetaId: mockFileMeta0.id, file: mockFile0})} as any); - const _loadFileMetasSpy = spyOn((component as any), '_loadFileMetas').and.stub(); - component.workflowSpec = mockWorkflowSpec0; - - (component as any)._openFileDialog(mockFileMeta0, mockFile0); - const updateReq = httpMock.expectOne(`apiRoot/file/${mockFileMeta0.id}/data`); - expect(updateReq.request.method).toEqual('PUT'); - updateReq.flush(mockFileMeta0); - - expect(openDialogSpy).toHaveBeenCalled(); - expect(_loadFileMetasSpy).toHaveBeenCalled(); - }); - - it('should flag a file as primary', () => { - const updateFileMetaSpy = spyOn((component as any).api, 'updateFileMeta').and.returnValue(of(mockFileMeta0)); - const _loadFileMetasSpy = spyOn((component as any), '_loadFileMetas').and.stub(); - expect(component.fileMetas.length).toEqual(mockFileMetas.length); - component.makePrimary(mockFileMeta0); - - expect(updateFileMetaSpy).toHaveBeenCalledTimes(mockFileMetas.length); - expect(component.fileMetas.length).toEqual(mockFileMetas.length); - expect(component.fileMetas.reduce((sum, fm) => fm.primary ? sum + 1 : sum, 0)).toEqual(1); - expect(_loadFileMetasSpy).toHaveBeenCalled(); - }); }); diff --git a/src/app/library-list/library-list.component.ts b/src/app/library-list/library-list.component.ts index b7d45ec..e2ee5d8 100644 --- a/src/app/library-list/library-list.component.ts +++ b/src/app/library-list/library-list.component.ts @@ -1,20 +1,8 @@ import {Component, Input, OnChanges, OnInit} from '@angular/core'; -import {MatDialog} from '@angular/material/dialog'; -import {MatSnackBar} from '@angular/material/snack-bar'; -import {ActivatedRoute, Router} from '@angular/router'; import { ApiService, - FileMeta, - FileParams, - FileType, - getFileType, - isNumberDefined, newFileFromResponse, WorkflowSpec } from 'sartography-workflow-lib'; -import {DeleteFileDialogComponent} from '../_dialogs/delete-file-dialog/delete-file-dialog.component'; -import {OpenFileDialogComponent} from '../_dialogs/open-file-dialog/open-file-dialog.component'; -import {DeleteFileDialogData, OpenFileDialogData} from '../_interfaces/dialog-data'; -import * as fileSaver from 'file-saver'; @Component({ selector: 'app-library-list', @@ -22,136 +10,47 @@ import * as fileSaver from 'file-saver'; styleUrls: ['./library-list.component.scss'] }) export class LibraryListComponent implements OnInit, OnChanges { - @Input() workflowSpec: WorkflowSpec; - fileMetas: FileMeta[]; - fileType = FileType; + @Input() workflowSpecId: string; + workflowLibraries: WorkflowSpec[]; constructor( private api: ApiService, - public dialog: MatDialog, - private route: ActivatedRoute, - private router: Router, - private snackBar: MatSnackBar, ) { } ngOnInit() { - this._loadFileMetas(); + this._loadWorkflowLibraries(); } ngOnChanges() { - this._loadFileMetas(); + this._loadWorkflowLibraries(); } - editFile(fileMeta?: FileMeta) { - if (fileMeta && ((fileMeta.type === FileType.BPMN) || (fileMeta.type === FileType.DMN))) { - this.router.navigate([`/modeler/${this.workflowSpec.id}/${fileMeta.id}`]); - } else { - // Show edit file meta dialog - this.editFileMeta(fileMeta); + + isChecked(libraryspec): boolean { + let checked = false; + for (const item of libraryspec.parents) { + checked = checked || (item.id === this.workflowSpecId); } + return checked; } - editFileMeta(fm: FileMeta) { - if (fm && isNumberDefined(fm.id)) { - this.api.getFileData(fm.id).subscribe(response => { - const file = newFileFromResponse(fm, response); - this._openFileDialog(fm, file); + updateItem(library: WorkflowSpec , checked: boolean) { + if (checked) { + this.api.deleteWorkflowLibrary(this.workflowSpecId, library.id).subscribe(() => { + this._loadWorkflowLibraries(); }); } else { - this._openFileDialog(); - } - } - - confirmDelete(fm: FileMeta) { - const dialogRef = this.dialog.open(DeleteFileDialogComponent, { - data: { - confirm: false, - fileMeta: fm, - } - }); - - dialogRef.afterClosed().subscribe((data: DeleteFileDialogData) => { - if (data && data.confirm && data.fileMeta) { - this._deleteFile(data.fileMeta); - } - }); - } - - makePrimary(fmPrimary: FileMeta) { - if (fmPrimary.type === FileType.BPMN) { - let numUpdated = 0; - // Fixme: This buisness rule does not belong here. - this.fileMetas.forEach(fm => { - fm.primary = (fmPrimary.id === fm.id); - this.api.updateFileMeta(fm).subscribe(() => { - numUpdated++; - - // Reload all fileMetas when all have been updated. - if (numUpdated === this.fileMetas.length) { - this._loadFileMetas(); - } - }); + this.api.addWorkflowLibrary(this.workflowSpecId, library.id).subscribe(() => { + this._loadWorkflowLibraries(); }); } } - private _openFileDialog(fm?: FileMeta, file?: File) { - const dialogData: OpenFileDialogData = { - fileMetaId: fm ? fm.id : undefined, - file: file, - mode: 'local', - fileTypes: [FileType.DOC, FileType.DOCX, FileType.XLSX, FileType.XLS], - }; - const dialogRef = this.dialog.open(OpenFileDialogComponent, {data: dialogData}); + private _loadWorkflowLibraries() { - dialogRef.afterClosed().subscribe((data: OpenFileDialogData) => { - if (data && data.file) { - const newFileMeta: FileMeta = { - id: data.fileMetaId, - content_type: data.file.type, - name: data.file.name, - type: getFileType(data.file), - workflow_spec_id: this.workflowSpec.id, - }; - - if (isNumberDefined(data.fileMetaId)) { - // Update existing file - this.api.updateFileData(newFileMeta, data.file).subscribe(() => { - this._loadFileMetas(); - }); - } else { - // Add new file - const fileParams: FileParams = { - workflow_spec_id: this.workflowSpec.id, - }; - - this.api.addFile(fileParams, newFileMeta, data.file).subscribe(dbFm => { - this._loadFileMetas(); - }); - } - } - }); - - } - - private _deleteFile(fileMeta: FileMeta) { - this.api.deleteFileMeta(fileMeta.id).subscribe(() => { - this._loadFileMetas(); - this.snackBar.open(`Deleted file ${fileMeta.name}.`, 'Ok', {duration: 3000}); - }); - } - - private _loadFileMetas() { - this.api.getFileMetas({workflow_spec_id: this.workflowSpec.id}).subscribe(fms => { - this.fileMetas = fms.sort((a, b) => (a.name > b.name) ? 1 : -1); - }); - } - - downloadFile(fm: FileMeta) { - this.api.getFileData(fm.id).subscribe(response => { - const blob = new Blob([response.body], {type: fm.content_type}); - fileSaver.saveAs(blob, fm.name); + this.api.getWorkflowSpecificationLibraries().subscribe(wfs => { + this.workflowLibraries = wfs; }); } } diff --git a/src/app/workflow-spec-card/workflow-spec-card.component.html b/src/app/workflow-spec-card/workflow-spec-card.component.html index 78ff917..94e59c2 100644 --- a/src/app/workflow-spec-card/workflow-spec-card.component.html +++ b/src/app/workflow-spec-card/workflow-spec-card.component.html @@ -23,7 +23,10 @@
True
False
 - +
+

Included Libraries

+ +

Workflow Spec Files

From 9aac003fead1570dd7dc07bffd9a33af5f336af8 Mon Sep 17 00:00:00 2001 From: Kelly McDonald Date: Tue, 10 Aug 2021 10:17:42 -0400 Subject: [PATCH 2/4] Swap order of components --- src/app/workflow-spec-card/workflow-spec-card.component.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/workflow-spec-card/workflow-spec-card.component.html b/src/app/workflow-spec-card/workflow-spec-card.component.html index 94e59c2..b60b0c0 100644 --- a/src/app/workflow-spec-card/workflow-spec-card.component.html +++ b/src/app/workflow-spec-card/workflow-spec-card.component.html @@ -23,12 +23,12 @@
True
False
 +

Workflow Spec Files

+

Included Libraries

-

Workflow Spec Files

- From 8a3fb4dc4abb815cca219b52cb2ae9a20fba1443 Mon Sep 17 00:00:00 2001 From: Dan Date: Tue, 10 Aug 2021 14:58:11 -0400 Subject: [PATCH 3/4] A little css cleanup. --- angular.json | 28 +++++++++++++++++-- .../workflow-spec-card.component.html | 2 +- .../workflow-spec-list.component.html | 14 +++++----- .../workflow-spec-list.component.scss | 9 ++++-- 4 files changed, 40 insertions(+), 13 deletions(-) diff --git a/angular.json b/angular.json index 96e78a9..97bb60e 100644 --- a/angular.json +++ b/angular.json @@ -11,6 +11,7 @@ "schematics": {}, "architect": { "build": { + "defaultConfiguration": "dev", "builder": "@angular-builders/custom-webpack:browser", "options": { "customWebpackConfig": { @@ -35,7 +36,14 @@ }, "configurations": { "production": { - "optimization": true, + "optimization": { + "scripts": true, + "styles": { + "minify": true, + "inlineCritical": false + }, + "fonts": true + }, "outputHashing": "all", "sourceMap": false, "extractCss": true, @@ -53,7 +61,14 @@ ] }, "staging": { - "optimization": true, + "optimization": { + "scripts": true, + "styles": { + "minify": true, + "inlineCritical": false + }, + "fonts": true + }, "outputHashing": "all", "sourceMap": false, "extractCss": true, @@ -71,7 +86,14 @@ ] }, "test": { - "optimization": true, + "optimization": { + "scripts": true, + "styles": { + "minify": true, + "inlineCritical": false + }, + "fonts": true + }, "outputHashing": "all", "sourceMap": false, "extractCss": true, diff --git a/src/app/workflow-spec-card/workflow-spec-card.component.html b/src/app/workflow-spec-card/workflow-spec-card.component.html index b60b0c0..05d5da1 100644 --- a/src/app/workflow-spec-card/workflow-spec-card.component.html +++ b/src/app/workflow-spec-card/workflow-spec-card.component.html @@ -15,7 +15,7 @@ -
+
ID
{{workflowSpec.id}}
Name
{{workflowSpec.name}}
Description
{{workflowSpec.description}}
diff --git a/src/app/workflow-spec-list/workflow-spec-list.component.html b/src/app/workflow-spec-list/workflow-spec-list.component.html index a3c9db1..89eaf9c 100644 --- a/src/app/workflow-spec-list/workflow-spec-list.component.html +++ b/src/app/workflow-spec-list/workflow-spec-list.component.html @@ -1,11 +1,11 @@ -
+

Workflow Specifications

-
- - @@ -20,7 +20,7 @@

Master Specification

- {{masterStatusSpec.display_name}} + {{masterStatusSpec.display_name}}
@@ -31,7 +31,7 @@

Libraries

- {{wfs.display_name}} + {{wfs.display_name}}