Commit Graph

913 Commits

Author SHA1 Message Date
Martin Stamm c4206a4d31 fix(replace): create new di on replace 2021-09-03 15:14:00 +02:00
Nico Rehwaldt f6d84696a9 test: verify label wiring
* import
* label updating (creation)
* label paste
2021-09-03 15:14:00 +02:00
Nico Rehwaldt f458c6833f test: increase timeout
Complex copy and paste test may otherwise timeout on GitHub actions.
2021-09-03 15:14:00 +02:00
Martin Stamm 5d30d576dc test: ensure that connectionDi exists 2021-09-03 15:14:00 +02:00
Martin Stamm 597c417dce chore: throw error when accessing DI from business object
Related to https://github.com/bpmn-io/bpmn-js/issues/1472
2021-09-03 15:14:00 +02:00
Martin Stamm 5589439774 feat: make elementFactory._getDefaultSize public
This has the benefit of using the public API method across our 
code base.
2021-09-03 15:14:00 +02:00
Martin Stamm ca8488b2c9 test: adjust to use `getDi` utility function
Related to https://github.com/bpmn-io/bpmn-js/issues/1472
2021-09-03 15:14:00 +02:00
Martin Stamm d19c4b0027 fix(import): pass context during collaboration import 2021-08-30 09:41:34 +00:00
Maciej Barelkowski 886da8924f test(modeling): add test for non-interrupting event replacement 2021-06-29 12:18:10 +00:00
Maciej Barelkowski b7fa6b934a test(bpmn-rules): verify CallActivity can connect with MessageFlow
Closes #1467
2021-06-25 10:33:40 +02:00
Maciej Barelkowski 2a60745991 Merge branch 'master' into develop 2021-06-02 08:53:22 +02:00
Maciej Barelkowski 7f1c0be591 fix(rules): disallow creating DataStoreReference if process is missing
Closes #1456
2021-05-31 18:31:39 +00:00
Maciej Barelkowski e0c4dea90d fix(modeling): append DataStoreReference to first available process
Related to #1456
2021-05-31 18:31:39 +00:00
Maciej Barelkowski 439bc4ead0 feat(modeling): use BPMN in Color for color setting
Additionally to custom bpmn.io properties, `modeling#setColor` will use
[BPMN in Color properties](https://github.com/bpmn-miwg/bpmn-in-color).
2021-05-27 12:43:53 +00:00
Maciej Barelkowski 4251e31af2 feat(bpmn-renderer): support displaying bpmn-in-color 2021-05-27 12:43:53 +00:00
Maciej Barelkowski 789e03afe6 test: support Promise as return value in `inject` 2021-05-17 12:04:05 +00:00
Maciej Barelkowski f120624580 Merge branch 'master' into develop 2021-05-06 16:06:04 +02:00
Martin Stamm b56604d5f3 fix(paste): don't insert multiple shapes on flow
closes #1440
2021-05-04 14:03:30 +00:00
Martin Stamm 1f0fdefe40 feat(message): show label on message flow
closes #777
2021-04-29 14:31:56 +02:00
Philipp Fromme 4806507936 feat: reconnect message flows when collapsing participant
Related to camunda/camunda-modeler#1651
2021-04-22 07:09:34 +00:00
Maciej Barelkowski d4078f1ab0 feat: replace elements on create
Closes #1340
2021-04-16 12:38:28 +00:00
Philipp Fromme c3e0d6d164 fix: copy root element references
Related to camunda/camunda-modeler#2185
2021-04-14 11:56:08 +00:00
KHADIR Tayeb 40f1d3af52 feat: enable connection tool for text annotation
fixes upstream camunda/camunda-modeler#2042
2021-04-07 11:51:22 +02:00
Nico Rehwaldt ca550a247a test(editor-actions): verify alignElements and distributeElements behavior 2021-03-04 18:22:51 +00:00
Nico Rehwaldt 58e1801f52 test: pacify PhantomJS 2021-03-03 23:50:44 +01:00
Nico Rehwaldt f7a4a3db7b style: pacify eslint 2021-03-03 23:45:11 +01:00
Nico Rehwaldt a7522ac5b1 test(Viewer): verify saveXML.done on no definitions loaded 2021-03-03 22:37:43 +00:00
Nico Rehwaldt 3567565514 fix(BaseViewer): always emit saveXML.done
This ensures we emit saveXML.done on error, too.
2021-03-03 22:37:43 +00:00
Nico Rehwaldt 6c02ecde34 fix(modeling): if we fix hover, we gotta fix out, too
This ensures our FixHoverBehavior (that ensures we drop onto /
connect to participants, not lanes) does fix the hover element
during *.out, too.

Otherwise there is no way for other behaviors to correctly
remove hover indicators.

Closes https://github.com/bpmn-io/bpmn-js/issues/1413
2021-01-28 11:11:27 +01:00
Niklas Kiefer 9b0f82dd47 fix(palette): activate globalConnect tool instead of toggling
This prevents unwanted move events when triggered from the palette action.

Closes #1402
2021-01-07 13:58:54 +00:00
Nico Rehwaldt 00294e2994 test: increase spec timeout 2021-01-06 12:57:36 +00:00
Nico Rehwaldt 8e863dad3d Merge branch 'master' into develop 2021-01-06 11:48:44 +01:00
Maximilian Trumpf 2e9f617911 fix(replace-menu): only allow cancel boundary events on transactions
related to camunda/camunda-modeler#2026
2021-01-05 07:27:08 +00:00
Nico Rehwaldt 44301d1830 chore: add <npm start> script
This script is the one stop utility that allows users to open a modeler
or viewer instance, directly within your browser.

Works via a custom launcher that openes the {KARMA_BASE}/debug.html
page in your default web browser.

Closes https://github.com/bpmn-io/bpmn-js/issues/1396
2020-12-21 22:43:43 +01:00
Nico Rehwaldt 5051420323 test(i18n): correctly disable during translation collection 2020-12-21 22:43:43 +01:00
Alexis Zeghers 5eff166135 feat(replace): add multiplicity marker to replace menu for participants
Closes #533
2020-12-11 06:59:20 +00:00
Niklas Kiefer 8faee2bde9 feat(replace-menu): update label of collapsed pool
* Indicate the action in a clearer, more standard-compliant way --> replaces an expanded pool with an empty "black box" + removing its content.
* We will not update the action identifier (`replace-with-collapsed-pool`) to avoid breaking changes.
* Make it possible to retrieve label via function

Related to camunda/camunda-modeler#2022
2020-12-07 10:33:27 +00:00
Alexis Zeghers 1ccba5c5e6 feat(replace): add switch between DataStore and DataObject in replace menu
Closes #1372
2020-12-03 11:01:38 +00:00
Nico Rehwaldt 00686dcb3b deps: update eslint + styles 2020-12-02 20:28:33 +00:00
Nico Rehwaldt 667d469f38 feat(modeling): provide generic moddle properties update API
Modeling#updateModdleProperties allows users to update moddle elements
that are backed up by diagram elements.

It provides us a path forward when we start to update more _hidden_
things from within the modeling canvas.
2020-11-19 14:24:59 +00:00
Alexis Zeghers 4b46f695ce feat(modeler): add toggle to mark a data object as a collection
Closes #381
2020-11-18 10:03:46 +00:00
Nico Rehwaldt 52c14a23d8 test(modeling): verify tooltip shown on failed create 2020-11-03 20:39:20 +00:00
Nico Rehwaldt 3d84aa486e test(Viewer): verify error on missing process/collaboration 2020-11-03 20:39:20 +00:00
Nico Rehwaldt 3ff287266c chore: resurrect translation reporter
This restores the translation reporter that allows us to extract
translations from the library, as we test it.
2020-11-03 20:39:20 +00:00
Niklas Kiefer a9ce32449a fix(rules): allow message boundary event as message flow target
Closes #1346
Related to camunda/camunda-modeler#1919
2020-09-14 14:07:13 +02:00
Maximilian Trumpf 90614dd99a feat(rules/bpmnRules): typed start event to none type on subProcess move
closes #831
2020-07-30 09:34:09 +02:00
Maximilian Trumpf 06ca742bc2 feat(popup-menu/replace): disallow replace typed event in subprocess 2020-07-30 09:34:09 +02:00
Maximilian Trumpf 8bc29e7f3e fix(bpmnRules): disallow boundaryEvents as message flow targets
closes #1300
2020-06-23 15:48:00 +02:00
Niklas Kiefer 949703aa08 feat(rules): allow starting connections from groups 2020-06-05 08:52:46 +00:00
Niklas Kiefer c7dcd6c77b test(rules): verify groups and text annotations can be connected
Related to #1327
2020-06-05 08:52:46 +00:00
Niklas Kiefer b7ad57e348 feat(context-pad): append text annotations on groups
Related to #1327
2020-06-05 08:52:46 +00:00
Oguz 157aec6ed6 feat(lib): deprecate import.parse.complete <context> payload
The <import.parse.complete> event is now invoked with

{
 error,
 definitions,
 elementsById,
 references,
 warnings
}

The old payload is deprecated:

{
  error,
  definitions,
  context: { elementsById, references, warnings }
}
2020-04-29 11:12:23 +02:00
Nico Rehwaldt 04ca31fac9 feat(lib): Promisify public APIs
This commit promisifies following APIs:

   BaseViewer#importXML
   BaseViewer#importDefinitions
   BaseViewer#open
   BaseViewer#saveXML
   BaseViewer#saveSVG
   Modeler#createDiagram

Related to https://github.com/bpmn-io/bpmn-js/issues/812

BREAKING CHANGES:

* Users are now expected to have Promises either by default or
polyfilled as the APIs return a Promise now.
2020-04-29 11:12:23 +02:00
Oguz 506321eafd chore(deps): update to bpmn-moddle v7.0.1
Adds awaitable import and export apis.

Related to https://github.com/bpmn-io/bpmn-js/issues/812
2020-04-29 11:12:23 +02:00
Philipp Fromme e03a4b2c59 chore(auto-place): move common feature to diagram-js
https://github.com/bpmn-io/dmn-js/issues/470
2020-04-16 11:36:12 +00:00
Maciej Barelkowski f1745547f0 feat(layouter): prefer straight layout for sub-process connections
Related to https://github.com/camunda/camunda-modeler/issues/1758
2020-04-08 11:14:46 +00:00
Philipp Fromme 7a67ff95b2 chore(documentation): fix JSDoc string types 2020-04-07 06:52:55 +00:00
Maciej Barelkowski aa58493872 test(modeling): verify attachment is not unnecessarily moved
Related to https://github.com/camunda/camunda-modeler/issues/1737
2020-04-01 13:52:58 +00:00
Maciej Barelkowski b9d237e300 test(modeling): verify re-layout of message flows when lane added
Related to #1289
Related to https://github.com/camunda/camunda-modeler/issues/655
2020-04-01 13:52:58 +00:00
Nico Rehwaldt 33f5f2d663 Merge branch 'master' into develop 2020-03-30 14:58:43 +02:00
Maciej Barelkowski 6bfecfa71e test(popup-menu): verify if linked events have name 2020-03-30 11:36:08 +02:00
Nico Rehwaldt bf436bef1e feat(replace): create bpmn:LinkEventDefinition with empty name
Closes https://github.com/bpmn-io/bpmn-js/issues/1296
2020-03-30 11:36:08 +02:00
Nico Rehwaldt 960a085d4c fix(modeling): do not resize label target when setting empty label
This prevents a bug that cause the label target to be accidentally
resized if the user updates the label value to an empty string (or null).

Closes #1294
2020-03-30 07:53:16 +00:00
Maciej Barelkowski c2ded3952f test(popup-menu): verify if linked events have name 2020-03-27 07:23:12 +00:00
Nico Rehwaldt 95b50f08a7 feat(replace): create bpmn:LinkEventDefinition with empty name
Closes https://github.com/bpmn-io/bpmn-js/issues/1296
2020-03-27 07:23:12 +00:00
Maciej Barelkowski d48812766f Merge branch 'master' into develop 2020-03-16 13:24:50 +01:00
Maciej Barelkowski 7696534f22 fix(modeling): save bpmndi as drawn on the diagram
Related to https://github.com/camunda/camunda-modeler/issues/1326

Closes #985
2020-03-16 12:24:05 +00:00
Maciej Barelkowski 62f331bc3d Merge branch 'master' into develop 2020-03-13 14:15:14 +01:00
Philipp Fromme b4eff93580 chore(space-tool): add tests for participant without lanes 2020-03-13 07:56:38 +00:00
Philipp Fromme dafa6f138c fix(space-tool): consider lanes when resizing participant
Related to camunda/camunda-modeler#1703
2020-03-13 07:56:38 +00:00
Philipp Fromme e4e789bd3e fix(label-editing): resize empty text annotations on complete
Related to bpmn-io/diagram-js-direct-editing#12
2020-03-10 14:35:39 +01:00
Nico Rehwaldt 368f9e14b5 fix(modeling): make AddLaneHandler recognize top-level labels
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 14:50:37 +01:00
Nico Rehwaldt d902a970e8 fix(modeling): update AddLaneHandler to new spaceTool API
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 14:50:37 +01:00
Maciej Barelkowski 53e7198a47 fix(modeling): assign id prefix matching element type
Closes #1285
2020-03-09 09:54:35 +00:00
Nico Rehwaldt ffa0a88d30 fix(modeling): update AddLaneHandler to new spaceTool API
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 10:48:05 +01:00
Nico Rehwaldt 039f4a0273 Merge branch 'master' into develop 2020-03-02 14:20:02 +01:00
Nico Rehwaldt 707257e020 fix(copy-paste): emit <moddleCopy.canSetCopiedProperty> with existing property 2020-03-02 13:08:42 +00:00
Nico Rehwaldt 98bc96caac test(Viewer): move missing diagram spec 2020-02-10 19:33:50 +01:00
Nico Rehwaldt 89f1699bc0 Merge branch 'master' into develop 2020-02-07 10:46:52 +01:00
Niklas Kiefer 566f0eadaa fix(import): set <isFrame> property on import
Closes #1278
2020-02-07 10:45:02 +01:00
Nico Rehwaldt 483a607631 test(modeling): add special space tool case 2020-02-06 13:47:32 +01:00
Nico Rehwaldt c5402c211d test(modeling): invert test case 2020-02-06 13:47:32 +01:00
Nico Rehwaldt cb5098242d test(space-tool): rewrite and improve specs 2020-02-06 13:47:32 +01:00
Philipp Fromme 50630c7aac fix(label-behavior): do not move labels if labelBehavior=false 2020-02-06 13:47:32 +01:00
Philipp Fromme 7ee304f424 feat(space-tool): ensure minimum size when resizing shapes 2020-02-06 13:47:32 +01:00
Maciej Barelkowski 035bb0c1fd feat(modeling): create generic ids for new elements
This makes sure that the semantic ID prefix reflects
the common type of all replace options.

ID prefixes for elements will match the examples:
  * `bpmn:ServiceTask` => `Activity_<id_suffix>`
  * `bpmn:EndEvent` => `Event_<id_suffix>`
  * `bpmn:EventBasedGateway` => `Gateway_<id_suffix>`
  * `bpmn:SequenceFlow` => `Flow_<id_suffix>`

Related to https://github.com/camunda/camunda-modeler/issues/1654
2020-02-06 13:43:04 +01:00
Maciej Barelkowski 9e31327335 feat(modeling/copy-paste): copy message referenced by SendTask
Related to https://github.com/camunda/camunda-modeler/issues/1637
2020-01-31 10:10:01 +00:00
Maciej Barelkowski dcc6d1ca94 feat(modeling/copy-paste): copy message referenced by ReceiveTask
Related to https://github.com/camunda/camunda-modeler/issues/1637
2020-01-31 10:10:01 +00:00
Maciej Barelkowski dc5a566e10 fix(modeling/copy-paste): copy referenced message if not present
Related to https://github.com/camunda/camunda-modeler/issues/1639
2020-01-31 06:36:23 +00:00
Nico Rehwaldt 82a250b014 fix(modeling): keep non-duplicate outgoing connection when dropping on flow
Closes https://github.com/bpmn-io/bpmn-js/issues/1263
2020-01-15 14:29:10 +00:00
Nico Rehwaldt cbbab12e21 test(replace): verify reconnect behavior on replace with different bounds
This ensures that we leave no dangling incoming / outgoing message flows
after replacing an expanded pool with a collapsed one.
2020-01-15 08:19:30 +00:00
Nico Rehwaldt 14eeba897d Merge branch 'master' into develop 2020-01-09 16:54:06 +01:00
Nico Rehwaldt 4a675b3780 fix(rules): allow associations where data associations are allowed, too
Related to https://github.com/camunda/camunda-modeler/issues/1635
2020-01-02 09:23:14 +00:00
Nico Rehwaldt 31b813097b test(modeling): verify moving associations 2020-01-02 09:23:14 +00:00
Maciej Barelkowski b2179bd489 test(snapping): simplify test case 2019-12-17 10:36:44 +00:00
Oguz Eroglu 27fec8bdf1 fix(snapping): snap origins of docking points on create
Related to: https://github.com/camunda/camunda-modeler/issues/1612
2019-12-17 10:36:44 +00:00
Nico Rehwaldt d6ab00783a Merge branch 'master' into develop 2019-12-16 10:55:28 +01:00
Niklas Kiefer 8efb20c03e fix(context-pad): do not open replace menu if context pad not open
Related to camunda/camunda-modeler#1613
2019-12-16 09:49:37 +00:00
Nico Rehwaldt d6adc51ddd test(modeling): make move stress test runnable again 2019-12-12 23:25:39 +01:00
Philipp Fromme 477217c891 feat(copy-paste): copy error, escalation, message and signal references
* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
2019-12-11 23:08:14 +01:00