654fa067d4
test(modeling): verify re-connect preview layout
2019-05-17 11:15:06 +02:00
82dbcc9451
test(modeling/behavior): remove unnecessary sinon usage
2019-05-16 15:25:15 +02:00
05fea05834
feat(modeling): prevent expanded subprocess overlap of previous content
...
This covers two scenarios:
1. When a shape is replaced with an expanded subprocess
2. When a subprocess is toggled from collapsed to expanded
Only when:
1. There are incoming sequence flows (previous content)
2. There are no outgoing sequence flows (following content)
2019-05-15 16:57:32 +02:00
2bdb36919d
test(modeling): verify connection preview layout
2019-05-09 14:12:37 +00:00
2335282a82
fix(bpmn-create-connect-preview): override #getConnection
2019-05-09 14:12:37 +00:00
48fcececbf
test(layout): add integration test for connection preview
2019-05-08 12:59:27 +00:00
883d6c8ad3
test(ResizeShape): add test coverage
...
* Restructure tests to make them more clear
* Add tests for businessObject updates (especially groups)
2019-05-07 14:36:32 +02:00
424a05a18a
feat(modeling): correctly handle event based gateway connections
...
Handles two new scenarios:
1. A user wants to connect an event-based gateway to an event-based
gateway target with existing incoming sequence flows. The existing
sequence flows are removed before connecting the new one.
2. A user wants to replace a gateway, that is already connected to
event-based gateway targets, with an event-based gateway. The existing
incoming sequence flows of the targets, which do not belong to the
newly replaced event-based gateway, are removed before the replacement
operation finishes.
This is because target elements in an event gateway configuration
must not have any additional incoming sequence flows other than
that from the event gateway.
2019-05-06 12:41:11 +02:00
b6e9c2186a
fix(BpmnRules): update canConnectSequenceFlow()
...
This prevents multiple incoming sequence flows to target events of an
event-based gateway when the connection source is not an event-based
gateway.
2019-05-06 12:41:11 +02:00
2935b23ee4
test(modeling/behavior): reorganize label positioning behavior specs
2019-04-25 16:27:58 +02:00
06ffc9d407
fix(modeling/BpmnLayouter): properly lay out boundary event connections
...
Closes #891
2019-04-24 11:56:01 +00:00
a40b95cf2f
test(modeling): verify connection layouting on element removal
...
Closes #989
2019-04-18 18:15:31 +02:00
55ca4c8f3d
chore(modeling/label): adjust label position to laid out connection
...
Closes #718
2019-04-18 16:06:44 +00:00
6c191590b5
test(modeling/layout): expect layout on reconnect end
2019-04-18 16:06:44 +00:00
6a396fb947
test(modeling/layout): add integration test for reconnection
2019-04-18 16:06:44 +00:00
8eced8a3fb
test(modeling): ensure layout is done after element removal
...
* adjust test suite to pass with diagram-js@3.2
* verify new cropping behavior
* verify #940 is fixed
2019-04-10 19:08:49 +00:00
6f7925080c
chore(modeling/BpmnUpdater): remove now unnecessary crop on reconnect
...
As of diagram-js@3.2.0 layouting will be triggered
on reconnectStart / reconnectEnd.
Related to #940
2019-04-10 19:08:49 +00:00
fe9d4ff06d
feat(modeling): ensure wrapping DataInput/Output in participant works
2019-03-29 13:21:34 +00:00
8c49cb679b
fix(modeling): properly handle DataInput / DataOutput move
...
Closes #961
2019-03-29 13:21:34 +00:00
4c270a01e4
test(Modeler): add data input / output editing spec
2019-03-26 11:55:36 +01:00
0a9efb793b
test(modeling/behavior): localize test diagram
2019-03-12 08:56:03 +00:00
39d4f1c57e
feat(modeling): set isHorizontal=true for partipant/lane DIs
...
Closes #934
2019-01-31 10:46:16 +00:00
6d54ff34e3
chore(boundary-event-behavior): clean up tests
2018-10-17 14:31:40 +00:00
178e1cfccb
fix(modeling/behaviors): add a behavior that deletes attached boundaries after replacing a gateway with an event based gateway
2018-10-17 13:12:31 +00:00
b3e4b1dc1f
fix(modeling/behaviors): add behavior for deleting boundaries on receive tasks after connecting to event based gateway
2018-10-16 10:53:57 +00:00
898a0fa9c8
fix(modeling/DropOnFlowBehavior): filter redundant connections
...
This prevents duplicate flows from being created, accidentially.
Closes #774
2018-07-25 11:10:51 +02:00
e637a8e57b
feat(modeling/BpmnLayouter): layout Element -> Element loops
...
Closes #824
2018-07-13 10:29:00 +02:00
220c0a73f3
feat(modeling/BpmnLayouter): handle boundary events
...
This adds proper connection layouting for sequence
flows leaving from boundary events.
If needed, such connections will be layoute with
an U-turn.
Closes #467
2018-07-13 10:16:11 +02:00
4806938600
feat(modeling): create label at appropriate position
...
This re-introduces adaptive label positioning
on label creation as a feature.
It worked before but broke during the introduction
of optional labels.
Closes #825
2018-07-11 13:26:43 +02:00
15596ef97c
test(modeling): verify correct label adjustment
2018-07-11 13:10:18 +02:00
abbe54912f
test(modeling): correct test cases
...
Ensure the test cases are not affected by accidential
automatic label adjumstment (TM).
2018-07-11 13:09:40 +02:00
300e7010c4
fix(modeling): correct DataStoreBehavior updating multiple stores
2018-06-18 09:21:18 +02:00
5cc28d5d55
fix(modeling): apply DataStoreBehavior in collaboration only
...
* updating parents of datastores in the root is only
necessary when deleting a subprocess in a collaboration
Related to camunda/camunda-modeler#823
2018-06-13 13:48:39 +02:00
100f3fb2ee
fix(label-behavior): text annotation resizing after text property change
...
Depends on bpmn-io/diagram-js#259
Related to camunda/camunda-modeler#631
2018-06-13 11:02:55 +02:00
6c081d854f
chore(label-editing): remove businessObject name on empty text
...
The following two actions will now unset the
business objects name property:
* deleting external label
* entering empty text via direct editing
2018-06-11 11:39:08 +02:00
a7a1743df0
fix(modeling): properly cascade label deletion
...
Ensure we execute the following nicely:
* unset name -> remove label shape
* remove label shape -> unset name
2018-06-11 11:39:08 +02:00
4a0f6da814
fix(label-behavior): properly check for name property change
...
Related to camunda/camunda-modeler#824
2018-06-06 13:35:57 +02:00
891cf4ac0c
feat(draw+modeling): support lineHeight
...
* take numeric line height into account when
rendering text labels
* take line height into account when directly
editing labels
* use default line height of 1.2 for text rendering
Closes #803
2018-05-29 11:58:15 +02:00
b1a4e08ddd
feat(modeling): assign ID when creating bpmn:LaneSet
2018-05-28 09:55:30 +02:00
7537757357
feat(labels): labels can be deleted
...
Related to camunda/camunda-modeler#243
2018-05-24 16:22:51 +02:00
690417b389
feat(modeling): allow data store anywhere in collaboration
...
ensure valid BPMN 2.0 parent when
* creating/moving data store
* removing participant
* turning process into collaboration
* turning collaboration into process
Closes #483
2018-05-17 15:09:37 +02:00
0f62183410
test(modeling): verify missing bpmndi:BPMNLabel update behavior
2018-05-17 14:57:54 +02:00
b98dd6fe95
fix(modeling): correctly handle missing bpmndi:Label bounds
...
Closes #794
2018-05-17 14:57:54 +02:00
327eb90140
style(tests): use not.to matchers
...
...in favor of to.not.
2018-05-03 16:37:24 +02:00
9be61259bd
chore(project): drop 'use strict'
...
We use ES modules, so 'use strict' is not necessary anymore.
2018-04-03 18:09:53 +02:00
d3449ca87c
chore(project): es6ify source code
...
* use ES6 import / export
* UTILS: export individual utilities
* TESTS: localize TestHelper includes
BREAKING CHANGE:
* all utilities export independent functions
* library sources got ported to ES6. You must now use
a ES module bundler such as Browserify + babelify or
Webpack to consume this library (or parts of it).
2018-04-03 16:32:14 +02:00
bec8d06e08
chore(project): fix typos introduced
2018-03-22 12:43:36 +01:00
11f5a22471
chore(project): adjust min-dash usage (2)
2018-03-22 11:59:39 +01:00
245d1d6a96
chore(project): upgrade lodash to min-dash
2018-03-22 11:59:39 +01:00
e8e5e2ced9
chore(project): update to min-dom@2
2018-03-22 00:54:59 +01:00
b03014fc2c
chore(project): update to new lint style
2018-02-27 10:08:31 +01:00
19e4e19bb5
chore(project): migrate to new SECTION comments
2018-02-27 09:57:22 +01:00
de63fd49a3
style(tests): reformat DropOnFlowBehaviorSpec
2018-02-14 22:20:11 +01:00
f5afc732fe
fix(drop-on-flow): don't insert on accidentally found intersection
...
Related to camunda/camunda-modeler#727
2018-02-14 22:15:33 +01:00
cbb2f9f600
fix(modeling): correct DI updating
...
Don't assign <di> property to businessObject; will
be serialized as di="[Object...]" otherwise.
Closes #756
2018-01-31 12:22:31 +01:00
953574eefb
style(tests): reformat UpdatePropertiesSpec
...
* line width = 80
2018-01-31 12:06:17 +01:00
38bff969ac
chore(tests): reformat color tests
2018-01-30 13:15:41 +01:00
f1daf4841f
fix(modeling): support newBounds
...
This fixes a bug where Modeling#updateLabel would not work on
text annotations, because these need to have labels pre-configured.
* Modeling#updateLabel now takes the (optional) newBounds
* newBounds must now explicitly be passed to trigger resize
for text annotations
* newBounds is _only_ passed for text annotations via
LabelEditingProvider (it was discarded before anyway)
* lib/features/label-editing did not depend on lib/features/modeling
for historical reasons. It now uses the offical #updateLabel
API provided by Modeling
* Localize test diagrams
Closes #753
2018-01-29 17:20:41 +01:00
d32da90013
chore(lint): bump eslint
...
...and fix lint errors
2018-01-28 20:35:04 +01:00
37a06a378d
chore(tests): use absolute lib requires
2018-01-24 11:41:21 +01:00
11354e951c
chore(project): migrate to new attach related Modeling APIs
...
Related to bpmn-io/diagram-js#242
BREAKING CHANGE:
* as documented in bpmn-io/diagram-js#242 a few modeling APIs changed;
users of these APIs must adapt accordingly.
2017-12-22 10:32:54 +01:00
2218b84af6
test(modeling): verify connection move behavior
...
Closes to #511
2017-12-14 23:42:02 +01:00
1333479815
fix(modeling/behavior): round label move adjustment
...
Ensure we don't return floating point numbers for conection label
adjustments calculated on connection changes.
2017-12-13 14:21:19 +01:00
a708a1cd4e
chore(tests): adapt bendpoint tests to new cropping
...
Related to #684
2017-12-13 14:20:40 +01:00
869e484601
chore(tests): use have.waypoints helper
2017-12-13 13:25:51 +01:00
f24b21684d
test(cropping): add stress test
...
Related to #684
2017-12-13 13:25:51 +01:00
5761e01ffe
feat(modeling): adjust label location based on free space
...
Reacts on connection create, layout, reconnect and waypoint
update to find a suitable place for the label and reposition it.
Closes #738
2017-12-11 15:40:40 +01:00
e7da5af0a1
chore(tests): depend on move module, where used
...
Tests would otherwise break in the future.
Related to bpmn-io/diagram-js#152
2017-12-10 23:04:11 +01:00
f05ad02198
feat(layout): filter redundant connection waypoints
2017-12-10 12:29:54 +01:00
7ffb865023
chore(project): consistent async error handling
...
Async utilities properly propagate _all_ errors to the
specified _done_ callback. Failing in _done_ does not
re-invoke it.
Adjustments made in
* Viewer#importXML
* Viewer#saveSVG
* Importer#importBpmnDiagram
Tests cleaned up to remove un-necessary `if (err) { ...` snippets.
2017-12-09 22:31:15 +01:00
105f326dad
chore(project): bump bpmn-moddle dependency
...
* unused namespace does not get serialized anymore
Closes #469
2017-12-09 22:30:56 +01:00
58207e7db2
feat(DropOnFlowBehavior): drop existing elements on flows
...
Closes #695
2017-07-27 15:15:08 +02:00
b1a544b84f
fix(dropOnFlowBehavior): ignore drop point if bendpoint is inside shape
...
Closes #696
2017-07-27 13:41:50 +02:00
e797d9c142
feat(label-editing): improve text annotation editing
...
Related to camunda/camunda-modeler#564
2017-07-25 15:05:35 +02:00
83f55b1fb1
fix(modeling): handle label layouting edge case
...
Related to #669
2017-05-03 15:02:52 +02:00
7d896855a9
fix(modeling): correct label line attachments not being recognized
...
* remove rounding where it does not matter
* work around some precision errors in logic
* adjust test cases (to higher precision)
Closes #669
2017-05-03 15:02:52 +02:00
8d536f2cce
style(modeling): reformat test case
2017-03-21 09:01:42 +01:00
2fd46ac294
fix(modeling/layout): handle zero-length lines during adjustment
...
Closes #669
2017-03-21 09:01:21 +01:00
12d700fd14
fix(drop-on-flow): disallow drop on flow label
...
Closes camunda/camunda-modeler#548
2017-03-10 12:47:23 +01:00
79e8378db0
fix(label-support): fix positioning of label created on shape create
...
* make sure label shape is created with correct size
* make sure test varifies behaviour
Closes camunda/camunda-modeler#535
2017-03-07 15:22:43 +01:00
c5f48f5cd1
test(modeling): pass on Arch Linux
2017-03-02 11:53:42 +01:00
d1072471c4
fix(drop-on-sequence-flow): ensure correct behaviour
...
Closes #667
2017-03-02 11:45:34 +01:00
81de98f786
feat(bpmn-renderer): use updated text util api
...
Related to bpmn-io/diagram-js#205
2017-03-02 10:55:40 +01:00
def402971c
feat(modeling): add move onto sequence flow
...
This adds the ability to move flow nodes onto existing
sequence flows (similar to the create on flow behavior
implemented with an earlier bpmn-js release).
Closes camunda/camunda-modeler#432
2017-01-27 15:31:26 +01:00
a2f33b8e93
feat(modeling): add API for setting fill/stroke color
...
Closes #629
2016-12-05 17:01:04 +01:00
404c35c97f
fix(BpmnRenderer): revert text annotations automatic content fitting
...
This reverts commit a53562e1d5Closes #635
2016-12-01 13:27:30 +01:00
a53562e1d5
feat(BpmnRenderer): text annotations automatically fit their content
...
Closes #600
2016-11-09 08:23:34 +01:00
5916e81222
chore(test): rework positioning test cases
2016-11-01 15:20:22 +01:00
c111bea876
fix(label-bounds): fix failing test case
2016-11-01 15:20:22 +01:00
db0ce65aa4
feat(graphics): remove snapsvg
...
Related to bpmn-io/diagram-js#50
2016-11-01 15:20:22 +01:00
2c7aad5e0b
feat(modeling/BpmnUpdater): update existing (source/target)Element in di
...
Closes #620
2016-11-01 10:43:08 +01:00
ccd5eeb758
fix(bpmn-updater): keep default flow when reconnecting sequence flow end
...
Closes #619
2016-10-19 11:10:11 +02:00
f4023cf321
fix(draw/BpmnRenderer): ensure labels keep position if width doesn't change
...
* adjust positioning tests to pass on Arch Linux
Closes #613
2016-10-07 14:06:28 +02:00
9010554282
chore(test): adjust existing test cases related to labels
...
Related to #601
2016-09-02 16:43:26 +02:00
c13ac91e94
feat(BpmnRenderer): align label size/position to text during rendering
...
Closes #601
2016-09-02 16:43:23 +02:00
a8cf097ed0
feat(modeling): retain waypoints with connection on shape deletion
...
When keeping the connection when the intermittant element,
make sure we keep the waypoints, too.
closes #581
2016-08-23 17:13:25 +02:00
91cfcd9bac
fix(modeling): handle float bendpoints in label behavior
...
* silently round all values when doing circle-line intersection
closes #602
2016-08-10 13:14:56 +02:00
226a0d76ed
feat(replace): properly collapse / expand SubProcess(es)
...
* correctly toggle collapse / expand state
* update children visibility
Closes #575
Closes #510
review(collapse-expand)
2016-08-09 11:33:59 +02:00
b881ca8086
fix(modeling): handle non-integer waypoints in LabelBehavior
...
* verify space tool / label layouting behavior
Closes #590
2016-07-14 08:54:45 +02:00
6c77e23692
fix(modeling): do not layout hidden labels
...
closes #587
2016-07-05 17:19:13 +02:00
Maciej Barelkowski
Gustavo E. Jimenez Folta
Philipp Fromme
Niklas Kiefer
Nico Rehwaldt
TheSharpieOne Bot
pedesen
Philipp Fromme
Nico Rehwaldt
Ricardo Matias
hoferch91
Jan Stümmel