Commit Graph

858 Commits

Author SHA1 Message Date
Maciej Barelkowski f1745547f0 feat(layouter): prefer straight layout for sub-process connections
Related to https://github.com/camunda/camunda-modeler/issues/1758
2020-04-08 11:14:46 +00:00
Philipp Fromme 7a67ff95b2 chore(documentation): fix JSDoc string types 2020-04-07 06:52:55 +00:00
Maciej Barelkowski aa58493872 test(modeling): verify attachment is not unnecessarily moved
Related to https://github.com/camunda/camunda-modeler/issues/1737
2020-04-01 13:52:58 +00:00
Maciej Barelkowski b9d237e300 test(modeling): verify re-layout of message flows when lane added
Related to #1289
Related to https://github.com/camunda/camunda-modeler/issues/655
2020-04-01 13:52:58 +00:00
Nico Rehwaldt 33f5f2d663 Merge branch 'master' into develop 2020-03-30 14:58:43 +02:00
Maciej Barelkowski 6bfecfa71e test(popup-menu): verify if linked events have name 2020-03-30 11:36:08 +02:00
Nico Rehwaldt bf436bef1e feat(replace): create bpmn:LinkEventDefinition with empty name
Closes https://github.com/bpmn-io/bpmn-js/issues/1296
2020-03-30 11:36:08 +02:00
Nico Rehwaldt 960a085d4c fix(modeling): do not resize label target when setting empty label
This prevents a bug that cause the label target to be accidentally
resized if the user updates the label value to an empty string (or null).

Closes #1294
2020-03-30 07:53:16 +00:00
Maciej Barelkowski c2ded3952f test(popup-menu): verify if linked events have name 2020-03-27 07:23:12 +00:00
Nico Rehwaldt 95b50f08a7 feat(replace): create bpmn:LinkEventDefinition with empty name
Closes https://github.com/bpmn-io/bpmn-js/issues/1296
2020-03-27 07:23:12 +00:00
Maciej Barelkowski d48812766f Merge branch 'master' into develop 2020-03-16 13:24:50 +01:00
Maciej Barelkowski 7696534f22 fix(modeling): save bpmndi as drawn on the diagram
Related to https://github.com/camunda/camunda-modeler/issues/1326

Closes #985
2020-03-16 12:24:05 +00:00
Maciej Barelkowski 62f331bc3d Merge branch 'master' into develop 2020-03-13 14:15:14 +01:00
Philipp Fromme b4eff93580 chore(space-tool): add tests for participant without lanes 2020-03-13 07:56:38 +00:00
Philipp Fromme dafa6f138c fix(space-tool): consider lanes when resizing participant
Related to camunda/camunda-modeler#1703
2020-03-13 07:56:38 +00:00
Philipp Fromme e4e789bd3e fix(label-editing): resize empty text annotations on complete
Related to bpmn-io/diagram-js-direct-editing#12
2020-03-10 14:35:39 +01:00
Nico Rehwaldt 368f9e14b5 fix(modeling): make AddLaneHandler recognize top-level labels
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 14:50:37 +01:00
Nico Rehwaldt d902a970e8 fix(modeling): update AddLaneHandler to new spaceTool API
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 14:50:37 +01:00
Maciej Barelkowski 53e7198a47 fix(modeling): assign id prefix matching element type
Closes #1285
2020-03-09 09:54:35 +00:00
Nico Rehwaldt ffa0a88d30 fix(modeling): update AddLaneHandler to new spaceTool API
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 10:48:05 +01:00
Nico Rehwaldt 039f4a0273 Merge branch 'master' into develop 2020-03-02 14:20:02 +01:00
Nico Rehwaldt 707257e020 fix(copy-paste): emit <moddleCopy.canSetCopiedProperty> with existing property 2020-03-02 13:08:42 +00:00
Nico Rehwaldt 98bc96caac test(Viewer): move missing diagram spec 2020-02-10 19:33:50 +01:00
Nico Rehwaldt 89f1699bc0 Merge branch 'master' into develop 2020-02-07 10:46:52 +01:00
Niklas Kiefer 566f0eadaa fix(import): set <isFrame> property on import
Closes #1278
2020-02-07 10:45:02 +01:00
Nico Rehwaldt 483a607631 test(modeling): add special space tool case 2020-02-06 13:47:32 +01:00
Nico Rehwaldt c5402c211d test(modeling): invert test case 2020-02-06 13:47:32 +01:00
Nico Rehwaldt cb5098242d test(space-tool): rewrite and improve specs 2020-02-06 13:47:32 +01:00
Philipp Fromme 50630c7aac fix(label-behavior): do not move labels if labelBehavior=false 2020-02-06 13:47:32 +01:00
Philipp Fromme 7ee304f424 feat(space-tool): ensure minimum size when resizing shapes 2020-02-06 13:47:32 +01:00
Maciej Barelkowski 035bb0c1fd feat(modeling): create generic ids for new elements
This makes sure that the semantic ID prefix reflects
the common type of all replace options.

ID prefixes for elements will match the examples:
  * `bpmn:ServiceTask` => `Activity_<id_suffix>`
  * `bpmn:EndEvent` => `Event_<id_suffix>`
  * `bpmn:EventBasedGateway` => `Gateway_<id_suffix>`
  * `bpmn:SequenceFlow` => `Flow_<id_suffix>`

Related to https://github.com/camunda/camunda-modeler/issues/1654
2020-02-06 13:43:04 +01:00
Maciej Barelkowski 9e31327335 feat(modeling/copy-paste): copy message referenced by SendTask
Related to https://github.com/camunda/camunda-modeler/issues/1637
2020-01-31 10:10:01 +00:00
Maciej Barelkowski dcc6d1ca94 feat(modeling/copy-paste): copy message referenced by ReceiveTask
Related to https://github.com/camunda/camunda-modeler/issues/1637
2020-01-31 10:10:01 +00:00
Maciej Barelkowski dc5a566e10 fix(modeling/copy-paste): copy referenced message if not present
Related to https://github.com/camunda/camunda-modeler/issues/1639
2020-01-31 06:36:23 +00:00
Nico Rehwaldt 82a250b014 fix(modeling): keep non-duplicate outgoing connection when dropping on flow
Closes https://github.com/bpmn-io/bpmn-js/issues/1263
2020-01-15 14:29:10 +00:00
Nico Rehwaldt cbbab12e21 test(replace): verify reconnect behavior on replace with different bounds
This ensures that we leave no dangling incoming / outgoing message flows
after replacing an expanded pool with a collapsed one.
2020-01-15 08:19:30 +00:00
Nico Rehwaldt 14eeba897d Merge branch 'master' into develop 2020-01-09 16:54:06 +01:00
Nico Rehwaldt 4a675b3780 fix(rules): allow associations where data associations are allowed, too
Related to https://github.com/camunda/camunda-modeler/issues/1635
2020-01-02 09:23:14 +00:00
Nico Rehwaldt 31b813097b test(modeling): verify moving associations 2020-01-02 09:23:14 +00:00
Maciej Barelkowski b2179bd489 test(snapping): simplify test case 2019-12-17 10:36:44 +00:00
Oguz Eroglu 27fec8bdf1 fix(snapping): snap origins of docking points on create
Related to: https://github.com/camunda/camunda-modeler/issues/1612
2019-12-17 10:36:44 +00:00
Nico Rehwaldt d6ab00783a Merge branch 'master' into develop 2019-12-16 10:55:28 +01:00
Niklas Kiefer 8efb20c03e fix(context-pad): do not open replace menu if context pad not open
Related to camunda/camunda-modeler#1613
2019-12-16 09:49:37 +00:00
Nico Rehwaldt d6adc51ddd test(modeling): make move stress test runnable again 2019-12-12 23:25:39 +01:00
Philipp Fromme 477217c891 feat(copy-paste): copy error, escalation, message and signal references
* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
2019-12-11 23:08:14 +01:00
Niklas Kiefer 3ad47af299 Merge branch 'master' into develop 2019-12-11 14:55:38 +01:00
Nico Rehwaldt bb94b206a7 feat(project): provide Base{Viewer|Modeler} distributions
This allows users to use the viewer / modeler features without
inheriting our modules.

Related to #258
2019-12-11 13:28:35 +01:00
Niklas Kiefer 9f8a724e9a fix(modeling): do not crop waypoints on pasting
Related to camunda/camunda-modeler#1611
2019-12-11 11:18:54 +00:00
Nico Rehwaldt 74411387a4 test(project): update test diagrams (namespace only) 2019-12-11 10:52:43 +00:00
Nico Rehwaldt b4b5d1d139 fix(modeling): correct creation of nested lanes
With diagram-js@5 we've introduced the CreateBehavior that ensures
elements are not created on top of lanes but always on top of the actual
participant.

Unfortunately we forgot about the fact that lanes are created once in a
while, too.

This commit accounts for this fact and ensures we do not adjust the
parent of to-be-created lanes.

(A test cases for splitting nested lanes did not exist until now).

Closes #1254
Closes #1253
2019-12-11 10:52:43 +00:00
Nico Rehwaldt c8eedf959f test(project): verify flowNodeRefs updating 2019-12-11 10:52:43 +00:00
Philipp Fromme 448a8250ab Merge branch 'master' into develop 2019-12-09 12:54:24 +01:00
Nico Rehwaldt 1b576cda17 test(project): make sinon an allowed global 2019-12-09 12:52:35 +01:00
Nico Rehwaldt a66e9a5c8d test(copy-paste): assert elements.changed behavior 2019-12-09 12:52:35 +01:00
Nico Rehwaldt a1be2ea631 test(project): register BpmnJS in integration tests 2019-12-09 08:32:04 +00:00
Nico Rehwaldt 4455c3fc35 fix(modeling/behavior): hook UpdateFlowNodeRefs behavior in on elements.create 2019-12-06 15:24:54 +00:00
Nico Rehwaldt d769e6ddb0 fix(grid-snapping): do not update waypoints on multiple create
Related to https://github.com/camunda/camunda-modeler/issues/1617
2019-12-06 15:24:54 +00:00
Philipp Fromme b2b607f558 fix(adaptive-label-positioning): do not adjust on paste
Related to camunda/camunda-modeler#1617
2019-11-29 20:38:16 +00:00
Nico Rehwaldt 748674fb35 fix(modeling): correctly fix hover on cleanup, too
Related to #1599
2019-11-25 17:42:58 +00:00
Nico Rehwaldt 6527e7d116 fix(draw): render colored BPMN group elements
Related to https://github.com/camunda/camunda-modeler/issues/1598
2019-11-25 14:44:43 +00:00
Philipp Fromme c8559cd4d9 chore(element-factory): fix test description 2019-11-20 15:53:53 +01:00
Philipp Fromme 8722b6e3c2 fix(element-factory): use BPMN factory to ensure IDs
Closes #1162
2019-11-20 14:41:09 +00:00
Philipp Fromme ec13d8e7b8 chore(copy-paste): add failing test case verifying #798
Failing test case was removed during refactoring.

Related to #798.
2019-11-19 23:54:12 +01:00
Philipp Fromme c8412c27f2 fix(modeling): update association parent on source or target move
Closes #683
2019-11-19 15:27:56 +00:00
Nico Rehwaldt e9687562d0 test(popup-menu): further simplify ReplaceMenuProviderSpec 2019-11-18 16:10:10 +00:00
Philipp Fromme 06e1478fc8 chore(rules): remove <connection.reconnectStart/End> rule 2019-11-18 13:38:19 +01:00
Philipp Fromme 1fa167088c feat(hover-fix): fix hover
* fix start instead of source
2019-11-18 13:38:19 +01:00
Philipp Fromme ca53ab56bb feat(modeling): replace connection on reconnect 2019-11-18 13:38:19 +01:00
Philipp Fromme ef5a72d722 Merge branch 'master' into develop 2019-11-18 11:03:25 +01:00
Philipp Fromme fe11c2ee78 fix(modeling): unclaim ID on shape/connection delete
* unclaim ID of deleted shapes and connections
* unclaim ID of referenced processes when deleting participant
* this does NOT ensure we unclaim IDs of elements like DI, events, errors, ...

Related to camunda/camunda-modeler#1503
Related to #608
2019-11-18 09:57:51 +01:00
Philipp Fromme dd3a139a29 fix(replace): do not resize on replace sub process with ad hoc
Requires bpmn-io/diagram-js#432
Closes #1231
2019-11-15 14:04:08 +01:00
Maciej Barelkowski 7041a1ab9b test(popup-menu): remove dependency on internals 2019-11-13 10:26:21 +01:00
Philipp Fromme e68978bf66 fix(bpmn-renderer): properly escape marker ids
Only characters and numbers are allowed. Anything else will be escaped.

Closes #1209
2019-11-07 21:58:09 +00:00
Oguz Eroglu 64d360575b fix(modeling): skip moving if label is not yet created.
Related to https://github.com/zeebe-io/zeebe-modeler/issues/134
2019-10-25 13:16:43 +00:00
Oguz Eroglu 41c6af1830 feat(adaptive-label-positioning): adjust label position post creation
Closes #1220
2019-10-14 14:48:32 +00:00
Philipp Fromme 2e27d74306 feat(modeling): copy and paste boundary events
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
Closes #1202
Closes #1204
Closes #1205
2019-10-13 23:19:52 +02:00
Philipp Fromme 59de7598b1 Merge branch 'master' into develop 2019-10-11 16:38:08 +02:00
Philipp Fromme 44cceb5da2 fix(adaptive-label-positioning): ignore labels that are being created
Closes #1211
2019-10-11 16:29:30 +02:00
Philipp Fromme 168a1493b2 fix(modeling): do not duplicate flow node refs
Closes: https://github.com/camunda/camunda-modeler/issues/1504
2019-10-11 16:29:24 +02:00
Philipp Fromme 5bed0aeca5 Merge branch 'master' into develop 2019-09-27 14:33:32 +02:00
ssoorriiin 37bcd070e8 fix(modeling): do not remove default sequence flow on type change
* do not remove default sequence flow when changing type to intermediate catch

Closes #1197
2019-09-27 14:33:08 +02:00
ssoorriiin b290078600 fix(modeling): do not remove sequence flow condition on type change
* do not remove sequence flow condition when changing type to intermediate catch

Closes #1199
2019-09-27 14:30:55 +02:00
Niklas Kiefer 0143595230 Merge branch 'master' into develop 2019-09-25 13:34:54 +02:00
Philipp Fromme a74d838dc7 fix(copy-paste): do NOT copy generic properties
Related to camunda/camunda-modeler#1507
2019-09-25 13:09:00 +02:00
Philipp Fromme 5736cfe794 Merge branch 'master' into develop 2019-09-24 14:41:03 +02:00
Oguz Eroglu d55e3afe35 fix(copy-paste): copy attacher properties
Closes #1190
2019-09-24 12:34:15 +00:00
Philipp Fromme 51232830e2 Merge branch 'master' into develop 2019-09-23 08:59:02 +02:00
Philipp Fromme f177a462ea fix(viewer): do not clear diagram if no diagram to clear
Closes #1181
2019-09-20 11:11:49 +00:00
Philipp Fromme 83e9f05efa fix(connect-snapping): snap to sub process mid
Related to camunda/camunda-modeler#1436
2019-09-13 14:29:38 +00:00
Niklas Kiefer dcf440b076 fix(auto-place): complete direct editing on auto place
Related to camunda/camunda-modeler#1502
2019-09-12 07:55:34 +02:00
Philipp Fromme 5294133a58 Merge branch 'master' into develop 2019-09-11 16:57:23 +02:00
Oguz Eroglu 86c61b0c0d fix(snapping): snap to task mid
Related to https://github.com/camunda/camunda-modeler/issues/1436
2019-09-11 16:56:40 +02:00
Jonathan Irwin aea527775e chore(context-pad): update spelling 2019-09-09 14:45:41 +02:00
Philipp Fromme ddaa3f0b03 fix(keyboard-move-selection): ensure moving lanes is not possible
Closes #943
2019-09-06 15:27:23 +00:00
Philipp Fromme 2f001e1f4a feat(copy-paste): copy process properties
Clone the linked process when copying a participant.

This ensures that properties attached to the process
are not getting lost.

Closes #1161
2019-09-06 15:27:31 +02:00
Philipp Fromme e1d8a67527 fix(drop-on-flow-behavior): handle shape created with bounds
* take into account that shapes can be created with position OR bounds

Fixes #1178
2019-08-29 12:47:53 +00:00
Nico Rehwaldt 70e8da3b9d Merge branch 'master' into develop 2019-08-21 09:53:30 +02:00
Philipp Fromme 6aaf816802 fix(bpmn-layouter): get preferred layout from orientation
Requires https://github.com/bpmn-io/diagram-js/pull/401

Closes #1121
2019-08-21 06:58:15 +00:00
Maciej Barelkowski 33156e43be chore(project): fix linting errors 2019-08-19 14:27:33 +00:00
Niklas Kiefer 5a7d579d3a fix(import): handle data associations on boundary import
Closes #1170
2019-08-19 08:19:04 +00:00