Commit Graph

686 Commits

Author SHA1 Message Date
Maciej Barelkowski 6243adfa92 test(copy-paste): increase timeout for complex 2021-10-20 17:07:26 +02:00
github-actions 6f421a4063 Merge master to develop 2021-10-15 11:07:21 +00:00
Maciej Barelkowski 1253326768 fix(copy-paste): do not create new id if unnecessary
Related to https://github.com/camunda/camunda-modeler/issues/1410
2021-10-15 13:07:00 +02:00
github-actions 6f88c01956 Merge master to develop 2021-10-15 08:38:22 +00:00
Nico Rehwaldt b4bd6557b1 chore: unbuild circular dependency
Inline `ResizeUtil` into behavior to prevent circular depdendency.

It is not being used outside the behavior anyway and uses behavior
internals (lane dimensions).
2021-10-15 10:38:06 +02:00
Martin Stamm c4206a4d31 fix(replace): create new di on replace 2021-09-03 15:14:00 +02:00
Nico Rehwaldt f6d84696a9 test: verify label wiring
* import
* label updating (creation)
* label paste
2021-09-03 15:14:00 +02:00
Nico Rehwaldt f458c6833f test: increase timeout
Complex copy and paste test may otherwise timeout on GitHub actions.
2021-09-03 15:14:00 +02:00
Martin Stamm 5d30d576dc test: ensure that connectionDi exists 2021-09-03 15:14:00 +02:00
Martin Stamm 597c417dce chore: throw error when accessing DI from business object
Related to https://github.com/bpmn-io/bpmn-js/issues/1472
2021-09-03 15:14:00 +02:00
Martin Stamm 5589439774 feat: make elementFactory._getDefaultSize public
This has the benefit of using the public API method across our 
code base.
2021-09-03 15:14:00 +02:00
Martin Stamm ca8488b2c9 test: adjust to use `getDi` utility function
Related to https://github.com/bpmn-io/bpmn-js/issues/1472
2021-09-03 15:14:00 +02:00
Maciej Barelkowski 886da8924f test(modeling): add test for non-interrupting event replacement 2021-06-29 12:18:10 +00:00
Maciej Barelkowski b7fa6b934a test(bpmn-rules): verify CallActivity can connect with MessageFlow
Closes #1467
2021-06-25 10:33:40 +02:00
Maciej Barelkowski 2a60745991 Merge branch 'master' into develop 2021-06-02 08:53:22 +02:00
Maciej Barelkowski 7f1c0be591 fix(rules): disallow creating DataStoreReference if process is missing
Closes #1456
2021-05-31 18:31:39 +00:00
Maciej Barelkowski e0c4dea90d fix(modeling): append DataStoreReference to first available process
Related to #1456
2021-05-31 18:31:39 +00:00
Maciej Barelkowski 439bc4ead0 feat(modeling): use BPMN in Color for color setting
Additionally to custom bpmn.io properties, `modeling#setColor` will use
[BPMN in Color properties](https://github.com/bpmn-miwg/bpmn-in-color).
2021-05-27 12:43:53 +00:00
Maciej Barelkowski f120624580 Merge branch 'master' into develop 2021-05-06 16:06:04 +02:00
Martin Stamm b56604d5f3 fix(paste): don't insert multiple shapes on flow
closes #1440
2021-05-04 14:03:30 +00:00
Philipp Fromme 4806507936 feat: reconnect message flows when collapsing participant
Related to camunda/camunda-modeler#1651
2021-04-22 07:09:34 +00:00
Maciej Barelkowski d4078f1ab0 feat: replace elements on create
Closes #1340
2021-04-16 12:38:28 +00:00
Philipp Fromme c3e0d6d164 fix: copy root element references
Related to camunda/camunda-modeler#2185
2021-04-14 11:56:08 +00:00
KHADIR Tayeb 40f1d3af52 feat: enable connection tool for text annotation
fixes upstream camunda/camunda-modeler#2042
2021-04-07 11:51:22 +02:00
Nico Rehwaldt ca550a247a test(editor-actions): verify alignElements and distributeElements behavior 2021-03-04 18:22:51 +00:00
Nico Rehwaldt 6c02ecde34 fix(modeling): if we fix hover, we gotta fix out, too
This ensures our FixHoverBehavior (that ensures we drop onto /
connect to participants, not lanes) does fix the hover element
during *.out, too.

Otherwise there is no way for other behaviors to correctly
remove hover indicators.

Closes https://github.com/bpmn-io/bpmn-js/issues/1413
2021-01-28 11:11:27 +01:00
Niklas Kiefer 9b0f82dd47 fix(palette): activate globalConnect tool instead of toggling
This prevents unwanted move events when triggered from the palette action.

Closes #1402
2021-01-07 13:58:54 +00:00
Nico Rehwaldt 00294e2994 test: increase spec timeout 2021-01-06 12:57:36 +00:00
Maximilian Trumpf 2e9f617911 fix(replace-menu): only allow cancel boundary events on transactions
related to camunda/camunda-modeler#2026
2021-01-05 07:27:08 +00:00
Alexis Zeghers 5eff166135 feat(replace): add multiplicity marker to replace menu for participants
Closes #533
2020-12-11 06:59:20 +00:00
Niklas Kiefer 8faee2bde9 feat(replace-menu): update label of collapsed pool
* Indicate the action in a clearer, more standard-compliant way --> replaces an expanded pool with an empty "black box" + removing its content.
* We will not update the action identifier (`replace-with-collapsed-pool`) to avoid breaking changes.
* Make it possible to retrieve label via function

Related to camunda/camunda-modeler#2022
2020-12-07 10:33:27 +00:00
Alexis Zeghers 1ccba5c5e6 feat(replace): add switch between DataStore and DataObject in replace menu
Closes #1372
2020-12-03 11:01:38 +00:00
Nico Rehwaldt 00686dcb3b deps: update eslint + styles 2020-12-02 20:28:33 +00:00
Nico Rehwaldt 667d469f38 feat(modeling): provide generic moddle properties update API
Modeling#updateModdleProperties allows users to update moddle elements
that are backed up by diagram elements.

It provides us a path forward when we start to update more _hidden_
things from within the modeling canvas.
2020-11-19 14:24:59 +00:00
Alexis Zeghers 4b46f695ce feat(modeler): add toggle to mark a data object as a collection
Closes #381
2020-11-18 10:03:46 +00:00
Nico Rehwaldt 52c14a23d8 test(modeling): verify tooltip shown on failed create 2020-11-03 20:39:20 +00:00
Niklas Kiefer a9ce32449a fix(rules): allow message boundary event as message flow target
Closes #1346
Related to camunda/camunda-modeler#1919
2020-09-14 14:07:13 +02:00
Maximilian Trumpf 90614dd99a feat(rules/bpmnRules): typed start event to none type on subProcess move
closes #831
2020-07-30 09:34:09 +02:00
Maximilian Trumpf 06ca742bc2 feat(popup-menu/replace): disallow replace typed event in subprocess 2020-07-30 09:34:09 +02:00
Maximilian Trumpf 8bc29e7f3e fix(bpmnRules): disallow boundaryEvents as message flow targets
closes #1300
2020-06-23 15:48:00 +02:00
Niklas Kiefer 949703aa08 feat(rules): allow starting connections from groups 2020-06-05 08:52:46 +00:00
Niklas Kiefer c7dcd6c77b test(rules): verify groups and text annotations can be connected
Related to #1327
2020-06-05 08:52:46 +00:00
Niklas Kiefer b7ad57e348 feat(context-pad): append text annotations on groups
Related to #1327
2020-06-05 08:52:46 +00:00
Nico Rehwaldt 04ca31fac9 feat(lib): Promisify public APIs
This commit promisifies following APIs:

   BaseViewer#importXML
   BaseViewer#importDefinitions
   BaseViewer#open
   BaseViewer#saveXML
   BaseViewer#saveSVG
   Modeler#createDiagram

Related to https://github.com/bpmn-io/bpmn-js/issues/812

BREAKING CHANGES:

* Users are now expected to have Promises either by default or
polyfilled as the APIs return a Promise now.
2020-04-29 11:12:23 +02:00
Philipp Fromme e03a4b2c59 chore(auto-place): move common feature to diagram-js
https://github.com/bpmn-io/dmn-js/issues/470
2020-04-16 11:36:12 +00:00
Maciej Barelkowski f1745547f0 feat(layouter): prefer straight layout for sub-process connections
Related to https://github.com/camunda/camunda-modeler/issues/1758
2020-04-08 11:14:46 +00:00
Philipp Fromme 7a67ff95b2 chore(documentation): fix JSDoc string types 2020-04-07 06:52:55 +00:00
Maciej Barelkowski aa58493872 test(modeling): verify attachment is not unnecessarily moved
Related to https://github.com/camunda/camunda-modeler/issues/1737
2020-04-01 13:52:58 +00:00
Maciej Barelkowski b9d237e300 test(modeling): verify re-layout of message flows when lane added
Related to #1289
Related to https://github.com/camunda/camunda-modeler/issues/655
2020-04-01 13:52:58 +00:00
Nico Rehwaldt 33f5f2d663 Merge branch 'master' into develop 2020-03-30 14:58:43 +02:00
Maciej Barelkowski 6bfecfa71e test(popup-menu): verify if linked events have name 2020-03-30 11:36:08 +02:00
Nico Rehwaldt bf436bef1e feat(replace): create bpmn:LinkEventDefinition with empty name
Closes https://github.com/bpmn-io/bpmn-js/issues/1296
2020-03-30 11:36:08 +02:00
Nico Rehwaldt 960a085d4c fix(modeling): do not resize label target when setting empty label
This prevents a bug that cause the label target to be accidentally
resized if the user updates the label value to an empty string (or null).

Closes #1294
2020-03-30 07:53:16 +00:00
Maciej Barelkowski c2ded3952f test(popup-menu): verify if linked events have name 2020-03-27 07:23:12 +00:00
Nico Rehwaldt 95b50f08a7 feat(replace): create bpmn:LinkEventDefinition with empty name
Closes https://github.com/bpmn-io/bpmn-js/issues/1296
2020-03-27 07:23:12 +00:00
Maciej Barelkowski d48812766f Merge branch 'master' into develop 2020-03-16 13:24:50 +01:00
Maciej Barelkowski 7696534f22 fix(modeling): save bpmndi as drawn on the diagram
Related to https://github.com/camunda/camunda-modeler/issues/1326

Closes #985
2020-03-16 12:24:05 +00:00
Maciej Barelkowski 62f331bc3d Merge branch 'master' into develop 2020-03-13 14:15:14 +01:00
Philipp Fromme b4eff93580 chore(space-tool): add tests for participant without lanes 2020-03-13 07:56:38 +00:00
Philipp Fromme dafa6f138c fix(space-tool): consider lanes when resizing participant
Related to camunda/camunda-modeler#1703
2020-03-13 07:56:38 +00:00
Philipp Fromme e4e789bd3e fix(label-editing): resize empty text annotations on complete
Related to bpmn-io/diagram-js-direct-editing#12
2020-03-10 14:35:39 +01:00
Nico Rehwaldt 368f9e14b5 fix(modeling): make AddLaneHandler recognize top-level labels
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 14:50:37 +01:00
Nico Rehwaldt d902a970e8 fix(modeling): update AddLaneHandler to new spaceTool API
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 14:50:37 +01:00
Maciej Barelkowski 53e7198a47 fix(modeling): assign id prefix matching element type
Closes #1285
2020-03-09 09:54:35 +00:00
Nico Rehwaldt ffa0a88d30 fix(modeling): update AddLaneHandler to new spaceTool API
Related to https://github.com/camunda/camunda-modeler/issues/1715
2020-03-09 10:48:05 +01:00
Nico Rehwaldt 707257e020 fix(copy-paste): emit <moddleCopy.canSetCopiedProperty> with existing property 2020-03-02 13:08:42 +00:00
Nico Rehwaldt 483a607631 test(modeling): add special space tool case 2020-02-06 13:47:32 +01:00
Nico Rehwaldt c5402c211d test(modeling): invert test case 2020-02-06 13:47:32 +01:00
Nico Rehwaldt cb5098242d test(space-tool): rewrite and improve specs 2020-02-06 13:47:32 +01:00
Philipp Fromme 50630c7aac fix(label-behavior): do not move labels if labelBehavior=false 2020-02-06 13:47:32 +01:00
Philipp Fromme 7ee304f424 feat(space-tool): ensure minimum size when resizing shapes 2020-02-06 13:47:32 +01:00
Maciej Barelkowski 035bb0c1fd feat(modeling): create generic ids for new elements
This makes sure that the semantic ID prefix reflects
the common type of all replace options.

ID prefixes for elements will match the examples:
  * `bpmn:ServiceTask` => `Activity_<id_suffix>`
  * `bpmn:EndEvent` => `Event_<id_suffix>`
  * `bpmn:EventBasedGateway` => `Gateway_<id_suffix>`
  * `bpmn:SequenceFlow` => `Flow_<id_suffix>`

Related to https://github.com/camunda/camunda-modeler/issues/1654
2020-02-06 13:43:04 +01:00
Maciej Barelkowski 9e31327335 feat(modeling/copy-paste): copy message referenced by SendTask
Related to https://github.com/camunda/camunda-modeler/issues/1637
2020-01-31 10:10:01 +00:00
Maciej Barelkowski dcc6d1ca94 feat(modeling/copy-paste): copy message referenced by ReceiveTask
Related to https://github.com/camunda/camunda-modeler/issues/1637
2020-01-31 10:10:01 +00:00
Maciej Barelkowski dc5a566e10 fix(modeling/copy-paste): copy referenced message if not present
Related to https://github.com/camunda/camunda-modeler/issues/1639
2020-01-31 06:36:23 +00:00
Nico Rehwaldt 82a250b014 fix(modeling): keep non-duplicate outgoing connection when dropping on flow
Closes https://github.com/bpmn-io/bpmn-js/issues/1263
2020-01-15 14:29:10 +00:00
Nico Rehwaldt cbbab12e21 test(replace): verify reconnect behavior on replace with different bounds
This ensures that we leave no dangling incoming / outgoing message flows
after replacing an expanded pool with a collapsed one.
2020-01-15 08:19:30 +00:00
Nico Rehwaldt 14eeba897d Merge branch 'master' into develop 2020-01-09 16:54:06 +01:00
Nico Rehwaldt 4a675b3780 fix(rules): allow associations where data associations are allowed, too
Related to https://github.com/camunda/camunda-modeler/issues/1635
2020-01-02 09:23:14 +00:00
Nico Rehwaldt 31b813097b test(modeling): verify moving associations 2020-01-02 09:23:14 +00:00
Maciej Barelkowski b2179bd489 test(snapping): simplify test case 2019-12-17 10:36:44 +00:00
Oguz Eroglu 27fec8bdf1 fix(snapping): snap origins of docking points on create
Related to: https://github.com/camunda/camunda-modeler/issues/1612
2019-12-17 10:36:44 +00:00
Nico Rehwaldt d6ab00783a Merge branch 'master' into develop 2019-12-16 10:55:28 +01:00
Niklas Kiefer 8efb20c03e fix(context-pad): do not open replace menu if context pad not open
Related to camunda/camunda-modeler#1613
2019-12-16 09:49:37 +00:00
Nico Rehwaldt d6adc51ddd test(modeling): make move stress test runnable again 2019-12-12 23:25:39 +01:00
Philipp Fromme 477217c891 feat(copy-paste): copy error, escalation, message and signal references
* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
2019-12-11 23:08:14 +01:00
Niklas Kiefer 3ad47af299 Merge branch 'master' into develop 2019-12-11 14:55:38 +01:00
Niklas Kiefer 9f8a724e9a fix(modeling): do not crop waypoints on pasting
Related to camunda/camunda-modeler#1611
2019-12-11 11:18:54 +00:00
Nico Rehwaldt 74411387a4 test(project): update test diagrams (namespace only) 2019-12-11 10:52:43 +00:00
Nico Rehwaldt b4b5d1d139 fix(modeling): correct creation of nested lanes
With diagram-js@5 we've introduced the CreateBehavior that ensures
elements are not created on top of lanes but always on top of the actual
participant.

Unfortunately we forgot about the fact that lanes are created once in a
while, too.

This commit accounts for this fact and ensures we do not adjust the
parent of to-be-created lanes.

(A test cases for splitting nested lanes did not exist until now).

Closes #1254
Closes #1253
2019-12-11 10:52:43 +00:00
Nico Rehwaldt c8eedf959f test(project): verify flowNodeRefs updating 2019-12-11 10:52:43 +00:00
Philipp Fromme 448a8250ab Merge branch 'master' into develop 2019-12-09 12:54:24 +01:00
Nico Rehwaldt 1b576cda17 test(project): make sinon an allowed global 2019-12-09 12:52:35 +01:00
Nico Rehwaldt a66e9a5c8d test(copy-paste): assert elements.changed behavior 2019-12-09 12:52:35 +01:00
Nico Rehwaldt 4455c3fc35 fix(modeling/behavior): hook UpdateFlowNodeRefs behavior in on elements.create 2019-12-06 15:24:54 +00:00
Nico Rehwaldt d769e6ddb0 fix(grid-snapping): do not update waypoints on multiple create
Related to https://github.com/camunda/camunda-modeler/issues/1617
2019-12-06 15:24:54 +00:00
Philipp Fromme b2b607f558 fix(adaptive-label-positioning): do not adjust on paste
Related to camunda/camunda-modeler#1617
2019-11-29 20:38:16 +00:00
Nico Rehwaldt 748674fb35 fix(modeling): correctly fix hover on cleanup, too
Related to #1599
2019-11-25 17:42:58 +00:00
Philipp Fromme c8559cd4d9 chore(element-factory): fix test description 2019-11-20 15:53:53 +01:00
Philipp Fromme 8722b6e3c2 fix(element-factory): use BPMN factory to ensure IDs
Closes #1162
2019-11-20 14:41:09 +00:00