From ebba2044359eb292dbe56b84829fdd8238f31854 Mon Sep 17 00:00:00 2001 From: Philipp Date: Sun, 30 Jan 2022 16:50:02 +0100 Subject: [PATCH] chore: code style * single-line comments should always be lowercase --- lib/features/drilldown/DrilldownBreadcrumbs.js | 8 ++++---- lib/features/modeling/behavior/SubProcessPlaneBehavior.js | 2 +- test/spec/features/drilldown/DrilldownIntegrationSpec.js | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/features/drilldown/DrilldownBreadcrumbs.js b/lib/features/drilldown/DrilldownBreadcrumbs.js index aec0e93a..4376fc0d 100644 --- a/lib/features/drilldown/DrilldownBreadcrumbs.js +++ b/lib/features/drilldown/DrilldownBreadcrumbs.js @@ -9,7 +9,7 @@ var OPEN_CLASS = 'bjs-breadcrumbs-shown'; /** - * Adds Overlays that allow switching planes on collapsed subprocesses. + * Adds overlays that allow switching planes on collapsed subprocesses. * * @param {eventBus} eventBus * @param {elementRegistry} elementRegistry @@ -24,7 +24,7 @@ export default function DrilldownBreadcrumbs(eventBus, elementRegistry, overlays var boParents = []; - // Update primary shape if Name or ID of the plane changes + // update primary shape if name or ID of the plane changes eventBus.on('element.changed', function(e) { var shape = e.element; @@ -37,7 +37,7 @@ export default function DrilldownBreadcrumbs(eventBus, elementRegistry, overlays primary && eventBus.fire('element.changed', { element: primary }); }); - // update breadcrumbs if name/id of the primary shape changes + // update breadcrumbs if name or ID of the primary shape changes eventBus.on('element.changed', function(e) { var shape = e.element, bo = getBusinessObject(shape); @@ -108,7 +108,7 @@ export default function DrilldownBreadcrumbs(eventBus, elementRegistry, overlays DrilldownBreadcrumbs.$inject = [ 'eventBus', 'elementRegistry', 'overlays', 'canvas' ]; -// helpers +// helpers ////////// /** * Returns the parents for the element using the business object chain, diff --git a/lib/features/modeling/behavior/SubProcessPlaneBehavior.js b/lib/features/modeling/behavior/SubProcessPlaneBehavior.js index ad34c3d0..149f07f6 100644 --- a/lib/features/modeling/behavior/SubProcessPlaneBehavior.js +++ b/lib/features/modeling/behavior/SubProcessPlaneBehavior.js @@ -20,7 +20,7 @@ var DEFAULT_POSITION = { /** - * Creates diPlanes and canvas planes when collapsed subprocesses are created. + * Creates bpmndi:BPMNPlane elements and canvas planes when collapsed subprocesses are created. * * * @param {Canvas} canvas diff --git a/test/spec/features/drilldown/DrilldownIntegrationSpec.js b/test/spec/features/drilldown/DrilldownIntegrationSpec.js index 78274b7a..c9a6328e 100644 --- a/test/spec/features/drilldown/DrilldownIntegrationSpec.js +++ b/test/spec/features/drilldown/DrilldownIntegrationSpec.js @@ -20,7 +20,7 @@ describe('features - drilldown', function() { beforeEach(bootstrapModeler(multiLayerXML, { modules: testModules })); - describe('Navigation - Collaboration', function() { + describe('navigation - collaboration', function() { var process, participant; @@ -85,7 +85,7 @@ describe('features - drilldown', function() { ); - it('should remember scroll and zoom after morph', inject(function(canvas, modeling) { + it('should remember scroll and zoom after switching planes', inject(function(canvas, modeling) { // given canvas.scroll({ dx: 500, dy: 500 }); @@ -109,7 +109,7 @@ describe('features - drilldown', function() { }); - describe('Breadcrumbs - Name changes', function() { + describe('breadcrumbs - name changes', function() { it('should update on plane name change', inject(function(canvas, modeling) {