sartography
/
bpmn-js
mirror of https://github.com/sartography/bpmn-js.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(copy-paste): correctly set $parent on copied model elements 

Related to camunda/camunda-modeler#625
This commit is contained in:
Nico Rehwaldt 2018-04-09 11:25:18 +02:00
parent b4fcb2d906
commit e159b002cd
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/util/model/ModelCloneHelper.js
View File

@ -106,7 +106,9 @@ ModelCloneHelper.prototype.clone = function(refElement, newElement, properties)
newProperty = self._deepClone(refElementProp, context); newProperty = self._deepClone(refElementProp, context);
if (context.hasNestedProperty) { if (context.hasNestedProperty) {
newElement[name] = newProperty; newProperty.$parent = newElement;
newElement.set(name, newProperty);
} }
context.hasNestedProperty = false; context.hasNestedProperty = false;

6
test/spec/features/copy-paste/BpmnCopyPasteSpec.js
View File

@ -664,7 +664,11 @@ describe('features/copy-paste', function() {
expect(copiedBo.asyncBefore).to.eql(bo.asyncBefore); expect(copiedBo.asyncBefore).to.eql(bo.asyncBefore);
expect(copiedBo.documentation).to.jsonEqual(bo.documentation); expect(copiedBo.documentation).to.jsonEqual(bo.documentation);
expect(copiedBo.extensionElements).to.jsonEqual(bo.extensionElements);
var copiedExtensions = copiedBo.extensionElements;
expect(copiedExtensions).to.jsonEqual(bo.extensionElements);
expect(copiedExtensions.$parent).to.equal(copiedBo);
}) })
); );