sartography
/
bpmn-js
mirror of https://github.com/sartography/bpmn-js.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore(Viewer): handle import error outside try/catch

This commit is contained in:
Nico Rehwaldt 2017-11-28 13:24:36 +01:00
parent 9b2a07d958
commit e0104e3589
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/Viewer.js
View File

@ -22,7 +22,7 @@ var Diagram = require('diagram-js'),
var inherits = require('inherits'); var inherits = require('inherits');
var Importer = require('./import/Importer'); var importBpmnDiagram = require('./import/Importer').importBpmnDiagram;
function checkValidationError(err) { function checkValidationError(err) {
@ -292,6 +292,8 @@ Viewer.prototype.saveSVG = function(options, done) {
Viewer.prototype.importDefinitions = function(definitions, done) { Viewer.prototype.importDefinitions = function(definitions, done) {
var err;
// use try/catch to not swallow synchronous exceptions // use try/catch to not swallow synchronous exceptions
// that may be raised during model parsing // that may be raised during model parsing
try { try {
@ -305,12 +307,13 @@ Viewer.prototype.importDefinitions = function(definitions, done) {
this._definitions = definitions; this._definitions = definitions;
// perform graphical import // perform graphical import
Importer.importBpmnDiagram(this, definitions, done); return importBpmnDiagram(this, definitions, done);
} catch (e) { } catch (e) {
err = e;
// handle synchronous errors
done(e);
} }
// handle synchronous errors
return done(err);
}; };
Viewer.prototype.getModules = function() { Viewer.prototype.getModules = function() {