sartography
/
bpmn-js
mirror of https://github.com/sartography/bpmn-js.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test(replace): verify reconnect behavior on replace with different bounds 

This ensures that we leave no dangling incoming / outgoing message flows
after replacing an expanded pool with a collapsed one.
This commit is contained in:
Nico Rehwaldt 2020-01-13 14:12:25 +01:00 committed by fake-join[bot]
parent e2667eeef5
commit cbbab12e21
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/spec/features/replace/BpmnReplace.collaboration.bpmn
View File

@ -1,9 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<bpmn:definitions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" id="Definitions_1" targetNamespace="http://bpmn.io/schema/bpmn"> <bpmn:definitions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" id="Definitions_1" targetNamespace="http://bpmn.io/schema/bpmn">
<bpmn:collaboration id="Collaboration_1wsnry3"> <bpmn:collaboration id="Collaboration_1wsnry3">
<bpmn:participant id="Participant_1" name="Pool" processRef="Process_1" /> <bpmn:participant id="Participant_1" name="A" processRef="Process_1" />
<bpmn:participant id="Participant_2" name="Pool" /> <bpmn:participant id="Participant_2" name="B" />
<bpmn:messageFlow id="MessageFlow_2" sourceRef="Participant_2" targetRef="Participant_1" /> <bpmn:messageFlow id="MessageFlow_B_to_A" sourceRef="Participant_2" targetRef="Participant_1" />
<bpmn:messageFlow id="MessageFlow_1" sourceRef="Task_1" targetRef="Participant_2" /> <bpmn:messageFlow id="MessageFlow_1" sourceRef="Task_1" targetRef="Participant_2" />
<bpmn:messageFlow id="MessageFlow_3" sourceRef="EndEvent_1" targetRef="Participant_2" /> <bpmn:messageFlow id="MessageFlow_3" sourceRef="EndEvent_1" targetRef="Participant_2" />
</bpmn:collaboration> </bpmn:collaboration>
@ -35,7 +35,7 @@
<bpmndi:BPMNShape id="Participant_06fwm9a_di" bpmnElement="Participant_2"> <bpmndi:BPMNShape id="Participant_06fwm9a_di" bpmnElement="Participant_2">
<dc:Bounds x="237" y="436" width="378" height="115" /> <dc:Bounds x="237" y="436" width="378" height="115" />
</bpmndi:BPMNShape> </bpmndi:BPMNShape>
<bpmndi:BPMNEdge id="MessageFlow_1xdh89f_di" bpmnElement="MessageFlow_2"> <bpmndi:BPMNEdge id="MessageFlow_1xdh89f_di" bpmnElement="MessageFlow_B_to_A">
<di:waypoint xsi:type="dc:Point" x="368" y="436" /> <di:waypoint xsi:type="dc:Point" x="368" y="436" />
<di:waypoint xsi:type="dc:Point" x="368" y="353" /> <di:waypoint xsi:type="dc:Point" x="368" y="353" />
<bpmndi:BPMNLabel> <bpmndi:BPMNLabel>
@ -58,7 +58,7 @@
<dc:Bounds x="508" y="170" width="90" height="20" /> <dc:Bounds x="508" y="170" width="90" height="20" />
</bpmndi:BPMNLabel> </bpmndi:BPMNLabel>
</bpmndi:BPMNShape> </bpmndi:BPMNShape>
<bpmndi:BPMNEdge id="MessageFlow_15s8xey_di" bpmnElement="MessageFlow_3"> <bpmndi:BPMNEdge id="MessageFlow_B_to_A_di" bpmnElement="MessageFlow_3">
<di:waypoint xsi:type="dc:Point" x="553" y="170" /> <di:waypoint xsi:type="dc:Point" x="553" y="170" />
<di:waypoint xsi:type="dc:Point" x="553" y="434" /> <di:waypoint xsi:type="dc:Point" x="553" y="434" />
<bpmndi:BPMNLabel> <bpmndi:BPMNLabel>

7
test/spec/features/replace/BpmnReplaceSpec.js
View File

@ -309,6 +309,8 @@ describe('features/replace - bpmn replace', function() {
// given // given
var shape = elementRegistry.get('Participant_1'); var shape = elementRegistry.get('Participant_1');
var messageFlow = elementRegistry.get('MessageFlow_B_to_A');
var collapsedBounds = assign({}, getBounds(shape), { height: 60 }); var collapsedBounds = assign({}, getBounds(shape), { height: 60 });
// when // when
@ -322,6 +324,11 @@ describe('features/replace - bpmn replace', function() {
expect(newShape.children).to.be.empty; expect(newShape.children).to.be.empty;
expect(newShape).to.have.bounds(collapsedBounds); expect(newShape).to.have.bounds(collapsedBounds);
expect(messageFlow).to.have.waypoints([
{ x: 368, y: 436 },
{ x: 368, y: newShape.y + collapsedBounds.height }
]);
})); }));