style(tests): reformat UpdatePropertiesSpec

* line width = 80

test/spec/features/modeling/UpdatePropertiesSpec.js

@@ -35,23 +35,31 @@ describe('features/modeling - update properties', function() {
 
   describe('should execute', function() {
 
-    it('setting loop characteristics', inject(function(elementRegistry, modeling, moddle) {
+    it('setting loop characteristics', inject(
+      function(elementRegistry, modeling, moddle) {
 
         // given
-      var loopCharacteristics = moddle.create('bpmn:MultiInstanceLoopCharacteristics');
+        var loopCharacteristics = moddle.create(
+          'bpmn:MultiInstanceLoopCharacteristics'
+        );
 
         var taskShape = elementRegistry.get('ServiceTask_1');
 
         // when
-      modeling.updateProperties(taskShape, { loopCharacteristics: loopCharacteristics });
+        modeling.updateProperties(taskShape, {
+          loopCharacteristics: loopCharacteristics
+        });
 
         // then
-      expect(taskShape.businessObject.loopCharacteristics).to.eql(loopCharacteristics);
+        expect(
+          taskShape.businessObject.loopCharacteristics
+        ).to.eql(loopCharacteristics);
 
 
         // task shape got updated
         expect(updatedElements).to.include(taskShape);
-    }));
+      }
+    ));
 
 
     it('unsetting default flow', inject(function(elementRegistry, modeling) {
@@ -87,8 +95,9 @@ describe('features/modeling - update properties', function() {
       expect(updatedElements).to.include(newDefaultFlowConnection);
     }));
 
-    it('should keep default flow when reconnecting another sequence flows start',
+
-      inject(function(elementRegistry, modeling) {
+    it('should keep unchanged default flow untouched', inject(
+      function(elementRegistry, modeling) {
 
         // given
         var gatewayShape = elementRegistry.get('ExclusiveGateway_1'),
@@ -96,21 +105,30 @@ describe('features/modeling - update properties', function() {
             taskShape = elementRegistry.get('Task_1');
 
         // when
-        modeling.reconnectStart(sequenceFlow, taskShape,
+        modeling.reconnectStart(
-          { x: taskShape.x + taskShape.width, y: taskShape.y + taskShape.height / 2 });
+          sequenceFlow,
+          taskShape,
+          {
+            x: taskShape.x + taskShape.width,
+            y: taskShape.y + taskShape.height / 2
+          }
+        );
 
         // then
-        expect(gatewayShape.businessObject.default).not.to.be.undefined;
+        expect(gatewayShape.businessObject.default).to.exist;
+      }
+    ));
 
-      }));
 
-    it('updating conditional flow on source replace', inject(function(bpmnReplace, elementRegistry) {
+    it('updating conditional flow on source replace', inject(
+      function(bpmnReplace, elementRegistry) {
 
         //given
         var conditionalFlow = elementRegistry.get('SequenceFlow_3'),
+            conditionalBo = conditionalFlow.businessObject,
             serviceTask = elementRegistry.get('ServiceTask_1');
 
-      var conditionExpression = conditionalFlow.businessObject.conditionExpression;
+        var conditionExpression = conditionalBo.conditionExpression;
 
         var userTaskData =  {
           type: 'bpmn:UserTask'
@@ -120,17 +138,20 @@ describe('features/modeling - update properties', function() {
         bpmnReplace.replaceElement(serviceTask, userTaskData);
 
         // then
-      expect(conditionalFlow.businessObject.conditionExpression).to.eql(conditionExpression);
+        expect(conditionalBo.conditionExpression).to.eql(conditionExpression);
-    }));
+      }
+    ));
 
 
-    it('updating conditional flow on target replace', inject(function(bpmnReplace, elementRegistry) {
+    it('updating conditional flow on target replace', inject(
+      function(bpmnReplace, elementRegistry) {
 
         //given
         var conditionalFlow = elementRegistry.get('SequenceFlow_3'),
+            conditionalBo = conditionalFlow.businessObject,
             endEvent = elementRegistry.get('EndEvent_1');
 
-      var conditionExpression = conditionalFlow.businessObject.conditionExpression;
+        var conditionExpression = conditionalBo.conditionExpression;
 
         var messageEndEventData =  {
           type: 'bpmn:EndEvent',
@@ -141,8 +162,9 @@ describe('features/modeling - update properties', function() {
         bpmnReplace.replaceElement(endEvent, messageEndEventData);
 
         // then
-      expect(conditionalFlow.businessObject.conditionExpression).to.eql(conditionExpression);
+        expect(conditionalBo.conditionExpression).to.eql(conditionExpression);
-    }));
+      }
+    ));
 
 
     it('setting name', inject(function(elementRegistry, modeling) {
@@ -173,7 +195,7 @@ describe('features/modeling - update properties', function() {
       expect(flowConnection.businessObject.name).to.equal('FOO BAR');
 
       // flow label got updated, too
-      expect(updatedElements).to.include(elementRegistry.get('SequenceFlow_1_label'));
+      expect(updatedElements).to.include(flowConnection.label);
     }));
 
 
@@ -196,25 +218,29 @@ describe('features/modeling - update properties', function() {
     it('updating id', inject(function(elementRegistry, modeling) {
 
       // given
-      var flowConnection = elementRegistry.get('SequenceFlow_1');
+      var flowConnection = elementRegistry.get('SequenceFlow_1'),
-      var ids = flowConnection.businessObject.$model.ids;
+          flowBo = flowConnection.businessObject;
+
+      var ids = flowBo.$model.ids;
 
       // when
       modeling.updateProperties(flowConnection, { id: 'FOO_BAR' });
 
       // then
-      expect(ids.assigned('FOO_BAR')).to.eql(flowConnection.businessObject);
+      expect(ids.assigned('FOO_BAR')).to.eql(flowBo);
       expect(ids.assigned('SequenceFlow_1')).to.be.false;
 
-      expect(flowConnection.businessObject.id).to.equal('FOO_BAR');
+      expect(flowBo.id).to.equal('FOO_BAR');
       expect(flowConnection.id).to.equal('FOO_BAR');
     }));
 
 
-    it('updating extension elements', inject(function(elementRegistry, modeling) {
+    it('updating extension elements', inject(
+      function(elementRegistry, modeling) {
 
         // given
-      var flowConnection = elementRegistry.get('SequenceFlow_1');
+        var flowConnection = elementRegistry.get('SequenceFlow_1'),
+            flowBo = flowConnection.businessObject;
 
         // when
         modeling.updateProperties(flowConnection, {
@@ -223,21 +249,27 @@ describe('features/modeling - update properties', function() {
         });
 
         // then
-      expect(flowConnection.businessObject.get('xmlns:foo')).to.equal('http://foo');
+        expect(flowBo.get('xmlns:foo')).to.equal('http://foo');
-      expect(flowConnection.businessObject.get('foo:customAttr')).to.equal('FOO');
+        expect(flowBo.get('foo:customAttr')).to.equal('FOO');
-    }));
+      }
+    ));
 
 
     it('setting di properties', inject(function(elementRegistry, modeling) {
 
       // given
-      var flowConnection = elementRegistry.get('SequenceFlow_1');
+      var flowConnection = elementRegistry.get('SequenceFlow_1'),
+          flowBo = flowConnection.businessObject;
 
       // when
-      modeling.updateProperties(flowConnection, { di: { fill: 'FUCHSIA' } });
+      modeling.updateProperties(flowConnection, {
+        di: {
+          fill: 'FUCHSIA'
+        }
+      });
 
       // then
-      expect(flowConnection.businessObject.di.fill).to.equal('FUCHSIA');
+      expect(flowBo.di.fill).to.equal('FUCHSIA');
     }));
 
 
@@ -259,7 +291,8 @@ describe('features/modeling - update properties', function() {
 
   describe('should undo', function() {
 
-    it('setting loop characteristics', inject(function(elementRegistry, modeling, commandStack, moddle) {
+    it('setting loop characteristics', inject(
+      function(elementRegistry, modeling, commandStack, moddle) {
 
         // given
         var loopCharactersistics = moddle.create('bpmn:MultiInstanceLoopCharacteristics');
@@ -272,50 +305,64 @@ describe('features/modeling - update properties', function() {
 
         // then
         expect(taskShape.businessObject.loopCharactersistics).not.to.exist;
-    }));
+      }
+    ));
 
 
-    it('unsetting default flow', inject(function(elementRegistry, commandStack, modeling) {
+    it('unsetting default flow', inject(
+      function(elementRegistry, commandStack, modeling) {
 
         // given
         var gatewayShape = elementRegistry.get('ExclusiveGateway_1'),
-          oldDefaultFlow = gatewayShape.businessObject['default'];
+            gatewayBo = gatewayShape.businessObject,
+            oldDefaultBo = gatewayShape.businessObject['default'],
+            oldDefaultConnection = elementRegistry.get(oldDefaultBo.id);
 
         // when
-      modeling.updateProperties(gatewayShape, { 'default': undefined });
+        modeling.updateProperties(gatewayShape, {
+          'default': undefined
+        });
+
         commandStack.undo();
 
         // then
-      expect(gatewayShape.businessObject['default']).to.eql(oldDefaultFlow);
+        expect(gatewayBo['default']).to.eql(oldDefaultBo);
 
         // flow got updated, too
-      expect(updatedElements).to.include(elementRegistry.get(oldDefaultFlow.id));
+        expect(updatedElements).to.include(oldDefaultConnection);
-    }));
+      }
+    ));
 
 
-    it('updating default flow', inject(function(elementRegistry, commandStack, modeling) {
+    it('updating default flow', inject(
+      function(elementRegistry, commandStack, modeling) {
 
         // given
         var gatewayShape = elementRegistry.get('ExclusiveGateway_1'),
+            gatewayBo = gatewayShape.businessObject,
             newDefaultFlowConnection = elementRegistry.get('SequenceFlow_2'),
             newDefaultFlow = newDefaultFlowConnection.businessObject,
             oldDefaultFlowConnection = elementRegistry.get('SequenceFlow_1'),
             oldDefaultFlow = oldDefaultFlowConnection.businessObject;
 
         // when
-      modeling.updateProperties(gatewayShape, { 'default': newDefaultFlow });
+        modeling.updateProperties(gatewayShape, {
+          'default': newDefaultFlow
+        });
         commandStack.undo();
 
         // then
-      expect(gatewayShape.businessObject['default']).to.eql(oldDefaultFlow);
+        expect(gatewayBo['default']).to.eql(oldDefaultFlow);
 
         // flow got updated, too
         expect(updatedElements).to.include(newDefaultFlowConnection);
         expect(updatedElements).to.include(oldDefaultFlowConnection);
-    }));
+      }
+    ));
 
 
-    it('updating name', inject(function(elementRegistry, commandStack, modeling) {
+    it('updating name', inject(
+      function(elementRegistry, commandStack, modeling) {
 
         // given
         var flowConnection = elementRegistry.get('SequenceFlow_1');
@@ -328,11 +375,13 @@ describe('features/modeling - update properties', function() {
         expect(flowConnection.businessObject.name).to.equal('default');
 
         // flow got updated, too
-      expect(updatedElements).to.include(elementRegistry.get('SequenceFlow_1_label'));
+        expect(updatedElements).to.include(flowConnection.label);
-    }));
+      }
+    ));
 
 
-    it('unsetting name', inject(function(elementRegistry, commandStack, modeling) {
+    it('unsetting name', inject(
+      function(elementRegistry, commandStack, modeling) {
 
         // given
         var flowConnection = elementRegistry.get('SequenceFlow_3');
@@ -344,14 +393,17 @@ describe('features/modeling - update properties', function() {
 
         // then
         expect(flowConnection.businessObject.name).to.equal('conditional');
-    }));
+      }
+    ));
 
 
     it('updating id', inject(function(elementRegistry, commandStack, modeling) {
 
       // given
-      var flowConnection = elementRegistry.get('SequenceFlow_1');
+      var flowConnection = elementRegistry.get('SequenceFlow_1'),
-      var ids = flowConnection.businessObject.$model.ids;
+          flowBo = flowConnection.businessObject;
+
+      var ids = flowBo.$model.ids;
 
       // when
       modeling.updateProperties(flowConnection, { id: 'FOO_BAR' });
@@ -359,17 +411,19 @@ describe('features/modeling - update properties', function() {
 
       // then
       expect(ids.assigned('FOO_BAR')).to.be.false;
-      expect(ids.assigned('SequenceFlow_1')).to.eql(flowConnection.businessObject);
+      expect(ids.assigned('SequenceFlow_1')).to.eql(flowBo);
 
-      expect(flowConnection.businessObject.id).to.equal('SequenceFlow_1');
       expect(flowConnection.id).to.equal('SequenceFlow_1');
+      expect(flowBo.id).to.equal('SequenceFlow_1');
     }));
 
 
-    it('updating extension elements', inject(function(elementRegistry, commandStack, modeling) {
+    it('updating extension elements', inject(
+      function(elementRegistry, commandStack, modeling) {
 
         // given
-      var flowConnection = elementRegistry.get('SequenceFlow_1');
+        var flowConnection = elementRegistry.get('SequenceFlow_1'),
+            flowBo = flowConnection.businessObject;
 
         modeling.updateProperties(flowConnection, {
           'xmlns:foo': 'http://foo',
@@ -380,33 +434,42 @@ describe('features/modeling - update properties', function() {
         commandStack.undo();
 
         // then
-      expect(flowConnection.businessObject.get('xmlns:foo')).not.to.exist;
+        expect(flowBo.get('xmlns:foo')).not.to.exist;
-      expect(flowConnection.businessObject.get('foo:customAttr')).not.to.exist;
+        expect(flowBo.get('foo:customAttr')).not.to.exist;
-    }));
+      }
+    ));
 
   });
 
 
   describe('should redo', function() {
 
-    it('setting loop characteristics', inject(function(elementRegistry, modeling, commandStack, moddle) {
+    it('setting loop characteristics', inject(
+      function(elementRegistry, modeling, commandStack, moddle) {
 
         // given
-      var loopCharacteristics = moddle.create('bpmn:MultiInstanceLoopCharacteristics');
+        var loopCharacteristics = moddle.create(
+          'bpmn:MultiInstanceLoopCharacteristics'
+        );
 
-      var taskShape = elementRegistry.get('ServiceTask_1');
+        var taskShape = elementRegistry.get('ServiceTask_1'),
+            taskBo = taskShape.businessObject;
 
         // when
-      modeling.updateProperties(taskShape, { loopCharacteristics: loopCharacteristics });
+        modeling.updateProperties(taskShape, {
+          loopCharacteristics: loopCharacteristics
+        });
         commandStack.undo();
         commandStack.redo();
 
         // then
-      expect(taskShape.businessObject.loopCharacteristics).to.eql(loopCharacteristics);
+        expect(taskBo.loopCharacteristics).to.eql(loopCharacteristics);
-    }));
+      }
+    ));
 
 
-    it('updating default flow', inject(function(elementRegistry, commandStack, modeling) {
+    it('updating default flow', inject(
+      function(elementRegistry, commandStack, modeling) {
 
         // given
         var gatewayShape = elementRegistry.get('ExclusiveGateway_1');
@@ -420,11 +483,15 @@ describe('features/modeling - update properties', function() {
         expect(gatewayShape.businessObject['default']).not.to.exist;
 
         // flow got updated, too
-      expect(updatedElements).to.include(elementRegistry.get('SequenceFlow_1'));
+        expect(updatedElements).to.include(
-    }));
+          elementRegistry.get('SequenceFlow_1')
+        );
+      }
+    ));
 
 
-    it('updating name', inject(function(elementRegistry, commandStack, modeling) {
+    it('updating name', inject(
+      function(elementRegistry, commandStack, modeling) {
 
         // given
         var flowConnection = elementRegistry.get('SequenceFlow_1');
@@ -438,11 +505,13 @@ describe('features/modeling - update properties', function() {
         expect(flowConnection.businessObject.name).to.equal('FOO BAR');
 
         // flow got updated, too
-      expect(updatedElements).to.include(elementRegistry.get('SequenceFlow_1_label'));
+        expect(updatedElements).to.include(flowConnection.label);
-    }));
+      }
+    ));
 
 
-    it('unsetting name', inject(function(elementRegistry, commandStack, modeling) {
+    it('unsetting name', inject(
+      function(elementRegistry, commandStack, modeling) {
 
         // given
         var flowConnection = elementRegistry.get('SequenceFlow_3');
@@ -455,48 +524,59 @@ describe('features/modeling - update properties', function() {
 
         // then
         expect(flowConnection.businessObject.name).not.to.exist;
-    }));
+      }
+    ));
 
   });
 
 
   describe('unwrap diagram elements', function() {
 
-    it('updating default flow with connection', inject(function(elementRegistry, modeling) {
+    it('updating default flow with connection', inject(
+      function(elementRegistry, modeling) {
 
         // given
         var gatewayShape = elementRegistry.get('ExclusiveGateway_1'),
             newDefaultFlowConnection = elementRegistry.get('SequenceFlow_2');
 
         // when
-      modeling.updateProperties(gatewayShape, { 'default': newDefaultFlowConnection });
+        modeling.updateProperties(gatewayShape, {
+          'default': newDefaultFlowConnection
+        });
 
         // then
-      expect(gatewayShape.businessObject['default']).to.eql(newDefaultFlowConnection.businessObject);
+        expect(gatewayShape.businessObject['default']).to.eql(
+          newDefaultFlowConnection.businessObject
+        );
 
         // flow got updated, too
         expect(updatedElements).to.include(newDefaultFlowConnection);
-    }));
+      }
+    ));
 
   });
 
 
   describe('error handling', function() {
 
-    it('should ignore unchanged id', inject(function(elementRegistry, modeling) {
+    it('should ignore unchanged id', inject(
+      function(elementRegistry, modeling) {
 
         // given
-      var flowConnection = elementRegistry.get('SequenceFlow_1');
+        var flowConnection = elementRegistry.get('SequenceFlow_1'),
-      var ids = flowConnection.businessObject.$model.ids;
+            flowBo = flowConnection.businessObject;
+
+        var ids = flowBo.$model.ids;
 
         // when
         modeling.updateProperties(flowConnection, { id: 'SequenceFlow_1' });
 
         // then
-      expect(ids.assigned('SequenceFlow_1')).to.eql(flowConnection.businessObject);
+        expect(ids.assigned('SequenceFlow_1')).to.eql(flowBo);
 
-      expect(flowConnection.businessObject.id).to.equal('SequenceFlow_1');
+        expect(flowBo.id).to.equal('SequenceFlow_1');
-    }));
+      }
+    ));
 
   });